Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-04-26 Thread Ni, Ray
.io; Ni, Ray > ; Kinney, Michael D ; > ard.biesheu...@linaro.org > Cc: ler...@redhat.com; mac...@microsoft.com > Subject: RE: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for > float. > > Guomin: > The size impact is small. This solution that moves _fltused to B

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-04-26 Thread Liming Gao
> ; ard.biesheu...@linaro.org > Cc: ler...@redhat.com; mac...@microsoft.com > Subject: RE: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for > float. > > I have compare the Image different, the are two image size will be affect > before and after move _fltused to Bas

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-04-23 Thread Guomin Jiang
ard.biesheu...@linaro.org > > Cc: ler...@redhat.com; mac...@microsoft.com > > Subject: Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib > for float. > > > > I guess the key point is /GL option. IntrinsicLib omit the /GL option > > to avoid the

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-04-22 Thread Liming Gao
io On Behalf Of Guomin Jiang > Sent: Thursday, April 23, 2020 12:04 PM > To: Ni, Ray ; devel@edk2.groups.io; Kinney, Michael D > ; ard.biesheu...@linaro.org > Cc: ler...@redhat.com; mac...@microsoft.com > Subject: Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for >

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-04-22 Thread Guomin Jiang
. > -Original Message- > From: Ni, Ray > Sent: Thursday, April 23, 2020 11:32 AM > To: Jiang, Guomin ; devel@edk2.groups.io; Kinney, > Michael D ; ard.biesheu...@linaro.org > Cc: ler...@redhat.com; mac...@microsoft.com > Subject: RE: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add F

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-04-22 Thread Ni, Ray
nney, Michael D > ; ard.biesheu...@linaro.org > Cc: ler...@redhat.com; mac...@microsoft.com > Subject: RE: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for > float. > > The size comparation between with _fltused and without _fltused, use > OvmfPkgX64 as build target >

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-04-22 Thread Guomin Jiang
age- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel > Sent: Friday, April 17, 2020 4:15 PM > To: Jiang, Guomin ; Ard Biesheuvel > > Cc: devel@edk2.groups.io; Ni, Ray ; Kinney, Michael D > ; ler...@redhat.com; mac...@microsoft.com > Subject: Re: [edk2-devel] [PATCH

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-04-22 Thread Guomin Jiang
ups.io On Behalf Of Guomin > Jiang > Sent: Tuesday, April 14, 2020 3:01 PM > To: devel@edk2.groups.io; Ni, Ray ; Kinney, Michael D > ; ard.biesheu...@linaro.org > Cc: ler...@redhat.com; mac...@microsoft.com > Subject: Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-04-17 Thread Ard Biesheuvel
On Tue, 14 Apr 2020 at 09:01, Jiang, Guomin wrote: > > Summarize current status: > > Problem Statement: > Openssl require _fltused to be defined as a constant anywhere floating point > is used. > It may use float out of edk2 tree and need _fltused, for example, Microsoft’s > OnScreenKeyboard and

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-04-14 Thread Guomin Jiang
2020 1:03 PM > To: devel@edk2.groups.io; Kinney, Michael D ; > ard.biesheu...@linaro.org; Kinney, Michael D > Cc: ler...@redhat.com; mac...@microsoft.com > Subject: Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for > float. > > UEFI spec allows using float o

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-04-13 Thread Ni, Ray
day, April 2, 2020 12:38 AM > To: devel@edk2.groups.io; ard.biesheu...@linaro.org; Kinney, Michael D > > Cc: ler...@redhat.com; mac...@microsoft.com > Subject: Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for > float. > > Hi Ard, > > I think adding a depe

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-04-01 Thread Michael D Kinney
ler...@redhat.com; > mac...@microsoft.com > Subject: Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: > Add FltUsedLib for float. > > On Tue, 31 Mar 2020 at 16:36, Kinney, Michael D > wrote: > > > > ARM and AARCH64 have a compiler intrinsic lib that is > link

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-03-31 Thread Ard Biesheuvel
On Tue, 31 Mar 2020 at 16:36, Kinney, Michael D wrote: > > ARM and AARCH64 have a compiler intrinsic lib that is linked against all > modules. > > [LibraryClasses.ARM, LibraryClasses.AARCH64] > # > # It is not possible to prevent ARM compiler calls to generic intrinsic > functions. > # Thi

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-03-31 Thread Michael D Kinney
: devel@edk2.groups.io On Behalf Of Sean via Groups.Io Sent: Tuesday, March 31, 2020 3:58 PM To: Laszlo Ersek ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float. Does anyone know off hand if defining this and enabling floating point has any

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-03-31 Thread Sean via Groups.Io
Does anyone know off hand if defining this and enabling floating point has any negative side effects if you don't need it?  Size? Optimization? Other?   That is my only concern for enabling in all modules which is why the initial proposal was for a new library. -=-=-=-=-=-=-=-=-=-=-=- Groups.io

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-03-31 Thread Laszlo Ersek
On 03/31/20 16:36, Kinney, Michael D wrote: > ARM and AARCH64 have a compiler intrinsic lib that is linked against all > modules. > > [LibraryClasses.ARM, LibraryClasses.AARCH64] > # > # It is not possible to prevent ARM compiler calls to generic intrinsic > functions. > # This library pro

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-03-31 Thread Michael D Kinney
Of Laszlo Ersek > Sent: Tuesday, March 31, 2020 5:42 AM > To: Ard Biesheuvel ; edk2- > devel-groups-io ; > mac...@microsoft.com > Subject: Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: > Add FltUsedLib for float. > > On 03/30/20 23:41, Ard Biesheuvel wrote: > > On Mon

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-03-31 Thread Laszlo Ersek
On 03/30/20 23:41, Ard Biesheuvel wrote: > On Mon, 30 Mar 2020 at 23:29, Matthew Carlson via Groups.Io > wrote: >> >> So it's not required by OpenSSL, it's required by the compiler whenever >> floating point is used, which can be in multiple places. For example, this >> is used in mu_plus (the M

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-03-31 Thread Laszlo Ersek
On 03/31/20 09:13, Ard Biesheuvel wrote: > On Tue, 31 Mar 2020 at 03:40, Jiang, Guomin wrote: >> >> Hi Laszlo, >> >> Thanks for you spending time review the changes. >> >> And I just want to present how to reproduce the build error. >> >> When build OvmfPkgX64, you can encounter this issue with yo

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-03-31 Thread Ard Biesheuvel
On Tue, 31 Mar 2020 at 03:40, Jiang, Guomin wrote: > > Hi Laszlo, > > Thanks for you spending time review the changes. > > And I just want to present how to reproduce the build error. > > When build OvmfPkgX64, you can encounter this issue with your local change. > The error as below: > TcgPei.li

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-03-30 Thread Guomin Jiang
gt; > Cc: Wang, Jian J ; Lu, XiaoyuX > ; Yao, Jiewen ; Sean Brogan > ; mac...@microsoft.com > Subject: Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for > float. > > On 03/30/20 11:02, Ard Biesheuvel wrote: > > On Mon, 30 Mar 2020 at 10:52, Guo

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-03-30 Thread Ard Biesheuvel
On Mon, 30 Mar 2020 at 23:29, Matthew Carlson via Groups.Io wrote: > > So it's not required by OpenSSL, it's required by the compiler whenever > floating point is used, which can be in multiple places. For example, this is > used in mu_plus (the Microsoft UEFI value add to EDK2) by the > OnScre

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-03-30 Thread Matthew Carlson via Groups.Io
So it's not required by OpenSSL, it's required by the compiler whenever floating point is used, which can be in multiple places. For example, this is used in mu_plus (the Microsoft UEFI value add to EDK2) by the OnScreenKeyboard driver as well as the UiToolKit driver. If you happen to use BaseCr

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-03-30 Thread Laszlo Ersek
On 03/30/20 11:02, Ard Biesheuvel wrote: > On Mon, 30 Mar 2020 at 10:52, Guomin Jiang > wrote: >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2596 >> >> OpenSSL requires _fltused to be defined as a constant anywhere >> floating point is used. >> This is to satisfy the linker, however, i

Re: [EXTERNAL] [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-03-30 Thread Bret Barkelew via Groups.Io
Reviewed-by: Bret Barkelew - Bret From: devel@edk2.groups.io on behalf of Guomin Jiang via Groups.Io Sent: Monday, March 30, 2020 1:52:47 AM To: devel@edk2.groups.io Cc: Jian J Wang ; Xiaoyu Lu Subject: [EXTERNAL] [edk2-devel] [PATCH] CryptoPkg/FltUsedLib

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-03-30 Thread Ard Biesheuvel
On Mon, 30 Mar 2020 at 10:52, Guomin Jiang wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2596 > > OpenSSL requires _fltused to be defined as a constant anywhere floating > point is used. > This is to satisfy the linker, however, it is possible to compile a > module with multiple d

[edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-03-30 Thread Guomin Jiang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2596 OpenSSL requires _fltused to be defined as a constant anywhere floating point is used. This is to satisfy the linker, however, it is possible to compile a module with multiple definitions of fltused. This causes the MSVC compiler to fail the