Re: [edk2-devel] [PATCH] BaseTools:ECC fails to detect function header comments issue

2020-01-20 Thread Bob Feng
I have 2 comments. 1. CheckParamName may return None. But according to other part of this function, it should return True or False. 2. The meaning of ParamList.pop(0) is not much clear. Thanks, Bob -Original Message- From: Fan, ZhijuX Sent: Monday, January 20, 2020 4:40 PM To: devel@ed

[edk2-devel] [PATCH] BaseTools:ECC fails to detect function header comments issue

2020-01-20 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1523 When the keyword after @param doesn't match the actual function parameter name, ECC doesn't detect such issue The patch is going to fix this issue Cc: Liming Gao Cc: Bob Feng Signed-off-by: Zhiju.Fan --- BaseTools/Source/Python/Ecc/c.py