Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-13 Thread Bob Feng
t; Thanks, Bob -Original Message- From: Rodriguez, Christian Sent: Tuesday, May 14, 2019 2:41 AM To: Feng, Bob C ; Laszlo Ersek ; devel@edk2.groups.io; fel...@ami.com Cc: Gao, Liming ; Zhu, Yonghong Subject: RE: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-13 Thread Christian Rodriguez
Gao, Liming >; Zhu, Yonghong >Subject: Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned >in inf are not hashed > >On 05/13/19 20:53, Christian Rodriguez wrote: >> I think a warning would be reasonable. >> >> I only mention the spec because it requ

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-13 Thread Laszlo Ersek
fel...@ami.com >> Cc: Feng, Bob C ; Gao, Liming >> ; Zhu, Yonghong >> Subject: Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned >> in inf are not hashed >> >> On 05/10/19 21:45, Rodriguez, Christian wrote: >>> Hashing is not changing fil

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-13 Thread Christian Rodriguez
iguez, Christian ; >>devel@edk2.groups.io; fel...@ami.com >>Cc: Feng, Bob C ; Gao, Liming >>; Zhu, Yonghong >>Subject: Re: [edk2-devel] [PATCH] BaseTools: Include headers not >>mentioned in inf are not hashed >> >>On 05/10/19 21:45, Rodriguez, Christia

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-13 Thread Christian Rodriguez
:devel@edk2.groups.io] On Behalf Of >>> Felix Polyudov >>> Sent: Friday, May 10, 2019 12:32 PM >>> To: Rodriguez, Christian ; >>> devel@edk2.groups.io; 'ler...@redhat.com' >>> Cc: Feng, Bob C ; Gao, Liming >>> ; Zhu, Yonghong >>&

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-13 Thread Christian Rodriguez
l@edk2.groups.io; fel...@ami.com >Cc: Feng, Bob C ; Gao, Liming >; Zhu, Yonghong >Subject: Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned >in inf are not hashed > >On 05/10/19 21:45, Rodriguez, Christian wrote: >> Hashing is not changing file format requi

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-13 Thread Bob Feng
>> devel@edk2.groups.io; 'ler...@redhat.com' >> Cc: Feng, Bob C ; Gao, Liming >> ; Zhu, Yonghong >> Subject: Re: [edk2-devel] [PATCH] BaseTools: Include headers not >> mentioned in inf are not hashed >> >> My suggestion would be to always bre

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-13 Thread Bob Feng
To: devel@edk2.groups.io; fel...@ami.com; 'ler...@redhat.com' Cc: Feng, Bob C ; Gao, Liming ; Zhu, Yonghong Subject: RE: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed Hashing is not changing file format requirements as Basetools has no requireme

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-13 Thread Laszlo Ersek
..@redhat.com' >> Cc: Feng, Bob C ; Gao, Liming >> ; Zhu, Yonghong >> Subject: Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned >> in inf are not hashed >> >> My suggestion would be to always break a build (no matter what the hashing >

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-10 Thread Christian Rodriguez
ts. > >> -Original Message- >> From: Rodriguez, Christian [mailto:christian.rodrig...@intel.com] >> Sent: Friday, May 10, 2019 3:14 PM >> To: devel@edk2.groups.io; Felix Polyudov; 'ler...@redhat.com' >> Cc: Feng, Bob C; Gao, Liming; Zhu, Yonghong >> Subject:

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-10 Thread Felix Polyudov
rodrig...@intel.com] > Sent: Friday, May 10, 2019 3:14 PM > To: devel@edk2.groups.io; Felix Polyudov; 'ler...@redhat.com' > Cc: Feng, Bob C; Gao, Liming; Zhu, Yonghong > Subject: RE: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in > inf are not hashed > >

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-10 Thread Christian Rodriguez
Sent: Friday, May 10, 2019 6:41 AM >To: devel@edk2.groups.io; 'ler...@redhat.com' ; >Rodriguez, Christian >Cc: Feng, Bob C ; Gao, Liming >; Zhu, Yonghong >Subject: Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned >in inf are not hashed > >> --

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-10 Thread Carsey, Jaben
t; ; Zhu, Yonghong > Subject: RE: [edk2-devel] [PATCH] BaseTools: Include headers not > mentioned in inf are not hashed > Importance: High > > Replies inline. > > >-Original Message- > >From: Carsey, Jaben > >Sent: Thursday, May 9, 2019 4:39 PM > >To

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-10 Thread Christian Rodriguez
Replies inline. >-Original Message- >From: Carsey, Jaben >Sent: Thursday, May 9, 2019 4:39 PM >To: devel@edk2.groups.io; Rodriguez, Christian > >Cc: Feng, Bob C ; Gao, Liming >; Zhu, Yonghong >Subject: RE: [edk2-devel] [PATCH] BaseTools: Include headers not m

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-10 Thread Felix Polyudov
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo > Ersek > Sent: Thursday, May 09, 2019 7:53 PM > > Hello Christian, > > On 05/09/19 23:27, Christian Rodriguez wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1787 > > > > Ge

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-09 Thread Laszlo Ersek
Hello Christian, On 05/09/19 23:27, Christian Rodriguez wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1787 > > Get a list of local header files that are not present in the > MetaFile for this module. Add those local header files into > the hashing algorithm for a module. If a local

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-09 Thread Carsey, Jaben
ect: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in > inf are not hashed > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1787 > > Get a list of local header files that are not present in the > MetaFile for this module. Add those local header files into > t

[edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-09 Thread Christian Rodriguez
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1787 Get a list of local header files that are not present in the MetaFile for this module. Add those local header files into the hashing algorithm for a module. If a local header file is not present in the MetaFile, the module will still build co