Re: [edk2-devel] [PATCH] BaseTools: Fix python3.8 SyntaxWarning

2019-07-15 Thread Laszlo Ersek
On 07/13/19 04:54, Bob Feng wrote: > I tested this patch on python2.7 and 3.7. It works fine. > > Reviewed-by: Bob Feng (This is commit eebc135ffb21 now, thanks!) Laszlo > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Saturday, July 13, 2019 5:03 AM > To: C

Re: [edk2-devel] [PATCH] BaseTools: Fix python3.8 SyntaxWarning

2019-07-12 Thread Bob Feng
I tested this patch on python2.7 and 3.7. It works fine. Reviewed-by: Bob Feng -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Saturday, July 13, 2019 5:03 AM To: Cole Robinson ; devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: Re: [PATCH] BaseTools: F

Re: [edk2-devel] [PATCH] BaseTools: Fix python3.8 SyntaxWarning

2019-07-12 Thread Laszlo Ersek
On 07/12/19 19:29, Cole Robinson wrote: > Building with python3.8 shows a warning like: > > SyntaxWarning: invalid escape sequence \( > GuidName = re.compile("\(GUID=[-a-fA-F0-9]+") > > It seems harmless, but it's easy enough to fix: mark the string as > raw with the 'r' prefix like is used els

[edk2-devel] [PATCH] BaseTools: Fix python3.8 SyntaxWarning

2019-07-12 Thread Cole Robinson
Building with python3.8 shows a warning like: SyntaxWarning: invalid escape sequence \( GuidName = re.compile("\(GUID=[-a-fA-F0-9]+") It seems harmless, but it's easy enough to fix: mark the string as raw with the 'r' prefix like is used elsewhere in the file Signed-off-by: Cole Robinson ---