Re: [edk2-devel] [PATCH] BaseTools/GenFw: Fix casting result of comparison

2021-03-29 Thread Tim Crawford
r detects this issue? > > Thanks > Liming > > -邮件原件- > > 发件人: devel@edk2.groups.io 代表 Tim Crawford > > 发送时间: 2021年3月26日 8:48 > > 收件人: devel@edk2.groups.io > > 主题: [edk2-devel] [PATCH] BaseTools/GenFw: Fix casting result of > > comparison > > &g

回复: [edk2-devel] [PATCH] BaseTools/GenFw: Fix casting result of comparison

2021-03-28 Thread gaoliming
Tim: This change is good. Reviewed-by: Liming Gao Besides, which compiler detects this issue? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Tim Crawford > 发送时间: 2021年3月26日 8:48 > 收件人: devel@edk2.groups.io > 主题: [edk2-devel] [PATCH] BaseTools/GenFw: Fix ca

[edk2-devel] [PATCH] BaseTools/GenFw: Fix casting result of comparison

2021-03-26 Thread Tim Crawford
The cast in IsDataShdr() is only applied the left side, causing it to always return FALSE. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3271 Signed-off-by: Tim Crawford --- BaseTools/Source/C/GenFw/Elf32Convert.c | 2 +- BaseTools/Source/C/GenFw/Elf64Convert.c | 2 +- 2 files changed, 2 i