Re: [edk2-devel] [EXTERNAL] Re: Hard Feature Freeze starts now for edk2-stable202005

2020-05-27 Thread Laszlo Ersek
On 05/27/20 00:11, Bret Barkelew wrote: > I just looked into it, and I think that AsciiStrCpyS() was the wrong function > to call in this loop anyway. AsciiStrCpyS() will fail without copying any > characters. > AsciiStrnCpyS() will perform the string "slicing"/"chunking" that the loop > seems t

Re: [edk2-devel] [EXTERNAL] Re: Hard Feature Freeze starts now for edk2-stable202005

2020-05-26 Thread Bret Barkelew via groups.io
Subject: Re: [edk2-devel] [EXTERNAL] Re: Hard Feature Freeze starts now for edk2-stable202005 I create PR https://github.com/tianocore/edk2/pull/644<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fpull%2F644&data=02%7C01%7Cbret.b

Re: [edk2-devel] [EXTERNAL] Re: Hard Feature Freeze starts now for edk2-stable202005

2020-05-26 Thread Liming Gao
I create PR https://github.com/tianocore/edk2/pull/644 for this patch. Thanks Liming From: Bret Barkelew Sent: Wednesday, May 27, 2020 6:11 AM To: Laszlo Ersek ; devel@edk2.groups.io; Gao, Liming ; annou...@edk2.groups.io Cc: Leif Lindholm ; af...@apple.com; Kinney, Michael D Subject: Re: [EXT

Re: [edk2-devel] [EXTERNAL] Re: Hard Feature Freeze starts now for edk2-stable202005

2020-05-26 Thread Bret Barkelew via groups.io
I just looked into it, and I think that AsciiStrCpyS() was the wrong function to call in this loop anyway. AsciiStrCpyS() will fail without copying any characters. AsciiStrnCpyS() will perform the string "slicing"/"chunking" that the loop seems to expect. The bug stands and we should try to get