Re: [edk2-devel] [[PATCH v2] 1/7] EmbeddedPkg: Fix DwEmmc driver bugs

2019-05-07 Thread Loh, Tien Hock
Hi Leif, Sorry for the late reply, I were held up in other areas of the work. > -Original Message- > From: Leif Lindholm > Sent: Friday, May 3, 2019 7:52 PM > To: Loh, Tien Hock > Cc: devel@edk2.groups.io; thlo...@gmail.com; Ard Biesheuvel > > Subject: Re: [[PATCH v2] 1/7] EmbeddedPkg:

Re: [edk2-devel] [[PATCH v2] 1/7] EmbeddedPkg: Fix DwEmmc driver bugs

2019-05-03 Thread Leif Lindholm
Hi Tien Hock, Thanks for splitting the patches back up, and sorry for taking so long to get around to reviewing. But could you please add some descriptive subject lines back as well? Most of my comments on this series are purely coding style related, a couple are not. On Fri, May 03, 2019 at 11:

[edk2-devel] [[PATCH v2] 1/7] EmbeddedPkg: Fix DwEmmc driver bugs

2019-05-02 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Added ACMD6 for SD support. For SD, after CMD55 is sent, the next command should be an application command, which should not expect data Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel --- EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 15