Re: [edk2-devel] edk2setup.sh shortcomings

2023-02-03 Thread tlaro...@polynum.com
Le Thu, Feb 02, 2023 at 04:06:13PM -0700, Rebecca Cran a écrit : > On 2/2/23 14:49, Brian J. Johnson wrote: > This above is misleading: this is not Brian J. Johnson who wrote what is below: this is me (Thierry Laronde): > > Hum... There is a very lethal weapon actually in use: the pillow. I > >

Re: [edk2-devel] edk2setup.sh shortcomings

2023-02-02 Thread tlaro...@polynum.com
Le Thu, Feb 02, 2023 at 05:50:32PM +0100, Gerd Hoffmann a écrit : > On Thu, Feb 02, 2023 at 12:29:32PM +0100, tlaro...@polynum.com wrote: > > edk2setup.sh has shortcomings. To list some: > > > > - The functions return a status but it is not tested; hence the > >

[edk2-devel] edk2setup.sh shortcomings

2023-02-02 Thread tlaro...@polynum.com
edk2setup.sh has shortcomings. To list some: - The functions return a status but it is not tested; hence the script goes to the end with a final "return $?" that simply returns the status of the last command that is "unset" which always successfully unsets, ev

Re: [edk2-devel] [PATCH 1/1 v2] BaseTools: remove useless dependency on libuuid

2023-01-31 Thread tlaro...@polynum.com
New pull request #3975: https://github.com/tianocore/edk2/pull/3975 CI tests passed. Could this trivial clean-up please be merged? TIA T. Laronde Le Mon, Jan 30, 2023 at 11:58:43AM +0100, tlaro...@polynum.com a écrit : > As asked by Bob Feng, I created a pull request #3969: > &

Re: [edk2-devel] CI passed yesterday; failing today only for PatchCheck

2023-01-31 Thread tlaro...@polynum.com
. OK. Thanks for the answer! T. Laronde > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of > > tlaro...@polynum.com > > Sent: Tuesday, January 31, 2023 1:53 AM > > To: devel@edk2.groups.io > > Subject: [edk2-devel] CI passed yester

[edk2-devel] CI passed yesterday; failing today only for PatchCheck

2023-01-31 Thread tlaro...@polynum.com
As requested, yesterday, for a trivial correction in BaseTools, removing useless libuuid dependency in GenFv/, I made a Pull Request and triggered a CI check test. All went fine. Today, looking if the patches have been reviewed and merged, I saw that since the master has changed, it required a mer

[edk2-devel] [PATCH 1/1 v2] BaseTools: remove useless dependency on libuuid

2023-01-30 Thread tlaro...@polynum.com
As asked by Bob Feng, I created a pull request #3969: https://github.com/tianocore/edk2/pull/3969 CI check test passed successfully. v2: - Remove also unneeded libuuid linking in GNUMakefile. >From d8967e70cf649ed8d9412ba6996906c5ae2ff47d Mon Sep 17 00:00:00 2001 From: Thierry LARONDE

Re: [edk2-devel] ??: [PATCH 1/1] BaseTools: remove useless header inclusion

2023-01-29 Thread tlaro...@polynum.com
, I should have removed the -luuid in GNUMakefile too. > > > ------ > > ???: tlaro...@polynum.com > > : 2023?1?26? 18:03 > > ???: devel@edk2.groups.io > > ??: Bob Feng ; Liming Gao > > ; Yuwei Chen > > ??: [PATCH 1/1] BaseTools: remove usel

[edk2-devel] PING [PATCH 1/1 v3] EmulatorPkg: fixes for NetBSD compilation

2023-01-27 Thread tlaro...@polynum.com
Hello, Could I have a statement about this patch? ACK, NACK, DROPPED, IGNORED or whatever? TIA Le Mon, Jan 09, 2023 at 06:03:38PM +0100, tlaro...@polynum.com a écrit : > EmulatorPkg: fixes for NetBSD compilation. > > Note: generated against today (2023-01-09) master. > >

[edk2-devel] [PATCH 1/1] BaseTools: remove useless header inclusion

2023-01-26 Thread tlaro...@polynum.com
GenFvInternalLib.c: useless inclusion and dependency on uuid.h. >From 6c0ba96fa11390750e102ebd277f59ef38970394 Mon Sep 17 00:00:00 2001 From: Thierry LARONDE Date: Thu, 26 Jan 2023 10:49:12 +0100 Subject: [PATCH] Remove useless uuid.h include. Signed-off-by: Thierry LARONDE --- BaseTools/Sourc

Re: [edk2-devel] Documentation errors

2023-01-20 Thread tlaro...@polynum.com
entered as BZ, but > this > was a simple issue that could be resolved immediately. > > Thanks, > > Mike > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of > > tlaro...@polynum.com > > Sent: Friday, January 20, 202