This reverts commit d4e0b9607c9a64a8eff20724b2e35ea2cd5bd33f.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2951
Previously false positive Ecc issue whose error code is 10014 was reported
under Linux OS. So we disabled it in EccCheck plugin for edk2 open CI.
As the bug is fixed, we need to r
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2904
As the false positive issue whose error code is 10014 has been
fixed, we need to re-enable it on open CI.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
.pytool/Plugin/EccCheck/E
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2920
Ecc issues whose error code is 10014, can't be correctly handled
under Linux OS, resulting from a bug in Ecc tool.
So we need to disable it before ecc tool is repaired.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
EccCheck is a plugin to report Ecc issues for code in pull request
, which will be run on open ci.
But note not each kind of issue could be reported out.
It can only handle the issues, whose line number in CSV report
accurately map with their
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
As planed we will enable Ecc check for edk2 on open ci. And they are ready now.
I appreciate receiving feedback and comments if someone find errors or false
positive issues.
I created a pipline of EccCheck for my forked edk2. Welcome every
Hi Laszlo,
Sorry for that. I removed it by mistake. I'll re-add it into the patch.
Thanks,
Shenglei
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo
> Ersek
> Sent: Tuesday, August 11, 2020 11:36 PM
> To: devel@edk2.groups.io; Zhang, Shengle
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Liming Gao
Cc: Michael D Kinney
Signed-off-by: Shenglei Zhang
Reviewed-by: Guomin Jiang
Reviewed-by: Liming Gao
---
FmpDevicePkg/FmpDevicePkg.ci.yaml | 12 ++
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
EccCheck is a plugin to report Ecc issues for code in pull request
, which will be run on open ci.
But note not each kind of issue could be reported out.
It can only handle the issues, whose line number in CSV report
accurately map with their
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
As planed we will enable Ecc check for edk2 on open ci. And they are
ready now. I appreciate receiving feedback and comments if someone
find errors or false positive issues.
I created a pipline of EccCheck for my forked edk2. Welcome everyon
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Besides, add submodule path in IgnoreFiles section.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/MdeModulePkg.ci.yaml | 14 +
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
Reviewed-by: Guomin Jiang
Reviewed-by: Liming Gao
---
FatPkg/FatPkg.ci.yaml | 12
1 file changed, 12 insertions(
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Besides, add submodule path in IgnoreFiles section.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Signed-off-by: Shenglei Zhang
---
CryptoPkg/CryptoPkg.ci.yaml | 13 +
1 f
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
Reviewed-by: Liming Gao
---
MdePkg/MdePkg.ci.yaml | 12
1 file changed, 12 insertions(+
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Shenglei Zhang
Acked-by: Ray Ni
Reviewed-by: Liming Gao
---
ShellPkg/ShellPkg.ci.yaml | 12
1 file changed, 12
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Besides, add submodule path in IgnoreFiles section.
Cc: Michael D Kinney
Cc: Sean Brogan
Cc: Bret Barkelew
Signed-off-by: Shenglei Zhang
---
UnitTestFrameworkPkg/Unit
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Shenglei Zhang
Reviewed-by: Jian J Wang
Reviewed-by: Liming Gao
---
SecurityPkg/SecurityPkg.ci.yaml | 1
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
Acked-by: Ray Ni
Reviewed-by: Liming Gao
---
PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 13 +
1 file changed, 13 ins
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Shenglei Zhang
Reviewed-by: Maciej Rabeda
Reviewed-by: Liming Gao
---
NetworkPkg/NetworkPkg.ci.yaml | 1
antlr4-python3-runtime is a lib to support Ecc run with Py3.x.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
Reviewed-by: Liming Gao
---
pip-requirements.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/pip-requirements.txt b/pip-
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Shenglei Zhang
Acked-by: Ray Ni
Reviewed-by: Eric Dong
Acked-by: Laszlo Ersek
Reviewed-by: Liming Gao
---
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
Acked-by: Ray Ni
Reviewed-by: Liming Gao
---
EmulatorPkg/EmulatorPkg.ci.yaml | 12 +++
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Shenglei Zhang
Acked-by: Laszlo Ersek
Reviewed-by: Liming Gao
---
OvmfPkg/OvmfPkg.ci.yaml | 12
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Shenglei Zhang
Reviewed-by: Liming Gao
---
ArmVirtPkg/ArmVirtPkg.ci.yaml | 12
1 fi
Thanks, Sean. That works.
> -Original Message-
> From: Sean Brogan
> Sent: Friday, August 7, 2020 11:35 PM
> To: devel@edk2.groups.io; Zhang, Shenglei ;
> Sean Brogan ; Bret Barkelew
>
> Cc: Kinney, Michael D ; Gao, Liming
>
> Subject: Re: [edk2-devel] Meet f
Hi folks,
I met a failure when I tried running a ci plugin locally. Does anybody know how
to deal with it?
Command and build log are listed below.
cmd: stuart_ci_build -c .pytool/CISettings.py TOOL_CHAIN_TAG=NO-TARGET
build log:
SECTION - Init SDE
ERROR - Dependency 'mu_nasm' is not met!
ERROR
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2777
Code wrapped by DISABLE_NEW_DEPRECATED_INTERFACES is deprecated.
So remove it.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
MdePkg/Library/BaseLib/String.c| 626 -
MdePkg/Library/B
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2777
Code wrapped by DISABLE_NEW_DEPRECATED_INTERFACES is deprecated.
So remove it from MdePkg and MdeModulePkg.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Michael D Kinney
Cc: Liming Gao
Shenglei Zhang (2):
MdePkg: Remove code wrapped by DISABLE_NEW
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2777
Code wrapped by DISABLE_NEW_DEPRECATED_INTERFACES is deprecated.
So remove it.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhang
---
.../DxePrintLibPrint2Protocol/PrintLib.c | 145 --
MdeModulePkg/Universal/
> -Original Message-
> From: Gao, Liming
> Sent: Wednesday, July 29, 2020 10:02 PM
> To: Zhang, Shenglei ; devel@edk2.groups.io
> Cc: Sean Brogan ; Bret Barkelew
> ; Kinney, Michael D
>
> Subject: RE: [PATCH v2 01/15] .pytool/Plugin: Add a plugin Li
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2691
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2833
Add a plugin to check license conflict for new added
files in a patch. It will report out errors when meeting
files which are now contributed under BSD-2-Clause-Patent.
Cc: Sean Brogan
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2691
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2833
LicenseCheck is now enabled in PatchCheck.py. But there's
a patch "Revert 'BaseTools/PatchCheck.py: Add LicenseCheck'"
to suggest revert the change.These patch series introduce
a plugin
> Sent: Wednesday, July 29, 2020 7:29 AM
> To: Zhang, Shenglei ; devel@edk2.groups.io;
> Kinney, Michael D
> Cc: Sean Brogan ; Bret Barkelew
> ; Gao, Liming
> Subject: RE: [PATCH 01/15] .pytool/Plugin: Add a plugin LicenseCheck
>
> Where did the requirement for BSD-3-Clause
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2777
With some functions to be deprecated, their usage in platforms
should also be updated.
Cc: Agyeman Prince
Signed-off-by: Shenglei Zhang
---
.../Library/BoardBdsHookLib/BoardBdsHookLib.c| 2 +-
.../Intel/SimicsOpenBoardPkg/SimicsDx
Hi Laszlo,
> -Original Message-
> From: Laszlo Ersek
> Sent: Monday, July 27, 2020 5:51 PM
> To: Zhang, Shenglei ; Rebecca Cran
>
> Cc: devel@edk2.groups.io; Justen, Jordan L ;
> Ard Biesheuvel
> Subject: Re: [PATCH 10/15] OvmfPkg/OvmfPkg.ci.yaml: Add configur
Hi Michael/Sean/Bret,
Could you help review this patch?
Thanks,
Shenglei
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zhang,
> Shenglei
> Sent: Monday, July 20, 2020 4:37 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Sean Brogan
Hi Laszlo,
VbeShim.h is existing in edk2 now. This plugin only checks the patches to be
checked in.
So there's no need to add existing files to this section.
Thanks,
Shenglei
> -Original Message-
> From: Laszlo Ersek
> Sent: Tuesday, July 21, 2020 6:01 AM
> To: Zhang,
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
EccCheck is a plugin to report Ecc issues for code in pull request
, which will be run on open ci.
But note not each kind of issue could be reported out.
It can only handle the issues, whose line number in CSV report
accurately map with their
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
As planed we will enable Ecc check for edk2 on open ci. And they are
ready now. I appreciate receiving feedback and comments if someone
find errors or false positive issues.
I created a pipline of EccCheck for my forked edk2. Welcome everyon
Bob,
Code review is for our internal use. Should I append it on Bugzilla?
Thanks,
Shenglei
> -Original Message-
> From: Feng, Bob C
> Sent: Tuesday, July 21, 2020 11:39 AM
> To: Zhang, Shenglei ; devel@edk2.groups.io
> Cc: Gao, Liming
> Subject: RE: [PATCH] BaseT
Add configuration IgnoreFiles for package config files.
So users can rely on this to skip license conflict for
some generated files.
Cc: Jiewen Yao
Cc: Jian J Wang
Signed-off-by: Shenglei Zhang
---
SecurityPkg/SecurityPkg.ci.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/SecurityP
Add configuration IgnoreFiles for package config files.
So users can rely on this to skip license conflict for
some generated files.
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
---
FatPkg/FatPkg.ci.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/FatPkg/FatPkg.ci.yaml b/FatPkg/FatPkg.ci
Add configuration IgnoreFiles for package config files.
So users can rely on this to skip license conflict for
some generated files.
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
---
EmulatorPkg/EmulatorPkg.ci.yaml | 4
1 file changed, 4 insertions(+)
diff -
Add configuration IgnoreFiles for package config files.
So users can rely on this to skip license conflict for
some generated files.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
MdePkg/MdePkg.ci.yaml | 4
1 file changed, 4 insertions(+)
diff --git a/MdePkg/MdePkg
Add configuration IgnoreFiles for package config files.
So users can rely on this to skip license conflict for
some generated files.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Shenglei Zhang
---
UefiCpuPkg/UefiCpuPkg.ci.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a
Add configuration IgnoreFiles for package config files.
So users can rely on this to skip license conflict for
some generated files.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Shenglei Zhang
---
ShellPkg/ShellPkg.ci.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ShellPkg/ShellPkg.c
Add configuration IgnoreFiles for package config files.
So users can rely on this to skip license conflict for
some generated files.
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
---
PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/PcAtChipsetPkg/PcAtChips
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2691
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2833
LicenseCheck is now enabled in PatchCheck.py. But there's
a patch "Revert 'BaseTools/PatchCheck.py: Add LicenseCheck'"
to suggest revert the change.These patch series introduce
a plugin
Add configuration IgnoreFiles for package config files.
So users can rely on this to skip license conflict for
some generated files.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Shenglei Zhang
---
OvmfPkg/OvmfPkg.ci.yaml | 4
1 file changed, 4 insertions(+)
diff
Add configuration IgnoreFiles for package config files.
So users can rely on this to skip license conflict for
some generated files.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Signed-off-by: Shenglei Zhang
---
CryptoPkg/CryptoPkg.ci.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/CryptoPkg/Cryp
Add configuration IgnoreFiles for package config files.
So users can rely on this to skip license conflict for
some generated files.
Cc: Michael D Kinney
Cc: Sean Brogan
Cc: Bret Barkelew
Signed-off-by: Shenglei Zhang
---
UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 4
1 file chan
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2691
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2833
Add a plugin to check license conflict for new added
files in a patch. It will report out errors when meeting
files which are now contributed under BSD-2-Clause-Patent
or BSD-3-Clause-P
Add configuration IgnoreFiles for package config files.
So users can rely on this to skip license conflict for
some generated files.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Shenglei Zhang
---
SecurityPkg/SecurityPkg.ci.yaml | 3 +++
1 file changed, 3 insertions(+)
diff -
Add configuration IgnoreFiles for package config files.
So users can rely on this to skip license conflict for
some generated files.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/MdeModulePkg.ci.yaml | 4
1 file changed, 4 insertions(+)
diff --git a/MdeModul
Add configuration IgnoreFiles for package config files.
So users can rely on this to skip license conflict for
some generated files.
Cc: Liming Gao
Cc: Michael D Kinney
Signed-off-by: Shenglei Zhang
---
FmpDevicePkg/FmpDevicePkg.ci.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Fm
Add configuration IgnoreFiles for package config files.
So users can rely on this to skip license conflict for
some generated files.
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Shenglei Zhang
---
ArmVirtPkg/ArmVirtPkg.ci.yaml | 4
1 file changed, 4 insertions(+)
Add configuration IgnoreFiles for package config files.
So users can rely on this to skip license conflict for
some generated files.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Shenglei Zhang
---
NetworkPkg/NetworkPkg.ci.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --g
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2836
Current PatchCheck.py checks each line to ensure line's length is not
larger than 76. But there's a case that length of user's name is much
longer than that number. So enhance the script to handle this case.
Cc: Bob Feng
Cc: Liming Gao
Sig
Comments below.
> -Original Message-
> From: Leif Lindholm
> Sent: Tuesday, July 7, 2020 7:57 PM
> To: Zhang, Shenglei
> Cc: devel@edk2.groups.io; Feng, Bob C ; Bret
> Barkelew ; Kinney, Michael D
> ; Gao, Liming ; Sean
> Brogan
> Subject: Re: [edk2-devel] [P
Comments below.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Leif
> Lindholm
> Sent: Monday, July 6, 2020 4:55 PM
> To: devel@edk2.groups.io; Zhang, Shenglei
> Cc: Feng, Bob C ; Bret Barkelew
> ; Kinney, Michael D
> ; Gao, Liming ; Sean
> B
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Michael D Kinney
Cc: Sean Brogan
Cc: Bret Barkelew
Signed-off-by: Shenglei Zhang
Acked-by: Ray Ni
---
UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 10
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Shenglei Zhang
Acked-by: Laszlo Ersek
---
OvmfPkg/OvmfPkg.ci.yaml | 11 +++
1 file chang
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Shenglei Zhang
Acked-by: Ray Ni
Reviewed-by: Eric Dong
Acked-by: Laszlo Ersek
---
UefiCpuPkg/UefiCpuPkg.ci
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
Acked-by: Ray Ni
---
PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 11 +++
1 file changed, 11 insertions(+)
diff --git a/Pc
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Shenglei Zhang
Reviewed-by: Jian J Wang
---
SecurityPkg/SecurityPkg.ci.yaml | 11 +++
1 file cha
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Shenglei Zhang
Acked-by: Ray Ni
---
ShellPkg/ShellPkg.ci.yaml | 11 +++
1 file changed, 11 insertions(+)
diff --git
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Shenglei Zhang
Reviewed-by: Maciej Rabeda
---
NetworkPkg/NetworkPkg.ci.yaml | 11 +++
1 file cha
antlr4-python3-runtime is a lib to support Ecc run with Py3.x.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
Reviewed-by: Liming Gao
---
pip-requirements.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/pip-requirements.txt b/pip-
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Signed-off-by: Shenglei Zhang
Reviewed-by: Guomin Jiang
Reviewed-by: Jian J Wang
---
CryptoPkg/CryptoPkg.ci.yaml | 11 +++
1 fi
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/MdeModulePkg.ci.yaml | 11 +++
1 file changed, 11 insertions(+)
diff --git a/MdeMo
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Liming Gao
Cc: Michael D Kinney
Signed-off-by: Shenglei Zhang
Reviewed-by: Guomin Jiang
---
FmpDevicePkg/FmpDevicePkg.ci.yaml | 11 +++
1 file changed, 11
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
As planed we will enable Ecc check for edk2 on open ci. And they are
ready now. I appreciate receiving feedback and comments if someone
find errors or false positive issues.
I created a pipline of EccCheck for my forked edk2. Welcome everyon
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Shenglei Zhang
Acked-by: Laszlo Ersek
---
ArmVirtPkg/ArmVirtPkg.ci.yaml | 11 +++
1 file
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
EccCheck is a plugin to report Ecc issues for code in pull request
, which will be run on open ci.
But note not each kind of issue could be reported out.
It can only handle the issues, whose line number in CSV report
accurately map with their
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
Reviewed-by: Guomin Jiang
---
FatPkg/FatPkg.ci.yaml | 11 +++
1 file changed, 11 insertions(+)
diff --git a/FatPkg/Fa
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
Reviewed-by: Liming Gao
---
MdePkg/MdePkg.ci.yaml | 11 +++
1 file changed, 11 insertions(+)
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
Acked-by: Ray Ni
---
EmulatorPkg/EmulatorPkg.ci.yaml | 11 +++
1 file changed, 11
Hi Lazslo,
Looks like I missed your ACK. I will add it in latter versions.
Thanks,
Shenglei
> -Original Message-
> From: Laszlo Ersek
> Sent: Saturday, July 4, 2020 12:02 AM
> To: Gao, Liming ; devel@edk2.groups.io; Zhang,
> Shenglei ; Leif Lindholm ;
> af...@apple.c
nt to reproduce Ecc
issues.
Thanks,
Shenglei
> -Original Message-
> From: Gao, Liming
> Sent: Thursday, July 2, 2020 10:31 AM
> To: devel@edk2.groups.io; Zhang, Shenglei
> Cc: Feng, Bob C ; Bret Barkelew
> ; Kinney, Michael D
> ; Sean Brogan
> Subject: RE: [edk2-
Reviewed-by: Shenglei Zhang
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Sami
> Mujawar
> Sent: Wednesday, July 1, 2020 3:37 AM
> To: devel@edk2.groups.io
> Cc: Sami Mujawar ; alexei.fedo...@arm.com;
> sean.bro...@microsoft.com; Gao, Liming ; Kinney,
> Michael D ; bret.
Reviewed-by: Shenglei Zhang
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Sami
> Mujawar
> Sent: Wednesday, July 1, 2020 3:37 AM
> To: devel@edk2.groups.io
> Cc: Sami Mujawar ; alexei.fedo...@arm.com;
> sean.bro...@microsoft.com; Gao, Liming ; Kinney,
> Michael D ; bret.
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
Acked-by: Ray Ni
---
EmulatorPkg/EmulatorPkg.ci.yaml | 11 +++
1 file changed, 11
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Shenglei Zhang
Reviewed-by: Maciej Rabeda
---
NetworkPkg/NetworkPkg.ci.yaml | 11 +++
1 file cha
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
MdePkg/MdePkg.ci.yaml | 11 +++
1 file changed, 11 insertions(+)
diff --git a/MdePkg/Mde
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Change-Id: I55c78eed392a8354a7201d17a591e4ff8dc3d6e9
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/MdeModulePkg.ci.yaml | 11 +++
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Shenglei Zhang
Acked-by: Ray Ni
---
ShellPkg/ShellPkg.ci.yaml | 11 +++
1 file changed, 11 insertions(+)
diff --git
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
Reviewed-by: Guomin Jiang
---
FatPkg/FatPkg.ci.yaml | 11 +++
1 file changed, 11 insertions(+)
diff --git a/FatPkg/Fa
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Liming Gao
Cc: Michael D Kinney
Signed-off-by: Shenglei Zhang
Reviewed-by: Guomin Jiang
---
FmpDevicePkg/FmpDevicePkg.ci.yaml | 11 +++
1 file changed, 11
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Michael D Kinney
Cc: Sean Brogan
Cc: Bret Barkelew
Signed-off-by: Shenglei Zhang
Acked-by: Ray Ni
---
UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 10
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Shenglei Zhang
---
SecurityPkg/SecurityPkg.ci.yaml | 11 +++
1 file changed, 11 insertions(+)
di
antlr4-python3-runtime is a lib to support Ecc run with Py3.x.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
pip-requirements.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/pip-requirements.txt b/pip-requirements.txt
index 57
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Shenglei Zhang
Acked-by: Laszlo Ersek
---
ArmVirtPkg/ArmVirtPkg.ci.yaml | 11 +++
1 file
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Signed-off-by: Shenglei Zhang
Reviewed-by: Guomin Jiang
---
CryptoPkg/CryptoPkg.ci.yaml | 11 +++
1 file changed, 11 insertions(
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Shenglei Zhang
Acked-by: Laszlo Ersek
---
OvmfPkg/OvmfPkg.ci.yaml | 11 +++
1 file chang
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
Acked-by: Ray Ni
---
PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 11 +++
1 file changed, 11 insertions(+)
diff --git a/Pc
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Shenglei Zhang
Acked-by: Ray Ni
---
UefiCpuPkg/UefiCpuPkg.ci.yaml | 11 +++
1 file changed, 11 inser
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
EccCheck is a plugin to report Ecc issues for code in pull request
, which will be run on open ci.
But note not each kind of issue could be reported out.
It can only handle the issues, whose line number in CSV report
accurately map with their
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
As planed we will enable Ecc check for edk2 on open ci. And they are
ready now. I appreciate receiving feedback and comments if someone
find errors or false positive issues.
I created a pipline of EccCheck for my forked edk2. Welcome everyon
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Michael D Kinney
Cc: Sean Brogan
Cc: Bret Barkelew
Signed-off-by: Shenglei Zhang
---
UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 10 ++
1 file cha
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
Reviewed-by: Guomin Jiang
---
PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 11 +++
1 file changed, 11 insertions(+)
diff -
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Liming Gao
Cc: Michael D Kinney
Signed-off-by: Shenglei Zhang
Reviewed-by: Guomin Jiang
---
FmpDevicePkg/FmpDevicePkg.ci.yaml | 11 +++
1 file changed, 11
1 - 100 of 477 matches
Mail list logo
