Re: [edk2-devel] Question about UEFI, AddressSanitizer and MMU mappings

Hello, I have some experience porting LLVM Sanitizers and am very interested in this project coming live to UEFI as well. I had success with both entirely static shadow memory allocation and dynamic on-demand allocation. For ASan in the UEFI  my personal idea would be trying to avoid page-fault

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix CPU stack guard support by aligning GDT buffer

I think in other places, the GDT is allocated using AllocatePool() > which guarantees an 8-byte alignment. > > Are you suggesting that the ALIGNAS macro would map to the compiler > specific alignment directives? We have not had to introduce that yet > and would like to figure ou

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix CPU stack guard support by aligning GDT buffer

user >> Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix CPU stack guard support by >> aligning GDT buffer >> >> UefiCpuPkg maintainers - please respond. >> >> Meanwhile, Vitaly, could you please provide a commit message? >> The BZ link is needed, but

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix CPU stack guard support by aligning GDT buffer

On Mon, Sep 20, 2021 at 17:13:47 +0300, Vitaly Cheptsov wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id639 >> >> >> >> Cc: Jiewen Yao >> >> Cc: Eric Dong >> >> Cc: Michael Kinney >> >> Cc: Jian J Wang >&g

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix CPU stack guard support by aligning GDT buffer

itting an update after > this patch is merged. > > >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3639 >> >> Cc: Jiewen Yao >> Cc: Eric Dong >> Cc: Michael Kinney >> Cc: Jian J Wang >> Cc: Jeff Fan >> Cc: Mikhail Krichanov

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix CPU stack guard support by aligning GDT buffer

Just to make it clear, this is an immediate solution that is good enough to fix the bug. However, a more proper solution would be to introduce the _Alignas ( https://en.cppreference.com/w/c/language/_Alignas ) concept to EDK II. I would suggest the following macro in Base.h: /** Enforce custom

[edk2-devel] [PATCH] UefiCpuPkg: Fix CPU stack guard support by aligning GDT buffer

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3639 Cc: Jiewen Yao Cc: Eric Dong Cc: Michael Kinney Cc: Jian J Wang Cc: Jeff Fan Cc: Mikhail Krichanov Cc: Marvin Häuser Signed-off-by: Vitaly Cheptsov --- .../Library/CpuExceptionHandlerLib/DxeException.c| 12

Re: [edk2-devel] [PATCH EDK2 v2 1/1] SecurityPkg/DxeImageVerificationLib:Enhanced verification of Offset

As a follow-up to Marvin’s e-mail and in the reference of the thread. I should add that to make the result more reliable we not only hope for the reviewer experience and testing, but also write formal proofs for several code properties. This is the primary reason the C code has not yet left the

Re: [edk2-devel] [Patch v9 2/2] MdePkg/Test/BaseLib: Add SAFE_STRING_CONSTRAINT_CHECK unit test

Time to get this land, thx Mike!Reviewed-By: Vitaly Cheptsov <vit9...@protonmail.com>On Wed, May 20, 2020 at 23:10, Michael D Kinney <michael.d.kin...@intel.com> wrote: Use the safe string function StrCpyS() in BaseLib to test theSAFE_STRING_CONSTRAINT_CHECK() macro.Cc: Andrew

Re: [edk2-devel] [Patch v9 2/2] MdePkg/Test/BaseLib: Add SAFE_STRING_CONSTRAINT_CHECK unit test

Time to get this land, thx Mike!Reviewed-By: Vitaly Cheptsov On Wed, May 20, 2020 at 23:10, Michael D Kinney <michael.d.kin...@intel.com> wrote: Use the safe string function StrCpyS() in BaseLib to test theSAFE_STRING_CONSTRAINT_CHECK() macro.Cc: Andrew Fish Cc: Ard Biesheuvel Cc

Re: [edk2-devel] [Patch v8 2/2] MdePkg/Test/BaseLib: Add SAFE_STRING_CONSTRAINT_CHECK unit test

Kinney > Cc: Vincent Zimmer > Cc: Zhichao Gao > Cc: Jiewen Yao > Cc: Vitaly Cheptsov > Signed-off-by: Michael D Kinney > --- > .../UnitTest/Library/BaseLib/Base64UnitTest.c | 85 +++ > 1 file changed, 85 insertions(+) > > diff --git a/MdePkg/Test

Re: [edk2-devel] [Patch v8 1/2] MdePkg: Fix SafeString performing assertions on runtime checks

Brian J. Johnson > Cc: Chasel Chiu > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Liming Gao > Cc: Marvin H?user > Cc: Michael D Kinney > Cc: Vincent Zimmer > Cc: Zhichao Gao > Cc: Jiewen Yao > Signed-off-by: Vitaly Cheptsov > --- &g

Re: [edk2-devel] [PATCH V7 1/1] MdePkg: Fix SafeString performing assertions on runtime checks

bled by default. A > developer that wants to see SAFE_STRING_CONSTRAINT_CHECK() conditions > that fail would need to enable DEBUG_VERBOSE messages. > > Thanks, > > Mike > > >> -Original Message----- >> From: devel@edk2.groups.io On >> Behalf

Re: [edk2-devel] [PATCH V6 1/1] MdePkg: Fix SafeString performing assertions on runtime checks

2.groups.io <mailto:devel@edk2.groups.io> >> mailto:devel@edk2.groups.io>> On >> Behalf Of Vitaly Cheptsov >> Sent: Thursday, May 14, 2020 10:39 AM >> To: Kinney, Michael D > <mailto:michael.d.kin...@intel.com>> >> Cc: devel@edk2.grou

Re: [edk2-devel] [PATCH V6 1/1] MdePkg: Fix SafeString performing assertions on runtime checks

ike > >> -Original Message- >> From: devel@edk2.groups.io On >> Behalf Of Vitaly Cheptsov >> Sent: Thursday, May 14, 2020 2:26 AM >> To: devel@edk2.groups.io >> Cc: Andrew Fish ; Ard Biesheuvel >> ; Bret Barkelew >> ; Brian J . Johnso

[edk2-devel] [PATCH V7 1/1] MdePkg: Fix SafeString performing assertions on runtime checks

: Jordan Justen CC: Laszlo Ersek CC: Leif Lindholm CC: Liming Gao CC: Marvin Häuser CC: Mike Kinney CC: Vincent Zimmer CC: Zhichao Gao Signed-off-by: Vitaly Cheptsov --- MdePkg/Include/Library/BaseLib.h| 111 --- MdePkg/Library/BaseLib/SafeString.c | 112

[edk2-devel] [PATCH V7 0/1] Disable safe string constraint assertions

reduce the communication to the minimum and abstain from proposing another approach. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Requesting to merge this into edk2-stable202005. Vitaly Cheptsov (1): MdePkg: Fix SafeString performing assertions on runtime checks MdePkg/Include

[edk2-devel] [PATCH V6 1/1] MdePkg: Fix SafeString performing assertions on runtime checks

Chiu CC: Jordan Justen CC: Laszlo Ersek CC: Leif Lindholm CC: Liming Gao CC: Marvin Häuser CC: Mike Kinney CC: Vincent Zimmer CC: Zhichao Gao Signed-off-by: Vitaly Cheptsov --- MdePkg/Include/Library/BaseLib.h| 120 ++-- MdePkg/Library/BaseLib/SafeString.c

[edk2-devel] [PATCH V6 0/1] Disable safe string constraint assertions

proposing another approach. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Requesting to merge this into edk2-stable202005. Vitaly Cheptsov (1): MdePkg: Fix SafeString performing assertions on runtime checks MdePkg/Include/Library/BaseLib.h| 120 ++-- MdePkg/Library

Re: [edk2-devel] [PATCH V4 00/27] Disabling safe string constraint assertions

002 | (gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask > & 0xC0) == 0 > - gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0|UINT8|0x0005 > - > ## This flag is used to control the print out Debug message. > # BIT0 - Initialization message. > # BIT1 - Warning message. >

Re: [edk2-devel] [PATCH V4 00/27] Disabling safe string constraint assertions

module link > will then fail when the module writer followed all the > rules. This is why including a libclass from another > libclass is bad idea. > > Mike > >> -Original Message- >> From: devel@edk2.groups.io On >> Behalf Of Laszlo Ersek >> Se

[edk2-devel] [PATCH V5 11/27] EmulatorPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Jordan Justen CC: Andrew Fish CC: Ray Ni Signed-off-by: Vitaly Cheptsov --- EmulatorPkg/EmulatorPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc index 1fc924ae5a

[edk2-devel] [PATCH V5 18/27] ShellPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Signed-off-by: Vitaly Cheptsov --- ShellPkg/ShellPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc index b7ee856b3a..27b148e6b2 100644 --- a/ShellPkg/ShellPkg.dsc +++ b/ShellPkg

[edk2-devel] [PATCH V5 02/27] UnitTestFrameworkPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Michael D Kinney CC: Sean Brogan CC: Bret Barkelew Signed-off-by: Vitaly Cheptsov --- UnitTestFrameworkPkg/Library/Posix/DebugLibPosix/DebugLibPosix.c | 94 UnitTestFrameworkPkg/Library/Posix/DebugLibPosix

[edk2-devel] [PATCH V5 24/27] UefiCpuPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Eric Dong CC: Ray Ni CC: Laszlo Ersek Signed-off-by: Vitaly Cheptsov --- UefiCpuPkg/UefiCpuPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc index d28cb5cccb

[edk2-devel] [PATCH V5 27/27] MdePkg: Use assertion on constraint violation bit in SafeString

violations. CC: Michael D Kinney CC: Liming Gao Signed-off-by: Vitaly Cheptsov --- MdePkg/Include/Library/BaseLib.h| 120 ++-- MdePkg/Library/BaseLib/SafeString.c | 2 +- 2 files changed, 61 insertions(+), 61 deletions(-) diff --git a/MdePkg/Include/Library/BaseLib.h b/MdePkg

[edk2-devel] [PATCH V5 06/27] ArmPlatformPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Leif Lindholm CC: Ard Biesheuvel Signed-off-by: Vitaly Cheptsov --- ArmPlatformPkg/ArmPlatformPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/ArmPlatformPkg/ArmPlatformPkg.dsc b/ArmPlatformPkg/ArmPlatformPkg.dsc index

[edk2-devel] [PATCH V5 15/27] IntelFsp2WrapperPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Chasel Chiu CC: Nate DeSimone CC: Star Zeng Signed-off-by: Vitaly Cheptsov --- IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc b

[edk2-devel] [PATCH V5 17/27] NetworkPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Maciej Rabeda CC: Jiaxin Wu CC: Siyuan Fu Signed-off-by: Vitaly Cheptsov --- NetworkPkg/NetworkPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc index 503d828f91

[edk2-devel] [PATCH V5 20/27] PcAtChipsetPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Ray Ni Signed-off-by: Vitaly Cheptsov --- PcAtChipsetPkg/PcAtChipsetPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dsc b/PcAtChipsetPkg/PcAtChipsetPkg.dsc index 01a3ee716a..89d66744eb

[edk2-devel] [PATCH V5 12/27] FatPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Ray Ni Signed-off-by: Vitaly Cheptsov --- FatPkg/FatPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/FatPkg/FatPkg.dsc b/FatPkg/FatPkg.dsc index d86256068b..f811964085 100644 --- a/FatPkg/FatPkg.dsc +++ b/FatPkg/FatPkg.dsc

[edk2-devel] [PATCH V5 05/27] ArmPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Leif Lindholm CC: Ard Biesheuvel Signed-off-by: Vitaly Cheptsov --- ArmPkg/ArmPkg.dsc | 1 + ArmPkg/Drivers/ArmCrashDumpDxe/ArmCrashDumpDxe.dsc | 1 + ArmPkg/Library

[edk2-devel] [PATCH V5 01/27] MdePkg: Introduce DebugCommonLib interface and BaseDebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 This library allows to make a common part of all DebugLib instances and avoid the need to update every DebugLib on extending a new debug mask PCD bit. CC: Michael D Kinney CC: Liming Gao Signed-off-by: Vitaly Cheptsov --- MdePkg

[edk2-devel] [PATCH V5 16/27] OvmfPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Jordan Justen CC: Laszlo Ersek CC: Ard Biesheuvel Signed-off-by: Vitaly Cheptsov --- OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c | 98 OvmfPkg/Library/PlatformDebugLibIoPort

[edk2-devel] [PATCH V5 23/27] StandaloneMmPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Ard Biesheuvel CC: Sami Mujawar CC: Jiewen Yao CC: Supreeth Venkatesh Signed-off-by: Vitaly Cheptsov --- StandaloneMmPkg/StandaloneMmPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/StandaloneMmPkg/StandaloneMmPkg.dsc

[edk2-devel] [PATCH V5 08/27] CryptoPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Jian J Wang CC: Xiaoyu Lu Signed-off-by: Vitaly Cheptsov --- CryptoPkg/CryptoPkg.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CryptoPkg/CryptoPkg.dsc b/CryptoPkg/CryptoPkg.dsc index f79ff331cf..72c8429c0a 100644 --- a

[edk2-devel] [PATCH V5 00/27] Disabling safe string constraint assertions

://edk2.groups.io/g/devel/topic/74138532. Requesting to merge into edk2-stable202005. Vitaly Cheptsov (27): MdePkg: Introduce DebugCommonLib interface and BaseDebugCommonLib UnitTestFrameworkPkg: Add support for DebugCommonLib MdePkg: Add support for DebugCommonLib MdeModulePkg: Add support

[edk2-devel] [PATCH V5 09/27] DynamicTablesPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Sami Mujawar CC: Alexei Fedorov Signed-off-by: Vitaly Cheptsov --- DynamicTablesPkg/DynamicTablesPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc b/DynamicTablesPkg

[edk2-devel] [PATCH V5 04/27] MdeModulePkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Jian J Wang CC: Hao A Wu Signed-off-by: Vitaly Cheptsov --- MdeModulePkg/Library/PeiDebugLibDebugPpi/DebugLib.c | 100 MdeModulePkg/Library/PeiDebugLibDebugPpi

[edk2-devel] [PATCH V5 25/27] UefiPayloadPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Maurice Ma CC: Guo Dong CC: Benjamin You Signed-off-by: Vitaly Cheptsov --- UefiPayloadPkg/UefiPayloadPkgIa32.dsc| 1 + UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 1 + 2 files changed, 2 insertions(+) diff --git a

[edk2-devel] [PATCH V5 26/27] MdePkg: Introduce assertion on constraint debug mask bit

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 This bit allows to control assertion on constraint violation. CC: Michael D Kinney CC: Liming Gao Signed-off-by: Vitaly Cheptsov --- MdePkg/Include/Library/DebugCommonLib.h| 18 ++ MdePkg/Include/Library

[edk2-devel] [PATCH V5 22/27] SourceLevelDebugPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Hao A Wu Signed-off-by: Vitaly Cheptsov --- SourceLevelDebugPkg/SourceLevelDebugPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc b/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc

[edk2-devel] [PATCH V5 21/27] SignedCapsulePkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Jiewen Yao CC: Chao Zhang Signed-off-by: Vitaly Cheptsov --- SignedCapsulePkg/SignedCapsulePkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/SignedCapsulePkg/SignedCapsulePkg.dsc b/SignedCapsulePkg/SignedCapsulePkg.dsc

Re: [edk2-devel] [PATCH V4 00/27] Disabling safe string constraint assertions

Hello everyone, Let me try in order. After an internal review I added the following to SafeString commit message: Note, for packages with constraint assertions disabled this change turn off the assertions on constraint violations. This is obvious, and I believe everyone agreed it is not healthy e

[edk2-devel] [PATCH V5 14/27] IntelFsp2Pkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Chasel Chiu CC: Nate DeSimone CC: Star Zeng Signed-off-by: Vitaly Cheptsov --- IntelFsp2Pkg/IntelFsp2Pkg.dsc| 1 + IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort

[edk2-devel] [PATCH V5 03/27] MdePkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Michael D Kinney CC: Liming Gao Signed-off-by: Vitaly Cheptsov --- MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf | 8 ++ MdePkg/Library/BaseDebugLibNull/DebugLib.c

[edk2-devel] [PATCH V5 19/27] SecurityPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Ray Ni CC: Zhichao Gao Signed-off-by: Vitaly Cheptsov --- SecurityPkg/SecurityPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc index 53fce05353..aa9814474c 100644

[edk2-devel] [PATCH V5 10/27] EmbeddedPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Leif Lindholm CC: Ard Biesheuvel Signed-off-by: Vitaly Cheptsov --- EmbeddedPkg/EmbeddedPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc index e88d76ab2f

[edk2-devel] [PATCH V5 13/27] FmpDevicePkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Liming Gao CC: Michael D Kinney Signed-off-by: Vitaly Cheptsov --- FmpDevicePkg/FmpDevicePkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/FmpDevicePkg/FmpDevicePkg.dsc b/FmpDevicePkg/FmpDevicePkg.dsc index b8fb9d7c19

[edk2-devel] [PATCH V5 07/27] ArmVirtPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Laszlo Ersek CC: Ard Biesheuvel CC: Leif Lindholm Signed-off-by: Vitaly Cheptsov --- ArmVirtPkg/ArmVirt.dsc.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc index

[edk2-devel] [PATCH V4 24/27] UefiCpuPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Signed-off-by: Vitaly Cheptsov --- UefiCpuPkg/UefiCpuPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc index d28cb5cccb..f5f407ad23 100644 --- a/UefiCpuPkg/UefiCpuPkg.dsc

[edk2-devel] [PATCH V4 01/27] MdePkg: Introduce DebugCommonLib interface and BaseDebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 This library allows to make a common part of all DebugLib instances and avoid the need to update every DebugLib on extending a new debug mask PCD bit. Signed-off-by: Vitaly Cheptsov --- MdePkg/Include/Library/DebugCommonLib.h

[edk2-devel] [PATCH V4 20/27] PcAtChipsetPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Signed-off-by: Vitaly Cheptsov --- PcAtChipsetPkg/PcAtChipsetPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dsc b/PcAtChipsetPkg/PcAtChipsetPkg.dsc index 01a3ee716a..89d66744eb 100644 --- a

[edk2-devel] [PATCH V4 21/27] SignedCapsulePkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Signed-off-by: Vitaly Cheptsov --- SignedCapsulePkg/SignedCapsulePkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/SignedCapsulePkg/SignedCapsulePkg.dsc b/SignedCapsulePkg/SignedCapsulePkg.dsc index c5080ec1dd..c3bedb1462

[edk2-devel] [PATCH V4 03/27] MdePkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Signed-off-by: Vitaly Cheptsov --- MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf | 10 ++ MdePkg/Library/BaseDebugLibNull/DebugLib.c | 98 --- MdePkg

[edk2-devel] [PATCH V4 22/27] SourceLevelDebugPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Signed-off-by: Vitaly Cheptsov --- SourceLevelDebugPkg/SourceLevelDebugPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc b/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc index a1a1b81d03

[edk2-devel] [PATCH V4 09/27] DynamicTablesPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Signed-off-by: Vitaly Cheptsov --- DynamicTablesPkg/DynamicTablesPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc b/DynamicTablesPkg/DynamicTablesPkg.dsc index 02f04447ff..239f671952

[edk2-devel] [PATCH V4 08/27] CryptoPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Signed-off-by: Vitaly Cheptsov --- CryptoPkg/CryptoPkg.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CryptoPkg/CryptoPkg.dsc b/CryptoPkg/CryptoPkg.dsc index f79ff331cf..72c8429c0a 100644 --- a/CryptoPkg/CryptoPkg.dsc +++ b

[edk2-devel] [PATCH V4 16/27] OvmfPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Signed-off-by: Vitaly Cheptsov --- OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c| 98 OvmfPkg/Library/PlatformDebugLibIoPort/PlatformRomDebugLibIoPort.inf | 1 + OvmfPkg/OvmfPkgIa32.dsc

[edk2-devel] [PATCH V4 00/27] Disabling safe string constraint assertions

Cc: Andrew Fish Cc: Mike Kinney Cc: Marvin Häuser Cc: Liming Gao Cc: Zhichao Gao CC: Laszlo Ersek This changesest hopefully finally resolves the longstanding https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Requesting to merge into edk2-stable202005. Vitaly Cheptsov (27): MdePkg

[edk2-devel] [PATCH V4 25/27] UefiPayloadPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Signed-off-by: Vitaly Cheptsov --- UefiPayloadPkg/UefiPayloadPkgIa32.dsc| 1 + UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 1 + 2 files changed, 2 insertions(+) diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc b/UefiPayloadPkg

[edk2-devel] [PATCH V4 04/27] MdeModulePkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Signed-off-by: Vitaly Cheptsov --- MdeModulePkg/Library/PeiDebugLibDebugPpi/DebugLib.c | 100 MdeModulePkg/Library/PeiDebugLibDebugPpi/PeiDebugLibDebugPpi.inf

[edk2-devel] [PATCH V4 13/27] FmpDevicePkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Signed-off-by: Vitaly Cheptsov --- FmpDevicePkg/FmpDevicePkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/FmpDevicePkg/FmpDevicePkg.dsc b/FmpDevicePkg/FmpDevicePkg.dsc index b8fb9d7c19..25ce1bd783 100644 --- a/FmpDevicePkg

[edk2-devel] [PATCH V4 11/27] EmulatorPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Signed-off-by: Vitaly Cheptsov --- EmulatorPkg/EmulatorPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc index 1fc924ae5a..3d2bfaad96 100644 --- a/EmulatorPkg

[edk2-devel] [PATCH V4 14/27] IntelFsp2Pkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Signed-off-by: Vitaly Cheptsov --- IntelFsp2Pkg/IntelFsp2Pkg.dsc| 1 + IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialPort.inf | 1 + IntelFsp2Pkg/Library

[edk2-devel] [PATCH V4 17/27] NetworkPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Signed-off-by: Vitaly Cheptsov --- NetworkPkg/NetworkPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc index 503d828f91..6018bc7e00 100644 --- a/NetworkPkg/NetworkPkg.dsc

[edk2-devel] [PATCH V4 15/27] IntelFsp2WrapperPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Signed-off-by: Vitaly Cheptsov --- IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc index cb4f69285d

[edk2-devel] [PATCH V4 26/27] MdePkg: Introduce assertion on constraint debug mask bit

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 This bit allows to control assertion on constrain violation. Signed-off-by: Vitaly Cheptsov --- MdePkg/Include/Library/DebugCommonLib.h| 18 ++ MdePkg/Include/Library/DebugLib.h | 18

[edk2-devel] [PATCH V4 02/27] UnitTestFrameworkPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Signed-off-by: Vitaly Cheptsov --- UnitTestFrameworkPkg/Library/Posix/DebugLibPosix/DebugLibPosix.c | 94 UnitTestFrameworkPkg/Library/Posix/DebugLibPosix/DebugLibPosix.inf | 1 + UnitTestFrameworkPkg

[edk2-devel] [PATCH V4 10/27] EmbeddedPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Signed-off-by: Vitaly Cheptsov --- EmbeddedPkg/EmbeddedPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc index e88d76ab2f..28822c66f4 100644 --- a/EmbeddedPkg

[edk2-devel] [PATCH V4 18/27] ShellPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Signed-off-by: Vitaly Cheptsov --- ShellPkg/ShellPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc index b7ee856b3a..27b148e6b2 100644 --- a/ShellPkg/ShellPkg.dsc +++ b/ShellPkg

[edk2-devel] [PATCH V4 27/27] MdePkg: Use assertion on constraint violation bit in SafeString

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 This change allows using SafeString interfaces for untrusted data checking when constraint violation assertions are disabled. Signed-off-by: Vitaly Cheptsov --- MdePkg/Include/Library/BaseLib.h| 120 ++-- MdePkg

[edk2-devel] [PATCH V4 23/27] StandaloneMmPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Signed-off-by: Vitaly Cheptsov --- StandaloneMmPkg/StandaloneMmPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/StandaloneMmPkg/StandaloneMmPkg.dsc b/StandaloneMmPkg/StandaloneMmPkg.dsc index f9546e182e..5d1fb929f7 100644

[edk2-devel] [PATCH V4 07/27] ArmVirtPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Signed-off-by: Vitaly Cheptsov --- ArmVirtPkg/ArmVirt.dsc.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc index cf44fc7389..4f3092a201 100644 --- a/ArmVirtPkg/ArmVirt.dsc.inc

[edk2-devel] [PATCH V4 12/27] FatPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Signed-off-by: Vitaly Cheptsov --- FatPkg/FatPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/FatPkg/FatPkg.dsc b/FatPkg/FatPkg.dsc index d86256068b..f811964085 100644 --- a/FatPkg/FatPkg.dsc +++ b/FatPkg/FatPkg.dsc @@ -44,6

[edk2-devel] [PATCH V4 05/27] ArmPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Signed-off-by: Vitaly Cheptsov --- ArmPkg/ArmPkg.dsc | 1 + ArmPkg/Drivers/ArmCrashDumpDxe/ArmCrashDumpDxe.dsc | 1 + ArmPkg/Library/SemiHostingDebugLib/DebugLib.c | 84

[edk2-devel] [PATCH V4 06/27] ArmPlatformPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Signed-off-by: Vitaly Cheptsov --- ArmPlatformPkg/ArmPlatformPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/ArmPlatformPkg/ArmPlatformPkg.dsc b/ArmPlatformPkg/ArmPlatformPkg.dsc index 5381c95af2..2a3432d91e 100644 --- a

[edk2-devel] [PATCH V4 19/27] SecurityPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Signed-off-by: Vitaly Cheptsov --- SecurityPkg/SecurityPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc index 53fce05353..aa9814474c 100644 --- a/SecurityPkg

Re: [edk2-devel] Disabling safe string constraint assertions

this time, and I hope only some small nuances are left. Best wishes, Vitaly > 11 мая 2020 г., в 18:19, Laszlo Ersek написал(а): > > On 05/11/20 14:03, Vitaly Cheptsov wrote: >> Hello, >> >> The new version of the patchset was submitted via github (mainly due to the &g

Re: [edk2-devel] Disabling safe string constraint assertions

I hope this still is in time for the May tag. Best wishes, Vitaly > 19 марта 2020 г., в 03:04, Vitaly Cheptsov написал(а): > > Andrew, Mike, > > Thank you very much for the comments. Yes, I am aware of PCD overriding in > the DSC file, and in fact we are using it for t

Re: [edk2-devel] [PATCH 1/1] ShellPkg: Add support for input with separately reported modifiers

be the situation: > 1. Change for all apps -> uefi spec update and accept such behavior > with description -> Done. > 2. Change for all apps -> uefi spec update to remove the ambiguous and > reject other behavior -> removal the change in first step. > >

Re: [edk2-devel] [PATCH 1/1] ShellPkg: Add support for input with separately reported modifiers

ate to remove the ambiguous and > reject other behavior -> removal the change in first step. > > Hi Vitaly, > > I used to think it is an additional support for different implementation > because of the spec. But if we approve this patch, all the app in edk2 using > t

[edk2-devel] [PATCH 0/1] OvmfPkg: Fix SMM/RT driver section alignment for XCODE5/CLANGPDB

Currently memory protection attributes are not working with XCODE5 and CLANGPDB (Xen only) due to misaligned sections. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2642 Requesting for merge in edk2-stable202005. Vitaly Cheptsov (1): OvmfPkg: Fix SMM/RT driver section alignment for

[edk2-devel] [PATCH 1/1] OvmfPkg: Fix SMM/RT driver section alignment for XCODE5/CLANGPDB

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2642 This patch resolves the problem of using memory protection attributes when OVMF firmware is compiled with XCODE5 and CLANGPDB. CC: Andrew Fish CC: Laszlo Ersek CC: Marvin Häuser Signed-off-by: Vitaly Cheptsov --- OvmfPkg/OvmfPkgIa32

Re: [edk2-devel] [PATCH 1/1] ShellPkg: Add support for input with separately reported modifiers

t below: > > > -Original Message- > > From: devel@edk2.groups.io <mailto:devel@edk2.groups.io> > > mailto:devel@edk2.groups.io>> On Behalf Of Vitaly > > Cheptsov via Groups.Io > > Sent: Monday, February 10, 2020 6:18 PM > > To: devel@edk2.groups.

[edk2-devel] [PATCH 0/1] BaseTools: Use SEH exceptions in CLANGPDB for IA32

From: Vitaly Cheptsov REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2628 Requesting for merge in edk2-stable202005. CC: Liming Gao CC: Marvin Häuser CC: Zhiguang Liu Vitaly Cheptsov (1): BaseTools: Use SEH exceptions in CLANGPDB for IA32 BaseTools/Conf/tools_def.template | 14

[edk2-devel] [PATCH 1/1] BaseTools: Use SEH exceptions in CLANGPDB for IA32

From: Vitaly Cheptsov REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2628 This patch reduces the size of IA32 binaries by ensuring that no .debug_frame / .eh_frame sections are generated through forcing SEH exception model, which is already the default in clang for X64. EDK II does not

Re: [edk2-devel] [PATCH 1/2] BaseTools: Change CLANGPDB target to reduce image size

t; > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2628 > > Using target i686-unknown-windows will generate smaller IA32 FV. > > CC: Vitaly Cheptsov > CC: Liming Gao > CC: Bob Feng > Signed-off-by: Zhiguang Liu > --- > BaseTools/Conf/tools_def.template | 2

Re: [edk2-devel] CLANGPDB binary debugging

21 марта 2020 г., в 20:13, Andrew Fish <af...@apple.com> написал(а):On Mar 21, 2020, at 3:28 AM, Vitaly Cheptsov <chept...@ispras.ru> wrote:Hello,Andrey, thanks for the hint, it was very helpful. I rewrote the GDB scripts to work with LLDB[1] and was able to debug OVMF built with CLA

Re: [edk2-devel] CLANGPDB binary debugging

/master/Debug/Scripts/lldb_uefi.py Best wishes, Vitaly > 20 марта 2020 г., в 22:14, Andrew Fish написал(а): > > > >> On Mar 20, 2020, at 8:13 AM, Vitaly Cheptsov > <mailto:chept...@ispras.ru>> wrote: >> >> Hello, >> >> We noticed that the

[edk2-devel] CLANGPDB binary debugging

Hello, We noticed that the original bugzilla, which intended to add new LLVM toolchain support[1], also wanted to bring ELF format support with DWARF debugging information. For some reason this did not make its way into EDK II, and we are currently wondering, how can one debug binaries built wi

Re: [edk2-devel] Disabling safe string constraint assertions

Library/BasePrintLib/BasePrintLib.inf > > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf > > > gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0xFF > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|8000

Re: [edk2-devel] Disabling safe string constraint assertions

d a one line declaration in a DEC file) to provide extra information > such as PCDs that the library class uses. We would need a significant > extension to the DEC file format and build tools for a library class > declaration to provide more information. > > Mike > > From: V

Re: [edk2-devel] Disabling safe string constraint assertions

.groups.io> > mailto:devel@edk2.groups.io>> On Behalf Of Vitaly > Cheptsov > Sent: Wednesday, March 18, 2020 12:36 PM > To: Laszlo Ersek mailto:ler...@redhat.com>>; Andrew Fish > mailto:af...@apple.com>>; Kinney, Michael D > mailto:michael.d.ki

Re: [edk2-devel] Disabling safe string constraint assertions

11 марта 2020 г., в 16:14, Laszlo Ersek <ler...@redhat.com> написал(а):On 03/11/20 14:09, Vitaly Cheptsov wrote:Hi everyone,So, I believe that by now we mostly agreed to let the originalproposition land as a short-term solution. We end up with:1. A PCD condition

Re: [edk2-devel] Disabling safe string constraint assertions

aszlo Ersek wrote: >> >>> On 03/04/20 18:53, Andrew Fish wrote: >>> >>> >>>> On Mar 4, 2020, at 5:33 AM, Laszlo Ersek wrote: >>>> >>>>> On 03/03/20 22:12, Vitaly Cheptsov wrote: >>>>> Hello, >>>>>

[edk2-devel] Disabling safe string constraint assertions

Hello, I am creating a new thread for this issue, as for some reason half of my messages do not display in the web-interface and some of e-mail clients in the previous one. It seems that somebody sent broken HTML code to groups.io , and it did not like to be quoted. It will b

Re: [edk2-devel] Patch List for 202002 stable tag

Liming, no problem from our side. The patch is now reviewed and I believe I provided all the necessarily material regarding its status. In case Ray would rather postpone it, I give no objection to this without prior notice. There is no problem from our side if EDK II team wants to prioritise ot

Re: [edk2-devel] Patch List for 202002 stable tag

Liming, Thanks for pinging me about this! With the PCD[1][2] I fully agree. The fact that it did not manage to land is mainly due to a sudden discussion that arose after complete silence for almost half a year, which was sort of unexpected. I will use this message as a suggestion to include th

Re: [edk2-devel] [PATCH 1/1] ShellPkg: Add support for input with separately reported modifiers

> -Original Message- >> From: devel@edk2.groups.io On Behalf Of Vitaly >> Cheptsov via Groups.Io >> Sent: Monday, February 10, 2020 6:18 PM >> To: devel@edk2.groups.io >> Subject: [edk2-devel] [PATCH 1/1] ShellPkg: Add support for input with &

  1   2   >