Re: [edk2-devel] [V1 PATCH 1/1] MdePkg: TDX: Correct TDCALL_INFO_RETURN_DATA layout

2023-04-25 Thread Vishal Annapurve via groups.io
On Wed, Feb 15, 2023 at 4:10 PM Xu, Min M wrote: > > On February 16, 2023 3:51 AM, Vishal Annapurve wrote: > > > > TDCALL_INFO should return num_vcpus as lower 4 bytes of r8 register > > according to the tdx spec, so reorder num_vcpus and max_vcpus fields to > > match the spec. > > > > Reference:

[edk2-devel] [V1 PATCH 1/1] MdePkg: TDX: Correct TDCALL_INFO_RETURN_DATA layout

2023-02-15 Thread Vishal Annapurve via groups.io
TDCALL_INFO should return num_vcpus as lower 4 bytes of r8 register according to the tdx spec, so reorder num_vcpus and max_vcpus fields to match the spec. Reference: Table 22.210 TDG.VP.INFO output operands https://cdrdv2.intel.com/v1/dl/getContent/733568 Signed-off-by: Vishal Annapurve --- Md

Re: [edk2-devel] [PATCH V4 22/31] OvmfPkg: Update PlatformPei to support TDX

2022-01-13 Thread Vishal Annapurve via groups.io
Thanks Min for the reference of the firmware design guide. If VMM is expected to set it then issue I mentioned with CoreInitializeMemoryServices can be ignored. Though its mentioned in the design guide, I was confused by the current implementation of TDX Qemu as per: https://github.com/intel/qe

Re: [edk2-devel] [PATCH V4 22/31] OvmfPkg: Update PlatformPei to support TDX

2022-01-13 Thread Vishal Annapurve via groups.io
Hi Min, > > +/** > + Transfer the incoming HobList for the TD to the final HobList for Dxe. > + The Hobs transferred in this function are ResourceDescriptor hob and > + MemoryAllocation hob. > + > + @param[in] VmmHobList The Hoblist pass the firmware > + > +**/ > +VOID > +EFIAPI > +TransferTdxHob

Re: [edk2-devel] [PATCH V6 1/1] OvmfPkg: Enable TDX in ResetVector

2021-09-14 Thread Vishal Annapurve via groups.io
Hi Min, Brijesh, Regarding: > diff --git a/OvmfPkg/ResetVector/Ia16/ResetVectorVtf0.asm b/OvmfPkg/ResetVector/Ia16/ResetVectorVtf0.asm > ... > +%ifdef ARCH_IA32 > nop > nop > jmp EarlyBspInitReal16 > >+%else >+ >+smswax We are having intermittent VM crashes with running th