Re: [edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms

Apologies, I am afraid as I may not be able to incorporate/address all the concerns expressed in the thread due to lack of my understanding in this space. But I have created a new PR which addresses Yi Li concerns about constraining the changes only to CryptoPkg. EDK2: PR to enable ECC Ciphers i

Re: [edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms

Sorry I missed the earlier feedback from You/Gerd/Jiewen and replied quickly with my updated patch set. I will try to look at them. -Vineel -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87252): https://edk2.groups.io/g/devel/message/87

Re: [edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms

Hi Yi Li, I am able to incorporate all your feedback regarding commit hygiene. Also able to validate them by firing an sample PR against EDK2 master https://github.com/tianocore/edk2/pull/2550/checks All of the checks passed expected 3 which seems to be infrastructure related. I would need your

Re: [edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms

Huge Thanks for "You can submit PR to edk2 mater branch directly to check for CI bugs(will not be reviewed or merged)." I am fixing them. Regarding the style(extra spaces and tabs), It is actually coming from openssl when we run CryptoPkg/Library/OpensslLib/process_files.pl Not sure if there a w

Re: [edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms

Hi Yi Li, I have posted the recent patch set to enable ECC ciphers in OpenSSLLib to the bug https://bugzilla.tianocore.org/show_bug.cgi?id=3679 I have ran the entire OVMF Azure pipeline locally and confirm that the code gets build without any issue. Thanks for the inputs after enlarging DXEFV t

Re: [edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms

Hi, Thanks for providing the inputs here. Really appreciated. I will try to resume the work(had to put it aside due to other priorities). Please expect the patch by EOW. Thanks, Vineel From: devel@edk2.groups.io On Behalf Of yi1 li via groups.io Sent: Tuesday, February 22, 2022 6:33 PM To: Vin

Re: [edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms

Hi Folks, We are able to resolve the __ModuleEntryPoint error and was able to run below build configurations locally. * Windows_VS2019 - Passed * EmulatorPkg_Win_VS2019 - Passed * OvmfPkg_Win_VS2019 - Passed * Ubuntu_GCC5 - Passed * ArmVirtPkg_Ubuntu_GCC5 - Passed * EmulatorPkg_Ubuntu_GCC5 -

Re: [edk2-devel] [PATCH] Enable wildcard host name matching in EDK2 HTTPS/TLS implementation

; Bret Barkelew Subject: Re: [edk2-devel] [PATCH] Enable wildcard host name matching in EDK2 HTTPS/TLS implementation Hi Vineel, I will integrate the change to edk2 tomorrow. For now: Reviewed-by: Maciej Rabeda Thanks, Maciej On 02-Nov-21 19:57, Vineel Kovvuri via groups.io wrote: > Hi Fo

Re: [edk2-devel] [PATCH] Enable wildcard host name matching in EDK2 HTTPS/TLS implementation

Hi Folks, Thanks for reviewing the patch. May I know what are the next steps to get it in to edk2? I have already updated the same in https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning Thanks, Vineel -Original Message- From: Wu, Jiaxin Sent: Monday, Novembe

Re: [edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms

Hi Jiewen, Sorry for the build break. I will fix this locally and send you the patch. Thanks, Vineel -Original Message- From: Yao, Jiewen Sent: Saturday, October 16, 2021 7:49 PM To: Vineel Kovvuri ; devel@edk2.groups.io; Sean Brogan ; Bret Barkelew ; Mike Turner Cc: Vineel Kovvuri