Re: [edk2-devel] [PATCH v2] BaseTools: Add support for version 3 of FMP Image Header structure

2021-05-11 Thread Sughosh Ganu
hi, Can this patch be merged. Thanks. -sughosh On Mon, 26 Apr 2021 at 21:27, Kinney, Michael D wrote: > Reviewed-by: Michael D Kinney > > Mike > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Sughosh > Ganu > > Sent: Friday, Apr

[edk2-devel] [PATCH v2] BaseTools: Add support for version 3 of FMP Image Header structure

2021-04-23 Thread Sughosh Ganu
Add support for the ImageCapsuleSupport field, introduced in version 3 of the EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER structure. This structure member is used to indicate if the corresponding payload has support for authentication and dependency. Signed-off-by: Sughosh Ganu --- Changes

[edk2-devel] [PATCH v2] BaseTools: Add support for version 3 of FMP Image Header structure

2021-04-22 Thread Sughosh Ganu
Add support for the ImageCapsuleSupport field, introduced in version 3 of the EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER structure. This structure member is used to indicate if the corresponding payload has support for authentication and dependency. Signed-off-by: Sughosh Ganu --- Changes

Re: [edk2-devel] [PATCH] BaseTools: GenerateCapsule.py: Add support for version 3 of FMP Image Header structure

2021-04-21 Thread Sughosh Ganu
Okay, understood. I will make the changes and submit a v2 shortly. Thanks for the explanation. -sughosh > > > Mike > > > > *From:* Sughosh Ganu > *Sent:* Wednesday, April 21, 2021 12:02 AM > *To:* Kinney, Michael D > *Cc:* devel@edk2.groups.io; Feng, Bob C ; Liming

Re: [edk2-devel] [PATCH] BaseTools: GenerateCapsule.py: Add support for version 3 of FMP Image Header structure

2021-04-21 Thread Sughosh Ganu
r am I missing something. -sughosh > > Thanks, > > Mike > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Sughosh > Ganu > > Sent: Monday, April 19, 2021 4:40 AM > > To: devel@edk2.groups.io > > Cc: Feng, Bob C ; Liming Ga

[edk2-devel] [PATCH] BaseTools: GenerateCapsule.py: Add support for version 3 of FMP Image Header structure

2021-04-19 Thread Sughosh Ganu
Add support for the ImageCapsuleSupport field, introduced in version 3 of the EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER structure. This structure member is used to indicate if the corresponding payload has support for authentication and dependency. Signed-off-by: Sughosh Ganu --- .../Source

Re: [edk2-devel] [PATCH v2 1/1] ArmPkg: Fix uninitialised variable in ArmMmuStandaloneMmLib

2021-02-26 Thread Sughosh Ganu
ror handling in functions that invoke GetMemoryPermissions(). > > Signed-off-by: Sami Mujawar > --- > The changes can be seen at: > https://github.com/samimujawar/edk2/tree/1657_stmm_ffa_fix_unused_var_v2 Tested the changes on the StandaloneMm image on the Qemu platform. Tested-by

Re: [edk2-devel] [PATCH v5 00/14] Add support for using FF-A calls

2021-02-22 Thread Sughosh Ganu
hi Sami, On Mon, 22 Feb 2021 at 19:40, Ard Biesheuvel wrote: > On Fri, 19 Feb 2021 at 07:36, Sughosh Ganu > wrote: > > > > The following patch series adds support for using the Firmware > > Framework(FF-A) as a transport mechanism for requesting services from > >

Re: [edk2-devel] [PATCH v5 04/14] ArmPkg: Introduce support for PcdFfaEnable

2021-02-22 Thread Sughosh Ganu
hi Ard, On Mon, 22 Feb 2021 at 16:19, Ard Biesheuvel wrote: > On Fri, 19 Feb 2021 at 07:36, Sughosh Ganu > wrote: > > > > The Secure Partition(SP) can request services from the Secure > > Partition Manager Core(SPMC) either through FF-A calls or through the >

[edk2-devel] [PATCH v5 14/14] StandaloneMmPkg: Allow sending FFA Direct Request message to StandaloneMm

2021-02-18 Thread Sughosh Ganu
From: Ilias Apalodimas Allow passing of a request to StandaloneMm Core through the Firmware Framework(FF-A) using FFA_MSG_SEND_DIRECT_REQ method. This method is used as a mechanism for requesting some service from StandaloneMm. Signed-off-by: Ilias Apalodimas Signed-off-by: Sughosh Ganu

[edk2-devel] [PATCH v5 13/14] MdeModulePkg/VariableStandaloneMm: Set PcdFlashNvStorageVariableBase to Pcd

2021-02-18 Thread Sughosh Ganu
From: Ilias Apalodimas Instead of running StMM in SPM, OP-TEE creates a new secure partition, which emulates SPM and isolates StMM from the rest of the Trusted Applications (TAs). We can then compile StMM as an FD image and run it in OP-TEE. With the addition of a new RPMB driver, we can leverage

[edk2-devel] [PATCH v5 12/14] ArmPkg: Allow FF-A calls to set memory region's attributes

2021-02-18 Thread Sughosh Ganu
From: Achin Gupta Allow setting memory region's permissions using either of the Firmware Framework(FF-A) ABI transport or through the earlier used SVC calls. Signed-off-by: Achin Gupta Co-developed-by: Sughosh Ganu Reviewed-by: Sami Mujawar --- Changes since V4: None ArmPkg/Li

[edk2-devel] [PATCH v5 11/14] ArmPkg: Allow FF-A calls to get memory region's attributes

2021-02-18 Thread Sughosh Ganu
From: Achin Gupta Allow getting memory region's permissions using either of the Firmware Framework(FF-A) ABI transport or through the earlier used SVC calls. Signed-off-by: Achin Gupta Co-developed-by: Sughosh Ganu --- Changes since V4: None ArmPkg/Library/StandaloneMmM

[edk2-devel] [PATCH v5 10/14] ArmPkg: Use FF-A header file in Standalone MM Arm MMU library

2021-02-18 Thread Sughosh Ganu
From: Achin Gupta Add the FF-A header for invoking the mmu functions using FF-A calls as the transport mechanism. Support for invoking the functions through FF-A will be added in a subsequent patch. Signed-off-by: Achin Gupta Reviewed-by: Sami Mujawar --- Changes since V4: None ArmPkg/Libra

[edk2-devel] [PATCH v5 09/14] StandaloneMmPkg: Add option to use FF-A calls for communication with SPM

2021-02-18 Thread Sughosh Ganu
From: Achin Gupta Add support for reporting completion of a MM request using either the Firmware Framework(FF-A) ABI transport or through the earlier used SVC calls. Signed-off-by: Achin Gupta Co-developed-by: Sughosh Ganu Reviewed-by: Sami Mujawar --- Changes since V4: None

[edk2-devel] [PATCH v5 07/14] ArmPkg: Add macros for SPM version with FF-A support enabled

2021-02-18 Thread Sughosh Ganu
: Sughosh Ganu --- Changes since V4: None ArmPkg/Include/IndustryStandard/ArmFfaSvc.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ArmPkg/Include/IndustryStandard/ArmFfaSvc.h b/ArmPkg/Include/IndustryStandard/ArmFfaSvc.h index 1eadf48ab5..bdf6ce4676 100644 --- a/ArmPkg/Include

[edk2-devel] [PATCH v5 08/14] StandaloneMmPkg: Add option to use FF-A calls for getting SPM version

2021-02-18 Thread Sughosh Ganu
With the introduction of Firmware Framework(FF-A), a Secure Partition can get the SPM version either using FF-A calls or through the existing svc calls. Use a runtime check to use either of the two methods based on the Pcd feature flag value. Signed-off-by: Sughosh Ganu Co-developed-by: Achin

[edk2-devel] [PATCH v5 06/14] StandaloneMmPkg: Use macros for SPM version check

2021-02-18 Thread Sughosh Ganu
Declare module wide variables for SPM major and minor versions to be used in checking the SPM version compatibility. Use the SPM major and minor version macros declared in the previous patch for the version check. Signed-off-by: Sughosh Ganu --- Changes since V4: None StandaloneMmPkg/Library

[edk2-devel] [PATCH v5 05/14] ArmPkg: Add macros for SPM version

2021-02-18 Thread Sughosh Ganu
Declare the values of SPM major and minor versions as macros which can be used in the module for checking the SPM version compatibility. Signed-off-by: Sughosh Ganu --- Changes since V4: None ArmPkg/Include/IndustryStandard/ArmMmSvc.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a

[edk2-devel] [PATCH v5 04/14] ArmPkg: Introduce support for PcdFfaEnable

2021-02-18 Thread Sughosh Ganu
. Signed-off-by: Sughosh Ganu --- Changes since V4: None ArmPkg/ArmPkg.dec | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec index f0b136a57a..a8a22c649f 100644 --- a/ArmPkg/ArmPkg.dec +++ b/ArmPkg/ArmPkg.dec @@ -84,6 +84,13 @@ # hardware coherency

[edk2-devel] [PATCH v5 03/14] StandaloneMmPkg: Use FF-A header file in Standalone MM Core entry point

2021-02-18 Thread Sughosh Ganu
From: Achin Gupta Add the Firmware Framework(FF-A) header in the StandaloneMm entry point driver. Support for invoking the functions through FF-A will be added in a subsequent patch. Signed-off-by: Achin Gupta Reviewed-by: Sami Mujawar --- Changes since V4: None StandaloneMmPkg/Library/Sta

[edk2-devel] [PATCH v5 02/14] ArmPkg/ArmSvcLib: Return x4-x7 in output parameters

2021-02-18 Thread Sughosh Ganu
From: Achin Gupta The Arm SMC calling convention standard v1.2 allows 8 input and output parameter registers. The FF-A specification relies on this communication. This patch extends the number of output registers returned by ArmCallSvc() to match this convention. Signed-off-by: Achin Gupta Revi

[edk2-devel] [PATCH v5 01/14] ArmPkg/IndustryStandard: Add barebones FF-A header

2021-02-18 Thread Sughosh Ganu
From: Achin Gupta This patch adds a rudimentary header file with defines for FF-A ABIs that will be used as the transport between S-EL0 and the SPM Signed-off-by: Achin Gupta Reviewed-by: Sami Mujawar Reviewed-by: Ard Biesheuvel --- Changes since V4: None ArmPkg/Include/IndustryStandard/Ar

[edk2-devel] [PATCH v5 00/14] Add support for using FF-A calls

2021-02-18 Thread Sughosh Ganu
ssage to StandaloneMm Sughosh Ganu (5): ArmPkg: Introduce support for PcdFfaEnable ArmPkg: Add macros for SPM version StandaloneMmPkg: Use macros for SPM version check ArmPkg: Add macros for SPM version with FF-A support enabled StandaloneMmPkg: Add option to use FF-A calls for get

[edk2-devel] [PATCH v4 14/14] StandaloneMmPkg: Allow sending FFA Direct Request message to StandaloneMm

2021-02-17 Thread Sughosh Ganu
From: Ilias Apalodimas Allow passing of a request to StandaloneMm Core through the Firmware Framework(FF-A) using FFA_MSG_SEND_DIRECT_REQ method. This method is used as a mechanism for requesting some service from StandaloneMm. Signed-off-by: Ilias Apalodimas Signed-off-by: Sughosh Ganu

[edk2-devel] [PATCH v4 13/14] MdeModulePkg/VariableStandaloneMm: Set PcdFlashNvStorageVariableBase to Pcd

2021-02-17 Thread Sughosh Ganu
From: Ilias Apalodimas Instead of running StMM in SPM, OP-TEE creates a new secure partition, which emulates SPM and isolates StMM from the rest of the Trusted Applications (TAs). We can then compile StMM as an FD image and run it in OP-TEE. With the addition of a new RPMB driver, we can leverage

[edk2-devel] [PATCH v4 10/14] ArmPkg: Use FF-A header file in Standalone MM Arm MMU library

2021-02-17 Thread Sughosh Ganu
From: Achin Gupta Add the FF-A header for invoking the mmu functions using FF-A calls as the transport mechanism. Support for invoking the functions through FF-A will be added in a subsequent patch. Signed-off-by: Achin Gupta Reviewed-by: Sami Mujawar --- Changes since V3: None ArmPkg/Libra

[edk2-devel] [PATCH v4 12/14] ArmPkg: Allow FF-A calls to set memory region's attributes

2021-02-17 Thread Sughosh Ganu
From: Achin Gupta Allow setting memory region's permissions using either of the Firmware Framework(FF-A) ABI transport or through the earlier used SVC calls. Signed-off-by: Achin Gupta Co-developed-by: Sughosh Ganu Reviewed-by: Sami Mujawar --- Changes since V3: * Change the patch head

[edk2-devel] [PATCH v4 09/14] StandaloneMmPkg: Add option to use FF-A calls for communication with SPM

2021-02-17 Thread Sughosh Ganu
From: Achin Gupta Add support for reporting completion of a MM request using either the Firmware Framework(FF-A) ABI transport or through the earlier used SVC calls. Signed-off-by: Achin Gupta Co-developed-by: Sughosh Ganu Reviewed-by: Sami Mujawar --- Changes since V3: None

[edk2-devel] [PATCH v4 11/14] ArmPkg: Allow FF-A calls to get memory region's attributes

2021-02-17 Thread Sughosh Ganu
From: Achin Gupta Allow getting memory region's permissions using either of the Firmware Framework(FF-A) ABI transport or through the earlier used SVC calls. Signed-off-by: Achin Gupta Co-developed-by: Sughosh Ganu --- Changes since V3: * Change the patch header to have the ArmPkg p

[edk2-devel] [PATCH v4 08/14] StandaloneMmPkg: Add option to use FF-A calls for getting SPM version

2021-02-17 Thread Sughosh Ganu
With the introduction of Firmware Framework(FF-A), a Secure Partition can get the SPM version either using FF-A calls or through the existing svc calls. Use a runtime check to use either of the two methods based on the Pcd feature flag value. Signed-off-by: Sughosh Ganu Co-developed-by: Achin

[edk2-devel] [PATCH v4 05/14] ArmPkg: Add macros for SPM version

2021-02-17 Thread Sughosh Ganu
Declare the values of SPM major and minor versions as macros which can be used in the module for checking the SPM version compatibility. Signed-off-by: Sughosh Ganu --- Changes since V3: * Put the macro definitions for the SPM major and minor versions in a separate patch, as suggested by Sami

[edk2-devel] [PATCH v4 07/14] ArmPkg: Add macros for SPM version with FF-A support enabled

2021-02-17 Thread Sughosh Ganu
: Sughosh Ganu --- Changes since V3: * Put the macro definitions for the SPM major and minor versions with FF-A support in a separate patch, as suggested by Sami. ArmPkg/Include/IndustryStandard/ArmFfaSvc.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ArmPkg/Include/IndustryStandard

[edk2-devel] [PATCH v4 06/14] StandaloneMmPkg: Use macros for SPM version check

2021-02-17 Thread Sughosh Ganu
Declare module wide variables for SPM major and minor versions to be used in checking the SPM version compatibility. Use the SPM major and minor version macros declared in the previous patch for the version check. Signed-off-by: Sughosh Ganu --- Changes since V3: * Separate out the declaration

[edk2-devel] [PATCH v4 04/14] ArmPkg: Introduce support for PcdFfaEnable

2021-02-17 Thread Sughosh Ganu
. Signed-off-by: Sughosh Ganu --- Changes since V3: * Put the PcdFfaEnable under the PcdsFeatureFlag.AARCH64 section to avoid build breakage for the X64 StandaloneMm builds. ArmPkg/ArmPkg.dec | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec index

[edk2-devel] [PATCH v4 03/14] StandaloneMmPkg: Use FF-A header file in Standalone MM Core entry point

2021-02-17 Thread Sughosh Ganu
From: Achin Gupta Add the Firmware Framework(FF-A) header in the StandaloneMm entry point driver. Support for invoking the functions through FF-A will be added in a subsequent patch. Signed-off-by: Achin Gupta Reviewed-by: Sami Mujawar --- Changes since V3: None StandaloneMmPkg/Library/Sta

[edk2-devel] [PATCH v4 02/14] ArmPkg/ArmSvcLib: Return x4-x7 in output parameters

2021-02-17 Thread Sughosh Ganu
From: Achin Gupta The Arm SMC calling convention standard v1.2 allows 8 input and output parameter registers. The FF-A specification relies on this communication. This patch extends the number of output registers returned by ArmCallSvc() to match this convention. Signed-off-by: Achin Gupta Revi

[edk2-devel] [PATCH v4 00/14] Add support for using FF-A calls

2021-02-17 Thread Sughosh Ganu
;s attributes Ilias Apalodimas (2): MdeModulePkg/VariableStandaloneMm: Set PcdFlashNvStorageVariableBase to Pcd StandaloneMmPkg: Allow sending FFA Direct Request message to StandaloneMm Sughosh Ganu (5): ArmPkg: Introduce support for PcdFfaEnable ArmPkg: Add macros for SPM version

[edk2-devel] [PATCH v4 01/14] ArmPkg/IndustryStandard: Add barebones FF-A header

2021-02-17 Thread Sughosh Ganu
From: Achin Gupta This patch adds a rudimentary header file with defines for FF-A ABIs that will be used as the transport between S-EL0 and the SPM Signed-off-by: Achin Gupta Reviewed-by: Sami Mujawar Reviewed-by: Ard Biesheuvel --- Changes since V3: None ArmPkg/Include/IndustryStandard/Ar