Hi Edhaya,
Yes, we could get rid of the TPM 2.0 definitions and include the MdePkg
definition, but it will require rework of TCG2.h to remove duplicate
definitions.
But, what is the general of philosophy of what source code edk2-test
should include from edk2? Since the purpose of edk2-test
Use compiler-independent OFFSET_OF macro defined from Base.h instead
of the GCC specific __builtin_offsetof
Signed-off-by: Stuart Yoder
---
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTestConformance.c
| 7 +++
1 file changed, 3 insertions(+), 4 deletions
Fix compiler warning by adding #pragma pack() to close a pragma
section. Also delete extraneous #pragma pack(1).
Signed-off-by: Stuart Yoder
Reviewed-by: Heinrich Schuchardt
---
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTest.h
| 3 +--
1 file changed, 1
The VS2015x86 build encountered errors due to type conversion
warnings. Resolve these by adding casts and refactoring.
Signed-off-by: Stuart Yoder
---
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTestConformance.c
| 18 --
1 file changed, 8
-resolve type conversion warnings
Patches are in github here:
https://github.com/stuyod01/edk2-test/tree/tcg2-cleanup
Version 2
-add SM3 hash type to TPM2.h
-resolve type conversion warnings
Stuart Yoder (4):
uefi-sct/SctPkg: TCG2 Protocol: correct definition of TPMT_HA struct
uefi-sct/SctPkg
e the size of hash algorithms varies, this should have been
defined as a union of the sizes of supported hash algorithms. This is
how is it done in the TPM Library specfication and in EDK2.
In addition, added the SM3 hash type to align with the TPM Library
spec.
Signed-off-by: Stuart Yoder
---
Fix compiler warning by adding #pragma pack() to close a pragma
section. Also delete extraneous #pragma pack(1).
Signed-off-by: Stuart Yoder
---
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTest.h
| 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff
are in github here:
https://github.com/stuyod01/edk2-test/tree/tcg2-cleanup
Stuart Yoder (3):
uefi-sct/SctPkg: TCG2 Protocol: correct definition of TPMT_HA struct
uefi-sct/SctPkg: TCG2 Protocol: use OFFSET_OF for computing offsets
uefi-sct/SctPkg: TCG2 Protocol: #pragma pack cleanup
uefi
e the size of hash algorithms varies, this should have been
defined as a union of the sizes of supported hash algorithms. This is
how is it done in the TPM Library specfication and in EDK2.
Signed-off-by: Stuart Yoder
---
uefi-sct/SctPkg/UEFI/Protocol/TCG2.h | 13 -
1 file change
Use compiler-independent OFFSET_OF macro defined from Base.h instead
of the GCC specific __builtin_offsetof
Signed-off-by: Stuart Yoder
---
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTestConformance.c
| 7 +++
1 file changed, 3 insertions(+), 4 deletions
mem.c |
69
ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni |
5 ++
5 files changed, 138 insertions(+)
Tested-by: Stuart Yoder
Tested on EDK2, output looks like:
Conformance Profile
/UefiShellDebug1CommandsLib.uni |
3 +
2 files changed, 137 insertions(+)
Tested-by: Stuart Yoder
Tested on EDK2, verbose output looks like:
Image Execution Table
TestImage1.bin: AUTH_UNTESTED
TestImage2.bin: AUTH_UNTESTED
TestImage6.bin: AUTH_SIG_FAILED
ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni |
23 ++-
2 files changed, 84 insertions(+), 2 deletions(-)
Tested-by: Stuart Yoder
RT properties is not implemented in EDK2, but is in the EFI
implementation in u-boot. Output looks like this:
RT
Reviewed-by: Stuart Yoder
On 4/3/24 4:19 PM, Sam Kaynor via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352
Implemented dumping of the UEFI Conformance Profiles Table using Dmem.c
Additionally added the base support for the table with new
header file
Reviewed-by: Stuart Yoder
On 4/3/24 4:19 PM, Sam Kaynor via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352
Implemented dumping of the Image Execution Table using Dmem.c
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Sam Kaynor
---
Notes:
v4:
- changed
Reviewed-by: Stuart Yoder
On 4/3/24 4:19 PM, Sam Kaynor via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352
Implemented the dumping of the UEFI RT Properties Table using Dmem.c
Added new entry to the help command for the -verbose option
Cc: Ray Ni
Cc: Zhichao Gao
Hi Sam,
See comments below...
+SHELL_STATUS
+DisplayRtProperties (
+ IN UINT64 Address
+ )
+{
+ EFI_RT_PROPERTIES_TABLE *RtPropertiesTable;
+ UINT32 RtServices;
+ SHELL_STATUSShellStatus;
+ EFI_STATUS Status;
+
+ ShellStatus = SHELL_SUCCESS;
+
+
On 12/15/23 8:30 AM, Heinrich Schuchardt wrote:
On 12/15/23 00:39, Stuart Yoder wrote:
From: Joseph Hemann
Please, provide commit messages.
This is fixed in v2 of the patch series. (Sent Jan 9)
Thanks,
Stuart
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to
Hi Sam,
See inline comments...
On 1/24/24 2:56 PM, Sam Kaynor wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352
Implemented the dumping of the UEFI RT Properties Table using Dmem.c
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Sam Kaynor
---
ShellPkg/Library/UefiShellDebug1Comm
Hi Sam,
See inline comments...
On 1/24/24 2:56 PM, Sam Kaynor wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352
Implemented dumping of the UEFI Conformance Profiles Table using Dmem.c
Additionally added the base support for the table with new
header file ConformanceProfiles.h (Cc
Hi Sam,
See inline comments...
On 1/24/24 2:56 PM, Sam Kaynor wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352
Implemented dumping of the Image Execution Table using Dmem.c
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Sam Kaynor
---
ShellPkg/Library/UefiShellDebug1CommandsLib
tree/tcgmortest_v3
Cc: G Edhaya Chandran
Cc: Barton Gao
Cc: Carolyn Gjertsen
Cc: Stuart Yoder
Cc: Sunny Wang
Abhi Singh (6):
uefi-sct/SctPkg: TCG MOR SetVariable Test
uefi-sct/SctPkg: TCG MORLOCK SetVariable Test
uefi-sct/SctPkg: TCG MORLOCK Unlocked State Test
uefi-sct/SctPkg: TCG MOR
From: Joseph Hemann
-add test for GetEventLog()
-test for valid and invalid event log format
-test event log header
-verify expected event log entry
Signed-off-by: Joseph Hemann
Signed-off-by: Stuart Yoder
---
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/Guid.h
From: Joseph Hemann
Define constants and data structure specified in the TCG EFI Protocol
specification.
Signed-off-by: Joseph Hemann
Signed-off-by: Stuart Yoder
---
uefi-sct/SctPkg/UEFI/Protocol/TCG2.h | 177
1 file changed, 177 insertions(+)
diff --git a/uefi-sct
From: Joseph Hemann
Add test verifying the functionality of the SubmitCommand function
using the TPM command TPM2_HASH_COMMAND.
Signed-off-by: Joseph Hemann
Signed-off-by: Stuart Yoder
---
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/Guid.h
| 5
for buffer
-add checkpoint for validating fields of the struct returned by GetCapability()
Signed-off-by: Joseph Hemann
Signed-off-by: Stuart Yoder
---
uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc
| 1 +
uefi-sct/SctPkg/TestCase/UEFI/EFI
From: Joseph Hemann
-add tests for HashLogExtendEvent()
-tests with valid, invalid, and out of range parameters
-do extend of data to PCR 16
Signed-off-by: Joseph Hemann
Signed-off-by: Stuart Yoder
---
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/Guid.h
From: Joseph Hemann
-add test for GetActivePcrBanks()
-checkpoint for NULL pointer passed for buffer
-checkpoint for test of function with proper input
Signed-off-by: Joseph Hemann
Signed-off-by: Stuart Yoder
---
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/Guid.h
This patch series adds tests for the TCG2 Protocol which is implemented by EDK2.
The protocol is defined in chapter 6 in the TCG EFI Protocol Specification:
https://trustedcomputinggroup.org/resource/tcg-efi-protocol-specification/
The definition of the test cases is in a specification that has be
From: Joseph Hemann
-add tests for HashLogExtendEvent()
-tests with valid, invalid, and out of range parameters
-do extend of data to PCR 16
Signed-off-by: Joseph Hemann
Signed-off-by: Stuart Yoder
---
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/Guid.h
From: Joseph Hemann
Signed-off-by: Joseph Hemann
Signed-off-by: Stuart Yoder
---
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/Guid.h
| 5 +
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTest.h
| 71
From: Joseph Hemann
-add test for GetEventLog()
-test for valid and invalid event log format
-test event log header
-verify expected event log entry
Signed-off-by: Joseph Hemann
Signed-off-by: Stuart Yoder
---
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/Guid.h
This patch series adds tests for the TCG2 Protocol which is implemented by EDK2.
The protocol is defined in chapter 6 in the TCG EFI Protocol Specification:
https://trustedcomputinggroup.org/resource/tcg-efi-protocol-specification/
The definition of the test cases is in a specification that has be
From: Joseph Hemann
Signed-off-by: Joseph Hemann
Signed-off-by: Stuart Yoder
---
uefi-sct/SctPkg/UEFI/Protocol/TCG2.h | 179
1 file changed, 179 insertions(+)
diff --git a/uefi-sct/SctPkg/UEFI/Protocol/TCG2.h
b/uefi-sct/SctPkg/UEFI/Protocol/TCG2.h
new file mode 100644
From: Joseph Hemann
-add test for GetActivePcrBanks()
-checkpoint for NULL pointer passed for buffer
-checkpoint for test of function with proper input
Signed-off-by: Joseph Hemann
Signed-off-by: Stuart Yoder
---
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/Guid.h
for buffer
-add checkpoint for validating fields of the struct returned by GetCapability()
Signed-off-by: Joseph Hemann
Signed-off-by: Stuart Yoder
---
uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc
| 1 +
uefi-sct/SctPkg/TestCase/UEFI/EFI
See inline comments...
On 9/21/23 11:37 AM, Abhimanyu Singh via groups.io wrote:
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419
-Implement MemoryOverwriteRequestControlLock Locked with
Key State test cases
-Add remaini
See inline comments...
On 9/21/23 11:37 AM, Abhimanyu Singh via groups.io wrote:
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419
-Implement MemoryOverwriteRequestControlLock Locked No Key
State test cases
-Add Assertio
See inline...
On 9/21/23 11:37 AM, Abhimanyu Singh via groups.io wrote:
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419
-Implement MemoryOverwriteRequestControlLock Unlocked State
test cases
-Add Assertions 19, 20, 21, a
See inline comments...
On 9/21/23 11:37 AM, Abhimanyu Singh via groups.io wrote:
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419
-Implement MemoryOverwriteRequestControlLockSetVariable test
cases
-Add Assertions 9 throug
See inline comments...
On 9/21/23 11:37 AM, Abhimanyu Singh via groups.io wrote:
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419
-Implement MemoryOverwriteRequestControlSetVariable test cases
-Add Assertions 5, 6, 7, and 8
On 9/21/23 11:37 AM, Abhimanyu Singh via groups.io wrote:
Resending to Cc the reviewers
These tests support platform firmware that implement
MemoryOverwriteRequestControl & MemoryOverwriteRequestControlLock
UEFI variables in accordance with TCG PC Platform Reset Attack
Mitigation Specificatio
Hi Abhi,
See inline comments...
On 8/17/23 11:10 AM, Abhimanyu Singh via groups.io wrote:
From: "Abhi.Singh"
SCT Platform Reset Check Test
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374
Test: https://bugzilla.tianocore.org/show_bug.cgi?id=4419
-Implement initial test infrast
)
EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS is deprecated and the UEFI spec
says this should return EFI_UNSUPPORTED.
Cc: Liming Gao
Cc: Hao A Wu
Cc: Sunny Wang
Signed-off-by: Stuart Yoder
---
MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion
See inline comments...
+EFI_STATUS
+BBTestGetCapabilityConformanceTestCheckpoint2 (
+ IN EFI_STANDARD_TEST_LIBRARY_PROTOCOL*StandardLib,
+ IN EFI_TCG2_PROTOCOL *TCG2
+ )
+{
+ EFI_TEST_ASSERTIONAssertionType;
+ EFI_STATUS
On 7/30/21 3:36 PM, Andrew Fish wrote:
On Jul 30, 2021, at 12:32 PM, Stuart Yoder mailto:stuart.yo...@arm.com>> wrote:
I am playing around with EDK2 on QEMU with a UEFI shell application and in the app
I allocate some memory using gBS->AllocatePool(EfiBootSer
I am playing around with EDK2 on QEMU with a UEFI shell application and in the app
I allocate some memory using gBS->AllocatePool(EfiBootServicesData, ...)
Programmatically accessing the pointer returned works fine, but when I print
it, it does not seem to be what I would expect is a valid addr
47 matches
Mail list logo
