Status = ...;
ASSERT_EFI_ERROR (Status);
} else {
ResponseMessage.Data.Response = NULL;
}
/* UNINITIALIZED USE */
if (EFI_ERROR (Status)) {
break;
}
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Sergei Dmitrouk
---
ShellPkg/DynamicCommand/HttpDynamicCommand/Http.c
If the function gets invalid value for the `ResizableBarOp` parameter
and asserts are disabled, `Bit` can be used uninitialized.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Ray Ni
Signed-off-by: Sergei Dmitrouk
---
Notes:
v2:
- simplify if-statement to avoid unused branches
MdeModulePkg/Bus
`Result` can be used uninitialized in both functions after following
either first or second `goto` statement.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Sergei Dmitrouk
---
CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPss.c | 1 +
CryptoPkg/Library
ad patches for specifics.
v2:
Second patch was simplified.
Sergei Dmitrouk (3):
ShellPkg/HttpDynamicCommand: Fix possible uninitialized use
MdeModulePkg/PciBusDxe: Fix possible uninitialized use
CryptoPkg/BaseCryptLib: Fix possible uninitialized use
CryptoPkg/Library/BaseCryptLib/Pk/Cry
sue can be detected in CI GCC5 build.
>
> Thanks
> Liming
> > -邮件原件-
> > 发件人: devel@edk2.groups.io 代表 Sergei
> > Dmitrouk
> > 发送时间: 2021年5月15日 21:01
> > 收件人: devel@edk2.groups.io; jiewen@intel.com
> > 抄送: Wang, Jian J ; Lu, XiaoyuX
> >
If the function gets invalid value for the `ResizableBarOp` parameter
and asserts are disabled, `Bit` can be used uninitialized.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Ray Ni
Signed-off-by: Sergei Dmitrouk
---
Notes:
v2:
- simplify if-statement to avoid unused branches
MdeModulePkg/Bus
e. It is an obvious logic
> issue.
>
> Do you think we can do anything on CI, to catch it during pre-check-in in the
> future?
> I just feel it is burden to make it post-check-in fix.
>
>
> Thank you
> Yao Jiewen
>
> > -Original Message-
> > From: Se
Status = ...;
ASSERT_EFI_ERROR (Status);
} else {
ResponseMessage.Data.Response = NULL;
}
/* UNINITIALIZED USE */
if (EFI_ERROR (Status)) {
break;
}
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Sergei Dmitrouk
---
ShellPkg/DynamicCommand/HttpDynamicCommand/Http.c
atches for specifics.
Sergei Dmitrouk (3):
ShellPkg/HttpDynamicCommand: Fix possible uninitialized use
MdeModulePkg/PciBusDxe: Fix possible uninitialized use
CryptoPkg/BaseCryptLib: Fix possible uninitialized use
CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPss.c | 1 +
CryptoPkg/Library/Ba
If the function gets invalid value for the `ResizableBarOp` parameter
and asserts are disabled, `Bit` can be used uninitialized.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Ray Ni
Signed-off-by: Sergei Dmitrouk
---
MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c | 5 +
1 file changed, 5 insertions(+)
diff
`Result` can be used uninitialized in both functions after following
either first or second `goto` statement.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Sergei Dmitrouk
---
CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPss.c | 1 +
CryptoPkg/Library
Justen
Signed-off-by: Sergei Dmitrouk
---
OvmfPkg/VirtioFsDxe/SimpleFsOpen.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/OvmfPkg/VirtioFsDxe/SimpleFsOpen.c
b/OvmfPkg/VirtioFsDxe/SimpleFsOpen.c
index d73d23fe8665..9e46e8ab8385 100644
--- a/OvmfPkg/VirtioFsDxe/SimpleFsOpen.c
+++ b
Compiling for IA32 target with gcc-5.5.0 emits "maybe-uninitialized" warnings.
Compilation command: build -a IA32 -p OvmfPkg/OvmfPkgIa32.dsc -t GCC49
Sergei Dmitrouk (2):
ShellPkg/UefiShellCommandLib: suppress incorrect gcc warning
OvmfPkg/VirtioFsDxe: suppress incorrect gc
`Dupes` is used only if `Duplicates != NULL` and function is left if
allocation of memory for `Dupes` fails, so it can't be used
uninitialized.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3228
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Sergei Dmitrouk
---
ShellPkg/Li
14 matches
Mail list logo
