Re: [edk2-devel] reg: MAC address could not change on pre-boot environment and failed to PXE boot.

2023-03-24 Thread Rabeda, Maciej
ds the stack, you will see that it gets called in Ip4Dxe DriverBinding->Start() function. What I would suggest is to only reconnect SNP driver. Thanks, Maciej From: Sivaraman Nainar Sent: Friday, March 24, 2023 5:22 AM To: devel@edk2.groups.io; Maciej Rabeda ; Rabeda, Maciej ; Santhosh Kumar V

Re: [edk2-devel] [PATCH v4] NetworkPkg/WifiProfileSync: Add WiFi profile sync protocol support

2022-11-02 Thread Rabeda, Maciej
you Vincent, I will add them to the protocol header file and send an updated patch today. -Original Message- From: Zimmer, Vincent Sent: Tuesday, November 1, 2022 10:39 AM To: Clark-williams, Zachary ; Rabeda, Maciej ; Luo, Heng ; Kuo, Scottie ; Kuo, Ted ; Dutkiewicz, Michal ; devel

Re: [edk2-devel] [PATCH v3 17/32] .mailmap: Add an entry for Maciej Rabeda

2020-01-07 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Thursday, January 2, 2020 20:24 To: devel@edk2.groups.io Cc: Leif Lindholm ; Kinney, Michael D ; Andrew Fish ; Laszlo Ersek ; Philippe Mathieu-Daude ; Rabeda, Maciej Subject: [PATCH v3

Re: [edk2-devel] [PATCH] Maintainers.txt: Update reviewer email address

2019-12-10 Thread Rabeda, Maciej
esday, December 10, 2019 19:28 To: devel@edk2.groups.io; ler...@redhat.com; Rabeda, Maciej ; Wu, Jiaxin ; Maciej Rabeda ; Gao, Liming ; Kinney, Michael D Cc: Fu, Siyuan Subject: RE: [edk2-devel] [PATCH] Maintainers.txt: Update reviewer email address Hi Maciej, Once a patch review is complete

Re: [edk2-devel] [PATCH] Maintainers.txt: Update reviewer email address

2019-12-10 Thread Rabeda, Maciej
the first place" For maintainer identification process, where does the mergify bot get the maintainer list from? Do you know who should I ask to be added to that list? Thanks! Maciej -Original Message- From: Laszlo Ersek Sent: Tuesday, December 10, 2019 13:37 To: Rabeda, Maciej ; deve

Re: [edk2-devel] [PATCH] Maintainers.txt: Update reviewer email address

2019-12-10 Thread Rabeda, Maciej
people that can apply that label is limited to EDK II Maintainers or is my assumption wrong? Thanks! Maciej -Original Message- From: Laszlo Ersek Sent: Tuesday, December 10, 2019 10:11 To: Rabeda, Maciej ; devel@edk2.groups.io; Wu, Jiaxin ; Maciej Rabeda ; Kinney, Michael D ; Gao,

Re: [edk2-devel] [PATCH] Maintainers.txt: Update reviewer email address

2019-12-10 Thread Rabeda, Maciej
Ok, Jiaxin :) Mike, Laszlo, Liming, Do you know who I should contact in regards to maintainership role transition (edk2 write access etc.)? Thanks! Maciej -Original Message- From: devel@edk2.groups.io On Behalf Of Wu, Jiaxin Sent: Tuesday, December 10, 2019 06:38 To: Maciej Rabeda ; d

Re: [edk2-devel] [PATCH 48/79] NetworkPkg/SnpDxe: Fix few typos

2019-12-06 Thread Rabeda, Maciej
vel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 48/79] NetworkPkg/SnpDxe: Fix few typos From: Antoine Coeur Fix few typos in comments and documentation. Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Maciej Rabeda Reviewed-by: Phili

Re: [edk2-devel] [PATCH 47/79] NetworkPkg/Mtftp6Dxe: Fix various typos

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:16 To: devel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 47/79] NetworkPkg/Mtftp6Dxe

Re: [edk2-devel] [PATCH 45/79] NetworkPkg/MnpDxe: Fix various typos

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:15 To: devel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 45/79] NetworkPkg/MnpDxe

Re: [edk2-devel] [PATCH 40/79] NetworkPkg/HttpDxe: Fix various typos

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:15 To: devel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 40/79] NetworkPkg/HttpDxe

Re: [edk2-devel] [PATCH 49/79] NetworkPkg/TcpDxe/Sock: Fix few typos

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:16 To: devel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 49/79] NetworkPkg/TcpDxe

Re: [edk2-devel] [PATCH 41/79] NetworkPkg/Ip4Dxe: Fix various typos

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:15 To: devel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 41/79] NetworkPkg/Ip4Dxe

Re: [edk2-devel] [PATCH 44/79] NetworkPkg/Library: Fix various typos

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:15 To: devel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 44/79] NetworkPkg/Library

Re: [edk2-devel] [PATCH 42/79] NetworkPkg/Ip6Dxe: Fix various typos

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:15 To: devel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 42/79] NetworkPkg/Ip6Dxe

Re: [edk2-devel] [PATCH 53/79] NetworkPkg/Udp6Dxe: Fix various typos

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:16 To: devel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 53/79] NetworkPkg/Udp6Dxe

Re: [edk2-devel] [PATCH 52/79] NetworkPkg/Udp4Dxe: Fix various typos

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:16 To: devel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 52/79] NetworkPkg/Udp4Dxe

Re: [edk2-devel] [PATCH 46/79] NetworkPkg/Mtftp4Dxe: Fix various typos

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:15 To: devel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 46/79] NetworkPkg/Mtftp4Dxe

Re: [edk2-devel] [PATCH 50/79] NetworkPkg/TcpDxe/Tcp: Fix various typos

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:16 To: devel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 50/79] NetworkPkg/TcpDxe

Re: [edk2-devel] [PATCH 51/79] NetworkPkg/Tls: Fix few typos

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:16 To: devel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 51/79] NetworkPkg/Tls: Fix

Re: [edk2-devel] [PATCH 54/79] NetworkPkg/UefiPxeBcDxe: Fix various typos

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:16 To: devel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 54/79] NetworkPkg

Re: [edk2-devel] [PATCH 55/79] NetworkPkg/VlanConfigDxe: Fix few typos

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:16 To: devel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 55/79] NetworkPkg

Re: [edk2-devel] [PATCH v2 051/105] .mailmap: Add an entry for Maciej Rabeda

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda PS. Disregard the legal note at the end of the email. -Original Message- From: Philippe Mathieu-Daude Sent: Friday, December 6, 2019 12:26 To: devel@edk2.groups.io Cc: Philippe Mathieu-Daude ; Rabeda, Maciej Subject: [PATCH v2 051/105] .mailmap: Add an

Re: [edk2-devel] Which is the proper edk2 package the EFI REST Structure DXE driver should stay with?

2019-11-18 Thread Rabeda, Maciej
Hi Abner, REST as a more generic network API and could possibly be placed in NetworkPkg. My concerns are: Is REST in UEFI going to be HTTP-based or is it planned to be tied to drivers outside of NetworkPkg? If it is going to be more generic, I do not think that it is a good idea

[edk2-devel] [PATCH v1 1/1] Maintainers.txt: Adding new NetworkPkg reviewer.

2019-11-05 Thread Rabeda, Maciej
Add Maciej Rabeda as reviewer of NetworkPkg. Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Maciej Rabeda --- Maintainers.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Maintainers.txt b/Maintainers.txt index 71a34a284567..922cc664ddc3 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@

[edk2-devel] [PATCH v1 0/1] Maintainers.txt: Adding new NetworkPkg reviewer.

2019-11-05 Thread Rabeda, Maciej
Add Maciej Rabeda as reviewer of NetworkPkg. Cc: Jiaxin Wu Cc: Siyuan Fu Maciej Rabeda (1): Maintainers.txt: Adding new NetworkPkg reviewer. Maintainers.txt | 1 + 1 file changed, 1 insertion(+) -- 2.17.0.windows.1 Int

[edk2-devel] [PATCH v2 1/1] NetworkPkg/SnpDxe: Remove ExitBootServices event

2019-10-14 Thread Rabeda, Maciej
Patch addresses Bugzilla #1972. During ExitBootServices stage, drivers should not call any functions known to use Memory Allocation Services. One of such functions (as per UEFI spec) is UNDI->Shutdown(). Since UNDI drivers during ExitBootServices phase are expected to put the adapter to such a sta

[edk2-devel] [PATCH v2 0/1] Remove UNDI calls from SNP during ExitBootServices

2019-10-14 Thread Rabeda, Maciej
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1974 Removing calls to UNDI->Shutdown() and Stop() functions in ExitBootServices event notification function. Since SNP event reacting to ExitBootServices is only calling those two functions, there is no need to create that event at all. Adding

Re: [edk2-devel] [PATCH v1 1/1] NetworkPkg/SnpDxe: Remove ExitBootServices event

2019-10-11 Thread Rabeda, Maciej
Laszlo, Siyuan, Very good input, thanks. I'll introduce the V2 patch with that fix + control with fixed PCD - it works for me :) -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, October 11, 2019 11:42 To: Fu, Siyuan ; devel@edk2.groups.io; Rabeda, M

Re: [edk2-devel] [PATCH v1 1/1] NetworkPkg/SnpDxe: Remove ExitBootServices event

2019-10-09 Thread Rabeda, Maciej
Sent: Wednesday, October 9, 2019 04:08 To: Rabeda, Maciej ; devel@edk2.groups.io Cc: Wu, Jiaxin Subject: RE: [PATCH v1 1/1] NetworkPkg/SnpDxe: Remove ExitBootServices event Hi, Maciej Have you tested what will happen if this SNP co-work with those UNDI drivers which don't have an ExitBootSe

[edk2-devel] [PATCH v1 1/1] NetworkPkg/SnpDxe: Remove ExitBootServices event

2019-10-08 Thread Rabeda, Maciej
Patch addresses Bugzilla #1972. During ExitBootServices stage, drivers should not call any functions known to use Memory Allocation Services. One of such functions (as per UEFI spec) is UNDI->Shutdown(). Since UNDI drivers during ExitBootServices phase are expected to put the adapter to such a sta

[edk2-devel] [PATCH v1 0/1] Remove UNDI calls from SNP during ExitBootServices

2019-10-08 Thread Rabeda, Maciej
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1974 Removing calls to UNDI->Shutdown() and Stop() functions in ExitBootServices event notification function. Since SNP event reacting to ExitBootServices is only calling those two functions, I am removing that as well. Cc: Siyuan Fu Cc: Jiaxin

Re: [edk2-devel] Polling Interval in MNP

2019-09-10 Thread Rabeda, Maciej
Hi Ramesh, I cannot see the 10ms comparison you have mentioned in MnpCheckPacketTimeout(). Quick code analysis suggests that received packets enqueued in the specific MNP instance queue have timeout value assigned to them. See MnpQueueRcvdPacket() line: RxDataWrap->TimeoutTick = Instance->Config

Re: [edk2-devel] reg: reg : HTTP Download Performance

2019-04-25 Thread Rabeda, Maciej
Hi Siva, Summary: UEFI HTTP: 2.35 Mbps Windows wget: 14.1 Mbps Could you clarify whether in the LAN scenario you get 100 Megabytes or Megabits per second? If you are getting 100 MB/s (instead of 100 Mb/s), I would like to follow up on how did you achieve such speeds :) If it's 100 Mbps, this s