it's added to the root. Fix that
by sign extending the start field to 64 bit.
Test: Booting UefiPayloadPkg still works on Ia32X64 and now also
works on X64.
Signed-off-by: Patrick Rudolph
---
UefiPayloadPkg/Library/CbParseLib/CbParseLib.c | 2 +-
1 file changed, 1 insertion(+),
Hi,
I cannot reproduce the issue on my setup. Please ignore it for now.
Regards,
Patrick Rudolph
On Mon, Apr 3, 2023 at 2:52 AM gaoliming via groups.io
wrote:
>
> Patrick:
> Can you give the reproduce step to generate ELF image that doesn't work
> with the option max-page-si
ally
works.
Signed-off-by: Patrick Rudolph
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4356
---
BaseTools/Conf/tools_def.template | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/BaseTools/Conf/tools_def.template
b/BaseTools/Conf/tools_def.template
index
Hi Marvin,
will send out a new patch series.
Regards,
Patrick Rudolph
On Thu, Mar 30, 2023 at 10:05 AM Marvin Häuser wrote:
>
> Hi Lean,
>
> I don’t think individual patches from a series are merged generally. Your 2/3
> has open concerns from both Liming and myself.
>
> B
- Use OS specific path seperator instead of hardcoding ';'
- Fix case of build artifact FV/PLATFORMPAYLOAD.Fv
Test:
python Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py
works on Linux.
Signed-off-by: Patrick Rudolph
Ref: https://bugzilla.tianocore.org/show_
Add package that are required to build PlatformPayloadFeaturePkg.
Test:
Running python
Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py
generates a FV.
Signed-off-by: Patrick Rudolph
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4359
---
Features/Intel
Fixed the title.
Sorry for the confusion.
On Thu, Mar 16, 2023 at 1:05 AM Ard Biesheuvel wrote:
>
> On Wed, 15 Mar 2023 at 23:57, Marvin Häuser wrote:
> >
> >
> > > On 15. Mar 2023, at 23:51, Ard Biesheuvel wrote:
> > >
> > > On Wed, 15 Mar 2023 at 23:16, Marvin Häuser wrote:
> > >>
> > >> Hi
ally
works.
Signed-off-by: Patrick Rudolph
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4356
---
BaseTools/Conf/tools_def.template | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/BaseTools/Conf/tools_def.template
b/BaseTools/Conf/tools_def.template
index
to use Oz and LTO, it always
crashes.
Test:
The ELF generated by
'python UefiPayloadPkg/UniversalPayloadBuild.py -a IA32' boots.
Signed-off-by: Patrick Rudolph
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4357
---
BaseTools/Conf/tools_def.template | 2 +-
1 file changed, 1 inse
- Use OS specific path seperator instead of hardcoding ';'
- Fix case of build artifact FV/PLATFORMPAYLOAD.Fv
Test:
python Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py
works on Linux.
Signed-off-by: Patrick Rudolph
Ref: https://bugzilla.tianocore.org/show_
Add package that are required to build PlatformPayloadFeaturePkg.
Test:
Running python
Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py
generates a FV.
Signed-off-by: Patrick Rudolph
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4359
---
Features/Intel
Add protocol gEfiHiiPackageListProtocolGuid to DEPEX
to make sure it's present before using it.
Fixes ASSERTION seen on DEBUG build.
Signed-off-by: Patrick Rudolph
---
ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
to use Oz and LTO, it always
crashes.
Test:
The ELF generated by
'python UefiPayloadPkg/UniversalPayloadBuild.py -a IA32' boots.
Signed-off-by: Patrick Rudolph
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4357
---
BaseTools/Conf/tools_def.template | 2 +-
1 file changed, 1 inse
ally
works.
Signed-off-by: Patrick Rudolph
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4356
---
BaseTools/Conf/tools_def.template | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/BaseTools/Conf/tools_def.template
b/BaseTools/Conf/tools_def.template
index
do you draw the line between platform code and "generic" payload code?
Regards,
Patrick Rudolph
On Wed, Mar 23, 2022 at 7:12 PM Dong, Guo wrote:
>
>
> Hi Sean,
> SMMSTORE and this FVB module are specific for coreboot while UefiPayloadPkg
> in Edk2 is targeting p
tocol is just a side effect.
3. Also it looks like this is platform specific code, which should be
part of edk2-platforms.
4. You should be able to use the VBT in DRAM. There's a pointer in the
ASLS register on PCI device 00:02.0.
Regards,
Patrick Rudolph
On Sun, Feb 27, 2022 at 10:46 P
,
Patrick Rudolph
On Thu, Feb 17, 2022 at 7:24 PM Ma, Maurice wrote:
>
> This vendor specific device driver implementation does not seem to fit into
> UEFI payload package scope well.
>
> Do you think https://github.com/tianocore/edk2-platforms/tree/master/Silicon
> could be
Hi,
can you please have a look at this patch?
It fixes a build failure.
Regards,
Patrick Rudolph
On Thu, Feb 10, 2022 at 10:24 PM Sean Rhodes wrote:
>
> Fix case match in to avoid build failure on
> Linu.
>
> Signed-off-by: Sean Rhodes
> ---
> UefiPayloadPkg/BlSupportS
Hi,
Can you please have a look at this patch?
The BlSupportSmm currently doesn't compile and this patch fixes the issue.
It would be very nice if you could add build tests for every option
defaulting to false to catch those issues in the future.
Regards,
Patrick Rudolph
On Thu, Feb 10, 20
stBridgeDxe] Bridge->Mem.Limit < 0x0001ULL".
Tested with coreboot as bootloader on platforms that have PCI resources
above 4GiB and on platforms that don't have resources above 4GiB.
Signed-off-by: Patrick Rudolph
---
UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c |
ach would be to fix the corner case handling, or
introduce and use a MtrrLibNull where necessary.
Regards,
Patrick Rudolph
On Thu, Feb 10, 2022 at 11:06 PM Michael D Kinney
wrote:
>
> Hi Sean,
>
> By disabling the MTRR lib in this way, the UefiPayloadPkg has no means to
> adjust cac
stBridgeDxe] Bridge->Mem.Limit < 0x0001ULL".
Tested with coreboot as bootloader on platforms that have PCI resources
above 4GiB and on platforms that don't have resources above 4GiB.
Signed-off-by: Patrick Rudolph
---
UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c |
Hi Grzegorz,
I tried this patch, but I cannot enroll the DBX downloaded from here:
https://uefi.org/revocationlistfile
Is it even possible with current code? Did you test DBX enrollment as well
using the revocation list file?
Regards,
Patrick
On Mon, Aug 2, 2021 at 12:47 PM Grzegorz Bernacki wr
ed above TOLUD as EfiMemoryMappedIO.
This fixes assertions seen in PciHostBridgeDxe.
Signed-off-by: Patrick Rudolph
---
.../UefiPayloadEntry/UefiPayloadEntry.c | 190 +-
.../UefiPayloadEntry/UefiPayloadEntry.h | 10 +
2 files changed, 197 insertions(+), 3 deleti
: 1EB6C000 00008000 4 (ACPI NVS)
> MEM: 1EB74000 0038C000 2
> MEM: 1EF0 0010 2
> MEM: 1F00 0100 2
>
> Thanks
> Maurice
>
> > -Original Message-
> > From: Pat
ed above TOLUD as EfiMemoryMappedIO.
This fixes assertions seen in PciHostBridgeDxe.
Signed-off-by: Patrick Rudolph
---
.../UefiPayloadEntry/UefiPayloadEntry.c | 190 +-
.../UefiPayloadEntry/UefiPayloadEntry.h | 10 +
2 files changed, 197 insertions(+), 3 deleti
yle table. Guessing the TOLUD might work in most cases, but
> may fail since
> the assumptions.
>
> I saw this patch fixed the memory type for ACPI memory. I think we could have
> this fix if the
> TOLUD guessing could be avoided.
>
> Thanks,
> Guo
>
> > -
quot; or "MMIO
in use and not detectable by OS".
Guess Top of lower usable DRAM (TOLUD) by walking memory ranges and then
mark everything reserved below TOLUD as DRAM and everything reserved above
TOLUD as MMIO.
This fixes several assertions seen in PciHostBridgeD
Tested the patch series on Intel Coffee Lake Platform using latest
coreboot master.
Everything seems to work fine.
Thanks
Patrick
On Thu, Jun 10, 2021 at 11:48 AM Zhiguang Liu wrote:
>
> Liming,
>
> Bugzilla is created at https://bugzilla.tianocore.org/show_bug.cgi?id=3447
>
> Thanks
> Zhiguang
available.
>
> Cc: Jian J Wang
> Cc: Hao A Wu
> Cc: Dandan Bi
> Cc: Star Zeng
> Cc: Zhichao Gao
> Signed-off-by: Patrick Rudolph
> Signed-off-by:
On Mon, May 24, 2021 at 9:13 AM Zhiguang Liu wrote:
> From SysTableInfo Hob, get ACPI table address, and creat gPldAcpiTableGuid
> Hob
> to store it. Remove diretly adding ACPI table to ConfigurationTable.
> Dxe ACPI driver will parse it and install ACPI table from Guid Hob.
>
> Cc: Maurice Ma
>
ilable.
>
> Cc: Jian J Wang
> Cc: Hao A Wu
> Cc: Dandan Bi
> Cc: Star Zeng
> Cc: Zhichao Gao
> Signed-off-by: Patrick Rudolph
> Signed-off-by: Zh
Hi Zhiguang,
this is still on my todo-list, but I'm quite busy right now.
If you got time please take care of that patch.
Regards,
Patrick Rudolph
On Thu, Apr 1, 2021 at 6:42 AM Liu, Zhiguang wrote:
>
> Hi Patrick Rudolph,
>
> I also want this feature that enables Smbios dr
f I can get rid of the table
shadow copy.
Regards,
Patrick Rudolph
On Wed, Mar 3, 2021 at 9:13 AM Ni, Ray wrote:
>
> In general, I agree this solution that lets SMBIOS driver directly absorbs
> the SMBIOS table from PEI.
> This can eliminate the needs of a separate driver that co
B RAM" was displayed.
Tests showed that the OS can still see the SMBIOS tables.
Signed-off-by: Patrick Rudolph
---
MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c | 223 +++-
1 file changed, 221 insertions(+), 2 deletions(-)
diff --git a/MdeModulePkg/Universal/SmbiosDxe/Smbi
ld make AllocateRuntimePool to allocate
> memory below 4GB while CpuDxe is dispatched above 4GB.
>
> Thanks,
> Guo
>
> > -Original Message-
> > From: Ma, Maurice
> > Sent: Monday, February 22, 2021 9:50 AM
> > To: Patrick Rudolph ; Dong, Guo
> >
hang in above 4GB case (commit:
> edd74ad3ad79b855f76d9cf60a96c405cb3e863b)
>
> Thanks,
> Guo
>
> > -Original Message-
> > From: devel@edk2.groups.io On Behalf Of Patrick
> > Rudolph
> > Sent: Monday, February 22, 2021 7:04 AM
> > To: devel@edk2.groups.io;
This patch breaks booting on master.
In CpuDxe.efi / InitGlobalDescriptorTable as the GDT pointer is casted
to 32bits.
Regards,
Patrick
On Fri, Feb 19, 2021 at 3:12 AM Ma, Maurice wrote:
>
> Reviewed-by: Maurice Ma
>
> Regards
> Maurice
>
> > -Original Message-
> > From: Dong, Guo
> >
BZ
> (https://bugzilla.tianocore.org/) for it?
>
> Thanks
> Liming
> > -邮件原件-
> > 发件人: bounce+27952+71716+4905953+8761...@groups.io
> > 代表 Patrick
> > Rudolph
> > 发送时间: 2021年2月17日 18:11
> > 收件人: devel@edk2.groups.io
> > 抄送: tcrawf...@sy
design proportions.
[1]:
https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/boot-screen-components#position-the-logo-during-post
Based on Tim Crawford initial commit.
Signed-off-by: Patrick Rudolph
---
MdeModulePkg/Include/Protocol/PlatformLogo.h | 3 ++-
MdeModul
B RAM" was displayed.
Tests showed that the OS can still see the SMBIOS tables.
Signed-off-by: Patrick Rudolph
---
MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c | 223 +++-
1 file changed, 221 insertions(+), 2 deletions(-)
diff --git a/MdeModulePkg/Universal/SmbiosDxe/Smbi
Hi Sunny,
none of the other packages are doing this before EndOfDxe. And there's
no point in having trusted console as earlier as possible, as nothing
is displayed in PlatformBootManagerBeforeConsole().
Please explain your use case. I don't see one here.
Kind Regards,
Patrick Rudolph
O
Currently the console is connected before EndOfDxe causing OptionsROMs
to be loaded, but their drivers aren't used and thus no GOP is installed.
To make use of 3rdparty OptionROMs connect the console after EndOfDxe.
Tested on Intel CFL board using Nvidia Quadro GPU.
Signed-off-by: Pa
I can confirm that it provides the same fix as my patch "MdeModulePkg:
Fix OptionROM scanning" sent earlier.
Tested on QEMU and Intel CFL board using coreboot as bootloader.
Kind Regards,
Patrick Rudolph
On Fri, Jan 29, 2021 at 10:00 AM Ni, Ray wrote:
>
> Rev
Hi,
Modifying the bootloader and defining an interface could take a while
and requires to add code that's already present in EDK2.
Would it be possible to move the Tcg*Pei code to a Library, so that it
could be directly used by BlSupportDxe in order to set the PCDs?
Kind Regards,
Patrick Ru
Hello,
Until now no regressions have been observed.
I'll provide a full test description using a wide variety of platforms soon.
Kind Regards,
Patrick Rudolph
On Thu, Jan 28, 2021 at 3:14 AM Wu, Hao A wrote:
>
> > -Original Message-----
> > From: Patrick Rudolph
BlSupportDxe is scheduled too late and other DXEs fail
to load due to broken PCI access.
Signed-off-by: Patrick Rudolph
---
UefiPayloadPkg/UefiPayloadPkg.fdf | 5 +
1 file changed, 5 insertions(+)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf
b/UefiPayloadPkg/UefiPayloadPkg.fdf
index
platforms not supporting rdrand.
Kind Regards,
Patrick Rudolph
On Thu, Jan 21, 2021 at 1:42 AM Ma, Maurice wrote:
>
> Hi, Patrick
>
> There is a BaseRngLib in MdePkg package already. I am wondering why a new
> instance was created under UefiPayloadPkg in the patch.
>
I don't want to use RegisterProtocolNotify() as it's discouraged, isn't it?
Kind Regards,
Patrick Rudolph
On Thu, Jan 21, 2021 at 2:14 AM Ma, Maurice wrote:
>
> Hi, Patrick
>
> In this patch I noticed that we changed the BlSupportDxe dependency from True
> to gEfiSmbiosP
howed that the OS can still see the SMBIOS tables.
Signed-off-by: Patrick Rudolph
---
UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c | 111 +++-
UefiPayloadPkg/BlSupportDxe/BlSupportDxe.h | 3 +
UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf | 5 +-
3 files changed, 115 insert
boot delay without this patch as it doesn't respond to 'GetProtocolRequest'.
Signed-off-by: Matt DeVillier
Signed-off-by: Patrick Rudolph
---
MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c | 28
1 file changed, 17 insertions(+), 11 deletions(-)
diff --git a/MdeModule
From: Matt DeVillier
SetConfig is already called during device enumeration,
no need to do it again here.
Signed-off-by: Matt DeVillier
---
MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c | 37
1 file changed, 37 deletions(-)
diff --git a/MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c
Uses the RDRAND instruction if available and install EfiRngProtocol.
The protocol may be used by iPXE or the Linux kernel to gather entropy.
Signed-off-by: Patrick Rudolph
---
UefiPayloadPkg/Library/BaseRngLib/BaseRng.c | 199
UefiPayloadPkg/Library/BaseRngLib
53 matches
Mail list logo
