Re: [edk2-devel] [PATCH v8 3/6] OvmfPkg/BaseMemEncryptLib: Invoke page encryption state change hypercall

2022-06-08 Thread Nikunj A. Dadhania via groups.io
Hi Ashish, On 6/7/2022 10:58 PM, Kalra, Ashish wrote: > > Hello Nikunj, > > Yes we can move MemEncryptSevLiveMigrationIsEnabled() check here before > calling SetMemoryEncDecHypercall3() > > but then we also need to remove the same check from inside > SetMemoryEncDecHypercall3() function. Sur

Re: [edk2-devel] [PATCH v8 3/6] OvmfPkg/BaseMemEncryptLib: Invoke page encryption state change hypercall

2022-06-08 Thread Nikunj A. Dadhania via groups.io
Hi Ashish, For case with latest OVMF and older qemu that does not enable live migrations, SetMemoryEncDecHypercall3() returns RETURN_UNSUPPORTED, which is correct. But then its actually treated as an error and OVMF sees an assert. This is a valid usecase and OVMF should move ahead without live mi

Re: [edk2-devel] [PATCH v8 5/6] OvmfPkg/PlatformPei: Mark SEC GHCB page as unencrypted via hypercall

2022-05-31 Thread Nikunj A. Dadhania via groups.io
Hi Ashish, I missed the v8 and replied on v7. On 4/5/2022 11:02 PM, Ashish Kalra via groups.io wrote: > From: Ashish Kalra > > Mark the SEC GHCB page (that is mapped as unencrypted in > ResetVector code) in the hypervisor's guest page encryption > state tracking. > > Cc: Jordan Justen > Cc: A

Re: [edk2-devel] [PATCH v7 5/6] OvmfPkg/PlatformPei: Mark SEC GHCB page as unencrypted via hypercall

2022-05-31 Thread Nikunj A. Dadhania via groups.io
Hi Ashish, On 8/19/2021 7:36 PM, Ashish Kalra via groups.io wrote: > From: Ashish Kalra > > Mark the SEC GHCB page (that is mapped as unencrypted in > ResetVector code) in the hypervisor's guest page encryption > state tracking. > > Cc: Jordan Justen > Cc: Ard Biesheuvel > Signed-off-by: Ashi