Re: [edk2-devel] [PATCH V2] RedfishPkg/RedfishDiscoverDxe: Install EFI_DISCOVER_PROTOCOL on each network interface

Reviewed-by: Nickle Wang Thanks, Nickle 於 2022年9月1日 週四 中午12:02寫道： > From: Abner Chang > > BZ 4037: > Install EFI_DISCOVER_PROTOCOL on each network interface. > > This fixes the issue that causes the high-level Redfish driver > on the network interface is stopped when: > 1. EFI_DISCOVER_PRO

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishDiscoverDxe: Install EFI_DISCOVER_PROTOCOL on each network interface

Hi Abner, I see that the comment is in the middle of function parameters. I suggest that we can move the comment to the position before function call. +Status = CloseProtocolService ( + // Close protocol and destroy service. +

Re: [edk2-devel] [PATCH] edk2-staging/RedfishClientPkg: Update Redfish converter lib

Reviewed-by: Nickle Wang Thanks, Nickle 於 2022年8月28日 週日 晚上7:30寫道： > From: Abner Chang > > Temporary modified on the auto-generated lib to support > Redfish BIOS attributes. RedfishScemaToCStructure python > script needs to be updated for fixing this issue. > > Signed-off-by: Abner Chang > C

Re: [edk2-devel] [PATCH] Maintainers.txt: Update maintainers list

> > M: Ard Biesheuvel [ardbiesheuvel] > > M: Abner Chang [changab] > > -R: Daniel Schaefer [JohnAZoidberg] > > +R: Daniel Schaefer [JohnAZoidberg] > > > > EmulatorPkg > > F: EmulatorPkg/ > > @@ -197,7 +197,7 @@ S: Maintained > > EmulatorPk