This refactor is derrived from ArmPkg/SMBIOS and customize to adapt
with platform. These changes help to separate each Type of SMBIOS table
into individual modules. It makes the structure of SmbiosPlatformDxe
module clear and easier to add new type of table.
Signed-off-by: Minh Nguyen
---
Platfo
This corrects "PcdSmbiosTables1MajorVersion" and
"PcdSmbiosTables1MinorVersion" of SMBIOS Type 1,
these PCDs should be for Type 0.
Signed-off-by: Minh Nguyen
---
Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec| 14
--
Platform/Ampere/JadePkg/Drivers/SmbiosPl
This adds support SMBIOS Tables Type 16, 17, 19 for information of
Physical Memory, Memory Device and Memory Array Mapped Address.
Signed-off-by: Minh Nguyen
---
Platform/Ampere/JadePkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf
| 6 +
Silicon/Ampere/AmpereAlt
These patches helps to add new SMBIOS Tables (Type 16, 17, 19) and refactor
SmbiosPlatformDxe.
Minh Nguyen (4):
JadePkg: Correct PCD names for SMBIOS Type 0
JadePkg: Leverage ArmPkg/Smbios (Type 0, 1, 2, 3, 13, 32)
JadePkg: Refactor SmbiosPlatformDxe
JadePkg: Add support SMBIOS Table Type
This implementation helps SMBIOS Table (Type 0, 1, 2, 3, 13, 32)
of Altra and AltraMax platform to utilize framework from ArmPkg.
Signed-off-by: Minh Nguyen
---
Platform/Ampere/JadePkg/Jade.dsc| 7
+-
Platform/Ampere/JadePkg/Jade.fdf
This helps to remove redundant assign for SmbiosHandle.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Sami Mujawar
Signed-off-by: Minh Nguyen
---
ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/
To iterate entire SMBIOS table records for searching specific records,
"SmbiosHandle" input need to be as "SMBIOS_HANDLE_PI_RESERVED". This
patch helps to fix that.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Sami Mujawar
Signed-off-by: Minh Nguyen
---
ArmPkg/Universal/Smbios/SmbiosMiscDxe/Smbio
These patches help to fix an issue in SmbiosMiscDxe and remove redundant asign
for SmbiosHandle.
Minh Nguyen (2):
ArmPkg/SmbiosMiscDxe: Fix procedure to get handle of SMBIOS records
ArmPkg/SmbiosMiscDxe: Remove redundant assign for SmbiosHandle
ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMi
From: Tam Chi Nguyen
This patch adds a new Pkcs7GetSignature API to support
extracting the signature data from PKCS7 Certificate.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Minh Nguyen
---
CryptoPkg/Include/Library/BaseCryptLib.h | 29 ++
From: Vu Nguyen
This adds PCIe Hot Plug library to support Hot Plug
feature and specific procedures for setting different
Portmap tables (GPIO pins used for PCIe reset).
Signed-off-by: Minh Nguyen
---
Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dec| 8
+-
Silicon/Am
From: Tinh Nguyen
Add PCIe link retry logic. If the card is detected to be present,
allow a retry for 3 times.
When the link is down, check if the LTSSMEN bit is cleared.
Based on Altra PCIe IP, the LTSSMEN bit is cleared from 1 to 0
if there is a surprising link down.
This indicates that a card
These patches support NVMe Hot Plug feature for Ampere Altra and Ampere Altra
Max.
Minh Nguyen (2):
AmpereAltraPkg: Add Hot Plug Slot Capable during PCIe port
initialization
AmpereAltraPkg: Change PCIe Amba Link Timeout value
Vu Nguyen (4):
AmpereAltraPkg: Add PCIe Hot Plug library
J
From: Vu Nguyen
This enables NVMe Hot Plug feature after finishing
PCIe set up. This helps to detect NVMe disk when
it's removed or inserted into its slot.
Signed-off-by: Minh Nguyen
---
Silicon/Ampere/AmpereAltraPkg/Drivers/PcieInitPei/PcieInitPei.inf | 3 ++-
Silicon/Ampere/AmpereAltraPkg/Dr
From: Vu Nguyen
This adds necessary changes of ACPI tables and defines the memory
region between OS and Trusted Firmware-A for supporting Hot Plug
of Ampere Altra Max.
Signed-off-by: Minh Nguyen
---
Platform/Ampere/JadePkg/Ac02AcpiTables/CommonDevices.asi | 24 +
Platform/Ampere/JadePkg/Ac02
Currently, the implementation starts link training and put device
out-of-reset right away. This make LinkStat and BlockEventStat registers
indicate that link is not up yet (LinkStat: 0x300 and BlockEventStat: 0x0).
This fix will start link training after putting device out-of-reset.
The values of L
From: Vu Nguyen
This adds necessary changes of ACPI tables and defines the memory
region between OS and Trusted Firmware-A for supporting Hot Plug
of Ampere Altra.
Signed-off-by: Minh Nguyen
---
Platform/Ampere/JadePkg/AcpiTables/Dsdt.asl | 499 -
Platform/Ampere/JadePkg/AcpiTables/
As AMBA_LINK_TIMEOUT_OFF spec, it impacts OS Hot Plug removal delay.
The greater value the longer delay it is. Per experiments, set it 2
from beginning of Root Port initialization for stable operation.
Signed-off-by: Minh Nguyen
---
Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c |
In order to detect the NVMe after OS boots successfully but
that NVMe's not present previously. Hot Plug Slot Capable
will help PCI Linux driver to initialize its slot iomem resource
which is used for detecting the disk when it's inserted.
Signed-off-by: Minh Nguyen
---
Silicon/Ampere/AmpereAltr
Because PCIe Auto bifurcation feature doesn't depend on the default
Devmap mode so that "DevMapModeAuto" is unnecessary in retrieving
the PCIe Devmap default mode.
Signed-off-by: Minh Nguyen
---
Silicon/Ampere/AmpereAltraPkg/Drivers/PcieInitPei/RootComplexNVParam.c | 2 +-
1 file changed, 1 inse
These patches help to improve PCIe core for Link training sequence and
add logic to check PCIe card is present or not. One patch also removes
unnecessary checks for PCIe Devmap mode.
Minh Nguyen (2):
AmpereAltraPkg: Remove PCIe "DevMapModeAuto" case in retrieving Devmap
mode
AmpereAltraPkg
From: Vu Nguyen
When a MAC address matching interface is found, a RestEx child will be
created to provide the Redfish communication on that interface.
Currently, It will try to locate all RestEx binding services and choose
the first satisfied instance without taking care about current selected
in
From: Nhi Pham
This adds a missing newline character to make the error log
readable in case the module is failed.
Signed-off-by: Minh Nguyen
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Reviewed-by: Nickle Wang
---
RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 3 +
From: Vu Nguyen
Id will be casted by CoreOpenProtocol, declare this variable with a
wrong type might result in the corruption of other local variables.
Signed-off-by: Minh Nguyen
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Reviewed-by: Nickle Wang
---
RedfishPkg/RedfishRestExDxe/
From: Vu Nguyen
It requires a fixed size array to store the content of device path PCD.
Add the array size to solve this issue.
Signed-off-by: Minh Nguyen
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Reviewed-by: Abner Chang
---
RedfishPkg/Include/Pcd/RestExServiceDevicePath.h | 5
From: Vu Nguyen
This change fixes condition checking of error status, the condition
should be compared with TRUE status to be identical with an error message.
Signed-off-by: Minh Nguyen
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Reviewed-by: Nickle Wang
---
RedfishPkg/RedfishDis
This patchset adds necessary changes for RedfishPkg to avoid some unexpected
cases and fix compilation.
Changes since v3:
+ Replaced __FUNCTION__ with __func__ to be more C11 compliant.
Changes since v2:
+ Added "Cc:" to maintainers in commit message.
+ Corrected patch format subject prefix.
C
From: Vu Nguyen
Add extra option call Auto to the Bifurcation selection. This mode will
automatically select the best bifurcation mode the current Root Complex.
Currently, this option only availabe on the RCA with x16 width.
Signed-off-by: Minh Nguyen
---
Silicon/Ampere/AmpereAltraPkg/Include/
These patches support for PCIe Auto Bifurcation feature of Ampere
silicon (Altra and Altra Max).
Vu Nguyen (2):
AmpereAltraPkg: Add support for PCIe Auto Bifurcation
AmpereAltraPkg: Enable auto bifurcation via BoardSetting
Silicon/Ampere/AmpereAltraPkg/Drivers/PcieInitPei/RootComplexNVParam.
From: Vu Nguyen
Add support for new BoardSetting's config value (0x000A) to enable auto
bifurcation mode per Root Complex:
Example:
NV_SI_RO_BOARD_S0_RCA2_CFG, 0x0098, 0x000A
NV_SI_RO_BOARD_S0_RCA3_CFG, 0x00A0, 0x000A
Signed-off-by: Minh Nguyen
---
Silicon/Ampere/AmpereAltraPk
From: Vu Nguyen
It requires a fixed size array to store the content of device path PCD.
Add the array size to solve this issue.
Signed-off-by: Minh Nguyen
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Reviewed-by: Abner Chang
---
RedfishPkg/Include/Pcd/RestExServiceDevicePath.h | 5
From: Vu Nguyen
When a MAC address matching interface is found, a RestEx child will be
created to provide the Redfish communication on that interface.
Currently, It will try to locate all RestEx binding services and choose
the first satisfied instance without taking care about current selected
in
From: Vu Nguyen
This change fixes condition checking of error status, the condition
should be compared with TRUE status to be identical with an error message.
Signed-off-by: Minh Nguyen
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDx
This patchset adds necessary changes for RedfishPkg to avoid some unexpected
cases and fix compilation.
Changes since v2:
+ Add "Cc:" to maintainers in commit message.
+ Correct patch format subject prefix.
Changes since v1:
+ Remove redundant change and change the commit message for more prec
From: Nhi Pham
This adds a missing newline character to make the error log
readable in case the module is failed.
Signed-off-by: Minh Nguyen
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Reviewed-by: Nickle Wang
---
RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 3 +
From: Vu Nguyen
Id will be casted by CoreOpenProtocol, declare this variable with a
wrong type might result in the corruption of other local variables.
Signed-off-by: Minh Nguyen
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Reviewed-by: Nickle Wang
---
RedfishPkg/RedfishRestExDxe/
From: Vu Nguyen
When a MAC address matching interface is found, a RestEx child will be
created to provide the Redfish communication on that interface.
Currently, It will try to locate all RestEx binding services and choose
the first satisfied instance without taking care about current selected
in
From: Vu Nguyen
Id will be casted by CoreOpenProtocol, declare this variable with a
wrong type might result in the corruption of other local variables.
Signed-off-by: Minh Nguyen
Reviewed-by: Nickle Wang
---
RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h | 3 ++-
1 file changed, 2 insertio
From: Vu Nguyen
It requires a fixed size array to store the content of device path PCD.
Add the array size to solve this issue.
Signed-off-by: Minh Nguyen
Reviewed-by: Abner Chang
---
RedfishPkg/Include/Pcd/RestExServiceDevicePath.h | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
d
This patchset adds necessary changes for RedfishPkg to avoid some unexpected
cases and fix compilation.
Changes since v1:
+ Remove redundant change and change the commit message for more precise in
PATCH 2/5.
Nhi Pham (1):
RedfishPkg: Add missing newline character
Vu Nguyen (4):
RedfishPk
From: Vu Nguyen
This change fixes condition checking of error status, the condition
should be compared with TRUE status to be identical with an error message.
Signed-off-by: Minh Nguyen
---
RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(
From: Nhi Pham
This adds a missing newline character to make the error log
readable in case the module is failed.
Signed-off-by: Minh Nguyen
Reviewed-by: Nickle Wang
---
RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
Hi Wang,
Thanks for this point, you're right. It's a redundant change and I will update
in v2 patches, but the second change is necessary. How do you think about that?
Thanks,
Minh Nguyen
-Original Message-
From: Nickle Wang
Sent: Friday, April 14, 2023 4:04 PM
To: Minh Nguyen OS ; d
From: Vu Nguyen
It requires a fixed size array to store the content of device path PCD.
Add the array size to solve this issue.
Signed-off-by: Minh Nguyen
---
RedfishPkg/Include/Pcd/RestExServiceDevicePath.h | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/RedfishPkg/Inc
From: Nhi Pham
This adds a missing newline character to make the error log
readable in case the module is failed.
Signed-off-by: Minh Nguyen
---
RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/RedfishPkg/Redfish
From: Vu Nguyen
When a MAC address matching interface is found, a RestEx child will be
created to provide the Redfish communication on that interface.
Currently, It will try to locate all RestEx binding services and choose
the first satisfied instance without taking care about current selected
in
From: Vu Nguyen
This change also fix miscellaneous errors on condition checking and
debug argument missing.
Signed-off-by: Minh Nguyen
---
RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/RedfishPkg/RedfishDiscoverDxe/R
From: Vu Nguyen
Id will be casted by CoreOpenProtocol, declare this variable with a
wrong type might result in the corruption of other local variables.
Signed-off-by: Minh Nguyen
---
RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
This patchset adds necessary changes for RedfishPkg to avoid
some unexpected cases and fix compilation.
Nhi Pham (1):
RedfishPkg: Add missing newline character
Vu Nguyen (4):
RedfishPkg: Correct variable type to prevent memory corruption
RedfishPkg: Prevent assertion of allocate zero lengt
48 matches
Mail list logo
