[edk2-devel] Buildtools error

2021-07-20 Thread Matthew Carlson via groups.io
leOrder FileList.remove(item) ValueError: list.remove(x): x not in list Happy to provide more information but in the meantime, I’ll be trying to figure out what’s going on. Thanks! - Matthew Carlson -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Re

[edk2-devel] [PATCH v2 1/1] EmbeddedPkg: fix guid for PrePiHobLib

2021-03-16 Thread Matthew Carlson
Currently there is a duplicate GUID shared by two INFs. This rolls the INF for the PrePiHobLib. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2381 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: devel@edk2.groups.io Signed-off-by: Matthew Carlson --- EmbeddedPkg/Library/PrePiHobLib

[edk2-devel] [PATCH v2 0/1] Fix GUID in PrePiHobLib

2021-03-16 Thread Matthew Carlson
Currently there is a duplicate GUID shared by two INFs. This rolls the INF for the PrePiHobLib. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2381 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: devel@edk2.groups.io Matthew Carlson (1): EmbeddedPkg: fix guid for PrePiHobLib EmbeddedPkg

[edk2-devel] [PATCH v2 1/1] CryptoPkg: Added CC flags for ARM on IntrinsicLib

2021-03-15 Thread Matthew Carlson
From: Matthew Carlson Signed-off-by: Matthew Carlson This added the compiler flags that were already defined for X64 and IA32. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2821 Ref: https://github.com/tianocore/edk2/pull/1493 Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc

[edk2-devel] [PATCH v2 0/1] CryptoPkg: Add flags for IntrinsicLib

2021-03-15 Thread Matthew Carlson
Small patch series that fixes a bugzilla. V2: Actually added the patch information. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2821 Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: devel@edk2.groups.io Matthew Carlson (1): CryptoPkg: Added CC flags for ARM

[edk2-devel] [PATCH v1 1/1] CryptoPkg: Added CC flags for ARM on IntrinsicLib

2021-03-15 Thread Matthew Carlson
From: Matthew Carlson Signed-off-by: Matthew Carlson This added the compiler flags that were already defined for X64 and IA32. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2821 Ref: https://github.com/tianocore/edk2/pull/1493 Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc

[edk2-devel] [PATCH v1 0/1] CryptoPkg: Add flags for IntrinsicLib

2021-03-15 Thread Matthew Carlson
Small patch series that fixes a bugzilla. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2821 Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: devel@edk2.groups.io Matthew Carlson (1): CryptoPkg: Added CC flags for ARM on IntrinsicLib CryptoPkg/Library

[edk2-devel] [PATCH v1 1/1] CryptoPkg: Added CC flags for ARM on IntrinsicLib

2021-03-15 Thread Matthew Carlson
From: Matthew Carlson Signed-off-by: Matthew Carlson This added the compiler flags that were already defined for X64 and IA32. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2821 Ref: https://github.com/tianocore/edk2/pull/1493 Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc

[edk2-devel] [PATCH v1 0/1] CryptoPkg: Add flags for IntrinsicLib

2021-03-15 Thread Matthew Carlson
Small patch series that fixes a bugzilla. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2821 Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: devel@edk2.groups.io Matthew Carlson (1): CryptoPkg: Added CC flags for ARM on IntrinsicLib CryptoPkg/Library

[edk2-devel] [PATCH v5 1/1] BaseTools: Use pip module if available, CI uses it by default

2021-02-08 Thread Matthew Carlson
From: Matthew Carlson Use the new edk2-basetools pip module. Includes a helpful message in setup to let users know which has been selected. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Reviewed-by: Bob Feng Signed-off-by: Matthew Carlson --- .pytool/CISettings.py

[edk2-devel] [PATCH v5 0/1] Use Pip version of BaseTools

2021-02-08 Thread Matthew Carlson
From: Matthew Carlson Hello all, This patch adds the capability to leverage the pip based BaseTools. The BaseTools master is current with EDK2 master (as of 3pm Nov 2, 2020). While I could rehash a lot of what has gone out on the mailing list, I think it might be better just to link the

[edk2-devel] [PATCH v4 1/1] BaseTools: Use pip module if available, CI uses it by default

2021-01-28 Thread Matthew Carlson
From: Matthew Carlson Use the new edk2-basetools pip module. Includes a helpful message in setup to let users know which has been selected. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Reviewed-by: Bob Feng Signed-off-by: Matthew Carlson --- .pytool/CISettings.py

[edk2-devel] [PATCH v4 0/1] Use Pip version of BaseTools

2021-01-28 Thread Matthew Carlson
From: Matthew Carlson Hello all, This patch adds the capability to leverage the pip based BaseTools. The BaseTools master is current with EDK2 master (as of 3pm Nov 2, 2020). While I could rehash a lot of what has gone out on the mailing list, I think it might be better just to link the

Re: [edk2-devel] [PATCH] EmulatorPkg: Add RngLib to satisfy dependency of OpensslLib

2020-09-23 Thread Matthew Carlson
project in the devops for tianocore (https://dev.azure.com/tianocore/) since the pipelines for edk2-ci should remain in one project. Perhaps edk2-platforms-ci? Matthew Carlson From: Samer El-Haj-MahmoudSent: Wednesday, September 23, 2020 6:43 AMTo: devel@edk2.groups.io; divneil.r.wadha...@intel.com

Re: [edk2-devel] [PATCH] EmulatorPkg: Add RngLib to satisfy dependency of OpensslLib

2020-09-19 Thread Matthew Carlson via groups.io
Thanks for catching this! -- - Matthew Carlson -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65411): https://edk2.groups.io/g/devel/message/65411 Mute This Topic: https://groups.io/mt/76949410/21656 Group Owner: devel+ow...@edk2

Re: [edk2-devel] 回复: [edk2-devel] [PATCH v10 0/5] Use RngLib instead of TimerLib for OpensslLib

2020-09-16 Thread Matthew Carlson via groups.io
Hey Liming! I added the two reviewed by and pushed to the PR here: https://github.com/tianocore/edk2/pull/933 Feel free to use that PR to merge in -- - Matthew Carlson -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65342): https

Re: [edk2-devel] 回复: edk2-devel] [PATCH v10 0/5] Use RngLib instead of TimerLib for OpensslLib

2020-09-15 Thread Matthew Carlson
Looks good to me On Sep 15, 2020, 6:39 PM -0700, gaoliming , wrote: > I normally check Maintainers.txt and make sure each patch get the review from > package maintainer or package reviewer. > > Thanks > Liming > 发件人: Matthew Carlson >  发送时间: 2020年9月16日 9:00 > 收件人

Re: [edk2-devel] [PATCH v10 0/5] Use RngLib instead of TimerLib for OpensslLib

2020-09-15 Thread Matthew Carlson
yes, I will help merge them.  ThanksLiming发件人: bounce+27952+65285+4905953+8761...@groups.io 代表 Matthew Carlson via groups.io发送时间: 2020年9月16日 6:48收件人: Matthew Carlson ; devel@edk2.groups.io主题: Re: [edk2-devel] [PATCH v10 0/5] Use RngLib instead of TimerLib for OpensslLib Just pinging this thread to

[edk2-devel] [PATCH v2 0/1] Update IASL extdep for CI

2020-09-15 Thread Matthew Carlson
From: Matthew Carlson Currently EDK2 has an external dependency to download the IASL compiler. This updates that nuget stream with a much more current version produced by a pipeline that runs regularly. Feel free to check out the repo here: https://dev.azure.com/projectmu/_git/acpica To

[edk2-devel] [PATCH v2 1/1] BaseTools: update IASL extdep to more modern version

2020-09-15 Thread Matthew Carlson
From: Matthew Carlson The IASL extdep is used for CI only and a recent fork of the ACPICA repo was made to make nuget builds more regular and easier to audit. https://dev.azure.com/projectmu/_git/acpica Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Cc: Sean Brogan Reviewed-by: Liming Gao

Re: [edk2-devel] [PATCH v10 0/5] Use RngLib instead of TimerLib for OpensslLib

2020-09-15 Thread Matthew Carlson via groups.io
Just pinging this thread to see what needs to get done next. Thank you Liming for the reviewed by on the MdeModulePkg changes. -- - Matthew Carlson -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65285): https://edk2.groups.io/g/devel

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: update IASL extdep to more modern version

2020-09-13 Thread Matthew Carlson
future, when update new iasl version again, only this line "version":"20200717.0.0" will be updated, right? ThanksLiming> -邮件原件-> 发件人: bounce+27952+65199+4905953+8761...@groups.io> 代表 Matthew> Carlson> 发送时间: 2020年9月12日 4:45> 收件人: devel@edk2.groups.io>

[edk2-devel] [PATCH v1 0/1] Update IASL extdep for CI

2020-09-11 Thread Matthew Carlson
From: Matthew Carlson Currently EDK2 has an external dependency to download the IASL compiler. This updates that nuget stream with a much more current version produced by a pipeline that runs regularly. Feel free to check out the repo here: https://dev.azure.com/projectmu/_git/acpica To

[edk2-devel] [PATCH v1 1/1] BaseTools: update IASL extdep to more modern version

2020-09-11 Thread Matthew Carlson
From: Matthew Carlson The IASL extdep is used for CI only and a recent fork of the ACPICA repo was made to make nuget builds more regular and easier to audit. https://dev.azure.com/projectmu/_git/acpica Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Cc: Sean Brogan Cc: devel@edk2.groups.io

Re: [edk2-devel] Basetools as a pip module

2020-09-02 Thread Matthew Carlson
;ll move ahead with a proposed solution in patches next week. -Matthew Carlson On Wed, Sep 2, 2020 at 1:49 AM Laszlo Ersek wrote: > On 09/02/20 02:49, Andrew Fish via groups.io wrote: > > > > > >> On Sep 1, 2020, at 4:35 PM, Matthew Carlson > wrote: > >> >

[edk2-devel] Basetools as a pip module

2020-09-01 Thread Matthew Carlson
. With two seperate versions of Basetools, it becomes very easy for the version of basetools you're using to not be the one you expect. Thank you. -Matthew Carlson -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64924): https://edk2.gr

[edk2-devel] [PATCH v10 0/5] Use RngLib instead of TimerLib for OpensslLib

2020-09-01 Thread Matthew Carlson
From: Matthew Carlson Hello all, This patch contains a fix for Bugzilla 1871. There's been a good bit of community discussion around the topic, so below follows a general overview of the discussion and what this patch does. This is the seventh iteration of this patch series, focused on

[edk2-devel] [PATCH v10 5/5] CryptoPkg: OpensslLib: Use RngLib to generate entropy in rand_pool

2020-09-01 Thread Matthew Carlson
From: Matthew Carlson Ref: https://github.com/tianocore/edk2/pull/845 Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 Changes OpenSSL to no longer depend on TimerLib and instead use RngLib. This allows platforms to decide for themsevles what sort of entropy source they provide to

[edk2-devel] [PATCH v10 2/5] MdePkg: BaseRngLibDxe: Add RngLib that uses RngDxe

2020-09-01 Thread Matthew Carlson
From: Matthew Carlson This adds a RngLib that uses the RngProtocol to provide randomness. This means that the RngLib is meant to be used with DXE_DRIVERS. Ref: https://github.com/tianocore/edk2/pull/845 Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 Cc: Ard Biesheuvel Cc: Michael D

[edk2-devel] [PATCH v10 0/5] Use RngLib instead of TimerLib for OpensslLib

2020-09-01 Thread Matthew Carlson
From: Matthew Carlson Hello all, This patch contains a fix for Bugzilla 1871. There's been a good bit of community discussion around the topic, so below follows a general overview of the discussion and what this patch does. This is the seventh iteration of this patch series, focused on

[edk2-devel] [PATCH v10 1/5] MdePkg: TimerRngLib: Added RngLib that uses TimerLib

2020-09-01 Thread Matthew Carlson
From: Matthew Carlson Added a new RngLib that provides random numbers from the TimerLib using the performance counter. This is meant to be used for OpenSSL to replicate past behavior. This should not be used in production as a real source of entropy. Ref: https://github.com/tianocore/edk2/pull

[edk2-devel] [PATCH v10 4/5] ArmVirtPkg: Add RngLib based on TimerLib for CryptoPkg

2020-09-01 Thread Matthew Carlson
From: Matthew Carlson Updates the DSC for the ArmVirtPkg platform to add a RngLib that uses the TimerLib. This is due to a later change that adds TimerLib as a dependency for OpenSSL. The TimerLib based RngLib mimics the behavior of OpenSSL previously and it is recommended to switch to a better

[edk2-devel] [PATCH v10 3/5] OvmfPkg: Add RngLib based on TimerLib for Crypto

2020-09-01 Thread Matthew Carlson
From: Matthew Carlson Updates the DSC's for Ovmf based platforms to add a RngLib that uses the TimerLib. This is due to a later change that adds TimerLib as a dependency for OpenSSL. The TimerLib based RngLib mimics the behavior of OpenSSL previously and it is recommended to switch to a b

[edk2-devel] [PATCH v9 5/5] CryptoPkg: OpensslLib: Use RngLib to generate entropy in rand_pool

2020-08-26 Thread Matthew Carlson
From: Matthew Carlson Ref: https://github.com/tianocore/edk2/pull/845 Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 Changes OpenSSL to no longer depend on TimerLib and instead use RngLib. This allows platforms to decide for themsevles what sort of entropy source they provide to

[edk2-devel] [PATCH v9 0/5] Use RngLib instead of TimerLib for OpensslLib

2020-08-26 Thread Matthew Carlson
From: Matthew Carlson Hello all, This patch contains a fix for Bugzilla 1871. There's been a good bit of community discussion around the topic, so below follows a general overview of the discussion and what this patch does. This is the seventh iteration of this patch series, focused on

[edk2-devel] [PATCH v9 1/5] MdePkg: TimerRngLib: Added RngLib that uses TimerLib

2020-08-26 Thread Matthew Carlson
From: Matthew Carlson Added a new RngLib that provides random numbers from the TimerLib using the performance counter. This is meant to be used for OpenSSL to replicate past behavior. This should not be used in production as a real source of entropy. Ref: https://github.com/tianocore/edk2/pull

[edk2-devel] [PATCH v9 3/5] OvmfPkg: Add RngLib based on TimerLib for Crypto

2020-08-26 Thread Matthew Carlson
From: Matthew Carlson Updates the DSC's for Ovmf based platforms to add a RngLib that uses the TimerLib. This is due to a later change that adds TimerLib as a dependency for OpenSSL. The TimerLib based RngLib mimics the behavior of OpenSSL previously and it is recommended to switch to a b

[edk2-devel] [PATCH v9 4/5] ArmVirtPkg: Add RngLib based on TimerLib for CryptoPkg

2020-08-26 Thread Matthew Carlson
From: Matthew Carlson Updates the DSC for the ArmVirtPkg platform to add a RngLib that uses the TimerLib. This is due to a later change that adds TimerLib as a dependency for OpenSSL. The TimerLib based RngLib mimics the behavior of OpenSSL previously and it is recommended to switch to a better

[edk2-devel] [PATCH v9 2/5] MdePkg: BaseRngLibDxe: Add RngLib that uses RngDxe

2020-08-26 Thread Matthew Carlson
From: Matthew Carlson This adds a RngLib that uses the RngProtocol to provide randomness. This means that the RngLib is meant to be used with DXE_DRIVERS. Ref: https://github.com/tianocore/edk2/pull/845 Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 Cc: Ard Biesheuvel Cc: Michael D

Re: [edk2-devel] [PATCH v8 1/5] MdePkg: TimerRngLib: Added RngLib that uses TimerLib

2020-08-20 Thread Matthew Carlson
I can think of doing this but none are very good.I'm open to suggestions. -Matthew Carlson On Thu, Aug 20, 2020 at 8:21 AM Kinney, Michael D < michael.d.kin...@intel.com> wrote: > Hi Matt, > > Some comments inline below. > > I also see come comments from Ard on this serie

[edk2-devel] [PATCH v8 1/5] MdePkg: TimerRngLib: Added RngLib that uses TimerLib

2020-08-19 Thread Matthew Carlson
From: Matthew Carlson Added a new RngLib that provides random numbers from the TimerLib using the performance counter. This is meant to be used for OpenSSL to replicate past behavior. This should not be used in production as a real source of entropy. Ref: https://github.com/tianocore/edk2/pull

[edk2-devel] [PATCH v8 2/5] MdePkg: BaseRngLibDxe: Add RngLib that uses RngDxe

2020-08-19 Thread Matthew Carlson
From: Matthew Carlson This adds a RngLib that uses the RngProtocol to provide randomness. This means that the RngLib is meant to be used with DXE_DRIVERS. Ref: https://github.com/tianocore/edk2/pull/845 Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 Cc: Ard Biesheuvel Cc: Michael D

[edk2-devel] [PATCH v8 5/5] CryptoPkg: OpensslLib: Use RngLib to generate entropy in rand_pool

2020-08-19 Thread Matthew Carlson
From: Matthew Carlson Ref: https://github.com/tianocore/edk2/pull/845 Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 Changes OpenSSL to no longer depend on TimerLib and instead use RngLib. This allows platforms to decide for themsevles what sort of entropy source they provide to

[edk2-devel] [PATCH v8 4/5] ArmVirtPkg: Add RngLib based on TimerLib for CryptoPkg

2020-08-19 Thread Matthew Carlson
From: Matthew Carlson Updates the DSC for the ArmVirtPkg platform to add a RngLib that uses the TimerLib. This is due to a later change that adds TimerLib as a dependency for OpenSSL. The TimerLib based RngLib mimics the behavior of OpenSSL previously and it is recommended to switch to a better

[edk2-devel] [PATCH v8 3/5] OvmfPkg: Add RngLib based on TimerLib for Crypto

2020-08-19 Thread Matthew Carlson
From: Matthew Carlson Updates the DSC's for Ovmf based platforms to add a RngLib that uses the TimerLib. This is due to a later change that adds TimerLib as a dependency for OpenSSL. The TimerLib based RngLib mimics the behavior of OpenSSL previously and it is recommended to switch to a b

[edk2-devel] [PATCH v8 0/5] Use RngLib instead of TimerLib for OpensslLib

2020-08-19 Thread Matthew Carlson
From: Matthew Carlson Hello all, This patch contains a fix for Bugzilla 1871. There's been a good bit of community discussion around the topic, so below follows a general overview of the discussion and what this patch does. This is the seventh iteration of this patch series, focused on

Re: [edk2-devel] [PATCH v7 0/5] Use RngLib instead of TimerLib for OpensslLib

2020-08-14 Thread Matthew Carlson
Thanks Mike, I've addressed all your comments. I'll wait for a few more people to weigh in before I send out v8. -Matthew Carlson On Thu, Aug 13, 2020 at 6:12 PM Kinney, Michael D < michael.d.kin...@intel.com> wrote: > Hi Matt, > > BaseRngLibTimerLib > ===

[edk2-devel] [PATCH v7 2/5] MdePkg: BaseRngLibDxe: Add RngLib that uses RngDxe

2020-08-13 Thread Matthew Carlson
From: Matthew Carlson This adds a RngLib that uses the RngProtocol to provide randomness. This means that the RngLib is meant to be used with DXE_DRIVERS. Ref: https://github.com/tianocore/edk2/pull/845 Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 Cc: Ard Biesheuvel Cc: Michael D

[edk2-devel] [PATCH v7 0/5] Use RngLib instead of TimerLib for OpensslLib

2020-08-13 Thread Matthew Carlson
From: Matthew Carlson Hello all, This patch contains a fix for Bugzilla 1871. There's been a good bit of community discussion around the topic, so below follows a general overview of the discussion and what this patch does. This is the seventh iteration of this patch series, focused on

[edk2-devel] [PATCH v7 4/5] ArmVirtPkg: Add RngLib based on TimerLib for CryptoPkg

2020-08-13 Thread Matthew Carlson
From: Matthew Carlson Updates the DSC for the ArmVirtPkg platform to add a RngLib that uses the TimerLib. This is due to a later change that adds TimerLib as a dependency for OpenSSL. The TimerLib based RngLib mimics the behavior of OpenSSL previously and it is recommended to switch to a better

[edk2-devel] [PATCH v7 3/5] OvmfPkg: Add RngLib based on TimerLib for Crypto

2020-08-13 Thread Matthew Carlson
From: Matthew Carlson Updates the DSC's for Ovmf based platforms to add a RngLib that uses the TimerLib. This is due to a later change that adds TimerLib as a dependency for OpenSSL. The TimerLib based RngLib mimics the behavior of OpenSSL previously and it is recommended to switch to a b

[edk2-devel] [PATCH v7 5/5] CryptoPkg: OpensslLib: Use RngLib to generate entropy in rand_pool

2020-08-13 Thread Matthew Carlson
From: Matthew Carlson Ref: https://github.com/tianocore/edk2/pull/845 Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 Changes OpenSSL to no longer depend on TimerLib and instead use RngLib. This allows platforms to decide for themsevles what sort of entropy source they provide to

[edk2-devel] [PATCH v7 1/5] MdePkg: TimerRngLib: Added RngLib that uses TimerLib

2020-08-13 Thread Matthew Carlson
From: Matthew Carlson Added a new RngLib that provides random numbers from the TimerLib using the performance counter. This is meant to be used for OpenSSL to replicate past behavior. This should not be used in production as a real source of entropy. Ref: https://github.com/tianocore/edk2/pull

Re: [edk2-devel] [PATCH v6 0/5] Use RngLib instead of TimerLib for OpensslLib

2020-08-13 Thread Matthew Carlson
I'll file a new bugzilla. https://bugzilla.tianocore.org/show_bug.cgi?id=2897 -Matthew Carlson On Thu, Aug 13, 2020 at 8:15 AM Yao, Jiewen wrote: > Thanks Matthew. > > I am OK, if you want to address the RDSEED in follow-up patch series. > > Would you please file a new Bug

Re: [edk2-devel] [PATCH v6 2/5] MdePkg: BaseRngLibDxe: Add RngLib that uses RngDxe

2020-08-13 Thread Matthew Carlson
e previous ones fail? I kept in the check for NULL since any inputs should be sanitized regardless of where they're coming from. I'm open to adding an assert there as well to help debugability. -Matthew Carlson On Thu, Aug 13, 2020 at 5:19 AM Ard Biesheuvel wrote: > On 8/13/20

Re: [edk2-devel] [PATCH v6 1/5] MdePkg: TimerRngLib: Added RngLib that uses TimerLib

2020-08-13 Thread Matthew Carlson
a few times. Copyright (c) Microsoft Corporation is the preferred way for the Microsoft copyright -Matthew Carlson On Thu, Aug 13, 2020 at 5:09 AM Ard Biesheuvel wrote: > On 8/13/20 12:43 AM, matthewfcarl...@gmail.com wrote: > > From: Matthew Carlson > > > > Added

[edk2-devel] [PATCH v6 3/5] OvmfPkg: Add RngLib based on TimerLib for Crypto

2020-08-12 Thread Matthew Carlson
From: Matthew Carlson Updates the DSC's for Ovmf based platforms to add a RngLib that uses the TimerLib. This is due to a later change that adds TimerLib as a dependency for OpenSSL. The TimerLib based RngLib mimics the behavior of OpenSSL previously and it is recommended to switch to a b

[edk2-devel] [PATCH v6 2/5] MdePkg: BaseRngLibDxe: Add RngLib that uses RngDxe

2020-08-12 Thread Matthew Carlson
From: Matthew Carlson This adds a RngLib that uses the RngProtocol to provide randomness. This means that the RngLib is meant to be used with DXE_DRIVERS. Ref: https://github.com/tianocore/edk2/pull/845 Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 Cc: Ard Biesheuvel Cc: Michael D

[edk2-devel] [PATCH v6 5/5] CryptoPkg: OpensslLib: Use RngLib to generate entropy in rand_pool

2020-08-12 Thread Matthew Carlson
From: Matthew Carlson Ref: https://github.com/tianocore/edk2/pull/845 Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 Changes OpenSSL to no longer depend on TimerLib and instead use RngLib. This allows platforms to decide for themsevles what sort of entropy source they provide to

[edk2-devel] [PATCH v6 1/5] MdePkg: TimerRngLib: Added RngLib that uses TimerLib

2020-08-12 Thread Matthew Carlson
From: Matthew Carlson Added a new RngLib that provides random numbers from the TimerLib using the performance counter. This is meant to be used for OpenSSL to replicate past behavior. This should not be used in production as a real source of entropy. Ref: https://github.com/tianocore/edk2/pull

[edk2-devel] [PATCH v6 4/5] ArmVirtPkg: Add RngLib based on TimerLib for CryptoPkg

2020-08-12 Thread Matthew Carlson
From: Matthew Carlson Updates the DSC for the ArmVirtPkg platform to add a RngLib that uses the TimerLib. This is due to a later change that adds TimerLib as a dependency for OpenSSL. The TimerLib based RngLib mimics the behavior of OpenSSL previously and it is recommended to switch to a better

[edk2-devel] [PATCH v6 0/5] Use RngLib instead of TimerLib for OpensslLib

2020-08-12 Thread Matthew Carlson
From: Matthew Carlson Hello all, This patch contains a fix for Bugzilla 1871. There's been a good bit of community discussion around the topic, so below follows a general overview of the discussion and what this patch does. Back in Devel message#40590 (https://edk2.groups.io/g/devel/me

Re: [edk2-devel] [PATCH v5 0/5] Use RngLib instead of TimerLib for OpensslLib

2020-08-12 Thread Matthew Carlson via groups.io
Will do. -- - Matthew Carlson -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64123): https://edk2.groups.io/g/devel/message/64123 Mute This Topic: https://groups.io/mt/76140302/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe

Re: [edk2-devel] [PATCH v5 4/5] ArmVirtPkg: Add RngLib based on TimerLib for CryptoPkg

2020-08-12 Thread Matthew Carlson via groups.io
You are correct, I'll fix it in v6 -- - Matthew Carlson -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64122): https://edk2.groups.io/g/devel/message/64122 Mute This Topic: https://groups.io/mt/76140306/21656 Group Owner: dev

Re: [edk2-devel] [PATCH v5 3/5] OvmfPkg: Add RngLib based on TimerLib for Crypto

2020-08-12 Thread Matthew Carlson via groups.io
I'll fix this for v6. Good spot. -- - Matthew Carlson -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64121): https://edk2.groups.io/g/devel/message/64121 Mute This Topic: https://groups.io/mt/76140305/21656 Group Owner: devel+ow...

Re: [edk2-devel] [PATCH v4 3/5] OvmfPkg: Add RngLib based on TimerLib for Crypto

2020-08-11 Thread Matthew Carlson via groups.io
-maintainers ) Is there a better way to get all the CC's from all the patches other than just copy and pasting them all? Perhaps the GetMaintainers.py where you specify multiple commits? Specifying a range didn't produce the desired behavior. -- - Matthew Carlson -=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v4 0/5] Use RngLib instead of TimerLib for OpensslLib

2020-08-11 Thread Matthew Carlson via groups.io
Thanks Guomin! I sent out a version 5 of this series. -- - Matthew Carlson -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64040): https://edk2.groups.io/g/devel/message/64040 Mute This Topic: https://groups.io/mt/76119011/21656 Group

[edk2-devel] [PATCH v5 1/5] MdePkg: TimerRngLib: Added RngLib that uses TimerLib

2020-08-11 Thread Matthew Carlson
From: Matthew Carlson Added a new RngLib that provides random numbers from the TimerLib using the performance counter. This is meant to be used for OpenSSL to replicate past behavior. This should not be used in production as a real source of entropy. Ref: https://github.com/tianocore/edk2/pull

[edk2-devel] [PATCH v5 4/5] ArmVirtPkg: Add RngLib based on TimerLib for CryptoPkg

2020-08-11 Thread Matthew Carlson
From: Matthew Carlson Updates the DSC for the ArmVirtPkg platform to add a RngLib that uses the TimerLib. This is due to a later change that adds TimerLib as a dependency for OpenSSL. The TimerLib based RngLib mimics the behavior of OpenSSL previously and it is recommended to switch to a better

[edk2-devel] [PATCH v5 3/5] OvmfPkg: Add RngLib based on TimerLib for Crypto

2020-08-11 Thread Matthew Carlson
From: Matthew Carlson Updates the DSC's for Ovmf based platforms to add a RngLib that uses the TimerLib. This is due to a later change that adds TimerLib as a dependency for OpenSSL. The TimerLib based RngLib mimics the behavior of OpenSSL previously and it is recommended to switch to a b

[edk2-devel] [PATCH v5 5/5] CryptoPkg: OpensslLib: Use RngLib to generate entropy in rand_pool

2020-08-11 Thread Matthew Carlson
From: Matthew Carlson Ref: https://github.com/tianocore/edk2/pull/845 Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 Changes OpenSSL to no longer depend on TimerLib and instead use RngLib. This allows platforms to decide for themsevles what sort of entropy source they provide to

[edk2-devel] [PATCH v5 2/5] MdePkg: BaseRngLibDxe: Add RngLib that uses RngDxe

2020-08-11 Thread Matthew Carlson
From: Matthew Carlson This adds a RngLib that uses the RngProtocol to provide randomness. This means that the RngLib is meant to be used with DXE_DRIVERS. Ref: https://github.com/tianocore/edk2/pull/845 Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 Cc: Michael D Kinney Cc: Liming

[edk2-devel] [PATCH v5 0/5] Use RngLib instead of TimerLib for OpensslLib

2020-08-11 Thread Matthew Carlson
From: Matthew Carlson Hello all, This patch contains a fix for Bugzilla 1871. There's been a good bit of community discussion around the topic, so below follows a general overview of the discussion and what this patch does. Back in Devel message#40590 (https://edk2.groups.io/g/devel/me

[edk2-devel] [PATCH v4 3/5] OvmfPkg: Add RngLib based on TimerLib for Crypto

2020-08-10 Thread Matthew Carlson
From: Matthew Carlson Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Anthony Perard Cc: Julien Grall Signed-off-by: Matthew Carlson --- OvmfPkg/OvmfPkgIa32.dsc| 1 + OvmfPkg/OvmfPkgIa32X64.dsc | 1 + OvmfPkg/OvmfPkgX64.dsc | 1 + OvmfPkg/OvmfXen.dsc| 1 + 4

[edk2-devel] [PATCH v4 5/5] CryptoPkg: OpensslLib: Use RngLib to generate entropy in rand_pool

2020-08-10 Thread Matthew Carlson
From: Matthew Carlson Changes OpenSSL to no longer depend on TimerLib and instead use RngLib. This allows platforms to decide for themsevles what sort of entropy source they provide to OpenSSL and TlsLib. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Signed-off-by: Matthew Carlson

[edk2-devel] [PATCH v4 4/5] ArmVirtPkg: Add RngLib based on TimerLib for CryptoPkg

2020-08-10 Thread Matthew Carlson
From: Matthew Carlson Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Matthew Carlson --- ArmVirtPkg/ArmVirt.dsc.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc index cf44fc73890b..ddfcd0cf9eee 100644 --- a

[edk2-devel] [PATCH v4 2/5] MdePkg: BaseRngLibDxe: Add RngLib that uses RngDxe

2020-08-10 Thread Matthew Carlson
From: Matthew Carlson Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Matthew Carlson --- MdePkg/Library/BaseRngLibDxe/RngDxeLib.c | 200 MdePkg/Library/BaseRngLibDxe/BaseRngLibDxe.inf | 38 MdePkg/MdePkg.dsc

[edk2-devel] [PATCH v4 1/5] MdePkg: TimerRngLib: Added RngLib that uses TimerLib

2020-08-10 Thread Matthew Carlson
From: Matthew Carlson Added a new RngLib that provides random numbers from the TimerLib using the performance counter. This is meant to be used for OpenSSL to replicate past behavior. This should not be used in production as a real source of entropy. Cc: Michael D Kinney Cc: Liming Gao Cc

[edk2-devel] [PATCH v4 0/5] Use RngLib instead of TimerLib for OpensslLib

2020-08-10 Thread Matthew Carlson
From: Matthew Carlson Ref: https://github.com/tianocore/edk2/pull/845 Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 Matthew Carlson (5): MdePkg: TimerRngLib: Added RngLib that uses TimerLib MdePkg: BaseRngLibDxe: Add RngLib that uses RngDxe OvmfPkg: Add RngLib based on TimerLib

Re: [edk2-devel] [Patch v2 0/2] Use RngLib instead of TimerLib for OpensslLib

2020-07-31 Thread Matthew Carlson via groups.io
I included a null lib and I was including the wrong version of Rng anyway. I think that would make sense to split them into two different DSC files. Typo fixed, good spot! -- - Matthew Carlson -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply

[edk2-devel] [PATCH v3 1/3] CryptoPkg: OpensslLib: Use RngLib to generate entropy in rand_pool

2020-07-31 Thread Matthew Carlson
From: Matthew Carlson Changes OpenSSL to no longer depend on TimerLib and instead use RngLib. This allows platforms to decide for themsevles what sort of entropy source they provide to OpenSSL and TlsLib. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Signed-off-by: Matthew Carlson

[edk2-devel] [PATCH v3 3/3] MdePkg: BaseRngLibDxe: Add RngLib that uses RngDxe

2020-07-31 Thread Matthew Carlson
From: Matthew Carlson Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Matthew Carlson --- MdePkg/Library/BaseRngLibDxe/RngDxeLib.c | 216 MdePkg/Library/BaseRngLibDxe/BaseRngLibDxe.inf | 38 MdePkg/MdePkg.dsc

[edk2-devel] [PATCH v3 0/3] Use RngLib instead of TimerLib for OpensslLib

2020-07-31 Thread Matthew Carlson
From: Matthew Carlson Fixes Bugzilla#1871 https://github.com/tianocore/edk2/pull/845 Matthew Carlson (3): CryptoPkg: OpensslLib: Use RngLib to generate entropy in rand_pool MdePkg: TimerRngLib: Added RngLib that uses TimerLib MdePkg: BaseRngLibDxe: Add RngLib that uses RngDxe CryptoPkg

[edk2-devel] [PATCH v3 2/3] MdePkg: TimerRngLib: Added RngLib that uses TimerLib

2020-07-31 Thread Matthew Carlson
From: Matthew Carlson Added a new RngLib that provides random numbers from the TimerLib using the performance counter. This is meant to be used for OpenSSL to replicate past behavior. This should not be used in production as a real source of entropy. Cc: Michael D Kinney Cc: Liming Gao Cc

Re: [edk2-devel] [Patch v2 0/2] Use RngLib instead of TimerLib for OpensslLib

2020-07-31 Thread Matthew Carlson via groups.io
[in]   LengthSize of the buffer, in bytes,  to fill with. @param [out]  RandBufferPointer to the buffer to store the random result. @retval TrueRandom bytes generation succeeded. @retval False   Failed to request random bytes. -- - Matthew Carlson -=-=-=-=-=-=-=-=-=-

[edk2-devel] [Patch v2 2/2] MdePkg: TimerRngLib: Added RngLib that uses TimerLib

2020-07-30 Thread Matthew Carlson
From: Matthew Carlson Added a new RngLib that provides random numbers from the TimerLib using the performance counter. This is meant to be used for OpenSSL to replicate past behavior. This should not be used in production as a real source of entropy. Cc: Michael D Kinney Cc: Liming Gao Cc

[edk2-devel] [Patch v2 0/2] Use RngLib instead of TimerLib for OpensslLib

2020-07-30 Thread Matthew Carlson
From: Matthew Carlson This fixes bugzilla 1871. See PR here: https://github.com/tianocore/edk2/pull/831 Matthew Carlson (2): CryptoPkg: OpensslLib: Use RngLib to generate entropy in rand_pool MdePkg: TimerRngLib: Added RngLib that uses TimerLib CryptoPkg/Library/OpensslLib/rand_pool.c

[edk2-devel] [Patch v2 1/2] CryptoPkg: OpensslLib: Use RngLib to generate entropy in rand_pool

2020-07-30 Thread Matthew Carlson
From: Matthew Carlson Changes OpenSSL to no longer depend on TimerLib and instead use RngLib. This allows platforms to decide for themsevles what sort of entropy source they provide to OpenSSL and TlsLib. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Signed-off-by: Matthew Carlson

[edk2-devel] [PATCH v1 0/2] Use RngLib instead of TimerLib for OpensslLib

2020-07-27 Thread Matthew Carlson
From: Matthew Carlson This fixes bugzilla 1871. Matthew Carlson (2): CryptoPkg: OpensslLib: Use RngLib to generate entropy in rand_pool MdePkg: TimerRngLib: Added RngLib that uses TimerLib CryptoPkg/Library/OpensslLib/rand_pool.c | 200 ++-- CryptoPkg/Library

[edk2-devel] [PATCH v1 1/2] CryptoPkg: OpensslLib: Use RngLib to generate entropy in rand_pool

2020-07-27 Thread Matthew Carlson
From: Matthew Carlson Changes OpenSSL to no longer depend on TimerLib and instead use RngLib. This allows platforms to decide for themsevles what sort of entropy source they provide to OpenSSL and TlsLib. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Signed-off-by: Matthew Carlson

[edk2-devel] [PATCH v1 2/2] MdePkg: TimerRngLib: Added RngLib that uses TimerLib

2020-07-27 Thread Matthew Carlson
From: Matthew Carlson Added a new RngLib that provides random numbers from the TimerLib using the performance counter. This is meant to be used for OpenSSL to replicate past behavior. This should not be used in production as a real source of entropy. Cc: Michael D Kinney Cc: Liming Gao Cc

Re: [edk2-devel] [PATCH v3 2/3] CryptoPkg: BaseCryptLib: Add unit tests (Host and Shell based)

2020-07-15 Thread Matthew Carlson
#x27;ll do a v5 and add it in. -Matthew Carlson On Wed, Jul 15, 2020 at 12:03 PM Kinney, Michael D < michael.d.kin...@intel.com> wrote: > Matt, > > > > For (4) and (5) I think I see the issue. Host based unit tests always > link against the standard C lib for the host OS

[edk2-devel] [PATCH v4 0/3] Add Unit Tests for BaseCryptLib to CryptoPkg

2020-07-15 Thread Matthew Carlson
From: Matthew Carlson This turns on Host Based Unit Tests for CryptoPkg, adds the unit test itself, and adds a POSIX BaseTimerLib for unit tests. Matthew Carlson (3): UnitTestFrameworkPkg : BaseTimerLibPosix: Adds a host-based timer Lib CryptoPkg: BaseCryptLib: Add unit tests (Host and

[edk2-devel] [PATCH v4 3/3] AzurePipelines : Pr Gate: Turn on HBUT for CryptoPkg

2020-07-15 Thread Matthew Carlson
From: Matthew Carlson Turns on Host Based Unit Tests for CryptoPkg by enabling the target NOOPT in the CI pipeline. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Reviewed-by: Michael D Kinney Signed-off-by: Matthew Carlson --- .azurepipelines/templates/pr-gate

[edk2-devel] [PATCH v4 1/3] UnitTestFrameworkPkg : BaseTimerLibPosix: Adds a host-based timer Lib

2020-07-15 Thread Matthew Carlson
From: Matthew Carlson This adds a host based BaseTimerLib that won't assert. Cc: Michael D Kinney Cc: Sean Brogan Cc: Bret Barkelew Reviewed-by: Michael D Kinney Signed-off-by: Matthew Carlson --- UnitTestFrameworkPkg/Library/Posix/BaseTimerLibPosix/TimerLibPosix.c |

Re: [edk2-devel] [PATCH v3 2/3] CryptoPkg: BaseCryptLib: Add unit tests (Host and Shell based)

2020-07-15 Thread Matthew Carlson
are a few functions that since we're building no std mode of OpenSSL we still need to provide. 6. That would be my guess- this is largely based on the edk2-staging HBFA branch and I've had to reverse engineer some of the steps for generating the test data. I fixed the instructions. -Matthew

Re: [edk2-devel] [PATCH v1 1/3] UnitTestFrameworkPkg : BaseTimerLib: Adds a host-based timer Lib

2020-07-09 Thread Matthew Carlson via groups.io
I sent out a new patch series. Not sure, it might be waiting in the -- - Matthew Carlson -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62316): https://edk2.groups.io/g/devel/message/62316 Mute This Topic: https://groups.io/mt/75379678

Re: [edk2-devel] [PATCH v1 1/3] UnitTestFrameworkPkg : BaseTimerLib: Adds a host-based timer Lib

2020-07-08 Thread Matthew Carlson via groups.io
Great point. I'll fix this. -- - Matthew Carlson -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62257): https://edk2.groups.io/g/devel/message/62257 Mute This Topic: https://groups.io/mt/75379678/21656 Group Owner: devel+ow...

Re: [edk2-devel] Creating a edk2-pytool-base repo under tianocore

2020-06-26 Thread Matthew Carlson via groups.io
Thanks Mike! -- - Matthew Carlson -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61756): https://edk2.groups.io/g/devel/message/61756 Mute This Topic: https://groups.io/mt/75109251/21656 Group Owner: devel+ow...@edk2.groups.io

[edk2-devel] Creating a edk2-pytool-base repo under tianocore

2020-06-25 Thread Matthew Carlson via groups.io
prefer it to be called edk2-pytool-base or edk2-basetools This will help us start the next stage. -- - Matthew Carlson -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61731): https://edk2.groups.io/g/devel/message/61731 Mute This To

  1   2   >