Re: [edk2-devel] Expansion of ARCH in .dsc files

2025-01-07 Thread Joey Vagedes via groups.io
Leif, For your awareness, Section 3.4 of the INF specification states that architectural modifiers for the [Defines] section tag are not permitted. So that you can Ctrl+F and to find the exact language, here is a quote: "architectural modifiers for the [Defines] section tag are not permitted"

Re: [edk2-devel] Adding AArch64 support to the mu_nasm package (nasm_ext_dep.yaml)

2024-06-24 Thread Joey Vagedes via groups.io
Hi Rebecca, Switching the external dependency to the below should resolve your issue: "source": "https://pkgs.dev.azure.com/projectmu/mu/_packaging/Basetools-Binary/nuget/v3/index.json"; "version": "20015.5.0" Thanks, Joey -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sen

Re: [edk2-devel] [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3

2024-05-17 Thread Joey Vagedes via groups.io
Reviewed-by: Joey Vagedes -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119060): https://edk2.groups.io/g/devel/message/119060 Mute This Topic: https://groups.io/mt/106161774/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe

Re: [edk2-devel] [PATCH v1 1/1] Update to CodeQL 2.16.1

2024-04-24 Thread Joey Vagedes via groups.io
CodeQL CLI binary. > > For more information on release details see: > > https://github.com/github/codeql-cli-binaries/releases > > For changes between the previous version (2.14.5) and 2.16.1 see: > > https://github.com/github/codeql-cli-binaries/compare/v2.14.5...v2.16.1

Re: [edk2-devel] [PATCH v2 7/9] .pytool/CISettings.py: add libspdm submodule.

2024-04-09 Thread Joey Vagedes via groups.io
Reviewed-by: joey.vage...@gmail.com -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117546): https://edk2.groups.io/g/devel/message/117546 Mute This Topic: https://groups.io/mt/105394121/21656 Group Owner: devel+ow...@edk2.groups.io Unsubs

Re: [edk2-devel] [PATCH 7/9] .pytool/CISettings.py: add libspdm submodule.

2024-04-03 Thread Joey Vagedes via groups.io
Reviewed-By: joey.vage...@gmail.com -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117377): https://edk2.groups.io/g/devel/message/117377 Mute This Topic: https://groups.io/mt/105281054/21656 Group Owner: devel+ow...@edk2.groups.io Unsubs

[edk2-devel] [PATCH v1 1/1] BaseTools: InfBuildData: Fix Private value retrieval

2024-03-13 Thread Joey Vagedes via groups.io
instance of the module is generated outside the package, causing the retrieval of private values to fail as the check to access private values is done by verifying the module to build, is inside the package. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4730 Signed-off-by: Joey Vagedes Cc: R

Re: [edk2-devel] [PATCH v3 0/6] UefiCpuPkg/MpInitLib: Add support for multiple MP_HAND_OFF HOBs

2024-02-26 Thread Joey Vagedes via groups.io
that are frozen, which is why it appears it's just a backup. I'll continue to monitor. Thanks, Joey -Original Message- From: Laszlo Ersek Sent: Monday, February 26, 2024 7:08 AM To: devel@edk2.groups.io; kra...@redhat.com Cc: Ni, Ray ; Rahul Kumar ; Oliver Steffen ; Kinn

Re: [edk2-devel] [PATCH v1 1/1] .pytool/Plugin: UncrustifyCheck: use stat instead of os.stat

2024-01-23 Thread Joey Vagedes via groups.io
Thanks Mike, I've prepared a Pull request with your Reviewed-By Tag. Feel free to add the push tag at your convenience. I appreciate your time! .pytool/Plugin: UncrustifyCheck: use stat instead of os.stat by Javagedes · Pull Request #5287 · tianocore/edk2 (github.com) ( https://github.com/tian

[edk2-devel] [PATCH v1 1/1] .pytool/Plugin: UncrustifyCheck: use stat instead of os.stat

2024-01-22 Thread Joey Vagedes via groups.io
The UncrustifyCheck plugin passes os.stat.S_IWRITE to os.chmod, when attempting to change file permissions. os.stat.S_IWRITE does not exist as os.stat is a function. The correct value is stat.S_IWRITE. Signed-off-by: Joey Vagedes Cc: Liming Gao Cc: Michael D Kinney Cc: Sean Brogan

[edk2-devel] [PATCH v1 0/1] UncrustifyCheck: use stat instead of os.stat

2024-01-22 Thread Joey Vagedes via groups.io
: Liming Gao Cc: Michael D Kinney Cc: Sean Brogan Joey Vagedes (1): .pytool/Plugin: UncrustifyCheck: use stat instead of os.stat .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.40.1.vfs.0.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io

Re: [edk2-devel] [PATCH v1 1/1] pip-requirements.txt: Update to latest

2024-01-11 Thread Joey Vagedes via groups.io
Thanks Mike, I've updated the PR / branch with the reviewed-by tag. It is ready to be merged at your convenience. pip-requirements.txt: Update to latest by Javagedes · Pull Request #5256 · tianocore/edk2 (github.com) ( https://github.com/tianocore/edk2/pull/5256 ) Thanks, Joey -=-=-=-=-=-=-=

Re: [edk2-devel] [PATCH] .pytool/Readme.md: Update matrix for DynamicTablesPkg

2024-01-11 Thread Joey Vagedes via groups.io
Hello. Reviewed-by: Joey Vagedes This has been merged via PR 5257 ( https://github.com/tianocore/edk2/pull/5257 ) , commit SHA 58355ec1926563efc954821a2851365182a4ebd4 Thanks, Joey -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online

[edk2-devel] [PATCH v1 1/1] pip-requirements.txt: Update to latest

2024-01-11 Thread Joey Vagedes via groups.io
From: "Joey Vagedes (from Dev Box)" Updates edk2-pytool-extensions, edk2-pytool-library, and regex to their latest respective releases. Signed-off-by: Joey Vagedes Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney --- pip-requirements.txt | 6 +++--- 1 file changed, 3 insert

Re: [edk2-devel] Updates to .mailmap needed for Jeff Brasen, Jake Garver, Joey Vagades and Michael Roth?

2024-01-08 Thread Joey Vagedes via groups.io
bringing this to my attention. Joey -Original Message- From: Rebecca Cran Sent: Thursday, January 4, 2024 4:06 PM To: devel@edk2.groups.io; Jeff Brasen ; j...@nvidia.com; michael.r...@amd.com; Joey Vagedes Subject: [EXTERNAL] Updates to .mailmap needed for Jeff Brasen, Jake Garver

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Fix raw strings containing valid escape characters

2024-01-08 Thread Joey Vagedes via groups.io
lid escape sequences, as is suggested by the > re (regex) module in python. > > Best Regards, > Yanbo Huang > > -Original Message- > From: gaoliming > Sent: Monday, January 8, 2024 9:25 PM > To: devel@edk2.groups.io; Chen, Christine ; 'Joey > Vagedes' >

Re: [edk2-devel] [PATCH] BaseTools/Workspace: Build fail if structure PCD is referred

2023-12-28 Thread Joey Vagedes via groups.io
I found two other files with similar issues. Here is my patch series to resolve all. [PATCH v1 1/1] BaseTools: Fix raw strings containing valid escape characters (groups.io) ( https://edk2.groups.io/g/devel/message/112986 ) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent

[edk2-devel] [PATCH v1 1/1] BaseTools: Fix raw strings containing valid escape characters

2023-12-28 Thread Joey Vagedes via groups.io
Fixes raw regex strings that contain valid (and purposeful) escape characters as they are being treated as individual characters rather than the single escaped character they represent (i.e. '\t' is being treated as a '\' and a 't' rather than a single tab character)

[edk2-devel] [PATCH v1 0/1] Fix raw strings containing valid escape characters

2023-12-28 Thread Joey Vagedes via groups.io
e the issue. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Joey Vagedes (1): BaseTools: Fix raw strings containing valid escape characters BaseTools/Source/Python/AutoGen/GenMake.py| 2 +- BaseTools/Source/Python/Common/Misc.py| 2 +- BaseTools/Source/P

Re: [edk2-devel] Some unpredictable behavior while parsing the FDF file.

2023-12-28 Thread Joey Vagedes via groups.io
Hello. It depends on the actual path that you are trying to include. This is the requirements for an include statement (coming directly from the FDF specification): > > > > The tools look for relative to the directory the FDF file > resides. If the file is not found, and the directory conta

Re: [edk2-devel] [PATCH] BaseTools/Workspace: Build fail if structure PCD is referred

2023-12-28 Thread Joey Vagedes via groups.io
Hello, This is in regard to my recent patch (see commit here: BaseTools: Resolve regex syntax warnings · tianocore/edk2@9f0061a (github.com) ( https://github.com/tianocore/edk2/commit/9f0061a03b61d282fbc0ba5be22155d06a5e64a1 ) ) that was resolving the newly introduced syntax warnings (that will

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Resolve regex syntax warnings

2023-12-13 Thread Joey Vagedes via groups.io
on old python version, such as Python 3.9? > > Thanks > Liming > > -----邮件原件- > > 发件人: Joey Vagedes > > 发送时间: 2023年12月7日 4:27 > > 收件人: devel@edk2.groups.io > > 抄送: Rebecca Cran ; Liming Gao > > ; Bob Feng ; Yuwei Chen > > > > 主题: [PATCH v1

[edk2-devel] [PATCH v1 0/1] Resolve regex syntax warnings

2023-12-06 Thread Joey Vagedes via groups.io
adds the r prefix to any regex pattern that uses an invalid escape sequence. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Signed-off-by: Joey Vagedes Joey Vagedes (1): BaseTools: Resolve regex syntax warnings BaseTools/Source/Python/AmlToC/AmlToC.py | 2

[edk2-devel] [PATCH v1 1/1] BaseTools: Resolve regex syntax warnings

2023-12-06 Thread Joey Vagedes via groups.io
Switches regex patterns to raw text to resolve python 3.12 syntax warnings in regards to invalid escape sequences, as is suggested by the re (regex) module in python. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Signed-off-by: Joey Vagedes --- BaseTools/Source/Python/AmlToC

Re: [edk2-devel] [PATCH v1 1/1] .github/workflows/codeql.yml: Add emacs output

2023-11-29 Thread Joey Vagedes via groups.io
Reviewed-by: Joey Vagedes On Wed, Nov 29, 2023 at 9:01 AM wrote: > From: Michael Kubacki > > Updates the workflow to also output files that can be loaded in emacs > to show CodeQL issues (in addition to the existing SARIF output for > standard SARIF viewers). > > The e

Re: [edk2-devel] [PATCH v3 0/2] Automatically set NXCOMPAT bit if requirements are met

2023-11-06 Thread Joey Vagedes via groups.io
Thank you, Rebecca! -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110770): https://edk2.groups.io/g/devel/message/110770 Mute This Topic: https://groups.io/mt/100122559/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://e

Re: [edk2-devel] [PATCH v1 0/1] Edk2ToolsBuild.py: Clarify make error

2023-11-06 Thread Joey Vagedes via groups.io
mber 6, 2023 1:54 PM To: devel@edk2.groups.io; Joey Vagedes Cc: Kinney, Michael D Subject: [EXTERNAL] RE: [edk2-devel] [PATCH v1 0/1] Edk2ToolsBuild.py: Clarify make error What is the random data at the end of your path emails??? Thanks, Mike > -Original Message- > From: devel@ed

[edk2-devel] [PATCH v1 1/1] BaseTools: Edk2ToolsBuild.py: Clarify make error

2023-11-06 Thread Joey Vagedes via groups.io
Clarify to users that they should review the build log when make (POSIX-like system) or nmake (Windows) fails to compile basetools. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Signed-off-by: Joey Vagedes --- BaseTools/Edk2ToolsBuild.py | 8 ++-- 1 file changed, 6

[edk2-devel] [PATCH v2 0/1] Edk2ToolsBuild.py: Clarify make error

2023-11-06 Thread Joey Vagedes via groups.io
user to review the build log, and where to find it. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Joey Vagedes (1): BaseTools: Edk2ToolsBuild.py: Clarify make error BaseTools/Edk2ToolsBuild.py | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) -- 2.34.1

[edk2-devel] [PATCH v1 1/1] BaseTools: Edk2ToolsBuild.py: Clarify make error

2023-11-06 Thread Joey Vagedes via groups.io
Clarify to users that they should review the build log when make (POSIX-like system) or nmake (Windows) fails to compile basetools. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Signed-off-by: Joey Vagedes --- BaseTools/Source/C/Common/BinderFuncs.c | 2 +- BaseTools

[edk2-devel] [PATCH v1 0/1] Edk2ToolsBuild.py: Clarify make error

2023-11-06 Thread Joey Vagedes via groups.io
user to review the build log, and where to find it. Joey Vagedes (1): BaseTools: Edk2ToolsBuild.py: Clarify make error BaseTools/Source/C/Common/BinderFuncs.c | 2 +- BaseTools/Edk2ToolsBuild.py | 8 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) -- 2.34.1

[edk2-devel] [PATCH v1 1/1] BaseTools: Resolve invalid escape sequence

2023-10-31 Thread Joey Vagedes via groups.io
practice to always use raw strings for regex strings. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Signed-off-by: Joey Vagedes --- BaseTools/Scripts/BinToPcd.py | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/BaseTools/Scripts/BinToPcd.py b

Re: [edk2-devel] [PATCH v1 0/2] Upgrade edk2-pytools to latest

2023-10-27 Thread Joey Vagedes via groups.io
Sent: Friday, October 27, 2023 10:32 AM To: devel@edk2.groups.io; Joey Vagedes Cc: Sean Brogan ; Kinney, Michael D ; Liming Gao Subject: Re: [edk2-devel] [PATCH v1 0/2] Upgrade edk2-pytools to latest Series: Reviewed-by: Michael Kubacki On 10/27/2023 11:15 AM, Joey Vagedes via groups.io

[edk2-devel] [PATCH v2 12/12] IntelFsp2WrapperPkg: CI: Add PrEval entry

2023-10-23 Thread Joey Vagedes via groups.io
From: Joey Vagedes Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as de

[edk2-devel] [PATCH v2 10/12] MdePkg: CI: Add PrEval entry

2023-10-23 Thread Joey Vagedes via groups.io
From: Joey Vagedes Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as de

[edk2-devel] [PATCH v2 11/12] MdeModulePkg: CI: Add PrEval entry

2023-10-23 Thread Joey Vagedes via groups.io
From: Joey Vagedes Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as de

[edk2-devel] [PATCH v2 08/12] RedfishPkg: CI: Add PrEval entry

2023-10-23 Thread Joey Vagedes via groups.io
From: Joey Vagedes Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as de

[edk2-devel] [PATCH v2 07/12] IntelFsp2Pkg: CI: Add PrEval entry

2023-10-23 Thread Joey Vagedes via groups.io
From: Joey Vagedes Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as de

[edk2-devel] [PATCH v2 06/12] FmpDevicePkg: CI: Add PrEval entry

2023-10-23 Thread Joey Vagedes via groups.io
From: Joey Vagedes Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as de

[edk2-devel] [PATCH v2 05/12] EmbeddedPkg: CI: Add PrEval entry

2023-10-23 Thread Joey Vagedes via groups.io
From: Joey Vagedes Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as de

[edk2-devel] [PATCH v2 04/12] DynamicTablesPkg: CI: Add PrEval entry

2023-10-23 Thread Joey Vagedes via groups.io
From: Joey Vagedes Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as de

[edk2-devel] [PATCH v2 03/12] CryptoPkg: CI: Add PrEval entry

2023-10-23 Thread Joey Vagedes via groups.io
From: Joey Vagedes Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as de

[edk2-devel] [PATCH v2 00/12] *** Update Edk2-pytools to latest versions ***

2023-10-23 Thread Joey Vagedes via groups.io
o Cc: Michael D Kinney Cc: Chasel Chiu Cc: Nate DeSimone Cc: Duggapu Chinni B Cc: Ray Han Lim Ng Cc: Jian J Wang Cc: Liming Gao Joey Vagedes (12): Edk2: edk2-pytools: Update to latest versions UnitTestFrameworkPkg: CI: Add PrEval entry CryptoPkg: CI: Add PrEval entry DynamicTablesPk

Re: [edk2-devel] [PATCH v1 13/24] StandaloneMmPkg: CI: Add PrEval entry

2023-10-09 Thread Joey Vagedes via groups.io
;s I have reviews on, to get it merged so that we can update edk2-pytools further. You will always be able to add this yourself at a later date if you wish. Thanks, Joey On Mon, Jun 26, 2023 at 2:35 PM Joey Vagedes wrote: > Adds a PrEval entry to the package's ci.yaml file which is use

Re: [edk2-devel] [PATCH v1 07/24] CryptoPkg: CI: Add PrEval entry

2023-10-09 Thread Joey Vagedes via groups.io
> [PATCH v1 13/24] CryptoPkg: CI: Add PrEval entry > > -Original Message- > From: devel@edk2.groups.io On Behalf Of Li, Yi > Sent: Wednesday, August 2, 2023 12:42 PM > To: Joey Vagedes ; devel@edk2.groups.io > Cc: Yao, Jiewen ; Lu, Xiaoyu1 ; > Jiang, Guomin &

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: BinToPcd: Resolve xdrlib deprecation

2023-07-13 Thread Joey Vagedes via groups.io
D < michael.d.kin...@intel.com> wrote: > Thank you for fixing this. > > Reviewed-by: Michael D Kinney > > > -Original Message- > > From: Joey Vagedes > > Sent: Tuesday, June 27, 2023 9:27 AM > > To: devel@edk2.groups.io > > Cc: Reb

[edk2-devel] [PATCH v3 2/2] BaseTools: GenFw: auto-set nxcompat flag

2023-07-13 Thread Joey Vagedes via groups.io
GenFw, --nonxcompat, to ensure the IMAGE_DLLCHARACTERISTICS_NX_COMPAT bit is not set, even if all requirements are met. Updates the manual for GenFw to include the new flag. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Signed-off-by: Joey Vagedes --- BaseTools/Source/C/GenFw

[edk2-devel] [PATCH v3 0/2] Automatically set NXCOMPAT bit if requirements are met

2023-07-13 Thread Joey Vagedes via groups.io
the following requirements are met: 1. It is a 64bit PE 2. The section alignment is evently divisible by 4K 3. No section is both EFI_IMAGE_SCN_MEM_EXECUTE and EFI_IMAGE_SCN_MEM_WRITE Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Joey Vagedes (2): MdePkg: IndustryStandard

[edk2-devel] [PATCH v3 1/2] MdePkg: IndustryStandard: Add DLL Characteristics

2023-07-13 Thread Joey Vagedes via groups.io
: Liming Gao Cc: Zhiguang Liu Signed-off-by: Joey Vagedes Reviewed-by: Michael D Kinney --- MdePkg/Include/IndustryStandard/PeImage.h | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/IndustryStandard/PeImage.h b/MdePkg/Include/IndustryStandard

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: scan Edk2ToolsBuild.py make output

2023-07-10 Thread Joey Vagedes via groups.io
Thanks Rebecca! Let me know if you need anything else from me before you get it merged. I appreciate your time! Joey On Sun, Jul 9, 2023 at 4:18 PM Rebecca Cran wrote: > Sorry for the delay. > > > Reviewed-by: Rebecca Cran > > > On 6/21/23 9:59 AM, Joey Va

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: scan Edk2ToolsBuild.py make output

2023-07-06 Thread Joey Vagedes via groups.io
at 8:59 AM Joey Vagedes wrote: > Adds edk2_logging.scan_compiler_output() to Edk2ToolsBuild.py to catch > some compilation errors and log them as an error. > > Cc: Rebecca Cran > Cc: Liming Gao > Cc: Bob Feng > Cc: Yuwei Chen > Signed-off-by: Joey Vagedes > --- >

Re: [edk2-devel] [PATCH v1 2/2] BaseTools: GenFw: auto-set nxcompat flag

2023-07-06 Thread Joey Vagedes via groups.io
Hi all, Do you have any concerns over the changes I've made to GenFw.c as seen above? Please let me know if you have any questions, concerns, or improvements; I would be happy to help! Thanks, Joey On Fri, Jun 23, 2023 at 8:44 AM Joey Vagedes wrote: > Automatically set the nxcompat

[edk2-devel] [PATCH v2 2/2] BaseTools: GenFw: auto-set nxcompat flag

2023-06-28 Thread Joey Vagedes via groups.io
flag to GenFw, --nonxcompat, to ensure the IMAGE_DLLCHARACTERISTICS_NX_COMPAT bit is not set, even if all requirements are met. Updates the manual for GenFw to include the new flag. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Signed-off-by: Joey Vagedes --- BaseTools/Source/C

[edk2-devel] [PATCH v2 0/2] Automatically set NXCOMPAT bit if requirements are met

2023-06-28 Thread Joey Vagedes via groups.io
requirements are met: 1. It is a 64bit PE 2. The section alignment is evently divisible by 4K 3. No section is both EFI_IMAGE_SCN_MEM_EXECUTE and EFI_IMAGE_SCN_MEM_WRITE Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Rebecca Cran Cc: Bob Feng Cc: Yuwei Chen Joey Vagedes (2

[edk2-devel] [PATCH v2 1/2] MdePkg: IndustryStandard: Add DLL Characteristics

2023-06-28 Thread Joey Vagedes via groups.io
: Liming Gao Cc: Zhiguang Liu Signed-off-by: Joey Vagedes --- MdePkg/Include/IndustryStandard/PeImage.h | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/IndustryStandard/PeImage.h b/MdePkg/Include/IndustryStandard/PeImage.h index 47037049348c

Re: [edk2-devel] [PATCH v1 1/2] MdePkg: IndustryStandard: Add DLL Characteristics

2023-06-27 Thread Joey Vagedes
el.com> wrote: > Hi Joey, > > Was the link to the PE/COFF specs that added these updated in the file > header? > > Also, shouldn't it be DLL_CHARACTERISRICS instead of DLLCHARACTERISRICS? > > Mike > > > -Original Message- > > From: Joey Vagedes

Re: [edk2-devel] [PATCH v1 0/2] Automatically set NXCOMPAT bit if requirements are met

2023-06-27 Thread Joey Vagedes
rs and may not be all encompassing. Thanks, Joey On Fri, Jun 23, 2023 at 9:11 AM Ard Biesheuvel wrote: > On Fri, 23 Jun 2023 at 18:03, Joey Vagedes wrote: > > > > Utilize GenFw to automatically set the NXCOMPAT bit of the DLL > Characteristics > > field of the Optional He

Re: [edk2-devel] [PATCH v1 00/24] Update Edk2-pytools to latest versions

2023-06-27 Thread Joey Vagedes
e dsc if only one DSC is in Package directory? > > Thanks > Liming > > -邮件原件- > > 发件人: Joey Vagedes > > 发送时间: 2023年6月27日 5:34 > > 收件人: devel@edk2.groups.io > > 抄送: Abner Chang ; Alexei Fedorov > > ; Ard Biesheuvel ; > > Ashraf Ali S

[edk2-devel] [PATCH v1 0/1] BaseTools: BinToPcd: Resolve xdrlib deprecation

2023-06-27 Thread Joey Vagedes
Removes the dependency on xdrlib and replaces it with custom logic to pack a per the xdr requirements. Necessary as xdrlib is being deprecated in python 3.13. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Cc: Michael D Kinney Joey Vagedes (1): BaseTools: BinToPcd: Resolve

[edk2-devel] [PATCH v1 1/1] BaseTools: BinToPcd: Resolve xdrlib deprecation

2023-06-27 Thread Joey Vagedes
Removes the dependency on xdrlib and replaces it with custom logic to pack a per the xdr requirements. Necessary as xdrlib is being deprecated in python 3.13. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Cc: Michael D Kinney Signed-off-by: Joey Vagedes --- BaseTools/Scripts

Re: [edk2-devel] [PATCH v1 0/2] Automatically set NXCOMPAT bit if requirements are met

2023-06-26 Thread Joey Vagedes
ore? > > Thanks > Liming > > -邮件原件- > > 发件人: devel@edk2.groups.io 代表 Joey Vagedes > > 发送时间: 2023年6月23日 23:45 > > 收件人: devel@edk2.groups.io > > 抄送: Michael D Kinney ; Liming Gao > > ; Zhiguang Liu ; > > Rebecca Cran ; Bob Feng ; > > Yuwei

[edk2-devel] [PATCH v1 22/24] MdePkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
ml file to determine if the package uses said library instance. If the package does use the library instance, it will be built and tested to ensure the package is not broken from the change. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Joey Vagedes --- MdePkg/MdePkg.c

[edk2-devel] [PATCH v1 23/24] MdeModulePkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
ml file to determine if the package uses said library instance. If the package does use the library instance, it will be built and tested to ensure the package is not broken from the change. Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Joey Vagedes --- MdeModulePkg/MdeModulePkg.ci.yaml | 3 +

[edk2-devel] [PATCH v1 24/24] IntelFsp2WrapperPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
hraf Ali S Cc: Susovan Mohapatra Signed-off-by: Joey Vagedes --- IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml index 45cb5a7d6f32..2d32bc65b

[edk2-devel] [PATCH v1 21/24] NetworkPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
ml file to determine if the package uses said library instance. If the package does use the library instance, it will be built and tested to ensure the package is not broken from the change. Cc: Maciej Rabeda Cc: Siyuan Fu Signed-off-by: Joey Vagedes --- NetworkPkg/NetworkPkg.ci.yaml | 3 +++ 1 fi

[edk2-devel] [PATCH v1 20/24] PcAtChipsetPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
ml file to determine if the package uses said library instance. If the package does use the library instance, it will be built and tested to ensure the package is not broken from the change. Cc: Ray Ni Signed-off-by: Joey Vagedes --- PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 3 +++ 1 file changed, 3

[edk2-devel] [PATCH v1 17/24] SecurityPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
ml file to determine if the package uses said library instance. If the package does use the library instance, it will be built and tested to ensure the package is not broken from the change. Cc: Jiewen Yao Cc: Jian J Wang Signed-off-by: Joey Vagedes --- SecurityPkg/SecurityPkg.ci.yaml | 3 +

[edk2-devel] [PATCH v1 19/24] PrmPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
ml file to determine if the package uses said library instance. If the package does use the library instance, it will be built and tested to ensure the package is not broken from the change. Cc: Michael Kubacki Cc: Nate DeSimone Signed-off-by: Joey Vagedes --- PrmPkg/PrmPkg.ci.yaml | 3 +++ 1 fi

[edk2-devel] [PATCH v1 18/24] RedfishPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
ml file to determine if the package uses said library instance. If the package does use the library instance, it will be built and tested to ensure the package is not broken from the change. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Joey Vagedes --- RedfishPkg/RedfishP

[edk2-devel] [PATCH v1 13/24] CryptoPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
ml file to determine if the package uses said library instance. If the package does use the library instance, it will be built and tested to ensure the package is not broken from the change. Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Ray Ni Signed-off-by: Joey Vagedes --- Stand

[edk2-devel] [PATCH v1 15/24] SignedCapsulePkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
ml file to determine if the package uses said library instance. If the package does use the library instance, it will be built and tested to ensure the package is not broken from the change. Cc: Hao A Wu Signed-off-by: Joey Vagedes --- SignedCapsulePkg/SignedCapsulePkg.ci.yaml | 3 +++ 1 file

[edk2-devel] [PATCH v1 14/24] SourceLevelDebugPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
ml file to determine if the package uses said library instance. If the package does use the library instance, it will be built and tested to ensure the package is not broken from the change. Cc: Hao A Wu Signed-off-by: Joey Vagedes --- SourceLevelDebugPkg/SourceLevelDebugPkg.ci.yaml | 3 +++ 1 fi

[edk2-devel] [PATCH v1 06/24] ArmPlatformPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
ml file to determine if the package uses said library instance. If the package does use the library instance, it will be built and tested to ensure the package is not broken from the change. Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Joey Vagedes --- ArmPlatformPkg/ArmPlatformPkg.ci.yaml

[edk2-devel] [PATCH v1 16/24] ShellPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
ml file to determine if the package uses said library instance. If the package does use the library instance, it will be built and tested to ensure the package is not broken from the change. Cc: Zhichao Gao Signed-off-by: Joey Vagedes --- ShellPkg/ShellPkg.ci.yaml | 3 +++ 1 file changed, 3

[edk2-devel] [PATCH v1 09/24] EmbeddedPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
ml file to determine if the package uses said library instance. If the package does use the library instance, it will be built and tested to ensure the package is not broken from the change. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Abner Chang Cc: Daniel Schaefer Signed-off-by: Jo

[edk2-devel] [PATCH v1 05/24] UefiCpuPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
ml file to determine if the package uses said library instance. If the package does use the library instance, it will be built and tested to ensure the package is not broken from the change. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Joey Vagedes ---

[edk2-devel] [PATCH v1 10/24] FatPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
ml file to determine if the package uses said library instance. If the package does use the library instance, it will be built and tested to ensure the package is not broken from the change. Cc: Ray Ni Signed-off-by: Joey Vagedes --- FatPkg/FatPkg.ci.yaml | 3 +++ 1 file changed, 3 insertions(+)

[edk2-devel] [PATCH v1 11/24] FmpDevicePkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
ml file to determine if the package uses said library instance. If the package does use the library instance, it will be built and tested to ensure the package is not broken from the change. Cc: Liming Gao Cc: Michael D Kinney Cc: Guomin Jiang Cc: Wei6 Xu Signed-off-by: Joey Vagedes --- Fm

[edk2-devel] [PATCH v1 02/24] UnitTestFrameworkPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
ml file to determine if the package uses said library instance. If the package does use the library instance, it will be built and tested to ensure the package is not broken from the change. Cc: Michael D Kinney Cc: Michael Kubacki Cc: Sean Brogan Signed-off-by: Joey Vagedes --- UnitTestFr

[edk2-devel] [PATCH v1 04/24] ArmPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
ml file to determine if the package uses said library instance. If the package does use the library instance, it will be built and tested to ensure the package is not broken from the change. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar Signed-off-by: Joey Vagedes --- ArmPkg/ArmPkg.c

[edk2-devel] [PATCH v1 08/24] DynamicTablesPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
ml file to determine if the package uses said library instance. If the package does use the library instance, it will be built and tested to ensure the package is not broken from the change. Cc: Sami Mujawar Cc: Alexei Fedorov Cc: Pierre Gondois Signed-off-by: Joey Vagedes --- Dynami

[edk2-devel] [PATCH v1 07/24] CryptoPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
ml file to determine if the package uses said library instance. If the package does use the library instance, it will be built and tested to ensure the package is not broken from the change. Cc: Jiewen Yao Cc: Yi Li Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Joey Vagedes --- CryptoPkg/CryptoP

[edk2-devel] [PATCH v1 12/24] IntelFsp2Pkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
Ashraf Ali S Cc: Susovan Mohapatra Signed-off-by: Joey Vagedes --- IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml b/IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml index 95d18cfcde1f..bd6f4cc961b0 100644 --- a/IntelFsp2Pkg/IntelFsp2P

[edk2-devel] [PATCH v1 01/24] Edk2: edk2-pytools: Update to latest versions

2023-06-26 Thread Joey Vagedes
Cc: Liming Gao Signed-off-by: Joey Vagedes --- pip-requirements.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pip-requirements.txt b/pip-requirements.txt index c221576bef3a..ed7e430f1572 100644 --- a/pip-requirements.txt +++ b/pip-requirements.txt @@ -12,8 +12,8

[edk2-devel] [PATCH v1 03/24] UefiPayloadPkg: CI: Add PrEval entry

2023-06-26 Thread Joey Vagedes
ml file to determine if the package uses said library instance. If the package does use the library instance, it will be built and tested to ensure the package is not broken from the change. Cc: Guo Dong Cc: Sean Rhodes Cc: James Lu Signed-off-by: Joey Vagedes --- UefiPayloadPkg/UefiPayloadPkg.c

[edk2-devel] [PATCH v1 00/24] Update Edk2-pytools to latest versions

2023-06-26 Thread Joey Vagedes
Cc: Sean Brogan Cc: Sean Rhodes Cc: Siyuan Fu Cc: Star Zeng Cc: Susovan Mohapatra Cc: Ted Kuo Cc: Wei6 Xu Cc: Xiaoyu Lu Cc: Yi Li Cc: Zhichao Gao Cc: Zhiguang Liu Joey Vagedes (24): Edk2: edk2-pytools: Update to latest versions UnitTestFrameworkPkg: CI: Add PrEval entry UefiPayloadPk

[edk2-devel] [PATCH v1 1/2] MdePkg: IndustryStandard: Add DLL Characteristics

2023-06-23 Thread Joey Vagedes
Add the bit masks for DLL Characteristics, used within the optional header of a PE, to the PeImage.h header file. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Joey Vagedes --- MdePkg/Include/IndustryStandard/PeImage.h | 15 +++ 1 file changed, 15 insertions

[edk2-devel] [PATCH v1 2/2] BaseTools: GenFw: auto-set nxcompat flag

2023-06-23 Thread Joey Vagedes
: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Signed-off-by: Joey Vagedes --- BaseTools/Source/C/GenFw/GenFw.c | 59 1 file changed, 59 insertions(+) diff --git a/BaseTools/Source/C/GenFw/GenFw.c b/BaseTools/Source/C/GenFw/GenFw.c index 0289c8ef8a5c..4581c4233c14 100644 --- a

[edk2-devel] [PATCH v1 0/2] Automatically set NXCOMPAT bit if requirements are met

2023-06-23 Thread Joey Vagedes
Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Rebecca Cran Cc: Bob Feng Cc: Yuwei Chen Joey Vagedes (2): MdePkg: IndustryStandard: Add DLL Characteristics BaseTools: GenFw: auto-set nxcompat flag MdePkg/Include/IndustryStandard/PeImage.h | 15 + BaseTools/Source/C/GenFw

[edk2-devel] [PATCH v1 0/1] Improve Edk2ToolsBuild.py compiler logging

2023-06-21 Thread Joey Vagedes
: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Joey Vagedes (1): BaseTools: scan Edk2ToolsBuild.py make output BaseTools/Edk2ToolsBuild.py | 11 +++ 1 file changed, 11 insertions(+) -- 2.41.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group

[edk2-devel] [PATCH v1 1/1] BaseTools: scan Edk2ToolsBuild.py make output

2023-06-21 Thread Joey Vagedes
Adds edk2_logging.scan_compiler_output() to Edk2ToolsBuild.py to catch some compilation errors and log them as an error. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Signed-off-by: Joey Vagedes --- BaseTools/Edk2ToolsBuild.py | 11 +++ 1 file changed, 11 insertions

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Update WindowsVsToolChain plugin

2023-02-06 Thread Joey Vagedes
to pytools) for edk2 on future PRs until this interface is changed. Thanks, Joey On Fri, Feb 3, 2023 at 7:43 PM Michael Kubacki wrote: > Acked-by: Michael Kubacki > > On 2/1/2023 3:22 PM, Joey Vagedes wrote: > > This patch updates edk2-pytool-library dependency to v0.13.0, w

[edk2-devel] [PATCH v1 0/1] *** Update edk2-pytools ***

2023-02-01 Thread Joey Vagedes
This patch updates edk2-pytool-extensions and edk2-pytool-library to latest. edk2-pytool-library has a breaking change that needed to be addressed in the BaseTools/Plugin/WindowsVsToolChain plugin. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Cc: Michael D Kinney Joey Vagedes (1): BaseTools

[edk2-devel] [PATCH v1 1/1] BaseTools: Update WindowsVsToolChain plugin

2023-02-01 Thread Joey Vagedes
: Joey Vagedes --- BaseTools/Plugin/WindowsVsToolChain/WindowsVsToolChain.py | 16 pip-requirements.txt | 4 ++-- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/BaseTools/Plugin/WindowsVsToolChain/WindowsVsToolChain.py b

[edk2-devel] [PATCH v1 3/3] EmulatorPkg/PlatformCI: Dyn BaseTools Selection

2022-10-17 Thread Joey Vagedes
Signed-off-by: Joey Vagedes --- EmulatorPkg/PlatformCI/PlatformBuild.py | 37 ++-- 1 file changed, 35 insertions(+), 2 deletions(-) diff --git a/EmulatorPkg/PlatformCI/PlatformBuild.py b/EmulatorPkg/PlatformCI/PlatformBuild.py index 6defbf6ef1..d6d37f6053 100644 --- a

[edk2-devel] [PATCH v1 2/3] OvmfPkg/PlatformCI: Dyn BaseTools Selection

2022-10-17 Thread Joey Vagedes
Yao Cc: Jordan Justen Cc: Gerd Hoffmann Signed-off-by: Joey Vagedes --- OvmfPkg/PlatformCI/PlatformBuildLib.py | 37 ++-- 1 file changed, 34 insertions(+), 3 deletions(-) diff --git a/OvmfPkg/PlatformCI/PlatformBuildLib.py b/OvmfPkg/PlatformCI/PlatformBuildLib.py index

[edk2-devel] [PATCH v1 0/3] Dynamic BaseTools Selection

2022-10-17 Thread Joey Vagedes
Lindholm CC: Sami Mujawar CC: Gerd Hoffmann Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Joey Vagedes Joey Vagedes (3): ArmVirtPkg/PlatformCI: Dyn BaseTools Selection OvmfPkg/PlatformCI: Dyn BaseTools Selection EmulatorPkg/PlatformCI: Dyn BaseTools Selection ArmVirtPkg/PlatformCI

[edk2-devel] [PATCH v1 1/3] ArmVirtPkg/PlatformCI: Dyn BaseTools Selection

2022-10-17 Thread Joey Vagedes
Lindholm CC: Sami Mujawar CC: Gerd Hoffmann Cc: Jiewen Yao Cc: Jordan Justen Signed-off-by: Joey Vagedes --- ArmVirtPkg/PlatformCI/PlatformBuild.py | 33 ++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/ArmVirtPkg/PlatformCI/PlatformBuild.py b/ArmVirtPkg