Thank you, Laszlo. I'll make sure to do that moving forward!
Patrick Henz
-Original Message-
From: Laszlo Ersek
Sent: Thursday, November 2, 2023 6:28 AM
To: devel@edk2.groups.io; mike.maslen...@gmail.com; Henz, Patrick
Cc: hao.a...@intel.com; ray...@intel.com
Subject: Re: [edk2-
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4578
The implementation of XhcGetElapsedTicks did not account for
non-zero start and stop values for the performance counter
timer, potentially resulting in an incorrect elapsed tick
count getting returned to the caller. Account for non-zero
start
That’s a great catch, thank you for bringing this to my attention Laszlo. Work
is in progress.
Patrick Henz
-Original Message-
From: Laszlo Ersek
Sent: Tuesday, October 31, 2023 7:16 AM
To: devel@edk2.groups.io; hao.a...@intel.com; Henz, Patrick
; Michael Brown
Cc: Kinney, Michael D
brary? Or do we just leave things as they
currently are?
Thanks,
Patrick Henz
-Original Message-
From: Wu, Hao A
Sent: Thursday, August 10, 2023 8:43 PM
To: Henz, Patrick ; devel@edk2.groups.io; Michael Brown
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Use Performance Time
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2948
XhciDxe uses the timer functionality provided by the
boot services table to detect timeout conditions. This
breaks the driver's ExitBootServices call back, as
CoreExitBootServices halts the timer before signaling
the ExitBootServices event. I
I saw your earlier message in regard to the build failure too, I'll make sure
to run the CI check.
Thanks,
Patrick Henz
-Original Message-
From: Wu, Hao A
Sent: Thursday, September 7, 2023 9:20 PM
To: Henz, Patrick ; devel@edk2.groups.io; Mike Maslenkin
Subject: RE: [edk2-
.groups.io On Behalf Of Wu, Hao A
Sent: Thursday, September 7, 2023 2:48 AM
To: Mike Maslenkin ; devel@edk2.groups.io
Cc: Henz, Patrick
Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg/XhciDxe: Use Performance
Timer for XHCI Timeouts
I do not have strong opinion on this considering it is an IO driver
I sent this patch out a few weeks ago now but haven't seen a reply, just
checking in to make sure it didn't get missed.
Thanks,
Patrick Henz
-Original Message-
From: devel@edk2.groups.io On Behalf Of Henz, Patrick
Sent: Monday, August 14, 2023 10:52 AM
To: devel@edk2.groups.i
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2948
XhciDxe uses the timer functionality provided by the
boot services table to detect timeout conditions. This
breaks the driver's ExitBootServices call back, as
CoreExitBootServices halts the timer before signaling
the ExitBootServices event. I
r would we rather I just add XhcGetElapsedTime to XhciDxe
for the time being?
Thanks,
Patrick Henz
-Original Message-
From: devel@edk2.groups.io On Behalf Of Wu, Hao A
Sent: Sunday, July 30, 2023 9:57 PM
To: devel@edk2.groups.io; Henz, Patrick ; Michael Brown
Subject: Re: [edk2-dev
kg/XhciDxe: Fix Broken Timeouts" commit
implementation.
Thanks,
Patrick Henz
-Original Message-
From: devel@edk2.groups.io On Behalf Of Michael Brown
Sent: Thursday, July 6, 2023 8:02 AM
To: devel@edk2.groups.io; Henz, Patrick
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: U
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2948
XhciDxe uses the timer functionality provided by the
boot services table to detect timeout conditions. This
breaks the driver's ExitBootServices call back, as
CoreExitBootServices halts the timer before signaling
the ExitBootServices event. I
Hi Jess,
Thank you for reporting this, it's certainly a bug. I'm planning to implement a
fix.
Thanks,
Patrick Henz
-Original Message-
From: Jessica Clarke
Sent: Wednesday, June 7, 2023 4:38 PM
To: h...@mx0a-002e3701.pphosted.com; Henz, Patrick ;
devel@edk2.groups.io
S
Hi all,
We (Hewlett Packard Enterprise) are also running into a race condition due to
how InitializeApicTimer initializes the APIC timers, we figured this might be a
good place to report our findings. On the occasion we notice that APs get stuck
in the timer interrupt handling code after gettin
c: Ray Ni
Signed-off-by: Patrick Henz
Patrick Henz (1):
MdeModulePkg/XhciDxe: Fix Broken Timeouts
MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c | 59 +-
MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 63 ++--
2 files changed, 94 insertions(+), 28 del
From: Patrick Henz
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2948
Timeouts in the XhciDxe driver are taking longer than
expected due to the timeout loops not accounting for
code execution time. As en example, 5 second timeouts
have been observed to take around 36 seconds to complete.
Us
devel@edk2.groups.io; Henz, Patrick ; Ni, Ray
Cc: Wang, Jian J
Subject: Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg/XhciDxe: Fix Broken
Timeouts
Hello Patrick, a couple of inline comments below.
Hello Ray, need your input on one thing below as well.
> -Original Message-
> From:
esday, September 2, 2020 12:09 AM
To: Henz, Patrick ; devel@edk2.groups.io
Cc: Wang, Jian J ; Ni, Ray
Subject: RE: [PATCH 0/1] Fix XhciDxe Timeouts
> -Original Message-
> From: patrick.h...@hpe.com
> Sent: Wednesday, September 2, 2020 2:55 AM
> To: devel@edk2.groups.io
> Cc:
18 matches
Mail list logo
