From: Sami Mujawar
Some SMBIOS structure/table fields have dependency on other SMBIOS
structures/tables. These dependencies are established using handles
pointing to the dependent tables.
A SMBIOS table handle can be obtained by either installing a SMBIOS
table or by allocating a handle, which r
Split the SMBIOS and ACPI table generators into their own files.
Signed-off-by: Girish Mahadevan
Reviewed-by: Jeff Brasen
---
.../DynamicTableManagerDxe/AcpiTableBuilder.c | 762 ++
.../DynamicTableManagerDxe.c | 1325 +
.../DynamicTableManagerDxe.inf
Add the Generator library for SMBIOS Table Type 19 - Memory Array
Mapped Address.
Signed-off-by: Girish Mahadevan
Reviewed-by: Jeff Brasen
---
.../Include/SmbiosNameSpaceObjects.h | 14 +
.../SmbiosType19Lib/SmbiosType19Generator.c | 364 ++
.../SmbiosType19Lib/Smbio
Add the Generator library for SMBIOS Table Type 17 - Memory
Device.
Signed-off-by: Girish Mahadevan
Reviewed-by: Jeff Brasen
---
.../Include/SmbiosNameSpaceObjects.h | 95
.../SmbiosType17Lib/SmbiosType17Generator.c | 491 ++
.../SmbiosType17Lib/SmbiosType17Lib.
Add the SMBIOS Table generator code to the DynamicTablesPkg.
This change includes adding new logic to the DynamicTableManager
to process and add SMBIOS tables and augmenting the existing SMBIOS
Factory generator to include installing multiple SMBIOS tables .
Also included is running the SMBIOS and
Add the Generator library for SMBIOS Table Type 16 - Physical
Memory Array.
Signed-off-by: Girish Mahadevan
Reviewed-by: Jeff Brasen
Reviewed-by: Nick Ramirez
---
.../SmbiosTableBuilder.c | 3 -
.../Include/SmbiosNameSpaceObjects.h | 19 +
.../SmbiosType16Lib/S
From: Sami Mujawar
Update the SMBIOS table dispatcher dependency table to add the
table dependencies for SMBIOS table Type 19, Type 20, Type 27,
Type 35 and Type 37.
The SMBIOS table Type 35 can have dependency on 6 other SMBIOS
tables. Therefore, increase the MAX_SMBIOS_DEPENDENCY to 6, and
als
Introduce a new namespace for SMBIOS related CM Objects.
Signed-off-by: Girish Mahadevan
Reviewed-by: Nick Ramirez
Reviewed-by: Jeff Brasen
---
.../Include/ConfigurationManagerObject.h | 14 ++-
.../Include/SmbiosNameSpaceObjects.h | 42 +++
2 files changed, 5
From: Sami Mujawar
Some SMBIOS tables do not have a fixed dependency and can depend on any
other SMBIOS tables. Therefore, the SMBIOS dispatcher cannot define a
fixed sequence for dispatching these tables. A possible solution is to
defer the dispatch of such SMBIOS tables towards the end, assumin
Add an extern call to build SMBIOS table as this seemed to have
been removed during v2.
Signed-off-by: Girish Mahadevan
---
.../DynamicTableManagerDxe/SmbiosTableDispatcher.c | 10 ++
1 file changed, 10 insertions(+)
diff --git
a/DynamicTablesPkg/Drivers/DynamicTableManagerDxe/Smbi
From: Sami Mujawar
SMBIOS Structure Types 0 through 127 (7Fh) are reserved
for and defined by the SMBIOS specification. Types 128
through 256 (80h to FFh) are available for system and
OEM-specific information.
Therefore, define a new type 'SMBIOS_TABLE_TYPE' that
represents a SMBIOS structure ty
Initial Set of patches to add SMBIOS table generation to DynamicTablesPkg.
This includes generators for Type16, 17 and 19.
These patches have been based off of dynamictables-reorg branch in edk2-staging.
PR: https://github.com/tianocore/edk2-staging/pull/510
Girish Mahadevan (8):
DynamicTablesP
Add a new helper macro which is a wrapper over StringTableAddString().
It adds a string to the string table, and if the string is NULL or empty,
add "" string instead.
Signed-off-by: Dat Mach
Signed-off-by: Nick Ramirez
Signed-off-by: Girish Mahadevan
---
.../Include/Library/SmbiosStringTableL
heckLib is called)
Best Regards
Girish
Regards,
Nhi
On 9/21/2023 3:27 AM, Girish Mahadevan via groups.io wrote:
Hello
We have a requirement to monitor setVariable calls, we'd like to get a
callback before and after the variable update.
Similar to VarCheckLib, except that VarCheckLib'
Hello
We have a requirement to monitor setVariable calls, we'd like to get a
callback before and after the variable update.
Similar to VarCheckLib, except that VarCheckLib's set callbacks are
called after endOfDxe.
We were thinking of doing something like:
===
--- a/MdeModuleP
Hi Sami,
Any chance we can try to get your dispatcher patches in for the upcoming
release.(if there are no other comments).
Best Regards
Girish
On 7/25/2023 5:29 PM, Girish Mahadevan via groups.io wrote:
External email: Use caution opening links or attachments
Hi Sami
My responses inline
Add the Generator library for SMBIOS Table Type 16 - Physical
Memory Array.
Signed-off-by: Girish Mahadevan
Reviewed-by: Jeff Brasen
Reviewed-by: Nick Ramirez
---
.../SmbiosTableBuilder.c | 3 -
.../Include/SmbiosNameSpaceObjects.h | 19 +
.../SmbiosType16Lib/S
Introduce a new namespace for SMBIOS related CM Objects.
Signed-off-by: Girish Mahadevan
Reviewed-by: Nick Ramirez
Reviewed-by: Jeff Brasen
---
.../Include/ConfigurationManagerObject.h | 14 ++-
.../Include/SmbiosNameSpaceObjects.h | 42 +++
2 files changed, 5
Split the SMBIOS and ACPI table generators into their own files.
Signed-off-by: Girish Mahadevan
Reviewed-by: Jeff Brasen
---
.../DynamicTableManagerDxe/AcpiTableBuilder.c | 798 ++
.../DynamicTableManagerDxe.c | 1356 +
.../DynamicTableManagerDxe.inf
Add the Generator library for SMBIOS Table Type 17 - Memory
Device.
Signed-off-by: Girish Mahadevan
Reviewed-by: Jeff Brasen
---
.../Include/SmbiosNameSpaceObjects.h | 70 +++
.../SmbiosType17Lib/SmbiosType17Generator.c | 445 ++
.../SmbiosType17Lib/SmbiosType17Lib.i
Add the SMBIOS Table generator code to the DynamicTablesPkg.
This change includes adding new logic to the DynamicTableManager
to process and add SMBIOS tables and augmenting the existing SMBIOS
Factory generator to include installing multiple SMBIOS tables .
Also included is running the SMBIOS and
Patch series to add SMBIOS Table generation using DynamicTablesPkg
This patch series builds on top of the SMBIOS table dispatcher work that
dispatches and installs SMBIOS tables in the correct order.
This patches series does the following:
- Modify the existing DynamicTableManagerDxe driver to re
Hi Sami
My responses inline [GM]
Best Regards
Girish
On 7/24/2023 11:48 AM, Sami Mujawar wrote:
External email: Use caution opening links or attachments
Hi Girish,
Thank you for taking this effort forward
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 22/07/2023
Hi Sami
Your patches worked. There was just one thing I had to add to get
compile to work. (inline with [GM]), other than that I think you can get
this in.
We've implemented about 18 table generators. (Types 0, 1, 2, 3, 8, 9,
11, 13, 14, 16, 17, 19, 32, 38, 39, 41, 43, 45)
Two more are und
I had one comment , in-line.
Thanks
Girish
On 7/11/2023 8:36 AM, Nishant Sharma via groups.io wrote:
External email: Use caution opening links or attachments
From: Achin Gupta
This patch discovers the SP manifest in DT format passed by the SPMC. It
then parses it to obtain the boot informat
Couple of comments/questions inline (prefixed by [GM])
Thanks
Girish
On 7/11/2023 8:36 AM, Nishant Sharma via groups.io wrote:
External email: Use caution opening links or attachments
From: Achin Gupta
This patch packages requests for accessing a Standalone MM driver
through the MM communic
A few comments in line. (Prefixed with [GM])
Best Regards
Girish
On 7/11/2023 8:36 AM, Nishant Sharma via groups.io wrote:
External email: Use caution opening links or attachments
From: Achin Gupta
This patch adds support for discovering the presence of the SP using the
EFI_MM_COMMUNICATION
Hi Sami
Response inline.[GM]
Best Regards
Girish
On 3/9/2023 3:41 AM, Sami Mujawar wrote:
External email: Use caution opening links or attachments
Hi Girish,
Thank you for your feedback.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 08/03/2023, 17:41, "Girish M
Hi Sami,
Thanks for your response.
I will update my patch series based on v2 of your dispatcher code and
point you to v3. (mid/late next week)
Can you also merge the Smbios String related patch (the
SmbiosStringLibrary).
It works well. (I think I've ack'd that patch).
My responses inline [
Hi Sami
Thanks for v2, I will apply these to my tree and test it out.
One small comment before I review/test the patch train inline (prefixed
by [GM])
Best Regards
Girish
On 3/8/2023 1:16 AM, Sami Mujawar wrote:
External email: Use caution opening links or attachments
Some SMBIOS structure
Hello Sami,
Mind taking a quick look whenever you have some bandwidth.
Thanks
Girish
On 1/27/2023 4:58 PM, Girish Mahadevan via groups.io wrote:
External email: Use caution opening links or attachments
Add the SMBIOS Table generator code to the DynamicTablesPkg.
This change includes adding
Currently the standalonemmlibinternal assumes the max physical bits
to be 36 which is causing issues on v8 architectures.
Instead use the MAX_ALLOC_ADDRESS macro to determine the maximum
allowed address rather than recomputing it locally.
Signed-off-by: Girish Mahadevan
---
.../ArmStandaloneMmMe
Hi
On 1/30/2023 4:27 AM, Ard Biesheuvel wrote:
External email: Use caution opening links or attachments
(cc Damian)
On Sat, 28 Jan 2023 at 01:27, Girish Mahadevan wrote:
Currently the standalonemmlibinternal assumes the max physical bits
to be 36 which is causing issues on v8 architectures
Currently the standalonemmlibinternal assumes the max physical bits
to be 36 which is causing issues on v8 architectures.
Instead use the MAX_ADDRESS macro to determine the maximum allowed address
rather than recomputing it locally.
Signed-off-by: Girish Mahadevan
---
.../ArmStandaloneMmMemLibIn
ution opening links or attachments*
Hi Girish,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 04/10/2022 11:43 pm, Girish Mahadevan via groups.io wrote:
Hello Sami
Thank you so much for your review, I apologize for the late response.
My comment in line about the h
Add the SMBIOS Table generator code to the DynamicTablesPkg.
This change includes adding new logic to the DynamicTableManager
to process and add SMBIOS tables and augmenting the existing SMBIOS
Factory generator to include installing multiple SMBIOS tables .
Also included is running the SMBIOS and
Hello Sami
Thank you so much for your review, I apologize for the late response.
My comment in line about the handle manager [GM].
Best Regards
Girish
On 9/12/2022 8:57 AM, Sami Mujawar wrote:
External email: Use caution opening links or attachments
Hi Girish,
Thank you for this patch and
Hi Sami
Response inline.[GM]
Best Regards
Girish
On 10/4/2022 2:16 AM, Sami Mujawar wrote:
External email: Use caution opening links or attachments
Hi Girish,
There are 2 cases that need handling. Please see my response inline
marked [SAMI].
Regards,
Sami Mujawar
On 04/10/2022 04:01 am,
Hello Sami,
My apologies for the late response. I had one question/comment.
Comment marked with [GM] inline.
Best Regards
Girish
On 9/12/2022 8:18 AM, Sami Mujawar wrote:
External email: Use caution opening links or attachments
The Section 6.1.3, SMBIOS specification version 3.6.0 describes
Modify the DynamicTableManagerDxe driver to install SMBIOS tables in
addition to ACPI tables.
Instead of adding gEfiSmbiosProtocolGuid to the DEPEX list, setup
callback notifications for gEfiSmbiosProtocolGuid and
gEfiAcpiTableProtocolGuid and install the SMBIOS and ACPI tables
in the respective no
Add a new CM object to describe memory devices and setup a new
Generator Library for SMBIOS Type17 table.
Signed-off-by: Girish Mahadevan
---
.../Include/ArmNameSpaceObjects.h | 59 +++
.../SmbiosType17Lib/SmbiosType17Generator.c | 338 ++
.../SmbiosType17Lib/Smbio
41 matches
Mail list logo
