Hi Leif
Tein Hock has reviewed this patch.
Please help to merge in edk2.
Regards
Gaurav Jain
> -Original Message-
> From: Loh, Tien Hock
> Sent: Thursday, April 30, 2020 6:47 AM
> To: Leif Lindholm
> Cc: Pankaj Bansal ; Ard Biesheuvel
> ; Gaurav Jain ;
> Meenaks
-off-by: Gaurav Jain
---
.../Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c
b/SignedCapsulePkg/Universal/SystemFirmwareUpdate
error.
ConvertPages: range 8001 - EBD6 covers multiple entries.
Signed-off-by: Gaurav Jain
---
Notes:
v2
Updated Commit Message with an Example
.../BlackBoxTest/MemoryAllocationServicesBBTestFunction.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
di
Hi Tien Hock
Can you help to review the patch?
Regards
Gaurav Jain
> -Original Message-
> From: Loh, Tien Hock
> Sent: Tuesday, April 7, 2020 1:23 PM
> To: Gaurav Jain ; Ard Biesheuvel
> ; Leif Lindholm
> Cc: devel@edk2.groups.io; Pankaj Bansal ;
> Haojian Zhuang
> -Original Message-
> From: Ard Biesheuvel
> Sent: Monday, April 6, 2020 7:42 PM
> To: Leif Lindholm ; Gaurav Jain
> Cc: devel@edk2.groups.io; Pankaj Bansal ;
> Haojian Zhuang ; Loh, Tien Hock
>
> Subject: [EXT] Re: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added M
can be processed is 0x.
then Update BlockCount on the basis of MaxBlock.
Signed-off-by: Gaurav Jain
---
EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c | 38 ---
1 file changed, 25 insertions(+), 13 deletions(-)
diff --git a/EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c
b
ASSERT in SetTime_Conf Consistency Test.
SCT Test expect return as Invalid Parameter.
So removed ASSERT().
Signed-off-by: Gaurav Jain
---
Notes:
v3
Removed Time Validity Checks in function SetWakeupTime.
v2
reverted changes related to valid range of years.
EmbeddedPkg
Gentle Reminder!!
Please review..
Regards
Gaurav Jain
> -Original Message-
> From: Gaurav Jain
> Sent: Tuesday, February 18, 2020 5:54 PM
> To: devel@edk2.groups.io
> Cc: Leif Lindholm ; Ard Biesheuvel
> ; Pankaj Bansal ; Gaurav
> Jain
> Subject: [PATCH v2
: Gaurav Jain
---
Notes:
v3
- Corrected Width check in PciIoIoRead, PciIoIoWrite.
- Removed BarIndex check as it is already in GetBarResource().
- Moved DEV_SUPPORTED_ATTRIBUTES Macro from NonDiscoverablePciDeviceIo.c
to NonDiscoverablePciDeviceIo.h
v2
- Reverted
> -Original Message-
> From: Wu, Hao A
> Sent: Monday, February 24, 2020 1:56 PM
> To: Gaurav Jain ; devel@edk2.groups.io; Gao, Liming
> ; af...@apple.com; ler...@redhat.com;
> l...@nuviainc.com; Kinney, Michael D
> Cc: Wang, Jian J ; Ni, Ray ; Ard
> Bi
ibutes'?
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, February 21, 2020 6:53 AM
> To: devel@edk2.groups.io; Gaurav Jain ; Gao, Liming
> ; af...@apple.com; ler...@redhat.com;
> l...@nuviainc.com; Kinney, Michael D
> Cc: Wang, Jian J ; Ni, Ray ; Ard
> -Original Message-
> From: Wu, Hao A
> Sent: Wednesday, February 19, 2020 12:04 PM
> To: Gaurav Jain ; devel@edk2.groups.io; Ard Biesheuvel
>
> Cc: Wang, Jian J ; Ni, Ray ; Pankaj
> Bansal
> Subject: [EXT] RE: [PATCH 1/1] MdeModulePkg/Pci: Fixed Asserts in S
: Gaurav Jain
---
Notes:
v2
- Reverted ASSERT(FALSE) code.
- Added Checks for Width, BarIndex, Buffer,
Address range in PciIoIoRead, PciIoIoWrite.
- Added Checks for Width, BarIndex, Result,
Address range in PciIoPollIo, PciIoPollMem,
PciIoCopyMem.
- Added
> Gaurav:
> Does this patch catch to edk2 stable tag 202002?
Yes
Thanks
Gaurav
> -Original Message-
> From: Gao, Liming
> Sent: Wednesday, February 19, 2020 2:36 PM
> To: devel@edk2.groups.io; Gaurav Jain
> Cc: Leif Lindholm ; Ard Biesheuvel
> ; Pankaj Ban
Hi Gao
> Gaurav:
> Does this patch catch to edk2 stable tag 202002?
Yes
> -Original Message-
> From: Gao, Liming
> Sent: Monday, February 17, 2020 2:15 PM
> To: devel@edk2.groups.io; Gaurav Jain ; Gao, Liming
>
> Cc: Wang, Jian J ; Wu, Hao A ;
> Ni, Ray
ASSERT in SetTime_Conf and SetWakeupTime_Conf Consistency Test.
SCT Test expect return as Invalid Parameter.
So removed ASSERT().
Added Time Validity Checks in SetWakeupTime.
Signed-off-by: Gaurav Jain
---
Changes in v2:
- reverted changes related to valid range of years.
---
EmbeddedPkg
ASSERT in SetTime_Conf and SetWakeupTime_Conf Consistency Test.
SCT Test expect return as Invalid Parameter.
So removed ASSERT().
Added Time Validity Checks in SetWakeupTime.
Signed-off-by: Gaurav Jain
---
EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c | 8
1 file changed, 4
Gentle Reminder!!
Please review..
> -Original Message-
> From: Gaurav Jain
> Sent: Thursday, January 30, 2020 1:48 PM
> To: devel@edk2.groups.io
> Cc: Jian J Wang ; Hao A Wu ;
> Ray Ni ; Pankaj Bansal ; Gaurav
> Jain
> Subject: [PATCH 1/1] MdeModulePkg/Pci: Fi
needs to be corrected. What are your thoughts?
> -Original Message-
> From: Ard Biesheuvel
> Sent: Tuesday, February 11, 2020 7:50 PM
> To: Gaurav Jain
> Cc: devel@edk2.groups.io; Leif Lindholm ; Pankaj Bansal
>
> Subject: Re: FW: [EXT] Re: [PATCH 1/1] EmbeddedPkg:
: Gaurav Jain
---
.../NonDiscoverablePciDeviceIo.c | 21 +++
1 file changed, 21 insertions(+)
diff --git
a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c
b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c
index
Hi Ard
I am waiting for your response.
Regards
Gaurav
-Original Message-
From: Gaurav Jain
Sent: Friday, January 31, 2020 1:58 PM
To: Ard Biesheuvel
Cc: devel@edk2.groups.io; Leif Lindholm ; Pankaj Bansal
Subject: RE: [EXT] Re: [PATCH 1/1] EmbeddedPkg: Fixed Asserts in SCT Runtime
> -Original Message-
> From: Ard Biesheuvel
> Sent: Thursday, January 30, 2020 2:52 PM
> To: Gaurav Jain
> Cc: devel@edk2.groups.io; Leif Lindholm ; Pankaj Bansal
>
> Subject: [EXT] Re: [PATCH 1/1] EmbeddedPkg: Fixed Asserts in SCT Runtime
> Services test.
ASSERT in CopyMem_Conf, PollMem_Conf, SetBarAttributes_Conf
Conformance Test.
SCT Test expect return as Invalid Parameter.
So removed ASSERT().
Signed-off-by: Gaurav Jain
---
.../NonDiscoverablePciDeviceIo.c | 20 ---
1 file changed, 17 insertions(+), 3 deletions
ASSERT in SetTime_Conf and SetWakeupTime_Conf Consistency Test.
SCT Test expect return as Invalid Parameter.
So removed ASSERT().
Signed-off-by: Gaurav Jain
---
EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a
24 matches
Mail list logo
