Thanks for your update. This version should pass CI.
> > >
> > > Sami:
> > > Can you help review the updated patch? So, it can still catch this
> > > stable
> > > tag.
> > >
> >
> > I will go ahead and review/submit it if you are
when StMM runs in OP-TEE.
Cc: Ard Biesheuvel
Cc: Ilias Apalodimas
Cc: Leif Lindholm
Cc: Sami Mujawar
Signed-off-by: Etienne Carriere
---
No change since v2
Changes since v1:
- Remove useless duplication of ArmSvcLib loading.
- Move BaseStackCheckLib to generic library classes instead of ARM
Use (UINTN) cast to cast physical or virtual address values to the
pointer size before casting from/to a pointer value.
Cc: Ard Biesheuvel
Cc: Ilias Apalodimas
Cc: Leif Lindholm
Cc: Sami Mujawar
Signed-off-by: Etienne Carriere
---
No change since v2
No change since v1
---
Drivers/OpTee
: Ard Biesheuvel
Cc: Ilias Apalodimas
Cc: Leif Lindholm
Cc: Sami Mujawar
Signed-off-by: Etienne Carriere
---
No change since v2
Changes since v1:
- Use _AARCH64 (resp. _AARCH32) suffix instead of _64 (resp. _32) in
the added macros.
---
Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.c | 2
: Sughosh Ganu
Cc: Thomas Abraham
Signed-off-by: Etienne Carriere
---
No change since v2
Changes since v1:
- split change in 3: this change relates to DeveloperBox only.
---
Platform/Socionext/DeveloperBox/DeveloperBoxMm.dsc | 2 +-
Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf | 2 +-
2 files
: Sughosh Ganu
Cc: Thomas Abraham
Signed-off-by: Etienne Carriere
---
No change since v2
Changes since v1:
- split change in 3: this change relates to StandaloneMm package only.
---
Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc | 2
+-
Platform/StandaloneMm
: Sughosh Ganu
Cc: Thomas Abraham
Signed-off-by: Etienne Carriere
---
Changes since v2:
- Fix StandaloneMmCpu.inf
path required when rebasing the patch.
Changes since v1:
- split change in 3: this change relates to Platform/ARM/SgiPkg only.
---
Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf | 2
d-instructions
[4]
https://source.denx.de/u-boot/u-boot/-/commit/99bb5f248ade371ee4713e0ef51401708ecbb13c
[5]
https://source.denx.de/u-boot/u-boot/-/commit/a9f7be509af90fa5f2c308867ad3b0bd48532c6e
Etienne Carriere (6):
Platform/ARM/SgiPkg: sync with edk2 StandaloneMmCpu path change
Platform/Socio
64b
Arm targets.
Signed-off-by: Etienne Carriere
---
Changes since v4:
- Update StandaloneMmCoreEntryPoint.h path in StandaloneMmPkg.dec for
both AArch64 and ARM targets.
Changes since v3:
- Fix BuildOptions.ARM in StandaloneMmPkg.
- Remove Cc tags.
No change since v2
Changes since v1
Use intermediate (UINTN) cast when casting int from/to pointer. This
is needed as UINT64 values cast from/to 32bit pointer for 32bit
architectures.
Signed-off-by: Etienne Carriere
Acked-by: Jiewen Yao
Reviewed-by: Sami Mujawar
---
No change since v4
Changes since v3:
- Remove Cc tags and
Thumb mode.
Signed-off-by: Etienne Carriere
Acked-by: Liming Gao
Reviewed-by: Sami Mujawar
---
No change since v4
Changes since v3:
- Removed Cc tags and apply review tags.
Changes since v2:
- Fix missing parentheses in expression.
Changes since v1:
- Fix typos in commit log and inline
and 64bit architectures.
Signed-off-by: Etienne Carriere
---
Changes since v4:
- Remove changes related to MmCommunicationDxe and ArmMmuPeiLib since
they currently don't need to be built for ARM targets.
- Remove review tags applied to patch v3.
Changes since v3:
- Remove Cc tags and
Defines ARM_SVC_ID_FFA_* and ARM_SVC_ID_SP_* identifiers for 32bit
function IDs as per SMCCC specification. Defines also generic ARM
SVC identifier macros to wrap 32bit or 64bit identifiers upon target
built architecture.
Signed-off-by: Etienne Carriere
Reviewed-by: Sami Mujawar
---
Changes
Library/Arm/StandaloneMmCoreEntryPoint.h
> not declared in package DEC StandaloneMmPkg/StandaloneMmPkg.dec
>
> Thanks
> Liming
> > -邮件原件-
> > 发件人: devel@edk2.groups.io 代表 Ard
> > Biesheuvel
> > 发送时间: 2021年7月28日 14:52
> > 收件人: Sami Mujawar
> >
Thumb mode.
Signed-off-by: Etienne Carriere
Acked-by: Liming Gao
Reviewed-by: Sami Mujawar
---
Changes since v3:
- Removed Cc tags and apply review tags.
Changes since v2:
- Fix missing parentheses in expression.
Changes since v1:
- Fix typos in commit log and inline comments
- Change if
Defines ARM_SVC_ID_FFA_* and ARM_SVC_ID_SP_* identifiers for 32bit
function IDs as per SMCCC specification. Defines also generic ARM
SVC identifier macros to wrap 32bit or 64bit identifiers upon target
built architecture.
Signed-off-by: Etienne Carriere
Reviewed-by: Sami Mujawar
---
Changes
/ArmMmuStandaloneMmLib.c
and compile it for both 32bit and 64bit architectures.
Signed-off-by: Etienne Carriere
Reviewed-by: Sami Mujawar
---
Changes since v3:
- Remove Cc tags and apply review tag.
No change since v2
No change since v1
---
ArmPkg/ArmPkg.dec
Use intermediate (UINTN) cast when casting int from/to pointer. This
is needed as UINT64 values cast from/to 32bit pointer for 32bit
architectures.
Signed-off-by: Etienne Carriere
Acked-by: Jiewen Yao
Reviewed-by: Sami Mujawar
---
Changes since v3:
- Remove Cc tags and apply review tags.
No
64b
Arm targets.
Signed-off-by: Etienne Carriere
---
Changes since v3:
- Fix BuildOptions.ARM in StandaloneMmPkg.
- Remove Cc tags.
No change since v2
Changes since v1:
- ARM_SMC_ID_MM_COMMUNICATE 32b/64b agnostic helper ID is defined
in ArmStdSmc.h (see 1st commit in this series) instead of
Hello Sami,
Thanks for the catch. I missed that. My comment below.
On Tue, 18 May 2021 at 13:07, Sami Mujawar wrote:
>
> Hi Etienne,
>
> Please find my response inline marked [SAMI].
>
> Regards,
>
> Sami Mujawar
>
> On 17/05/2021 08:40 AM, Etienne Carriere wr
es.
>
> Thanks
> Liming
> > -邮件原件-
> > 发件人: devel@edk2.groups.io 代表 Etienne
> > Carriere
> > 发送时间: 2021年5月17日 15:35
> > 收件人: gaoliming
> > 抄送: devel@edk2.groups.io; Achin Gupta ; Ard
> > Biesheuvel ; Jiewen Yao
> > ; Leif Lindholm ; Sami
Use intermediate (UINTN) cast when casting int from/to pointer. This
is needed as UINT64 values cast from/to 32bit pointer for 32bit
architectures.
Cc: Achin Gupta
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Sughosh Ganu
Signed-off-by: Etienne Carriere
---
No
64b
Arm targets.
Cc: Achin Gupta
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Sughosh Ganu
Signed-off-by: Etienne Carriere
---
No change since v2
Changes since v1:
- ARM_SMC_ID_MM_COMMUNICATE 32b/64b agnostic helper ID is defined
in ArmStdSmc.h (see 1st commit
/ArmMmuStandaloneMmLib.c
and compile it for both 32bit and 64bit architectures.
Cc: Achin Gupta
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sughosh Ganu
Signed-off-by: Etienne Carriere
---
No change since v2
No change since v1
---
ArmPkg/ArmPkg.dec
Thumb mode.
Cc: Bob Feng
Cc: Liming Gao
Cc: Achin Gupta
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sughosh Ganu
Signed-off-by: Etienne Carriere
---
Changes since v2:
- Fix missing parentheses in expression.
Changes since v1:
- Fix typos in commit log and inline comments
- Change if() test
Signed-off-by: Etienne Carriere
---
No change since v2
Changes since v1:
- Define ARM_SMC_ID_MM_COMMUNICATE 32b/64b agnostic helper ID in
ArmStdSmc.h, as expected by few following commits in this series.
---
ArmPkg/Include/IndustryStandard/ArmFfaSvc.h | 12
ArmPkg/Include
On Mon, 17 May 2021 at 09:24, gaoliming wrote:
>
> Acked-by: Liming Gao
>
> > -邮件原件-
> > 发件人: Etienne Carriere
> > 发送时间: 2021年5月17日 13:49
> > 收件人: devel@edk2.groups.io
> > 抄送: Achin Gupta ; Ard Biesheuvel
> > ; Jiewen Yao ; Leif
> > L
Dear all,
For info, Tested on Qemu/arm and stm32mp1 (both armv7-a) and on 64bit
Qemu/AArch64.
I used OP-TEE 3.13.0 to host the StMM instance.
Regards,
Etienne
On Mon, 17 May 2021 at 07:50, Etienne Carriere
wrote:
>
> This change allows to build StandaloneMmPkg components for 32b
when StMM runs in OP-TEE.
Cc: Ard Biesheuvel
Cc: Ilias Apalodimas
Cc: Leif Lindholm
Cc: Sami Mujawar
Signed-off-by: Etienne Carriere
---
Changes since v1:
- Remove useless duplication of ArmSvcLib loading.
- Move BaseStackCheckLib to generic library classes instead of ARM only.
- include
Use (UINTN) cast to cast physical or virtual address values to the
pointer size before casting from/to a pointer value.
Cc: Ard Biesheuvel
Cc: Ilias Apalodimas
Cc: Leif Lindholm
Cc: Sami Mujawar
Signed-off-by: Etienne Carriere
---
No change since v1
---
Drivers/OpTee/OpteeRpmbPkg
: Ard Biesheuvel
Cc: Ilias Apalodimas
Cc: Leif Lindholm
Cc: Sami Mujawar
Signed-off-by: Etienne Carriere
---
Changes since v1:
- Use _AARCH64 (resp. _AARCH32) suffix instead of _64 (resp. _32) in
the added macros.
---
Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.c | 2 +-
Drivers/OpTee
: Sughosh Ganu
Cc: Thomas Abraham
Signed-off-by: Etienne Carriere
---
Changes since v1:
- split change in 3: this change relates to StandaloneMm package only.
---
Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc | 2
+-
Platform/StandaloneMm/PlatformStandaloneMmPkg
: Sughosh Ganu
Cc: Thomas Abraham
Signed-off-by: Etienne Carriere
---
Changes since v1:
- split change in 3: this change relates to DeveloperBox only.
---
Platform/Socionext/DeveloperBox/DeveloperBoxMm.dsc | 2 +-
Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf | 2 +-
2 files changed, 2 insertions
: Sughosh Ganu
Cc: Thomas Abraham
Signed-off-by: Etienne Carriere
---
Changes since v1:
- split change in 3: this change relates to Platform/ARM/SgiPkg only.
---
Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 2 +-
Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf | 2 +-
2 files changed, 2 insertions(+), 2
64b
Arm targets.
Cc: Achin Gupta
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Sughosh Ganu
Signed-off-by: Etienne Carriere
---
Changes since v1:
- ARM_SMC_ID_MM_COMMUNICATE 32b/64b agnostic helper ID is defined
in ArmStdSmc.h (see 1st commit in this series
Use intermediate (UINTN) cast when casting int from/to pointer. This
is needed as UINT64 values cast from/to 32bit pointer for 32bit
architectures.
Cc: Achin Gupta
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Sughosh Ganu
Signed-off-by: Etienne Carriere
---
No
Thumb mode.
Cc: Bob Feng
Cc: Liming Gao
Cc: Achin Gupta
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sughosh Ganu
Signed-off-by: Etienne Carriere
---
Changes since v1:
- Fix typos in commit log and inline comments
- Change if() test operand to be an explicit boolean
---
BaseTools/Source/C
Signed-off-by: Etienne Carriere
---
Changes since v1:
- Define ARM_SMC_ID_MM_COMMUNICATE 32b/64b agnostic helper ID in
ArmStdSmc.h, as expected by few following commits in this series.
---
ArmPkg/Include/IndustryStandard/ArmFfaSvc.h | 12
ArmPkg/Include/IndustryStandard/ArmMmSvc.h
/ArmMmuStandaloneMmLib.c
and compile it for both 32bit and 64bit architectures.
Cc: Achin Gupta
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sughosh Ganu
Signed-off-by: Etienne Carriere
---
No change since v1
---
ArmPkg/ArmPkg.dec | 2 +-
ArmPkg
ps://developer.arm.com/tools-and-software/open-source-software/developer-tools/gnu-toolchain/gnu-a/downloads
>
> Apart from this, there are some minor comments that I have marked inline
> as [SAMI].
>
> With those addressed.
>
> Reviewed-by: Sami Mujawar
>
> Regards,
>
>
: Ard Biesheuvel
Cc: Ilias Apalodimas
Cc: Leif Lindholm
Cc: Sami Mujawar
Signed-off-by: Etienne Carriere
---
Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.c | 2 +-
Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.h | 16 ++--
2 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/Drivers
Use (UINTN) cast to cast physical or virtual address values to the
pointer size before casting from/to a pointer value.
Cc: Ard Biesheuvel
Cc: Ilias Apalodimas
Cc: Leif Lindholm
Cc: Sami Mujawar
Signed-off-by: Etienne Carriere
---
Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.c | 21
: Sughosh Ganu
Cc: Thomas Abraham
Signed-off-by: Etienne Carriere
---
Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 2
+-
Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf | 2
+-
Platform/Socionext/DeveloperBox/DeveloperBoxMm.dsc
when StMM runs in OP-TEE.
Cc: Ard Biesheuvel
Cc: Ilias Apalodimas
Cc: Leif Lindholm
Cc: Sami Mujawar
Signed-off-by: Etienne Carriere
---
Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc |
12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git
support in OpTee drivers and last updates
PlatformStandaloneMmRpmb.dsc for 32bit the ARM architure.
[1] https://edk2.groups.io/g/devel/message/74734
Etienne Carriere (4):
sync with edk2 where StandaloneMmCpu moved to AArch64/ parent
directory
Drivers/OpTee: Add Aarch32 SVC IDs for 32bit Arm
Hello Liming,
Sure, I will do, thanks.
Regards,
Etienne
On Thu, 6 May 2021 at 05:26, gaoliming wrote:
> Etienne:
> Can you submit one BZ (https://bugzilla.tianocore.org/) for this new
> feature?
>
> Thanks
> Liming
> > -邮件原件-
> > 发件人: devel@edk2.grou
64b
Arm targets.
Cc: Achin Gupta
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Sughosh Ganu
Signed-off-by: Etienne Carriere
---
StandaloneMmPkg/Core/StandaloneMmCore.inf
| 2
Use intermediate (UINTN) cast when casting int from/to pointer. This
is needed as UINT64 values cast from/to 32bit pointer for 32bit
architectures.
Cc: Achin Gupta
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Sughosh Ganu
Signed-off-by: Etienne Carriere
Signed-off-by: Etienne Carriere
---
ArmPkg/Include/IndustryStandard/ArmFfaSvc.h | 12
ArmPkg/Include/IndustryStandard/ArmMmSvc.h | 15 +++
2 files changed, 27 insertions(+)
diff --git a/ArmPkg/Include/IndustryStandard/ArmFfaSvc.h
b/ArmPkg/Include/IndustryStandard
change is a resend of [2], rebased to latest master.
[1]
https://github.com/etienne-lms/edk2-platforms/commit/becbd185167f6a115dbd3895bc6071ab04e44d9b
[2] https://edk2.groups.io/g/devel/message/72834 (with 72835, 72836, 72837 and
72838)
Etienne Carriere (5):
ArmPkg/IndustryStandard: 32b/64b
Thumb mode.
Cc: Bob Feng
Cc: Liming Gao
Cc: Achin Gupta
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sughosh Ganu
Signed-off-by: Etienne Carriere
---
BaseTools/Source/C/GenFv/GenFvInternalLib.c | 38 +++-
1 file changed, 29 insertions(+), 9 deletions(-)
diff --git a/BaseTools
/ArmMmuStandaloneMmLib.c
and compile it for both 32bit and 64bit architectures.
Cc: Achin Gupta
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sughosh Ganu
Signed-off-by: Etienne Carriere
---
ArmPkg/ArmPkg.dec | 2 +-
ArmPkg/ArmPkg.dsc
specification upon the
target architecture.
Signed-off-by: Etienne Carriere
---
ArmPkg/ArmPkg.dec | 2 +-
ArmPkg/ArmPkg.dsc | 2 +-
.../MmCommunicationDxe/MmCommunication.c | 2 +-
.../{AArch64 => }/ArmMmuStandaloneMmLib.c |
Use intermediate (UINTN) cast when casting int from/to pointer. This
is needed as UINT64 values cast from/to 32bit pointer for 32bit
architectures.
Signed-off-by: Etienne Carriere
---
.../StandaloneMmCpu/AArch64/StandaloneMmCpu.c | 8
.../AArch64/CreateHobList.c
64b
Arm targets.
Signed-off-by: Etienne Carriere
---
StandaloneMmPkg/Core/StandaloneMmCore.inf| 2 +-
.../StandaloneMmCpu/{AArch64 => }/EventHandle.c | 12 ++--
.../{AArch64 => }/StandaloneMmCpu.c | 2 +-
.../{AArch64 => }/StandaloneMmCpu.h
Thumb mode.
Signed-off-by: Etienne Carriere
---
BaseTools/Source/C/GenFv/GenFvInternalLib.c | 39 -
1 file changed, 30 insertions(+), 9 deletions(-)
diff --git a/BaseTools/Source/C/GenFv/GenFvInternalLib.c
b/BaseTools/Source/C/GenFv/GenFvInternalLib.c
index 6e296b8ad6
.
[1] https://developer.arm.com/documentation/den0077/latest
Signed-off-by: Etienne Carriere
---
ArmPkg/Include/IndustryStandard/ArmFfaSvc.h | 12
ArmPkg/Include/IndustryStandard/ArmMmSvc.h | 15 +++
2 files changed, 27 insertions(+)
diff --git a/ArmPkg/Include
57 matches
Mail list logo
