Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Error handling of TpmMeasureAndLogDataWithFlags()

2024-03-12 Thread Chen, Gang C
Reviewed-by: Chen Gang C BR Gang -Original Message- From: Lin, Du Sent: Tuesday, March 12, 2024 5:20 PM To: devel@edk2.groups.io Cc: Lin, Du ; S, Ashraf Ali ; Chiu, Chasel ; Chen, Gang C ; Duggapu, Chinni B ; Desimone, Nathaniel L ; Zeng, Star ; Mohapatra, Susovan ; Kuo, Ted

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Error handling of FspmWrapperInit()

2024-03-12 Thread Chen, Gang C
Reviewed-by: Chen Gang C BR Gang -Original Message- From: Lin, Du Sent: Tuesday, March 12, 2024 5:28 PM To: devel@edk2.groups.io Cc: Lin, Du ; S, Ashraf Ali ; Chiu, Chasel ; Chen, Gang C ; Duggapu, Chinni B ; Desimone, Nathaniel L ; Zeng, Star ; Mohapatra, Susovan ; Kuo, Ted

[edk2-devel] [PATCH 1/1] UefiPayloadPkg/UefiPayloadEntry: Remove SCI enabling check

2024-01-07 Thread Chen, Gang C
It's too early to check the SCI enable status, which is set in the BDS phase ususally. Remove the check from UPL. Signed-off-by: Gang Chen Cc: Gua Guo Cc: Guo Dong Cc: James Lu Cc: Sean Rhodes --- UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c | 38 - 1 file changed, 38 dele

[edk2-devel] [PATCH 0/1] Remove SCI status check from UPL

2024-01-07 Thread Chen, Gang C
Check SCI status too early will cause the below error message will be printed out always: ERROR: The ACPI enabling status is inconsistent: SCI is not enabled but the ACPI table does not provide a means to enable it through FADT->SmiCmd. This may cause issues in OS. SCI will be set in BDS. So check

[edk2-devel] [PATCH 1/1] UefiPayloadPkg/UefiPayloadEntry: Remove SCI enabling check

2024-01-07 Thread Chen, Gang C
It's too early to check the SCI enable status, which is set in the BDS phase ususally. Remove the check from UPL. Signed-off-by: Gang Chen Cc: Gua Guo Cc: Guo Dong Cc: James Lu Cc: Sean Rhodes --- UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c | 38 - 1 file changed, 38 dele

[edk2-devel] [PATCH 0/1] Remove SCI status check from UPL

2024-01-07 Thread Chen, Gang C
Check SCI status too early will cause the below error message will be printed out always: ERROR: The ACPI enabling status is inconsistent: SCI is not enabled but the ACPI table does not provide a means to enable it through FADT->SmiCmd. This may cause issues in OS. SCI will be set in BDS. So check

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Add variable initialization

2023-11-09 Thread Chen, Gang C
Reviewed-by: Chen Gang C BR Gang -Original Message- From: Guo, Gua Sent: Thursday, November 9, 2023 6:07 PM To: Hsu, JasonX ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Zeng, Star ; Chiu, Chasel ; Chen, Gang C ; Duggapu, Chinni B ; Kuo, Ted ; S, Ashraf Ali ; Mohapatra

Re: [edk2-devel] [PATCH] Maintainers.txt: Update for IntelFsp2Pkg and IntelFsp2WrapperPkg.

2023-04-26 Thread Chen, Gang C
Reviewed-by: Chen Gang C mailto:gang.c.c...@intel.com>> Best Regards Gang From: Kuo, Ted Sent: Thursday, April 27, 2023 11:45 AM To: Mohapatra, Susovan ; Chiu, Chasel ; devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Duggapu, Chinni B ; Ng, Ray Han Lim ; Chen, Gang C

Re: [edk2-devel] [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable for openssl

2023-02-01 Thread Chen, Gang C
Hi Jiewen, Here is the bug link: https://bugzilla.tianocore.org/show_bug.cgi?id=4334. Thanks. Best Regards Gang -Original Message- From: Yao, Jiewen Sent: Friday, January 6, 2023 5:45 PM To: Chen, Gang C ; devel@edk2.groups.io Cc: Wang, Jian J Subject: RE: [PATCH] CryptoPkg/Library

[edk2-devel] [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable for openssl

2023-01-04 Thread Chen, Gang C
The GCC warning fix is not in 1.1.1x. Ignore the warning type -Wno-unused-but-set-variable with GCC compiler in the build option. Cc: Jiewen Yao Cc: Jian J Wang Signed-off-by: Gang Chen --- CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 ++ CryptoPkg/Library/OpensslLib/OpensslLibAcce

Re: [edk2-devel] [PATCH] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1s

2022-11-18 Thread Chen, Gang C
5:32 PM To: Chen, Gang C ; devel@edk2.groups.io Cc: Wang, Jian J ; Yao, Jiewen Subject: RE: [PATCH] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1s Hi Have you run the tiano CI ? Would you please share the size data before and after? Thank you Yao, Jiewen > -Original Message- > Fr

[edk2-devel] [PATCH] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1s

2022-11-17 Thread Chen, Gang C
Upgrade openssl to 1.1.1s. Pick up bugfixes from the latest openssl release, which include some GCC build warnings cleaning up. Cc: Jian J Wang Cc: Jiewen Yao Signed-off-by: Gang Chen --- CryptoPkg/Library/OpensslLib/openssl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[edk2-devel] [PATCH] UefiPayloadPkg/PayloadLoaderPeim: remove GCC build warning

2022-08-24 Thread Chen, Gang C
Fix the gcc build warning: variable PldInfo set but not used [-Wunused-but-set-variable] Cc: Ray Ni Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Gang Chen --- UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c | 5 - 1 file changed, 5 deletions(-) diff --git a/U

Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/dec: update the PcdCpuStackGuard property

2022-04-11 Thread Chen, Gang C
:55 PM To: devel@edk2.groups.io; Chen, Gang C Cc: Jiang, Guomin ; Bi, Dandan ; Zhang, Di ; Wang, Jian J ; Gao, Liming Subject: RE: [edk2-devel] [PATCH 1/2] MdeModulePkg/dec: update the PcdCpuStackGuard property FixedAtBuild PCD can be accessed at any time from any CPU. But dynamic PCD can only

[edk2-devel] [PATCH 2/2] UefiCpuPkg/CpuExceptionHandlerLib: remove duplicated pcd check

2022-04-11 Thread Chen, Gang C
Remove the duplicated PcdCpuStackGuard check for it has been checked at the entry of InitializeMpExceptionStackSwitchHandlers, which will invoke the current function. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3897 Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: devel@edk2.groups.io Sign

[edk2-devel] [PATCH 1/2] MdeModulePkg/dec: update the PcdCpuStackGuard property

2022-04-11 Thread Chen, Gang C
Update the PcdCpuStackGuard from PcdsFixedAtBuild to PcdsDynamicEx for the requirement to set different value in FSP API mode and FSP Dispatch mode. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3897 Cc: Jian J Wang Cc: Liming Gao Cc: devel@edk2.groups.io Signed-off-by: Gang Chen --- M

[edk2-devel] [PATCH 0/2] update the property of PcdCpuStackGuard

2022-04-11 Thread Chen, Gang C
This serial patch is to change the property of PcdCpuStackGuard from PcdsFixedAtBuild to PcdsDynamicEx. The purpose of this change is for the requirement to set the different value in FSP API mode and FSP Dispatch mode. And there is duplicated check for this PCD in both InitializeCpuExceptionHand

[edk2-devel] [PATCH] MdeModulePkg/dec: update the PcdCpuStackGuard property

2022-04-08 Thread Chen, Gang C
Update the PcdCpuStackGuard from PcdsFixedAtBuild to PcdsDynamicEx. Meanwhile, remove the duplicate check for PcdCpuStackGuard for some limitation, which has been checked at the entry of InitializeMpExceptionStackSwitchHandlers. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3897 Cc: Jian J