Re: [edk2-devel] [BUG] Extremely slow boot times with CPU and GPU passthrough and host phys-bits > 40

2024-11-22 Thread Brian J. Johnson via groups.io
k if the MTRRs and page attributes are getting set properly is a good one. That has caused this type of problem in the past. -- Brian J. Johnson Hewlett Packard Enterprise brian.john...@hpe.com -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Onl

Re: [edk2-devel] HII Keyword utility

2024-05-15 Thread Brian J. Johnson
I like the idea; it sounds useful for automation.  Although more and more of that is moving to Redfish now.  No idea where it should go, though. *Brian J. Johnson *Enterprise X86 Lab Hewlett Packard Enterprise *From

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-10 Thread Brian J. Johnson
ane(ish!) email workflow (openfw.io + b4). Otherwise, no objections, it's better than edk2.git's half-email half-PR frankenprocess. I'd guess this change only encompasses edk2.git? How about the other repos? Any timeline for those? The plan is to apply this to all repos, one at a

Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-02 Thread Brian J. Johnson
On 5/1/24 18:19, Dionna Glaze via groups.io wrote: On Wed, May 1, 2024 at 11:12 AM Leif Lindholm via groups.io wrote: On 2024-05-01 18:43, Michael D Kinney wrote: Hello, I would like to propose that TianoCore move all code review from email based code reviews to GitHub Pull Requests based co

Re: [edk2-devel] [PATCH V1 1/1] UefiCpuPkg/ResetVector: Cache Disable should not be set by default in CR0

2024-01-22 Thread Brian J. Johnson
uncached accesses. Since this is a VM, it's not actually uncached at the hardware level, but I don't know how QEMU/KVM handles uncached guest mappings It may be doing a VMEXIT for every byte. Anyway, I suggest double-checking your page tables and MTRRs. -- Brian J. Johnson Enterprise

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Initialise serial port early in StandaloneMmEntryPoint

2024-01-10 Thread Brian J. Johnson
and a library class to implement it, with an empty instance for general use and your own platform-specific instance which calls SerialPortInitialize(). or 2. Write your own platform-specific version of StandaloneMmCoreEntryPoint. -- Brian J. Johnson Enterprise X86 Lab Hewlett Packard Enterpr

Re: [edk2-devel] question about cxl device enumeration in pci bus driver

2023-11-07 Thread Brian J. Johnson
%20SW%20Guide_Rev1p0.pdf *Brian J. Johnson *Enterprise X86 Lab Hewlett Packard Enterprise *From:* Yoshinoya [mailto:yoshinoyat...@163.com] *Sent:* Monday, November 6, 2023 at 5:20 AM *To:* devel@edk2.groups.io *Cc

Re: 回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9

2023-08-04 Thread Brian J. Johnson
Liming and Jiewen, I asked Terry Lee to give this patchset a spin, and it seemed to work well for our h/w use case. The size increase vs. OpenSSL 1.1.1n was noticeable, but workable. We're good with merging it. Brian J. Johnson HP Enterprise Misison-Critical Systems Ori

Re: [edk2-devel] [Help] in Setting up EFI Shell in QEMU to allow for HTTP Requests

2023-02-17 Thread Brian J. Johnson
Are you sure you have the HttpDxe driver in your OVMF build?  Looks like you'd need to build with either -D NETWORK_HTTP_ENABLE or -D NETWORK_HTTP_BOOT_ENABLE. See https://github.com/tianocore/edk2/blob/master/OvmfPkg/README for details on HTTPS. *Brian J. Johnson *Hewlett Pa

Re: [edk2-devel] [PATCH v3 1/5] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data

2023-02-02 Thread Brian J. Johnson
tely, neither HobLib nor AllocatePages() has an interface for setting the "Name" field. But you can call AllocatePages(), then search the HOB list for the resulting HOB, and update it's AllocDescriptor.Name field. -- Brian J. Johnson Enterprise X86 Lab Hewlett Packard Enterprise

Re: [edk2-devel] edk2setup.sh shortcomings

2023-02-02 Thread Brian J. Johnson
cal input. That helps avoid unnecessary rebuilds of code which hasn't actually changed. It affects items like the order of dependencies in the generated makefiles. Setting PYTHONHASHSEED knocked several minutes off of the rebuild time for one of our platforms. Recommended. Brian J. Joh

Re: [edk2-devel] [PATCH v7 2/2] tools_def: add -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS

2022-12-01 Thread Brian J. Johnson
OK. Doesn't look like a big impact. Thanks, Brian J. Johnson Original Message From: Gerd Hoffmann [mailto:kra...@redhat.com] Sent: Thursday, December 1, 2022 at 2:38 AM To: Brian J. Johnson Cc: devel@edk2.groups.io, Alexey Kardashevskiy , Liming Gao , Erdem Aktas ,

Re: [edk2-devel] [PATCH v7 2/2] tools_def: add -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS

2022-11-30 Thread Brian J. Johnson
Gerd, Sorry, gotta ask: does this make much difference in the size of the compiled code? That's a constraint on many real-hardware X64 platforms, especially for 32-bit code. Brian J. Johnson Original Message From: Gerd Hoffmann [mailto:kra...@redhat.com] Sent: Wedn

Re: [edk2-devel] Access 64bit address space in 32bit mode

2022-11-09 Thread Brian J. Johnson
Slight correction:  PAE paging can access up to 52 physical address bits, for 4 PBytes of memory.  Section 4.4 of the Intel® 64 and IA-32 Architectures Software Developer’s Manual Volume 3 (3A, 3B, 3C & 3D): System Programming Guide covers it. Brian J. Joh

Re: [edk2-devel] How to guard CAR's stack overflow

2022-09-22 Thread Brian J. Johnson
early PEI code I've seen uses the same selector for ds, ef, fs, gs, and ss. Hope that helps.  This is mostly theoretical.  I don't actually have a lot of experience with x86 segment programming. Brian J. Johnson --

Re: [edk2-devel] How to guard CAR's stack overflow

2022-09-19 Thread Brian J. Johnson
  See sections 5.1 - 5.3 of the Intel SDM, volume 3. Brian J. Johnson *From:* Ni, Ray [mailto:ray...@intel.com] *Sent:* Wednesday, September 14, 2022, 10:25 PM *To:* devel@edk2.groups.io , tiger...@zhaoxin.com *Cc:* Fan,

Re: [edk2-devel] [PATCH 1/2] OvmfPkg: Introduce NULL class library to inhibit driver load

2022-08-16 Thread Brian J. Johnson
o control, and install it only when you want the module to be dispatched. That's pretty straightforward, although it does result in "Driver %g was discovered but not loaded!!" messages from CoreDisplayDiscoveredNotDispatched() if sufficient debugging is enabled. Brian J. Johnson Laszlo On 08/15/22 1

[edk2-devel] FreePool in PEI (was: Clarification of Memory management in PEI phase)

2022-07-01 Thread Brian J. Johnson
of future inclusion in PI? Vincent On Wed, Jun 22, 2022 at 2:41 PM Brian J. Johnson wrote: Andrew, Yes, adding a new HOB type to represent free pool would probably be the easiest. Or we could write or borrow a traditional malloc() implementation, similar to DXE's pool allocator, and

Re: [edk2-devel] Clarification of Memory management in PEI phase

2022-06-22 Thread Brian J. Johnson
would avoid fragmenting the pool memory when non-pool HOBs are added.  It would probably be more code, though. Brian J. Johnson *From:* Andrew Fish [mailto:af...@apple.com] *Sent:* Wednesday, June 22, 2022, 3:54 PM *To:* Br

Re: [edk2-devel] [PATCH V1 1/1] MdeModulePkg: Add Definition of EDKII_PEI_VARIABLE_PPI

2022-06-22 Thread Brian J. Johnson
le to modify settings in response to h/w changes and external requests, without having to boot all the way to DXE, write the variables, then trigger a reset. Brian J. Johnson Original Message From: Nate DeSimone [mailto:nathaniel.l.desim...@intel.com] Sent: Monday, June 13, 2022,

Re: [edk2-devel] Clarification of Memory management in PEI phase

2022-06-22 Thread Brian J. Johnson
n in post-DRAM PEI, and depends on allocating and freeing memory in different phases of its operation. Brian J. Johnson *From:* Ayush Singh [mailto:ayushdevel1...@gmail.com] *Sent:* Friday, June 10, 2022, 12:22 AM *To:* A

Re: [edk2-devel] Running and Testing Modules and Applications

2022-06-03 Thread Brian J. Johnson
run. I've done that quite a bit in the past. Good luck, Brian J. Johnson Original Message From: Ayush Singh [mailto:ayushdevel1...@gmail.com] Sent: Friday, June 3, 2022, 11:49 AM To: edk2-devel-groups-io Subject: [edk2-devel] Running and Testing Modules and Application

Re: [edk2-devel] [edk2-discuss] GSoC Proposal

2022-04-18 Thread Brian J. Johnson
; Shi, Steven Subject: Re: [edk2-devel] [edk2-discuss] GSoC Proposal Hey Brian, On 15.04.22 18:22, Brian J. Johnson wrote: Nate, Andrew, Marvin, Pedro, Ada, et al, This is a great discussion.  I've been debating where to weigh in... Personally, I don't think this topic can get enough

Re: [edk2-devel] [edk2-discuss] GSoC Proposal

2022-04-15 Thread Brian J. Johnson
UEFI services, setup screens, etc.) That puts more and more pressure on XIP storage and cache-as-RAM. How can we encourage a change? Thanks, Brian J. Johnson On 4/15/22 03:15, Nate DeSimone wrote: Hi Andrew, On 4/14/22, 7:43 PM, "Andrew Fish" wrote: On Apr 14, 2022, at 6:06 PM

Re: [edk2-devel] RFC: Add BaseLib/QuickSort in MdePkg

2021-09-28 Thread Brian J. Johnson
I'll add my agreement to Marvin and Jeff: a low-level sort routine like this should let the caller be in charge of memory allocation, so it can be used in the widest variety of contexts (SEC, exception handlers, APs, etc.) So let's make the BufferOneElement parameter mandatory.

Re: [edk2-devel] [PATCH v1] OvmfPkg: Add build options for 8MB and 16MB X64 OVMF images

2021-05-28 Thread Brian J. Johnson
. I welcome this patch for that reason. But I'd also like OVMF to benefit from this change even when it is built with a traditional -- and regrettably, ever-growing -- DXE phase. I welcome this patch for that reason too. Thank you, Laszlo -- Brian J. Johnson Enterprise X86 Lab He

Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Reduce reset vector memory pressure

2020-09-25 Thread Brian J. Johnson
The standards may be different (if there are any standards at all in that area.) -- Brian J. Johnson Enterprise X86 Lab Hewlett Packard Enterprise -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65632): https://edk2.groups.io/g/devel/m

Re: [edk2-devel] [edk2-rfc] MdeModulePkg/StatusCodeHandler: Separate NULL class libraries for Memory and serial handlers from MdeModulePkg/Universal/StatusCodeHandler modules

2020-06-25 Thread Brian J. Johnson
bit by sharing common library routines, such as BaseLib, with the StatusCodeRouter modules. If those don't seem like worthwhile advantages, that's OK with me.  I don't want to belabor the point, or impede progress.  If others are OK with the proposal as it stands, then I am too

Re: [edk2-devel] [edk2-rfc] MdeModulePkg/StatusCodeHandler: Separate NULL class libraries for Memory and serial handlers from MdeModulePkg/Universal/StatusCodeHandler modules

2020-06-24 Thread Brian J. Johnson
t like to take that opportunity to reduce the complexity of the overall status code stack while we're at it. Thanks, *Brian J. Johnson *Enterprise X86 Lab Hewlett Packard Enterprise *From:* Bi, Dandan [mailto:dandan...@int

Re: [edk2-devel] [edk2-rfc] MdeModulePkg/StatusCodeHandler: Separate NULL class libraries for Memory and serial handlers from MdeModulePkg/Universal/StatusCodeHandler modules

2020-06-19 Thread Brian J. Johnson
modules would be needed. Thanks, -- *Brian J. Johnson *Enterprise X86 Lab Hewlett Packard Enterprise *hpe.com* <3D"hpe.com"> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61533): https://edk2.groups.io/g/devel/mess

Re: [edk2-devel] [PATCH v7 00/43] SEV-ES guest support

2020-05-18 Thread Brian J. Johnson
dler to provide underlying support to the rest of BIOS. CpuExceptionHandlerLib is large and complex, but monolithic. I don't have a solution to propose, but maybe it will get someone thinking -- Brian J. Johnson Enterprise X86 Lab Hewlett Packard Enterprise brian.john...@hpe.com -

Re: [edk2-devel] [PATCH V4 00/27] Disabling safe string constraint assertions

2020-05-13 Thread Brian J. Johnson
As am I -- I don't see that they add value. Brian Original Message From: Bret Barkelew via groups.io [mailto:bret.barkelew=microsoft@groups.io] Sent: Wednesday, May 13, 2020, 9:41 AM To: devel@edk2.groups.io , ler...@redhat.com , Kinney, Michael D , Vitaly Cheptsov Cc:

Re: [edk2-devel] [RFC][PATCH v1] UefiCpuPkg/MpInitLib DXE: Reduce AP status check interval

2020-03-23 Thread Brian J. Johnson
s of APs, and we have had to do various tweaks to the MP init. code. Having a PCD to adjust this timeout will be very useful. Thanks, -- Brian J. Johnson Enterprise X86 Lab Hewlett Packard Enterprise brian.john...@hpe.com -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent

Re: [edk2-devel] [PATCH v3 6/6] OvmfPkg IA32: add support for loading X64 images

2020-02-26 Thread Brian J. Johnson
berOfSections (or at least verify that all pointers you calculate from them point within the overall image. Or has that already been done by the PeCoff loader by the time this code is called? Thanks, Brian J. Johnson +} +Section++; + } + return NULL; +} + +STATIC +EFI_STATUS +

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg: Entend the support keyboard type of Terminal console

2019-09-13 Thread Brian J. Johnson
Include/Guid/HiiBootMaintenanceFormset.h gEfiIfrBootMaintenanceGuid = { 0xb2dedc91, 0xd59f, 0x48d2, { 0x89, 0x8a, 0x12, 0x49, 0xc, 0x74, 0xa4, 0xe0 }} -- 2.21.0.windows.1 -- Brian J. Johnson Enterprise X86 Lab Hewlett Packard Enterprise -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: Yo

Re: [edk2-devel] [Patch 0/2] UefiCpuPkg: Default avoid print.

2019-08-01 Thread Brian J. Johnson
On 7/31/19 1:58 PM, Laszlo Ersek wrote: On 07/31/19 18:34, Brian J. Johnson wrote: I do wonder if there would be a clean way to let a DebugLib instance itself declare that AP_DEBUG() is safe. That way a platform would only need to override the DebugLib instance in the DSC file, rather than

Re: [edk2-devel] [Patch 0/2] UefiCpuPkg: Default avoid print.

2019-07-31 Thread Brian J. Johnson
have no idea about other architectures.) That wouldn't solve the problem everywhere -- anyone using a custom DebugLib would have to update it themselves. But it would solve it solidly in the majority of cases. Thoughts? -- Brian J. Johnson Enterprise X86 Lab Hewlett Packard Enterprise -=-=-

Re: [edk2-devel] TianoCore Community Design Meeting Minutes

2019-05-07 Thread Brian J. Johnson
On 5/6/19 11:06 AM, Laszlo Ersek wrote: On 05/03/19 23:41, Brian J. Johnson wrote: On 5/2/19 2:33 PM, sean.brogan via groups.io wrote: Brian, I would really like to hear about the challenges your team faced and issues that caused those solutions to be unworkable.  Project Mu has and continues

Re: [edk2-devel] TianoCore Community Design Meeting Minutes

2019-05-03 Thread Brian J. Johnson
.) We're also generally focusing on one platform at a time, not trying to update shared code across many at once. So our use case may be different from Sean's. This got rather long... I hope it helps explain where we're coming from. -- Brian J. Johnson Enterprise X86 Lab Hewl

Re: [edk2-devel] [Patch V2 2/6] MdePkg/BaseLib: Use PcdSpeculationBarrierType

2019-04-30 Thread Brian J. Johnson
) { +AsmCpuid (0x01, NULL, NULL, NULL, NULL); + } } Looks good. I'm not a maintainer, but FWIW: Reviewed-by: Brian J. Johnson -- Brian J. Johnson Enterprise X86 Lab Hewlett Packard Enterprise brian.john...@hpe.com +1 651 683 7521 Office Eagan, MN hp

Re: [edk2-devel] [Patch 1/4] MdePkg/BaseLib: Verify SSE2 support in IA32 AsmLfence()

2019-04-26 Thread Brian J. Johnson
pile-time decision? I haven't tried to track down all the callers of AsmLfence Thanks, -- Brian J. Johnson Enterprise X86 Lab Hewlett Packard Enterprise -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39666): https://edk2.gro

Re: [edk2-devel] TianoCore Community Design Meeting Minutes

2019-04-23 Thread Brian J. Johnson
some external tooling in the past, and found it completely unworkable. Perhaps Project Mu's tooling is better than ours was. But for modules which are developed together by the same group of people, keeping all the code in a single git repo lets you make the best use o