Re: [edk2-devel][PATCH] Maintainers.txt: Add new reviewer for UefiPayloadPkg

2022-07-15 Thread Benjamin You
Reviewed-by: Benjamin You > -Original Message- > From: Dong, Guo > Sent: Saturday, July 16, 2022 9:02 AM > To: devel@edk2.groups.io > Cc: Dong, Guo ; Ni, Ray ; You, > Benjamin ; Maurice Ma ; > Kinney, Michael D ; Rhodes, Sean > > Subject: [edk2-devel][PATC

Re: [edk2-devel] [`edk2-devel][PATCH V3 0/8] Add SMM variable support for UEFI payload

2021-10-23 Thread Benjamin You
Reviewed-by: Benjamin You > -Original Message- > From: Dong, Guo > Sent: Friday, October 22, 2021 11:46 PM > To: devel@edk2.groups.io > Cc: Dong, Guo ; Ni, Ray ; Ma, > Maurice ; You, Benjamin > Subject: [`edk2-devel][PATCH V3 0/8] Add SMM variable support for UEF

Re: [edk2-devel] [Patch 3/3] Maintainers.txt: Add GitHub IDs

2021-07-08 Thread Benjamin You
Hi Mike, On > -R: Benjamin You and > +M: Benjamin You [BenjaminYou] Could you please change "M" to "R"? I am no longer a maintainer for UEFIPayload package. Thanks! - ben > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael D &

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Update EFI Memory Service conditions

2021-01-30 Thread Benjamin You
Hi Aiden, Could you please insert some comments for below codes? + if (Base == 0x00) { +Attribue &= ~EFI_RESOURCE_ATTRIBUTE_TESTED; } Also, is this removal of legacy region to protect coreboot data structures in the region? Thanks, - ben > -Original Message- > From: devel@edk2.g

Re: [edk2-devel] [PATCH] Maintainers.txt: Update Maintainers and reviewers for UefiPayloadPkg

2021-01-27 Thread Benjamin You
Reviewed-by: Benjamin You > -Original Message- > From: devel@edk2.groups.io On Behalf Of Dong, Guo > Sent: Monday, January 25, 2021 1:59 AM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; You, Benjamin > ; philipp.deppenwi...@9elements.com; Kinney, > Michael D &

Re: [edk2-devel] [patch] CorebootPayloadPkg: Remove the dependency of ShellBinPkg

2019-04-10 Thread Benjamin You
Reviewed-by: Benjamin You Thanks, - ben > -Original Message- > From: Bi, Dandan > Sent: Wednesday, April 10, 2019 1:34 PM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Agyeman, Prince > ; You, Benjamin > Subject: [patch] CorebootPayloadPkg: Remove the depe