Re: [edk2-devel] [PATCHv2 1/1] MdeModulePkg/Ahci: Skip retry for non-transient errors

2023-03-28 Thread Anbazhagan, Baraneedharan via groups.io
Reviewed-by: Baraneedharan Anbazhagan mailto:anbazha...@hp.com>> From: devel@edk2.groups.io On Behalf Of Wu, Hao A via groups.io Sent: Monday, March 27, 2023 9:03 PM To: Albecki, Mateusz ; devel@edk2.groups.io Cc: Ni, Ray ; Chang, Hunter ; Anbazhagan, Baraneedharan Subject: Re: [edk2-devel] [

Re: [edk2-devel] [PATCH 0/1] MdeModulePkg/Ahci: Skip retry for non-transient errors

2023-03-26 Thread Anbazhagan, Baraneedharan via groups.io
to:devel@edk2.groups.io> mailto:devel@edk2.groups.io>> On Behalf Of Anbazhagan, Baraneedharan via groups.io Sent: Friday, March 24, 2023 12:55 AM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Wu, Hao A mailto:hao.a...@intel.com>>; Albecki, Mateusz mailto:mateusz.al

Re: [edk2-devel] [PATCH 0/1] MdeModulePkg/Ahci: Skip retry for non-transient errors

2023-03-23 Thread Anbazhagan, Baraneedharan via groups.io
Hi, This patch seems to resolve the issue reported in 4011 - MdeModulePkg: Need configurable AHCI command retries (tianocore.org) and verified with 'AHCI_COMMAND_RETRIES' as 5. Able to unlock the drive with correct password on 2nd attempt aft

[edk2-devel] MdeModulePkg/UefiBootManagerLib: Use hob size to process MemoryTypeInfo

2022-12-06 Thread Anbazhagan, Baraneedharan via groups.io
Current code relies on last entry in hob to be MaxMemoryType enum value which keeps changing on new memory type definition. If the HOB is created by binaries built with older Edk2, current code leads to hang which could be avoided by using hob size. Signed-off-by: Baraneedharan Anbazhagan anbazha

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/Ata: Fix command status reporting

2022-10-20 Thread Anbazhagan, Baraneedharan via groups.io
Below patch didn't resolve https://bugzilla.tianocore.org/show_bug.cgi?id=4011 since AhciRecoverPortError return success on incorrect drive password and continues with additional retries before returning to caller. From: Wu, Hao A Sent: Tuesday, October 18, 2022 8:37 PM To: Anbazhagan, Baraneed

[edk2-devel] [PATCH v2] MdeModulePkg: Use configurable PCD for AHCI command retries

2022-09-07 Thread Anbazhagan, Baraneedharan via groups.io
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4011 AHCI commands are retried internally which prevents platform feature like drive password to process correctly entered password on subsequent attempts. PCD allows the platform to determine the number of retries. Signed-off-by: Baraneedharan

[edk2-devel] MdeModulePkg: Use configurable PCD for AHCI command retries

2022-09-07 Thread Anbazhagan, Baraneedharan via groups.io
https://bugzilla.tianocore.org/show_bug.cgi?id=4011 AHCI commands are retried internally which prevents platform feature like drive password to process correctly entered password on subsequent attempts. PCD allows the platform to determine the number of retries. Signed-off-by: Baraneedharan Anbaz

Re: [edk2-devel] NetworkPkg: Fix invalid pointer for DNS response token on error

2021-11-24 Thread Anbazhagan, Baraneedharan via groups.io
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3719 Token->RspData.H2AData is de-allocated on error but it is not set to NULL. HTTP module attempts to free again and cause assert. Signed-off-by: Baraneedharan Anbazhagan anbazha...@hp.com --- NetworkPkg/DnsDxe/DnsIm

Re: [edk2-devel] [PATCH v2 009/105] .mailmap: Add an entry for Baraneedharan Anbazhagan

2019-12-07 Thread Anbazhagan, Baraneedharan via Groups.Io
Reviewed-by: Baraneedharan Anbazhagan -Original Message- From: Philippe Mathieu-Daude Sent: Friday, December 6, 2019 5:25 AM To: devel@edk2.groups.io Cc: Philippe Mathieu-Daude ; Anbazhagan, Baraneedharan Subject: [PATCH v2 009/105] .mailmap: Add an entry for Baraneedharan Anbazhagan