Re: [edk2-devel] Please re-open and review https://github.com/tianocore/edk2/pull/5701

2024-08-07 Thread Alexander D
Why is that bot even configured to close pull requests? It often takes months for some patches to get any attention here, so it seems counterintuitive. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120285): https://edk2.groups.io/g/deve

Re: [edk2-devel] [Question] How do you set PCIe host bridge address space granularity for a PCI host bridge defined with PciHostBridgeLib?

2024-07-29 Thread Alexander D
> > 1) when implementing PciHostBridgeLib, are we supposed to put host > addresses (address the CPU uses after translation) in the Mem/MemAbove4G > apertures or PCI/device addresses? (address the device uses before > translation) PCI_ROOT_BRIDGE_APERTURE is defined here: edk2/MdeModulePkg/Include

Re: [edk2-devel] [PATCH edk2-platforms 5/5] Platform/RaspberryPi: Drop platform specific EfiResetSystemLib

2024-07-25 Thread Alexander D
Shouldn't there be an alternative to gRaspberryPiEventResetGuid for the FVB driver? If you make changes to the var store then reset, pretty sure they'll be getting lost, right? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120039): htt

Re: [edk2-devel] [Question] How do you set PCIe host bridge address space granularity for a PCI host bridge defined with PciHostBridgeLib?

2024-07-24 Thread Alexander D
Btw, "EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR" is just a structure used across the codebase to represent an address space. It doesn't have anything to do with the ACPI tables if that was your impression. ACPI tables are only consumed by an OS. If you wish to have PCIe working there, you still have to

Re: [edk2-devel] [Question] How do you set PCIe host bridge address space granularity for a PCI host bridge defined with PciHostBridgeLib?

2024-07-24 Thread Alexander D
That's expected. All PCIe endpoints in your case have *non-prefetchable* 64-bit BARs. These can only reside below 4 GB, so EDK2 downgrades them to the 32-bit non-prefetchable aperture. If you had a device with a *prefetchable* 64-bit BAR (e.g. GPU VRAM), it would enumerate as "PMem64" and then