[edk2-devel] [PATCH v5 6/6] uefi-sct/SctPkg: TCG MORLOCK Locked with Key State Test

2024-04-08 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlLock Locked with Key State test cases -Add remaining Assertions 32 - 49 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTe

[edk2-devel] [PATCH v5 5/6] uefi-sct/SctPkg: TCG MORLOCK Locked No Key State Test

2024-04-08 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlLock Locked No Key State test cases -Add Assertions 21 - 31 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTest Cc: G Ed

[edk2-devel] [PATCH v5 4/6] uefi-sct/SctPkg: TCG MORLOCK Unlocked State Test

2024-04-08 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlLock Unlocked State test cases -Add Assertions 17, 18, 19, and 20 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTest Cc

[edk2-devel] [PATCH v5 3/6] uefi-sct/SctPkg: TCG MORLOCK SetVariable Test

2024-04-08 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlLockSetVariable test cases -Add Assertions 7 through 16 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTest Cc: G Edhaya

[edk2-devel] [PATCH v5 2/6] uefi-sct/SctPkg: TCG MOR SetVariable Test

2024-04-08 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlSetVariable test cases -Add Assertions 5 and 6 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTest Cc: G Edhaya Chandran

[edk2-devel] [PATCH v5 1/6] uefi-sct/SctPkg: TCG Platform Reset Check Test

2024-04-08 Thread Abhimanyu Singh
From: "Abhi.Singh" SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement initial test infrastructure for all test cases including updates to: CommonGenFramework.sh, UEFI_SCT.dsc, and Category.ini. -Add Guid.c and Guid.

[edk2-devel] [PATCH v5 0/6] EDK2-TEST TCG MOR Tests

2024-04-08 Thread Abhimanyu Singh
Updates after feedback from Sunny -updated several SCT assertion string outputs -these were done make the assertions more descriptive -fixed the issue in patch 5/6 that contained stray chars from a merge Patch series: These tests support platform firmware that implement MemoryOverwriteRequestCo

[edk2-devel] [PATCH v4 6/6] uefi-sct/SctPkg: TCG MORLOCK Locked with Key State Test

2024-03-05 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlLock Locked with Key State test cases -Add remaining Assertions 32 - 49 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTe

[edk2-devel] [PATCH v4 5/6] uefi-sct/SctPkg: TCG MORLOCK Locked No Key State Test

2024-03-05 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlLock Locked No Key State test cases -Add Assertions 21 - 31 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTest Cc: G Ed

[edk2-devel] [PATCH v4 3/6] uefi-sct/SctPkg: TCG MORLOCK SetVariable Test

2024-03-05 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlLockSetVariable test cases -Add Assertions 7 through 16 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTest Cc: G Edhaya

[edk2-devel] [PATCH v4 4/6] uefi-sct/SctPkg: TCG MORLOCK Unlocked State Test

2024-03-05 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlLock Unlocked State test cases -Add Assertions 17, 18, 19, and 20 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTest Cc

[edk2-devel] [PATCH v4 2/6] uefi-sct/SctPkg: TCG MOR SetVariable Test

2024-03-05 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlSetVariable test cases -Add Assertions 5 and 6 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTest Cc: G Edhaya Chandran

[edk2-devel] [PATCH v4 1/6] uefi-sct/SctPkg: TCG Platform Reset Check Test

2024-03-05 Thread Abhimanyu Singh
From: "Abhi.Singh" SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement initial test infrastructure for all test cases including updates to: CommonGenFramework.sh, UEFI_SCT.dsc, and Category.ini. -Add Guid.c and Guid.

[edk2-devel] [PATCH v4 0/6] EDK2-TEST TCG MOR Tests

2024-03-05 Thread Abhimanyu Singh
Updates after feedback from Heinrich -updated deprecated useage of HandleProtocol() to OpenProtocol(). -added checks for unexpected values for Step and CheckpointStep values. -added check if system fails to cold reset, returns EFI_DEVICE_ERROR. -cast Attributes to (UINTN) when passing to RecordAs

[edk2-devel] [PATCH v2 6/6] uefi-sct/SctPkg: TCG MORLOCK Locked with Key State Test

2023-09-21 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlLock Locked with Key State test cases -Add remaining Assertions 33 - 49 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTe

[edk2-devel] [PATCH v2 1/6] uefi-sct/SctPkg: TCG Platform Reset Check Test

2023-09-21 Thread Abhimanyu Singh
From: "Abhi.Singh" SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement initial test infrastructure for all test cases including updates to: CommonGenFramework.sh, UEFI_SCT.dsc, and Category.ini. -Add Guid.c and Guid.

[edk2-devel] [PATCH v2 3/6] uefi-sct/SctPkg: TCG MORLOCK SetVariable Test

2023-09-21 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlLockSetVariable test cases -Add Assertions 9 through 18 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTest Cc: G Edhaya

[edk2-devel] [PATCH v2 2/6] uefi-sct/SctPkg: TCG MOR SetVariable Test

2023-09-21 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlSetVariable test cases -Add Assertions 5, 6, 7, and 8 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTest Cc: G Edhaya Ch

[edk2-devel] [PATCH v2 5/6] uefi-sct/SctPkg: TCG MORLOCK Locked No Key State Test

2023-09-21 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlLock Locked No Key State test cases -Add Assertions 23 - 32 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTest Cc: G Ed

[edk2-devel] [PATCH v2 4/6] uefi-sct/SctPkg: TCG MORLOCK Unlocked State Test

2023-09-21 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlLock Unlocked State test cases -Add Assertions 19, 20, 21, and 22 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTest Cc

[edk2-devel] [PATCH v2 0/6] RESEND: TCG MemoryOverwriteRequest Tests

2023-09-21 Thread Abhimanyu Singh
Resending to Cc the reviewers These tests support platform firmware that implement MemoryOverwriteRequestControl & MemoryOverwriteRequestControlLock UEFI variables in accordance with TCG PC Platform Reset Attack Mitigation Specification. The 6 patches are split up according to the six sections do

[edk2-devel] [PATCH v2 6/6] uefi-sct/SctPkg: TCG MORLOCK Locked with Key State Test

2023-08-22 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlLock Locked with Key State test cases -Add remaining Assertions 33 - 49 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTe

[edk2-devel] [PATCH v2 1/6] uefi-sct/SctPkg: TCG Platform Reset Check Test

2023-08-22 Thread Abhimanyu Singh
From: "Abhi.Singh" SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement initial test infrastructure for all test cases including updates to: CommonGenFramework.sh, UEFI_SCT.dsc, and Category.ini. -Add Guid.c and Guid.

[edk2-devel] [PATCH v2 5/6] uefi-sct/SctPkg: TCG MORLOCK Locked No Key State Test

2023-08-22 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlLock Locked No Key State test cases -Add Assertions 23 - 32 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTest Cc: G Ed

[edk2-devel] [PATCH v2 3/6] uefi-sct/SctPkg: TCG MORLOCK SetVariable Test

2023-08-22 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlLockSetVariable test cases -Add Assertions 9 through 18 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTest Cc: G Edhaya

[edk2-devel] [PATCH v2 4/6] uefi-sct/SctPkg: TCG MORLOCK Unlocked State Test

2023-08-22 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlLock Unlocked State test cases -Add Assertions 19, 20, 21, and 22 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTest Cc

[edk2-devel] [PATCH v2 0/6] TCG MemoryOverwriteRequest Tests

2023-08-22 Thread Abhimanyu Singh
These tests support platform firmware that implement MemoryOverwriteRequestControl & MemoryOverwriteRequestControlLock UEFI variables in accordance with TCG PC Platform Reset Attack Mitigation Specification. The 6 patches are split up according to the six sections documented in the SCT spec linked

[edk2-devel] [PATCH v2 2/6] uefi-sct/SctPkg: TCG MOR SetVariable Test

2023-08-22 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlSetVariable test cases -Add Assertions 5, 6, 7, and 8 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTest Cc: G Edhaya Ch

Re: [edk2-devel] [PATCH V1 1/1] uefi-sct/SctPkg: RouteConfig() returns EFI_ACCESS_DENIED passes with warning

2023-08-22 Thread Abhimanyu Singh
Working BZ link: 3759 – SCT test fails when RouteConfig returns EFI_ACCESS_DENIED (tianocore.org) ( https://bugzilla.tianocore.org/show_bug.cgi?id=3759 ) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107959): https://edk2.groups.io/g/d

[edk2-devel] [PATCH V1 1/1] uefi-sct/SctPkg: RouteConfig() returns EFI_ACCESS_DENIED passes with warning

2023-08-22 Thread Abhimanyu Singh
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3759 HIIConfigAccess and HIIConfigRouting Protocol RouteConfig tests assertions store a failure when RouteConfig returns EFI_ACCESS_DENIED. In the UEFI SPEC RouteConfig in both protocols can return EFI_ACCESS_DENIED when the action violates a sys

[edk2-devel] [PATCH v1 0/1] TCG MemoryOverwriteRequest Tests

2023-08-17 Thread Abhimanyu Singh
These tests support platform firmware that implement MemoryOverwriteRequestControl & MemoryOverwriteRequestControlLock UEFI variables in accordance with TCG PC Platform Reset Attack Mitigation Specification. The first patch contains the Platform Reset Check Test that is defined in the SCT spec.

[edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: TCG MemoryOverwriteRequest

2023-08-17 Thread Abhimanyu Singh
From: "Abhi.Singh" SCT Platform Reset Check Test SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 Test: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement initial test infrastructure for all test cases including updates to: CommonGenFramework.sh, UEFI_SCT.dsc, and Ca

Re: [edk2-devel] 回复: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/Variable: TcgMorLockSmm Key Mismatch changes lock state

2023-07-09 Thread Abhimanyu Singh
Hi Liming and Michael, I have added the requested change, here is the PR: https://github.com/tianocore/edk2/pull/4546 Thanks, Abhi -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106747): https://edk2.groups.io/g/devel/message/106747 Mu

Re: [edk2-devel] [PATCH v2] MdeModulePkg/Variable: TcgMorLockSmm Key Mismatch changes lock state

2023-06-14 Thread Abhimanyu Singh
Hi Liming and Jian, Could you please review this patch? Michael has taken a look over and given Acked-by. Thanks, Abhi -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106089): https://edk2.groups.io/g/devel/message/106089 Mute This Topi

[edk2-devel] [PATCH v2] MdeModulePkg/Variable: TcgMorLockSmm Key Mismatch changes lock state

2023-06-12 Thread Abhimanyu Singh
From: Abhi Singh REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4410 REPO: https://github.com/tianocore/edk2/commit/7c9e1303fce5d49f8b597b4afd99ed855faaffaa Inside TcgMorLockSmm.c, the SetVariableCheckHandlerMorLock() function contains a scenario to prevent a possible dictionary attack

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/Variable: TcgMorLockSmm Key Mismatch changes lock state

2023-06-08 Thread Abhimanyu Singh
Jian and Liming, I was wondering if y'all could review this patch? It is a small change so hopefully there is not much downtime to review/test. Thank you, Abhi -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105957): https://edk2.groups

[edk2-devel] [PATCH v1 0/1] uefi-sct/SctPkg: TCGMOR SCT Test Implementation

2023-04-21 Thread Abhimanyu Singh
The TCG PC Client Platform Reset Attack Mitigation Spec v1.10 is based on UEFI Variables, and there should be a way to test for the variables and functionality based on the TCG specification. REF to Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 Proposed SCT spec: https://bugzilla

[edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: TCGMOR Platform Reset Check Test

2023-04-21 Thread Abhimanyu Singh
-implement initial test infrastructure for TCG MOR test cases including updates to: CommonGenFramework.sh, UEFI_SCT.dsc, and Category.ini -add initial TCG MOR Platform Reset Check Test -Test Assertion that checks if the platform creates the MOR EFI variable as in the TCG Platform Reset Mitiga

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/Variable: TcgMorLockSmm Key Mismatch changes lock state

2023-04-13 Thread Abhimanyu Singh
Working link to Bugzilla Ticket: 4410 – TcgMorLockSmm: Key Mismatch doesn't update the MorLock Variable Value. (tianocore.org) ( https://bugzilla.tianocore.org/show_bug.cgi?id=4410 ) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102958

[edk2-devel] [PATCH v1 1/1] MdeModulePkg/Variable: TcgMorLockSmm Key Mismatch changes lock state

2023-04-12 Thread Abhimanyu Singh
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4410 Inside TcgMorLockSmm.c, the SetVariableCheckHandlerMorLock() function contains a scenario to prevent a possible dictionary attack on the MorLock Key in accordance with the TCG Platform Reset Mitigation Spec v1.10. The mechanism to prevent t

[edk2-devel] [PATCH v1] uefi-sct: move Maintainers.txt to top level directory

2023-01-27 Thread Abhimanyu Singh
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4327 Maintainers.txt has been moved from under uefi-sct/ to the top level directory. This is consistent with other TianoCore repos in which Maintainers.txt is in the top level directory. Now under edk2-test/ Cc: G Edhaya Chandran Cc: Barton Gao

[edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: update path to edk2-test-parser, check for repo

2023-01-26 Thread Abhimanyu Singh
buildzip.sh was referencing the obsolete sct_parser project which has been replaced with edk2-test-parser. The script now checks for the edk2-test-parser repo in $pwd, if not present then the script exits and reminds the user to clone edk2-test-parser. Now the script copies edk2-test-parser/* recu

[edk2-devel] [PATCH v1 0/1] update path to edk2-test-parser, checks for repo

2023-01-26 Thread Abhimanyu Singh
buildzip.sh was referencing the obsolete sct_parser project which has been replaced with edk2-test-parser. The script now checks for the edk2-test-parser repo in $pwd, if not present then the script exits and reminds the user to clone edk2-test-parser. Now the script copies edk2-test-parser/* re