[edk2-devel] [edk2-platforms][PATCH v2 4/5] JadePkg: Add PlatformBmcReadyLib to support BMC ready check

2024-08-06 Thread Nhi Pham via groups.io
This adds the PlatformBmcReadyLib library instance, which provides a function to check whether the BMC is ready for transaction or not. The function checks the GPIO pin specified by the PcdBmcReadyGpio PCD and returns TRUE if the pin is set to a logic high level, indicating that the BMC is ready.

[edk2-devel] [edk2-platforms][PATCH v2 5/5] Ampere/Jade: Enable IPMI SSIF

2024-08-06 Thread Nhi Pham via groups.io
This adds the building of IPMI SSIf and associated modules. Signed-off-by: Nhi Pham --- Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 23 Platform/Ampere/JadePkg/Jade.dsc | 2 ++ Platform/Ampere/JadePkg/Jade.fdf | 17

[edk2-devel] [edk2-platforms][PATCH v2 3/5] AmpereAltraPkg: Add SmbusHc PEI and DXE drivers

2024-08-06 Thread Nhi Pham via groups.io
This adds the implementation of SMBUS PPI and Protocol to produce SMBUS interface in both PEI and DXE phases for use by IPMI SSIF. Signed-off-by: Nhi Pham --- Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.inf | 43 +++ Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.inf |

[edk2-devel] [edk2-platforms][PATCH v2 2/5] AmpereSiliconPkg: Define PCDs for SMBUS and BMC

2024-08-06 Thread Nhi Pham via groups.io
This introduces fixed PCDs for SMBUS and BMC as specified to Ampere. Signed-off-by: Nhi Pham --- Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec b/Silic

[edk2-devel] [edk2-platforms][PATCH v2 1/5] AmpereAltraPkg/DwI2cLib: Add support for SMBUS+PEC operation

2024-08-06 Thread Nhi Pham via groups.io
This introduces two input parameters to the I2cProbe() and updates the InternalI2cRead() for the support of the SMBUS operation with optional PEC check, which will be used by the IPMI SSIF driver. Signed-off-by: Nhi Pham --- Silicon/Ampere/AmpereAltraPkg/Include/Library/I2cLib.h |

[edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

2024-08-06 Thread Nhi Pham via groups.io
This updates the I2C library and implements SMBUS PEI/DXE drivers to support IPMI SSIF in the Mt. Jade platform. v2: - Refine the changes of the DwI2cLib per Leif's comments and update the commit message accordingly. - Remove the additional PCD PcdBmcSlaveAddr since it's is unused. NOTE: Regard

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Wednesday, August 7, 2024 #cal-reminder

2024-08-06 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Wednesday, August 7, 2024 5:30pm to 6:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-

Re: [edk2-devel] [PATCH edk2-platforms v3 0/1] Move to the GitHub Pull Request workflow

2024-08-06 Thread Michael D Kinney
I have sent invites. They have to respond to invite. Mike > -Original Message- > From: Rebecca Cran > Sent: Tuesday, August 6, 2024 1:56 PM > To: Kinney, Michael D ; devel@edk2.groups.io; > Leif Lindholm ; Kubacki, Michael > > Subject: Re: [edk2-devel] [PATCH edk2-platforms v3 0/1] Mov

Re: [edk2-devel] [PATCH edk2-platforms v3 0/1] Move to the GitHub Pull Request workflow

2024-08-06 Thread Rebecca Cran
Ah, thanks. Also, could someone with admin rights please update permissions on edk2-platforms so the following maintainers have write access to edk2-platforms please? @zailiangsun @yqian4 @benjamindoron @jackpot51 @BobCF @JohnAZoidberg -- Rebecca On 8/6/2024 1:14 PM, Kinney, Michael

Re: [edk2-devel] [PATCH edk2-platforms v3 0/1] Move to the GitHub Pull Request workflow

2024-08-06 Thread Michael D Kinney
I suspect you will run into the same permissions issues that required the use of a GitHub App credentials to run the AssignReviewers.yml. See this change for reference: https://github.com/tianocore/edk2/pull/6050 Mike > -Original Message- > From: Rebecca Cran > Sent: Tuesday,

Re: [edk2-devel] [PATCH edk2-platforms v3 0/1] Move to the GitHub Pull Request workflow

2024-08-06 Thread Rebecca Cran
Could I get some reviews on this please? -- Rebecca On 8/1/24 3:43 PM, Rebecca Cran wrote: Changes from v2 to v3: Added note to AssignReviewers.yml to say where it was copied from. Sorted platforms in CODEOWNERS and REVIEWERS alphabetically. Sorted entries in CONTRIBUTORS.md by first name.

[edk2-devel] [PATCH] IntelSiliconPkg: Add IgdOpRegion32.h to support IGD OpRegion v3.2

2024-08-06 Thread Ck, Chitralekha
- Backlight related fields in MBOX2 has uncalibrated brightness support - Valid Bit added for BCL in MBOX2 Signed-off-by: Ck, Chitralekha Cc: Rangasai V Chaganty Cc: Ashraf Ali S Cc: Ray Ni --- .../Include/IndustryStandard/IgdOpRegion32.h | 58 +++ 1 file changed, 58 insertio

Re: [edk2-devel] [PATCH] IntelSiliconPkg: Add IgdOpRegion32.h to support IGD OpRegion v3.2

2024-08-06 Thread Ck, Chitralekha
PR : https://github.com/tianocore/edk2-platforms/pull/177 -Original Message- From: Ck, Chitralekha Sent: Tuesday, August 6, 2024 11:01 AM To: devel@edk2.groups.io Cc: Ck, Chitralekha ; Ck; Chaganty, Rangasai V ; S, Ashraf Ali ; Ni, Ray Subject: [PATCH] IntelSiliconPkg: Add IgdOpRegi

[edk2-devel] [PATCH] IntelSiliconPkg: Add IgdOpRegion32.h to support IGD OpRegion v3.2

2024-08-06 Thread Ck, Chitralekha
- Backlight related fields in MBOX2 has uncalibrated brightness support - Valid Bit added for BCL in MBOX2 Signed-off-by: Ck, Chitralekha Cc: Rangasai V Chaganty Cc: Ashraf Ali S Cc: Ray Ni --- .../Include/IndustryStandard/IgdOpRegion32.h | 58 +++ 1 file changed, 58 insertio

Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec

2024-08-06 Thread Leif Lindholm
On Thu, Aug 01, 2024 at 10:19:50 -0500, Jeremy Linton wrote: > Hi, > > > On 8/1/24 09:44, Ard Biesheuvel wrote: > > On Thu, 1 Aug 2024 at 16:11, Ard Biesheuvel wrote: > > > > > > On Thu, 1 Aug 2024 at 15:49, Jeremy Linton wrote: > > > > > > > > Hi, > > > > > > > > On 7/31/24 11:33, Ard Biesh

Re: [edk2-devel] [PATCH edk2-platforms 1/2] Platform AARCH64: Move PrePeiCore users to Sec.inf

2024-08-06 Thread Leif Lindholm
On Mon, Aug 05, 2024 at 21:14:33 +0200, Marcin Juszkiewicz wrote: > On 31.07.2024 18:33, Ard Biesheuvel wrote: > > PrePeiCore has been superseded by Sec.inf, which is a more common naming > > for the SEC module, aligned with other architectures. No functional > > changes intended. > > > > Switch a

Re: [edk2-devel] Migrating edk2-libc to use GitHub PR review process

2024-08-06 Thread Rebecca Cran
On 8/6/2024 3:10 AM, Jayaprakash, N wrote: Hi Rebecca, Mike suggested me to talk to you to see the possibility of getting edk2-libc repo to the GitHub PR review process. It’s a relatively small repo with few contributors. Would like to understand what it takes to migrate to the new process?

[edk2-devel] Migrating edk2-libc to use GitHub PR review process

2024-08-06 Thread Jayaprakash, N
Hi Rebecca, Mike suggested me to talk to you to see the possibility of getting edk2-libc repo to the GitHub PR review process. It's a relatively small repo with few contributors. Would like to understand what it takes to migrate to the new process? Would you be able to help in this migration? R

Re: [edk2-devel] [tianocore/edk2] Tools and CI Meeting - Date 8/5 (Discussion #6047)

2024-08-06 Thread Rebecca Cran
> > Current status of enabling PRs in edk2-platforms > Last week's update: #6001 (comment) > "Sent patch to create CODEOWNERS, REVIEWERS, CONTRIBUTORS and the GitHub workflow script to assign reviewers, currently waiting for people to review it." > @bcran - C