[edk2-devel] [PATCH] CryptoPkg: BaseCryptLib: ASN1_get_object() function return value is not checked properly in CryptX509.c.

2024-03-18 Thread Sountharya N via groups.io
Added Inf variable, and the error case returned value was checked properly. --- CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c b/CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c ind

Re: [edk2-devel] [PATCH 1/3] CryptoPkg/BaseCryptLib: add additional RSAEP-OAEP crypto functions

2024-03-18 Thread Li, Yi
Hi Chris, 1. Please create a feature request BugZilla to introduce the background of the new API, such as purpose and application scenarios. 2. I took a quick look, the new API will make Pkcs1v2De/Encrypt support RsaContext input and the rest is same as old API right? Regards, Yi -Original

Re: [edk2-devel] [PATCH v1 21/26] OvmfPkg/LoongArchVirt: Add FdtQemuFwCfgLib

2024-03-18 Thread Chao Li
Hi Gerd, Thanks, Chao On 2024/3/18 23:28, Gerd Hoffmann wrote: On Sat, Mar 16, 2024 at 10:17:00AM +0800, lixianglai wrote: Hi Gerd: On Mon, Mar 11, 2024 at 02:39:31AM -0700, Chao Li wrote: This library for PEI phase, and obtains the QemuFwCfg base address by directly parsing the FDT, reads a

Re: [edk2-devel] [PATCH v1 20/26] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib

2024-03-18 Thread Chao Li
Hi Gerd, Thanks, Chao On 2024/3/18 23:21, Gerd Hoffmann wrote: On Sat, Mar 16, 2024 at 06:19:00PM +0800, lixianglai wrote: Hi Gerd: On Mon, Mar 11, 2024 at 02:39:24AM -0700, Chao Li wrote: Add NorFlashQemuLib for LoongArch, it is referenced from ArmVirtPkg. What are the differences to the A

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, March 19, 2024 #cal-reminder

2024-03-18 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, March 19, 2024 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4e

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, March 18, 2024 #cal-notice

2024-03-18 Thread Group Notification
*Tools, CI, Code base construction meeting series* *When:* Monday, March 18, 2024 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f988bf-86f1

[edk2-devel] [PATCH 3/3] CryptoPkg/BaseCryptLibUnitTest: add unit test functions

2024-03-18 Thread Chris Ruffin via groups.io
From: Chris Ruffin Add unit test functions: TestVerifyPkcs1v2Decrypt() TestVerifyTestRsaOaepEncrypt() TestVerifyTestRsaOaepDecrypt() Signed-off-by: Chris Ruffin Cc: Jiewen Yao Cc: Yi Li Cc: Wenxing Hou --- .../Library/BaseCryptLib/OaepEncryptTests.c | 184 +- 1 file change

[edk2-devel] [PATCH 2/3] CryptoPkg/Driver: add additional RSAEP-OAEP crypto functions

2024-03-18 Thread Chris Ruffin via groups.io
From: Chris Ruffin Add new library members to CryptoPkg/Driver. Signed-off-by: Chris Ruffin Cc: Jiewen Yao Cc: Yi Li Cc: Wenxing Hou --- CryptoPkg/Driver/Crypto.c | 116 +- .../Pcd/PcdCryptoServiceFamilyEnable.h| 3 + .../BaseCryptLibOnProtocolP

[edk2-devel] [PATCH 1/3] CryptoPkg/BaseCryptLib: add additional RSAEP-OAEP crypto functions

2024-03-18 Thread Chris Ruffin via groups.io
From: Chris Ruffin Expand the availability of the RSAEP-OAEP crypto capability in BaseCryptLib. Applications using RSA crypto functions directly from OpensslLib can transition to BaseCryptLib to take advantage of the shared crypto feature in CryptoDxe. Pkcs1v2Decrypt(): decryption using DER-enc

[edk2-devel] [PATCH] Package/Module: edk2-platforms\Features\Intel\UserInterface\UserAuthFeaturePkg

2024-03-18 Thread Nayana Patel
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4645 Clear out the variable SmmCommunicateSetPassword which contains password before goto Exit. To avoid vulnerability. Signed-off-by: Nayana Patel --- .../UserAuthenticationDxeSmm/UserAuthenticationSmm.c| 2 ++ 1 file changed, 2 i

[edk2-devel] [PATCH] REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4650

2024-03-18 Thread V V, Pranav
sPasswordStrong checks for password complexity requirements. It does bare minimal checking for existence of uppercase, lowercase, numeral, and symbol. A password with repeating characters would be an acceptable password, such as 1!Aa.IsPasswordInHistory checks if the password hash of the pas

[edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: Revert "ProcessLibraryConstructorList()"

2024-03-18 Thread brucex . wang
From: Bruce Wang This reverts commit 1c0db2315109233e77e6b5a52704d14550dcba3c That commit cause a build error "ProcessLibraryConstructorList undefined" in FitUniversalPayloadEntry.c Cc: Gua Guo Cc: Guo Dong Cc: James Lu Cc: Sean Rhodes Signed-off-by: BruceX Wang --- .../UefiPayloadEntry/

[edk2-devel] [PATCH v1 0/1] Revert "ProcessLibraryConstructorList()

2024-03-18 Thread brucex . wang
From: Bruce Wang This reverts commit 1c0db2315109233e77e6b5a52704d14550dcba3c That commit caused debug messages to be missing in FitUniversalPayload.c. Bruce Wang (1): UefiPayloadPkg: Revert "ProcessLibraryConstructorList()" .../UefiPayloadEntry/FitUniversalPayloadEntry.inf | 2 +- Ue

[edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: Cleanup ProcessLibraryConstructorList()

2024-03-18 Thread brucex . wang
From: Bruce Wang ProcessLibraryConstructorList() no needs to be called manually after INF version greater or equal to 1.30. Cc: Guo Dong Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: BruceX Wang --- UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.c | 2 -- UefiPayloadPk

[edk2-devel] [PATCH v1 0/1] Cleanup ProcessLibraryConstructorList()

2024-03-18 Thread brucex . wang
From: Bruce Wang ProcessLibraryConstructorList() no needs to be called manually after INF version greater or equal to 1.30. Bruce Wang (1): UefiPayloadPkg: Cleanup ProcessLibraryConstructorList() UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.c | 2 -- UefiPayloadPkg/UefiPayloadEnt

[edk2-devel] [PATCH 3/3] CryptoPkg/BaseCryptLibUnitTest: add unit test functions

2024-03-18 Thread Chris Ruffin via groups.io
From: Chris Ruffin Add unit test functions: TestVerifyPkcs1v2Decrypt() TestVerifyTestRsaOaepEncrypt() TestVerifyTestRsaOaepDecrypt() Signed-off-by: Chris Ruffin Cc: Jiewen Yao Cc: Yi Li Cc: Wenxing Hou --- .../Library/BaseCryptLib/OaepEncryptTests.c | 184 +- 1 file change

[edk2-devel] [PATCH 2/3] CryptoPkg/Driver: add additional RSAEP-OAEP crypto functions

2024-03-18 Thread Chris Ruffin via groups.io
From: Chris Ruffin Add new library members to CryptoPkg/Driver. Signed-off-by: Chris Ruffin Cc: Jiewen Yao Cc: Yi Li Cc: Wenxing Hou --- CryptoPkg/Driver/Crypto.c | 116 +- .../Pcd/PcdCryptoServiceFamilyEnable.h| 3 + .../BaseCryptLibOnProtocolP

[edk2-devel] [PATCH 1/3] CryptoPkg/BaseCryptLib: add additional RSAEP-OAEP crypto functions

2024-03-18 Thread Chris Ruffin via groups.io
From: Chris Ruffin Expand the availability of the RSAEP-OAEP crypto capability in BaseCryptLib. Applications using RSA crypto functions directly from OpensslLib can transition to BaseCryptLib to take advantage of the shared crypto feature in CryptoDxe. Pkcs1v2Decrypt(): decryption using DER-enc

Re: [edk2-devel] [PATCH 1/2] OvmfPkg: Add VirtHstiDxe driver

2024-03-18 Thread Konstantin Kostiuk
On Thu, Mar 14, 2024 at 12:28 PM Yao, Jiewen wrote: > Question: What is the value to provide an *empty* HSTI table? > > IMHO, If the goal is to perform some security check, I think we need > provide a *real* HSTI table. > HSTI is very vendor-specific and depends on features that a vendor support

[edk2-devel] [PATCH 2/2] OvmfPkg: Add VirtHstiDxe to OVMF firmware build

2024-03-18 Thread Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk --- OvmfPkg/OvmfPkgIa32.dsc| 2 ++ OvmfPkg/OvmfPkgIa32.fdf| 1 + OvmfPkg/OvmfPkgIa32X64.dsc | 2 ++ OvmfPkg/OvmfPkgIa32X64.fdf | 1 + OvmfPkg/OvmfPkgX64.dsc | 2 ++ OvmfPkg/OvmfPkgX64.fdf | 1 + 6 files changed, 9 insertions(+) diff --git a/OvmfP

[edk2-devel] [PATCH 1/2] OvmfPkg: Add VirtHstiDxe driver

2024-03-18 Thread Konstantin Kostiuk
The driver provides empty HSTI table. Signed-off-by: Konstantin Kostiuk --- OvmfPkg/VirtHstiDxe/VirtHstiDxe.c | 75 + OvmfPkg/VirtHstiDxe/VirtHstiDxe.inf | 64 2 files changed, 139 insertions(+) create mode 100644 OvmfPkg/VirtHstiDxe/VirtHs

[edk2-devel] [PATCH 0/2] OvmfPkg: Implement minimal HSTI driver

2024-03-18 Thread Konstantin Kostiuk
Resolve: https://issues.redhat.com/browse/RHEL-28751 HSTI (Hardware Security Test Interface) table is a requiremnt for ont test [1] from Microsoft Server Virtualization Validation Program. HSTI is a UEFI driver that provides a way to query the platform for the presence of security features. Curre

Re: [edk2-devel] [PATCH] NanhuDev:Add BOSC NanhuDev platform

2024-03-18 Thread Ran Wang
Add Leif and Michael to cc list Hi Sunil, On 2024/3/14 13:28, Sunil V L wrote: Hi Ran, On Mon, Mar 11, 2024 at 12:29:53PM +0800, Ran Wang wrote: Hi Sunil, On 2024/3/8 19:44, Sunil V L wrote: On Fri, Mar 08, 2024 at 12:31:26AM -0800, WangYang wrote: Hi,Sunil V L How about this status

Re: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo description details

2024-03-18 Thread Pethaiyan, Madhan
Hi Mike , I had raised new code review addressing the coding standard errors and those were not part of my change any way .. Thanks, P. Madhan -Original Message- From: Kinney, Michael D Sent: Sunday, March 10, 2024 1:47 AM To: devel@edk2.groups.io; Pethaiyan, Madhan Cc: Liming Gao ;

[edk2-devel] [PATCH V1 1/3] FmpDevicePkg: GetImageInfo Add missing conditions

2024-03-18 Thread Pethaiyan Madhan
1.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImage(): Add the following sentence at the end of the Image parameter description. "May be NULL with a zero ImageSize in order to determine the size of the buffer needed". Modify the description of "EFI_INVALID_PARAMETER" return code as "The ImageSize is n

[edk2-devel] [PATCH V1 3/3] SignedCapsulePkg: Update GetImage and GetImageInfo description details

2024-03-18 Thread Pethaiyan Madhan
1.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImage(): Add the following sentence at the end of the Image parameter description. "May be NULL with a zero ImageSize in order to determine the size of the buffer needed". Modify the description of "EFI_INVALID_PARAMETER" return code as "The ImageSize is n

[edk2-devel] [PATCH V1 2/3] MdePkg: Update GetImage , GetImageInfo description details

2024-03-18 Thread Pethaiyan Madhan
1.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImage(): Add the following sentence at the end of the Image parameter description. "May be NULL with a zero ImageSize in order to determine the size of the buffer needed". Modify the description of "EFI_INVALID_PARAMETER" return code as "The ImageSize is n

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, March 18, 2024 #cal-reminder

2024-03-18 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, March 18, 2024 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f

Re: [edk2-devel] [PATCH v2 6/6] uefi-sct/SctPkg: TCG2 Protocol: add SubmitCommand test

2024-03-18 Thread Sunny Wang
Looks good to me. For others' reference, the change has been already verified by running SystemReady SIE (Security Interface extension) tests on multiple SystemReady certified Arm systems. Reviewed-by: Sunny Wang -Original Message- From: devel@edk2.groups.io On Behalf Of Stuart Yoder v

Re: [edk2-devel] [PATCH v2 5/6] uefi-sct/SctPkg: TCG2 Protocol: add GetEventLog test

2024-03-18 Thread Sunny Wang
Looks good to me. For others' reference, the change has been already verified by running SystemReady SIE (Security Interface extension) tests on multiple SystemReady certified Arm systems. Reviewed-by: Sunny Wang -Original Message- From: devel@edk2.groups.io On Behalf Of Stuart Yoder v

Re: [edk2-devel] [PATCH v2 4/6] uefi-sct/SctPkg: TCG2 Protocol: add HashLogExtendEvent test

2024-03-18 Thread Sunny Wang
Looks good to me. For others' reference, the change has been already verified by running SystemReady SIE (Security Interface extension) tests on multiple SystemReady certified Arm systems. Reviewed-by: Sunny Wang -Original Message- From: devel@edk2.groups.io On Behalf Of Stuart Yoder v

Re: [edk2-devel] [PATCH v2 3/6] uefi-sct/SctPkg: TCG2 Protocol: add GetActivePcrBanks test

2024-03-18 Thread Sunny Wang
Looks good to me. For others' reference, the change has been already verified by running SystemReady SIE (Security Interface extension) tests on multiple SystemReady certified Arm systems. Reviewed-by: Sunny Wang -Original Message- From: devel@edk2.groups.io On Behalf Of Stuart Yoder v

Re: [edk2-devel] [PATCH v2 2/6] uefi-sct/SctPkg: TCG2 Protocol: add test infrastructure and GetCapability Test

2024-03-18 Thread Sunny Wang
Looks good to me. For others' reference, the change has been already verified by running SystemReady SIE (Security Interface extension) tests on multiple SystemReady certified Arm systems. Reviewed-by: Sunny Wang -Original Message- From: devel@edk2.groups.io On Behalf Of Stuart Yoder v

Re: [edk2-devel] [PATCH v2 1/6] uefi-sct/SctPkg: TCG2 Protocol: add header with TCG2 protocol definitions

2024-03-18 Thread Sunny Wang
Looks good to me. For others' reference, the change has been already verified by running SystemReady SIE (Security Interface extension) tests on multiple SystemReady certified Arm systems. Reviewed-by: Sunny Wang -Original Message- From: devel@edk2.groups.io On Behalf Of Stuart Yoder v

[edk2-devel] [PATCH] SecurityPkg/Tcg2Config: Hide BIOS unsupported hash algorithm from UI

2024-03-18 Thread Xu, Wei6
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4731 TCG2 configuration UI shows all the hash algorithms that TPM hardware supports in the checkbox. If user only selects one algorithm that is supported by TPM hardware but not supported by BIOS and uncheck the others, the SyncPcrAllocationsAndP

Re: [edk2-devel] [PATCH v1 21/26] OvmfPkg/LoongArchVirt: Add FdtQemuFwCfgLib

2024-03-18 Thread Gerd Hoffmann
On Sat, Mar 16, 2024 at 10:17:00AM +0800, lixianglai wrote: > Hi Gerd: > > On Mon, Mar 11, 2024 at 02:39:31AM -0700, Chao Li wrote: > >> This library for PEI phase, and obtains the QemuFwCfg base address by > >> directly parsing the FDT, reads and writes the data in QemuFwCfg by > >> operating on t

Re: [edk2-devel] [PATCH v1 20/26] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib

2024-03-18 Thread Gerd Hoffmann
On Sat, Mar 16, 2024 at 06:19:00PM +0800, lixianglai wrote: > Hi Gerd: > > On Mon, Mar 11, 2024 at 02:39:24AM -0700, Chao Li wrote: > >> Add NorFlashQemuLib for LoongArch, it is referenced from ArmVirtPkg. > > What are the differences to the ArmVirtPkg version? > In this lib we have assigned the fo

Re: [edk2-devel] [PATCH v4 1/4] MdePkg.dec: RISC-V: Define override bit for Svpbmt extension

2024-03-18 Thread Sunil V L
On Thu, Mar 14, 2024 at 01:19:14PM -0700, Tuan Phan wrote: > Define the BIT 2 as the override bit for Svpbmt extension. This will > be used by RISC-V MMU library to support EFI_MEMORY_UC and > EFI_MEMORY_WC. > Reviewed-by: Sunil V L -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messa

Re: [edk2-devel] [PATCH v4 4/4] OvmfPkg/RiscVVirt: Disable Svpbmt extension

2024-03-18 Thread Sunil V L
On Thu, Mar 14, 2024 at 01:19:17PM -0700, Tuan Phan wrote: > Disable Svpbmt extension as QEMU not enables it in default config. > Reviewed-by: Sunil V L -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116840): https://edk2.groups.io/g/de

Re: [edk2-devel] [PATCH v4 3/4] UefiCpuPkg: RISC-V: MMU: Support Svpbmt extension

2024-03-18 Thread Sunil V L
Hi Tuan, On Thu, Mar 14, 2024 at 01:19:16PM -0700, Tuan Phan wrote: > The GCD EFI_MEMORY_UC and EFI_MEMORY_WC memory attributes will be > supported when Svpbmt extension available. > > Cc: Gerd Hoffmann > Cc: Laszlo Ersek > Cc: Rahul Kumar > Cc: Ray Ni > Signed-off-by: Tuan Phan > --- > ...

Re: [edk2-devel] [PATCH] uefi-sct/SctPkg:Enhance BBTestReadKeyStrokeExFunctionAutoTestCheckpoint1()

2024-03-18 Thread G Edhaya Chandran
The patch is up streamed by the below commit: https://github.com/tianocore/edk2-test/commit/032822757792c5d4d0bfed1fd8524e69ef4f2d17 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116838): https://edk2.groups.io/g/devel/message/116838 Mut

Re: [edk2-devel] [PATCH v1 1/1] MdePkg/BaseLib: Fix AARCH64 compilation error

2024-03-18 Thread levi.yun
I think it would be nice if you add diff --git a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S index 3e58119b25d2..505d3765c522 100644 --- a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S +++ b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.

[edk2-devel] [PATCH] IntelFsp2Pkg/Tools: Updated iterator usage for Python 3 compatibility

2024-03-18 Thread Zhiguang Liu
Updated iterator usage for Python 3 compatibility Cc: Chasel Chiu Cc: Nate DeSimone Cc: Duggapu Chinni B Cc: Star Zeng Cc: Ted Kuo Cc: Ashraf Ali S Cc: Susovan Mohapatra Signed-off-by: Zhiguang Liu --- IntelFsp2Pkg/Tools/PatchFv.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[edk2-devel] [PATCH] IntelFsp2Pkg/Tools: Let PatchFv support to get Image Base.

2024-03-18 Thread Zhiguang Liu
Now, the value params of PatchFv support below value getting from map file: ModuleName:FunctionName ModuleName:GlobalVariableName ModuleGuid:Offset This patch add a new type ModuleName:KeyWord KeyWord now supports "BASE", indicating the address of the Image base. For example, ModuleName:BASE