Re: [edk2-devel] [PATCH v2] IntelFsp2WrapperPkg: Error handling of FspmWrapperInit()

2024-03-13 Thread Ashraf Ali S
Reviewed-by: S, Ashraf Ali Thanks., S, Ashraf Ali -Original Message- From: Ni, Ray Sent: Thursday, March 14, 2024 8:22 AM To: devel@edk2.groups.io; Lin, Du Cc: S, Ashraf Ali ; Chiu, Chasel ; Chen, Gang C ; Duggapu, Chinni B ; Desimone, Nathaniel L ; Zeng, Star ; Mohapatra, Susovan

Re: [edk2-devel] [PATCH] NanhuDev:Add BOSC NanhuDev platform

2024-03-13 Thread Sunil V L
Hi Ran, On Mon, Mar 11, 2024 at 12:29:53PM +0800, Ran Wang wrote: > Hi Sunil, > > On 2024/3/8 19:44, Sunil V L wrote: > > On Fri, Mar 08, 2024 at 12:31:26AM -0800, WangYang wrote: > > > Hi,Sunil V L > > > > > > How about this status. > > > > > > > > > > -原始邮件- > > > > 发件人: WangYan

[edk2-devel] [PATCH v3 4/4] DynamicTablesPkg: Adds ACPI SSDT HPET Table generator

2024-03-13 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar Adds generic ACPI SSDT HPET table generator library. Register/Deregister HPET table. Adds ACPI namespace object for HPET device. Adds Address space for HPET device. Cc: Sami Mujawar Cc: Pierre Gondois Signed-off-by: Abdul Lateef Attar --- DynamicTablesPkg/DynamicTabl

[edk2-devel] [PATCH v3 3/4] DynamicTablesPkg: Adds ACPI WSMT Table generator

2024-03-13 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar Adds generic ACPI WSMT table generator library. Register/Deregister WSMT table. Update the WSMT table during boot as per specification. Cc: Sami Mujawar Cc: Pierre Gondois Signed-off-by: Abdul Lateef Attar --- DynamicTablesPkg/DynamicTables.dsc.inc| 2 + Dy

[edk2-devel] [PATCH v3 1/4] DynamicTablesPkg: Adds ACPI FADT Table generator

2024-03-13 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar Adds generic ACPI FADT table generator library. Register/Deregister FADT table. Adds Arch namespace ids. Update the FADT table during boot as per specification. Cc: Sami Mujawar Cc: Pierre Gondois Signed-off-by: Abdul Lateef Attar --- DynamicTablesPkg/DynamicTables.d

[edk2-devel] [PATCH v3 2/4] DynamicTablesPkg: Adds ACPI HPET Table generator

2024-03-13 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar Adds generic ACPI HPET table generator library. Register/Deregister HPET table. Update the HPET table during boot as per specification. Cc: Sami Mujawar Cc: Pierre Gondois Signed-off-by: Abdul Lateef Attar --- DynamicTablesPkg/DynamicTables.dsc.inc| 2 + Dy

[edk2-devel] [PATCH v3 0/4] Adds generic FADT, HPET and WSMT table generators

2024-03-13 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar PR: https://github.com/tianocore/edk2/pull/5468 V3: delta changes Restructure the code as the review comments. Added sanity check for WSMT flags. Added CM object for HPET base address. V2: delta changes Addressed review comments Adds ACPI HPET table to add HPET

Re: [edk2-devel] [PATCH v2] IntelFsp2WrapperPkg: Error handling of FspmWrapperInit()

2024-03-13 Thread Ni, Ray
Reviewed-by: Ray Ni Thanks, Ray > -Original Message- > From: devel@edk2.groups.io On Behalf Of Du Lin > Sent: Thursday, March 14, 2024 10:02 AM > To: devel@edk2.groups.io > Cc: Lin, Du ; S, Ashraf Ali ; Chiu, > Chasel ; Chen, Gang C ; > Duggapu, Chinni B ; Desimone, Nathaniel L > ; Zeng,

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Error handling of FspmWrapperInit()

2024-03-13 Thread Du Lin
This patch has been updated to address Ray's comment. For more details, please check [PATCH v2] IntelFsp2WrapperPkg: Error handling of FspmWrapperInit() (groups.io) ( https://edk2.groups.io/g/devel/message/116723 ). Thanks Ray for the comment. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You recei

Re: [edk2-devel] [PATCH v1 00/26] Part 2 patch set to enable LoongArch virtual machine in edk2

2024-03-13 Thread Chao Li
Hi All, I submitted this version a few days ago and any comments are very welcome, can you review this series? Thanks, Chao On 2024/3/11 17:36, Chao Li wrote: This patch set is the part 2 of enable LoongArch virtual machine and is a continuation of the first patch series v8 submitted at: htt

[edk2-devel] [PATCH v2] IntelFsp2WrapperPkg: Error handling of FspmWrapperInit()

2024-03-13 Thread Du Lin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4701 The error handling of FspmWrapperInit() is limited to ASSERT statements only, which only works in debug builds, but not in release builds. Fix the issue by enhancing the error handling of FspmWrapperInit() to cover both debug builds and rele

Re: [edk2-devel] [PATCH 0/4][edk2-redfish-client] RedfishClientPkg: fix deallocation of C-structures

2024-03-13 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Done. Thanks! > -Original Message- > From: Mike Maslenkin > Sent: Thursday, March 14, 2024 2:41 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nickle Wang > Subject: Re: [PATCH 0/4][edk2-redfish-client] RedfishClientPkg: fix > d

Re: [edk2-devel] [PATCH 0/4][edk2-redfish-client] RedfishClientPkg: fix deallocation of C-structures

2024-03-13 Thread Mike Maslenkin
On Sun, Mar 10, 2024 at 1:41 PM Mike Maslenkin wrote: > > This set contains fixes for proper deallocation of the structures > returned by JsonStructProtocol->ToStructure(). > > PR: https://github.com/tianocore/edk2-redfish-client/pull/82 > > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nickle Wa

Re: [edk2-devel][PATCH v3 0/3] Fix Runtime Granularity Issues

2024-03-13 Thread Oliver Smith-Denny
Hi Ray and Mike, Can you help get this patchset reviewed and merged? It contains a fix for a UEFI spec violation and it has been sitting on the mailing list for a month. Unfortunately Liming has not reviewed after weekly friendly pings and he is the only main level MdeModulePkg maintainer. Liming

Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes

2024-03-13 Thread Oliver Smith-Denny
Hi Liming, Friendly ping, can you please review this patchset? Thanks, Oliver On 3/11/2024 2:29 PM, Oliver Smith-Denny wrote: ImagePropertiesRecordLib is currently creating Image Records that are not accurate. It is setting the CodeSegmentSize to be the size of the raw data in the image file,

Re: [edk2-devel] [PATCH] AMD/AmdPlatformPkg: Update AMD Vangogh platform reference code

2024-03-13 Thread Yao, Ken via groups.io
[AMD Official Use Only - General] [AMD Official Use Only - General] Below changes are reviewed and verified. Reviewed-by: Ken Yao -Original Message- From: Zhai, MingXin (Duke) Sent: Tuesday, March 12, 2024 11:06 AM To: devel@edk2.groups.io Cc: Yao, Ken ; Fu, Igniculus ; Chang, Abner

[edk2-devel] [PATCH v1 1/1] BaseTools: InfBuildData: Fix Private value retrieval

2024-03-13 Thread Joey Vagedes via groups.io
Update retrieval of private guids, protocols, or ppis from a package's declaration file to use the original path of the module's INF file rather than the current path. When building the same module multiple times in the same INF (by override the define's FILE_GUID), a temporary instance of the modu

Re: [edk2-devel] [PATCH v2] DynamicTablesPkg/SSDT: Require Package node in hierarchy

2024-03-13 Thread Sami Mujawar
Merged at https://github.com/tianocore/edk2/commit/308e6e0936c43063551babb4a71c46775b1dc01c Thanks. Regards, Sami Mujawar On 12/03/2024, 16:14, "Sami Mujawar" mailto:sami.muja...@arm.com>> wrote: Hi Jeshua, Apologies, I somehow missed getting this merged. I will get this in before end of

Re: [edk2-devel] [PATCH 0/2] ArmPkg/MdePkg: Move Chipset/* files to MdePkg

2024-03-13 Thread PierreGondois
Hello Michael, On 3/12/24 17:53, Kinney, Michael D wrote: The MdePkg does have a standard location for CPU specific register related includes. Did you consider moving some of the content into * MdePkg/Include/Register/Arm * MdePkg/Include/Register/AArch64 Yes right, this should be a better l

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Error handling of FspmWrapperInit()

2024-03-13 Thread Ni, Ray
> - ASSERT (MeasurementExcludedFvPpi != NULL); > + if (MeasurementExcludedFvPpi == NULL) { > +ASSERT (FALSE); I prefer the original meaningful assertion instead of ASSERT (FALSE). Adding if-check is a good change to me. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent

Re: [edk2-devel] [PATCH v2 4/4] DynamicTablesPkg: Adds ACPI SSDT HPET Table generator

2024-03-13 Thread Abdul Lateef Attar via groups.io
Thanks Pierre for the review, I'll address the review comments. Please see inline for my reply On 11-03-2024 19:46, Pierre Gondois wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Hello Abdul, On 3/4

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/QemuBootOrderLib: Measure the etc/boot-menu-wait

2024-03-13 Thread sunceping
On Tuesday, March 12, 2024 7:04 PM Gerd Hoffmann wrote: > On Wed, Mar 13, 2024 at 07:51:46AM +0800, Ceping Sun wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4415 > > > > Refer to the section 8.3.4 of tdx-virtual-firmware-design-guide > > spec, OVMF would uses FW_CFG_IO_SELECTOR(0x

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/QemuBootOrderLib: Measure the etc/boot-menu-wait

2024-03-13 Thread sunceping
On Tuesday, March 12, 2024 3:58 PM Yao, Jiewen wrote: > Subject: RE: [PATCH V1 1/1] OvmfPkg/QemuBootOrderLib: Measure the > etc/boot-menu-wait > > Thanks for the patch. > > Is this the only missing configuration data? > Or do you have more on the way? > This is not the only missing configuratio

Re: [edk2-devel] [PATCH V1 1/3] MdePkg/BaseLib: Update TDVMCALL_EXPOSE_REGS_MASK

2024-03-13 Thread sunceping
@Liming Gao @Kinney, Michael D This patch has been submitted for review over two weeks. May I have your comments about the patch? Thanks Ceping > -Original Message- > From: Sun, CepingX > Sent: Monday, March 4, 2024 11:23 AM > To: Liming Gao ; Kinney, Michael D > ; devel@edk2.groups.io;

Re: [edk2-devel] [PATCH] AMD/AmdPlatformPkg: Update AMD Vangogh platform reference code

2024-03-13 Thread Xing, Eric via groups.io
[AMD Official Use Only - General] Below changes are reviewed and verified. Reviewed-by: Eric Xing > -Original Message- > From: Zhai, MingXin (Duke) > Sent: Tuesday, March 12, 2024 11:06 AM > To: devel@edk2.groups.io > Cc: Yao, Ken ; Fu, Igniculus ; > Chang, Abner ; Xing, Eric > Subjec