[edk2-devel] [PATCH v2 0/1] Add support for generating SRAT tables

SbsaQemu can configure with numa-related arguments, but OS cannot identify the numa architecture without SRAT tables. We add supporting for generating SRAT tables at runtime to solve this issue. the numa-related information and memory information can be obtained via SMC calls which is provided on

[edk2-devel] [PATCH v2 1/1] SbsaQemu: AcpiDxe: Create SRAT table at runtime

Add support to create SRAT(System resource affinity table) for sbsa platform at runtime. Signed-off-by: Xiong Yining Signed-off-by: Chen Baozi Reviewed-by: Marcin Juszkiewicz --- .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.h | 27 ++ .../Include/Library/SbsaQemuHardwareInfoLib.h | 11 +++

Re: [edk2-devel] [PATCH 5/5] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to SaveCpuMpData()

> > > + > > + if (CpuMpData->ApLoopMode != ApInHltLoop) { > > +MpHandOff->StartupSignalValue= MP_HAND_OFF_SIGNAL; > > +MpHandOff->WaitLoopExecutionMode = sizeof (VOID *); > > + } > > +} > > As noted elsewhere, these fields don't belong in the loop (they don't > b

[edk2-devel] [PATCH v3 1/1] SbsaQemu: add memory space for the high memory nodes

To support more memory nodes, we refer to the implement of "OvmfPkg/Fdt/HighMemDxe" to add memory space for the high memory nodes except the first one. Signed-off-by: Xiong Yining Signed-off-by: Chen Baozi --- Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 + Platform/Qemu/SbsaQemu/SbsaQem

[edk2-devel] [PATCH v3 0/1] support multi memory nodes

When SaSbQemu platform is configured with multi memory nodes, like numa architecture, os will ignore any memory node in the device tree except the first one. The kernel reads UEFI memory map for memory information when booting via UEFI. However UEFI only allocates the first memory node memory

[edk2-devel] [PATCH v1 2/3] DynamicTablesPkg: Adds ACPI HPET Table generator

From: Abdul Lateef Attar Adds generic ACPI HPET table generator library. Register/Deregister HPET table. Update the HPET table during boot as per specification. Cc: Sami Mujawar Cc: Pierre Gondois Signed-off-by: Abdul Lateef Attar --- DynamicTablesPkg/DynamicTables.dsc.inc| 2 + Dy

[edk2-devel] [PATCH v1 3/3] DynamicTablesPkg: Adds ACPI WSMT Table generator

From: Abdul Lateef Attar Adds generic ACPI WSMT table generator library. Register/Deregister WSMT table. Update the WSMT table during boot as per specification. Cc: Sami Mujawar Cc: Pierre Gondois Signed-off-by: Abdul Lateef Attar --- DynamicTablesPkg/DynamicTables.dsc.inc| 2 + Dy

[edk2-devel] [PATCH v1 1/3] DynamicTablesPkg: Adds ACPI FADT Table generator

From: Abdul Lateef Attar Adds generic ACPI FADT table generator library. Register/Deregister FADT table. Adds Arch namespace ids. Update the FADT table during boot as per specification. Cc: Sami Mujawar Cc: Pierre Gondois Signed-off-by: Abdul Lateef Attar --- DynamicTablesPkg/DynamicTables.d

[edk2-devel] [PATCH v1 0/3] DynamicTablesPkg: Adds generic FADT, HPET and WSMT table generators

From: Abdul Lateef Attar PR: https://github.com/tianocore/edk2/pull/5384 Adds new space for ArchNameSpaceObjects. Adds generic FADT table generator. Adds generic HPET table generator. Adds generic WSMT table generator. Cc: Sami Mujawar Cc: Pierre Gondois Cc: Abdul Lateef Attar Abdul Lateef

[edk2-devel] [PATCH 5/6] RedfishPkg/RedfishDebugLib: use RedfishHttpLib

Remove RedfishLib and use RedfishHttpLib for debug printing Redfish response data. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.inf | 4 ++-- RedfishPkg/Include/Library/RedfishDebugLib.h | 2 +

[edk2-devel] [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external symbol issue

-Fix below compiler error reported in edk2 CI. ERROR - Linker #2001 from JsonLib.lib(load.obj) : unresolved external symbol __ftol2 -The file MathFtol.c is copied from IntrinsicLib in CryptoPkg. -Add MathFtol.c to EccCheck IgnoreFiles. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchyts

[edk2-devel] [PATCH 4/6] RedfishPkg/RedfishLib: include RedfishServiceData.h

Redfish common structures are moved to RedfishServiceData.h. Remove them from RedfishLib.h Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishPkg/Include/Library/RedfishLib.h | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff

[edk2-devel] [PATCH 3/6] RedfishPkg: introduce RedfishHttpLib

RedfishHttpLib is a wrapper library for Redfish feature drivers to call Redfish HTTP Protocol easily. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishPkg/RedfishPkg.dec | 5 + RedfishPkg/RedfishLibs.dsc.inc| 3

[edk2-devel] [PATCH 2/6] RedfishPkg: implement Redfish HTTP protocol

implement Redfish HTTP protocol driver. Signed-off-by: Nickle Wang Co-authored-by: Igor Kulchytskyy Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishPkg/RedfishPkg.dec |7 +- RedfishPkg/RedfishComponents.dsc.inc |3 +- RedfishPkg/RedfishPk

[edk2-devel] [PATCH 1/6] RedfishPkg: introduce Redfish HTTP protocol

Introduce Redfish HTTP protocol to improve Redfish performance and communication stability between BIOS and Redfish service. - Feature drivers often query same Redfish resource multiple times for different purpose. Implement HTTP cache mechanism to improve HTTP GET performance. "UseCache" parameter

[edk2-devel] [PATCH 0/6] Introduce Redfish http protocol

This patch series introduce Redfish HTTP protocol to RedfishPkg. This is to improve Redfish performance and communication stability between BIOS and Redfish service. Two big functions are introduced: 1) HTTP cache mechanism is implemented to reduce the number of communiocation between BIOS and B

Re: [edk2-devel] [PATCH v3 1/4] OvmfPkg/Sec: Setup MTRR early in the boot process.

On Monday, February 12, 2024 11:22 PM, Gerd Hoffmann wrote: > On Thu, Feb 01, 2024 at 10:38:43AM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > > Can you confirm (a) this patch is OK for > > > > "OvmfPkg/IntelTdx/Sec/SecMain.c", and (b) this series fixes the slowdown > you had encountered? > > > >

[edk2-devel] [PATCH] Pkg-Module: Silicon/Marvell

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4689 Bug 4689 - GetInfo() of Adapter Information Protocol should have a provision for IHV to return no data for UEFI Spec compliance 2.9 [mantis #1866] Signed-off-by: Gahan Saraiya --- Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c | 1 + 1 file

Re: [edk2-devel] [PATCH] Pkg-Module: OptionRomPkg, MinPlatformPkg, Silicon/Marvell

Discarding the thread to split in to 3 different review patch. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115621): https://edk2.groups.io/g/devel/message/115621 Mute This Topic: https://groups.io/mt/104454915/21656 Group Owner: devel+

[edk2-devel] [PATCH] Pkg-Module: OptionRomPkg

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4689 Bug 4689 - GetInfo() of Adapter Information Protocol should have a provision for IHV to return no data for UEFI Spec compliance 2.9 [mantis #1866] Signed-off-by: Gahan Saraiya --- Drivers/OptionRomPkg/UndiRuntimeDxe/Undi32.h | 17

[edk2-devel] [PATCH] Pkg-Module: MinPlatformPkg

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4689 Bug 4689 - GetInfo() of Adapter Information Protocol should have a provision for IHV to return no data for UEFI Spec compliance 2.9 [mantis #1866] Signed-off-by: Gahan Saraiya --- .../Test/Library/TestPointLib/DxeTestPointAip.c

Re: [edk2-devel] [PATCH 1/5] UefiCpuPkg/MpInitLib: Add ProcessorIndex argument to GetMpHandOffHob()

> > That will only work if the HOBs are returned in ProcessorIndex order. > > That happens to be the case in my testing; the HOBs are returned in the > same order they are created by patch #5 of this series. > > Is that behavior guaranteed? MdePkg/Include/Library/HobLib.h doesn't > say anything

Re: [edk2-devel] [PATCH v1 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Check BspIndex first before lock cmpxchg

> From C11 "5.1.2.4 Multi-threaded executions and data races": > > - paragraph 4: "Two expression evaluations conflict if one of them > modifies a memory location and the other one reads or modifies the same > memory location." > > - paragraph 25: "The execution of a program contains a data race

[edk2-devel] [PATCH] IntelSiliconPkg/VTd: Reset the one-shot bits before modifing GCMD_REG

Here is the process of modify GCMD_REG. Read GSTS_REG Reset the one-shot bits. Modify the target comamnd value. Write the command value to GCMD_REG. Wait until GSTS_REG indicates command is serviced. Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Jenny Huang Signed-off-by: Sheng Wei --- ...

Re: [edk2-devel] [PATCH 1/2] Add maintainers for EaglestreamSiliconBinPkg and EaglestreamOpenBoardBinPkg

Hi Nathaniel, I can not tell which repo these are for. Can you please indicate the target repo in the subject such as: [edk2-platforms][Patch x/y] [edk2-non-osi][Patch x/y] I the repo is not specified, then [edk2] is assumed. Thanks, Mike > -Original Message- > From: devel@edk2.grou

Re: [edk2-devel] [PATCH 2/2] Update Maintainers for Intel packages

Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of > Nathaniel Haller > Sent: Friday, February 16, 2024 5:48 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Chiu, > Chasel > Subject: [edk2-devel] [PATCH 2/2] Update Maintainers for

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, February 20, 2024 #cal-reminder

*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, February 20, 2024 6:30pm to 7:30pm (UTC-08:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344

Re: [edk2-devel] The API in BaseCryptLib can't seed the pseudorandom number generator properly

Hi Eddie, > the API in CryptPkg "RandomSeed()"(X64, in CryptRandTsc.c) always returned > false Does your code run in a XIP environment? Such like PreMemory stage or other cases. The setup of Randlib in OpenSsl 3.0 relies on global variables, so there may be an error if the global variables are

Re: [edk2-devel] The API in BaseCryptLib can't seed the pseudorandom number generator properly

Thanks Laslo and Eddie. I am just back from Chinese New Year vocation, still checking email. If you can file a Bugzilla (https://bugzilla.tianocore.org/) with source code of your app, that would be very helpful for us to investigate this issue. > -Original Message- > From: devel@edk2.g

Re: [edk2-devel] [edk2-redfish-client][PATCH V3] RedfishClientPkg: Readme.md update

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner > via groups.io > Sent: Monday, February 5, 2024 4:36 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: Re: [edk2-devel] [edk2-redfish-cli

Re: [edk2-devel] GVT-g VM takes a long time before OVMF splash shown - bisected

Hi, On 2/19/24 19:18, chriscjsus via groups.io wrote: > Sorry if this is a duplicate post.  I sent an email to > devel@edk2.groups.io before creating an > account on groups.io. > > This started with edk2-stable202311.  I bisected this to > > first bad commit: [e8aa4

[edk2-devel] [PATCH] Pkg-Module: OptionRomPkg, MinPlatformPkg, Silicon/Marvell

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4689 Bug 4689 - GetInfo() of Adapter Information Protocol should have a provision for IHV to return no data for UEFI Spec compliance 2.9 [mantis #1866] Signed-off-by: Gahan Saraiya --- Drivers/OptionRomPkg/UndiRuntimeDxe/Undi32.h| 17 +

[edk2-devel] [PATCH 2/2] Update Maintainers for Intel packages

Update PurleySiliconBinPkg, WhitleyOpenBoardBinPkg, and WhitleySiliconBinPkg maintainers. Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Nathaniel Haller --- Maintainers.txt | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt index 66a

[edk2-devel] GVT-g VM takes a long time before OVMF splash shown - bisected

Sorry if this is a duplicate post.  I sent an email to devel@edk2.groups.io before creating an account on groups.io. This started with edk2-stable202311.  I bisected this to first bad commit: [e8aa4c6546ad5b04a1100fa2618e424f58e354f5] UefiCpuPkg/ResetVector: Cache Disable should not be set by d

[edk2-devel] GVT-g VM takes a long time before OVMF splash shown - bisected

This started with edk2-stable202311.  I bisected this to # first bad commit: [e8aa4c6546ad5b04a1100fa2618e424f58e354f5] UefiCpuPkg/ResetVector: Cache Disable should not be set by default in CR0 I tried the lastest ovmf git master with same result.  Reverting the above commit fixed the issue.

[edk2-devel] [PATCH 1/2] Add maintainers for EaglestreamSiliconBinPkg and EaglestreamOpenBoardBinPkg

Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Nathaniel Haller --- Maintainers.txt | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 1d5dacb..66ac96d 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -50,6 +50,11 @@ M: Isaac Oram M:

[edk2-devel] [PATCH 0/2] Intel maintainers updates

Adding maintainers for new Intel packages, EaglestreamSiliconBinPkg and EaglestreamOpenBoardBinPkg, then replacing Isaac W Oram from the Intel package maintainers lists. Nathaniel Haller (2): Add maintainers for EaglestreamSiliconBinPkg and EaglestreamOpenBoardBinPkg Update Maintainers for

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/NvmExpressDxe: use format "0x%lx" for UINT64 values.

On 2/16/24 22:26, Mike Maslenkin wrote: > Signed-off-by: Mike Maslenkin > Cc: Ray Ni > --- > MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.c > b/MdeModulePkg/Bus/Pci/N

Re: [edk2-devel] [PATCH edk2-libc 1/1] StdLib: Remove the 'register' keyword from public interfaces

On 2/16/24 22:46, Pedro Falcato wrote: > ISO C interfaces do not have the 'register' keyword, so this is > technically non-compliant and other consumers of C headers (such as C++) > will error out when seeing this keyword. > > This should not affect anything, functionality-wise or ABI-wise. > > C

Re: [edk2-devel] The API in BaseCryptLib can't seed the pseudorandom number generator properly

On 2/17/24 10:17, eddie wang wrote: > Hi Laszlo, > After digging dipper,  we found that the *EVP_RAND_fetch *in > "rand_new_seed" and "rand_new_drbg" both got NULL in our case. It's > meant the DRBG implementation could  > not be fetched. We also compared it to the case on Linux, and they could > b

Re: [edk2-devel] [edk2-platforms PATCH 5/6] LoongArchQemuPkg: fix SEC ProcessLibraryConstructorList() prototype

On 2/19/24 03:21, Chao Li wrote: > Hi Laszlo, > > I have tested: > > 1. Follow edk2 series patch 3 changes to > BaseTools/Source/Python/AutoGen/GenC.py. > > 2. Follow edk2-platforms series patch 5 changes to > edk2-platforms/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c. > > After the change

Re: [edk2-devel] [PATCH v2 12/12] OvmfPkg: only add shell to FV in case secure boot is disabled

On 2/19/24 11:21, Gerd Hoffmann wrote: >>> -!if $(BUILD_SHELL) == TRUE >>> +!if $(BUILD_SHELL) == TRUE && $(SECURE_BOOT_ENABLE) == FALSE >>> >>> !if $(TOOL_CHAIN_TAG) != "XCODE5" >>> !if $(NETWORK_ENABLE) == TRUE >> >> This does the job: >> >> Reviewed-by: Laszlo Ersek >> >> An alternative could

Re: [edk2-devel] [PATCH 2/5] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to GetBspNumber()

On 2/19/24 12:37, Gerd Hoffmann wrote: > Hi, > >> (I'm missing the larger picture here -- is this related to the problem >> -- too many CPUs to fit their infos into a single HOB -- that Pawel >> worked on for a while? > > Different HOB, but similar underlying problem. > > At least the HOB stru

Re: [edk2-devel] [PATCH 5/5] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to SaveCpuMpData()

On 2/15/24 10:31, Gerd Hoffmann wrote: > Add support for splitting Hand-Off data into multiple HOBs. This is > required for VMs with thousands of CPUs. The actual CPU count per HOB > is much smaller (128) for better test coverage. > > Signed-off-by: Gerd Hoffmann > --- > UefiCpuPkg/Library/MpIn

Re: [edk2-devel] [PATCH 4/5] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to MpInitLibInitialize

On 2/15/24 10:31, Gerd Hoffmann wrote: > Loop over all MP_HAND_OFF HOBs instead of expecting a single HOB > covering all CPUs in the system. > > Add a new HaveMpHandOff variable to track whenever MP_HAND_OFF HOBs are > present, using the MpHandOff pointer for that does not work because the > varia

Re: [edk2-devel] [PATCH 2/5] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to GetBspNumber()

Hi, > (I'm missing the larger picture here -- is this related to the problem > -- too many CPUs to fit their infos into a single HOB -- that Pawel > worked on for a while? Different HOB, but similar underlying problem. At least the HOB structure already has the fields needed to allow splitting

Re: [edk2-devel] [PATCH 3/5] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to SwitchApContext()

On 2/15/24 10:31, Gerd Hoffmann wrote: > Remove the MpHandOff parameter. This is not useful in case multiple > HOBs are present in the system. The function will use GetMpHandOffHob() > to loop over all HOBs instead. > > Signed-off-by: Gerd Hoffmann > --- > UefiCpuPkg/Library/MpInitLib/MpLib.h

Re: [edk2-devel] [PATCH 1/5] UefiCpuPkg/MpInitLib: Add ProcessorIndex argument to GetMpHandOffHob()

On 2/15/24 10:31, Gerd Hoffmann wrote: > This allows to specify which HOB should be returned in case multiple > MP_HAND_OFF HOBs are present in the system. > > Also add the function prototype to the MpLib.h header file. > > Signed-off-by: Gerd Hoffmann > --- > UefiCpuPkg/Library/MpInitLib/MpLib

Re: [edk2-devel] [PATCH 2/5] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to GetBspNumber()

On 2/15/24 10:31, Gerd Hoffmann wrote: > Remove the MpHandOff parameter. This is not useful in case multiple > HOBs are present in the system. The function will use GetMpHandOffHob() > to loop over all HOBs instead. > > Signed-off-by: Gerd Hoffmann > --- > UefiCpuPkg/Library/MpInitLib/MpLib.c

Re: [edk2-devel] [PATCH v2 12/12] OvmfPkg: only add shell to FV in case secure boot is disabled

> > -!if $(BUILD_SHELL) == TRUE > > +!if $(BUILD_SHELL) == TRUE && $(SECURE_BOOT_ENABLE) == FALSE > > > > !if $(TOOL_CHAIN_TAG) != "XCODE5" > > !if $(NETWORK_ENABLE) == TRUE > > This does the job: > > Reviewed-by: Laszlo Ersek > > An alternative could be (perhaps informing the user better): >

Re: [edk2-devel] [PATCH 1/5] UefiCpuPkg/MpInitLib: Add ProcessorIndex argument to GetMpHandOffHob()

On Mon, Feb 19, 2024 at 02:34:42AM +, Ni, Ray wrote: > > + for (GuidHob = GetFirstGuidHob (&mMpHandOffGuid); > > + GuidHob != NULL; > > + GuidHob = GetNextGuidHob (&mMpHandOffGuid, GET_NEXT_HOB > > (GuidHob))) > > + { > > MpHandOff = (MP_HAND_OFF *)GET_GUID_HOB_DATA (GuidHob)

Re: [edk2-devel] Problem Booting Starlingx On PXE

On 19/02/2024 06:44, Hamit Can Karaca wrote: I am having problem while booting Starlingx on iPXE on UEFI. It says malformed binary and does not allow me to boot afterwards. What should I do in BIOS to solve this problem? I can boot Starlingx on other platforms using OEM BIOS. Our platform is

Re: [edk2-devel] [edk2-stable202402 PATCH 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: distinguish GetSmBase() failure modes

Laszlo, Sorry for the late reply. Thanks for your code refactoring patch and bugfix patch! Thanks, Dun -Original Message- From: Laszlo Ersek Sent: Thursday, February 15, 2024 4:45 PM To: Kinney, Michael D ; Leif Lindholm ; devel@edk2.groups.io; Leif Lindholm ; Andrew Fish (af...@app