On Mon, Nov 20, 2023 at 4:24 AM Dhaval Sharma wrote:
>
> As per ACPI Spec 6.5+ Table 5-9 if xDSDT is avaialble,
nit: available
> it should be used first. Handle required flow when xDSDT
> is abscent or present.
nit: absent
Separate nit: Please update the patch's subject to something more
descr
On Wed, Nov 29, 2023 at 12:56 AM Ni, Ray wrote:
>
> It's good. But I am curious why --ignore-change-id is needed?
I didn't ask, but presumably, if you have an internal gerrit instance
that runs CI before pushing, PatchCheck.py may be part of the CI
workflow; in those cases, we don't want it to er
Reviewed-by: Yuwei Chen
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Wednesday, November 29, 2023 3:49 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> ; Rebecca Cran ; Chen,
> Christine
> Subject: [PATCH v1 1/1] BaseTools/Conf/target.template: Use VS
Hi Mike and Liming,
Ping for review, I'd love to know your opinion, as the last email saied,
your opinion can decide the direction, so please review the new patches
of MdePkg for this series, please...
Thanks,
Chao
On 2023/11/27 11:27, Chao Li wrote:
Hi Mike and Liming,
You opinion is ver
Ray do you mean set it as default checking?
It is a good point.
> -Original Message-
> From: Ni, Ray
> Sent: Wednesday, November 29, 2023 8:56 AM
> To: devel@edk2.groups.io; Chen, Christine ; Pierre
> Gondois
> Cc: Rebecca Cran ; Gao, Liming
> ; Feng, Bob C ; Sami
> Mujawar ; yeoreum
It's good. But I am curious why --ignore-change-id is needed?
Thanks,
Ray
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yuwei
> Chen
> Sent: Wednesday, November 29, 2023 8:23 AM
> To: Pierre Gondois ; devel@edk2.groups.io
> Cc: Rebecca Cran ; Gao, Liming
> ; Feng, Bob C ;
Reviewed-by: Min Xu
> -Original Message-
> From: Sun, CepingX
> Sent: Monday, November 27, 2023 8:41 AM
> To: devel@edk2.groups.io
> Cc: Sun, CepingX ; Yao, Jiewen
> ; Xu, Min M
> Subject: [PATCH V1 1/1] SecurityPkg/DxeTpm2MeasureBootLib: Check the
> Integer overflow
>
> From: Ceping S
The patch is good for me.
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Pierre Gondois
> Sent: Wednesday, November 22, 2023 9:15 PM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran ; Gao, Liming
> ; Feng, Bob C ; Chen,
> Christine ; Sami Mujawar
> ; yeoreum@arm.com
> Subject: [P
Pushed as 7528798
-Original Message-
From: devel@edk2.groups.io On Behalf Of Nate DeSimone
Sent: Friday, November 17, 2023 10:36 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel
Subject: [edk2-devel] [edk2-platforms][PATCH v1] WhitleyOpenBoardPkg: Replace
Python Interpreter Name
Removes th
Pushed as 073fbeb
-Original Message-
From: devel@edk2.groups.io On Behalf Of Nate DeSimone
Sent: Friday, November 17, 2023 10:36 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Gao, Liming
; Dong, Eric
Subject: [edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg: Remove usage
of PYTH
Pushed as 15e9fae
-Original Message-
From: devel@edk2.groups.io On Behalf Of Nate DeSimone
Sent: Friday, November 17, 2023 10:36 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel
Subject: [edk2-devel] [edk2-platforms][PATCH v1] PurleyOpenBoardPkg: Replace
Python Interpreter Name
Removes the
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3267
Adds two new helper functions.
Currently, a function exists in Tpm2CommandLib to copy a digest list
to a buffer. A function to perform the inverse operation - copying
from a buffer to a digest list is added.
A functi
From: Michael Kubacki
Updates the default tool chain from VS2015x86 to VS2019.
This is the VS tool chain used in CI and more likely to be installed
on developer's systems. This is used in stuart commands when a
toolchain is not explicitly specified.
Cc: Bob Feng
Cc: Liming Gao
Cc: Rebecca Cra
Hi Maciej,
Reviewed-by: Michael D Kinney
I have invited you to the EDK II Staging Maintainer team that
allows you to create this new branch in the edk2-staging repo.
Mike
> -Original Message-
> From: Czajkowski, Maciej
> Sent: Monday, November 13, 2023 7:09 AM
> To: devel@edk2.groups.
Thanks for update! Change looks good to me.
Acked-by: Chasel Chiu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Dhaval
> Sharma
> Sent: Sunday, November 19, 2023 8:24 PM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Liu, Zhiguang
> ; Bi, Dandan
> Subject: [edk2-deve
On Tue, 28 Nov 2023 at 16:15, gaoliming via groups.io
wrote:
>
> Reviewed-by: Liming Gao
>
Thanks I'll queue this up.
> > -邮件原件-
> > 发件人: devel@edk2.groups.io 代表 Ard
> > Biesheuvel
> > 发送时间: 2023年11月23日 16:36
> > 收件人: Nhi Pham
> > 抄送: devel@edk2.groups.io; gaolim...@byosoft.com.cn;
On Tue, 28 Nov 2023 at 18:47, Marcin Juszkiewicz
wrote:
>
> Update the TF-A binaries:
>
> - v2.10 release
> - Neoverse-N2 errata fix
> https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/24936
> (check for SCU before accessing DSU registers)
>
> v2.10 brought change on how we enable
Update the TF-A binaries:
- v2.10 release
- Neoverse-N2 errata fix
https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/24936
(check for SCU before accessing DSU registers)
v2.10 brought change on how we enable cpu features to have one binary
working on v8.0 (a57/a72), v8.2 (n1), v8
On Tue, 28 Nov 2023 at 18:12, wrote:
>
> From: Michael Kubacki
>
> GetNextEntryAttribute() is currently applying a 64-bit mask
> (TT_ATTRIBUTES_MASK) to a 32-bit descriptor value (EntryType).
> The original descriptor was 64 bits containing the upper and
> lower attributes which are included in T
On Tue, 28 Nov 2023 at 18:15, Michael Kubacki
wrote:
>
> On 11/28/2023 4:51 AM, Ard Biesheuvel wrote:
> > On Tue, 28 Nov 2023 at 01:15, wrote:
> >>
> >> From: Michael Kubacki
> >>
> >> This series contains two changes:
> >>
> >> 1. To fix a compiler warning with the current state of code.
> >> 2
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3267
Adds two new helper functions.
Currently, a function exists in Tpm2CommandLib to copy a digest list
to a buffer. A function to perform the inverse operation - copying
from a buffer to a digest list is added.
A functi
From: Michael Kubacki
GetNextEntryAttribute() is currently applying a 64-bit mask
(TT_ATTRIBUTES_MASK) to a 32-bit descriptor value (EntryType).
The original descriptor was 64 bits containing the upper and
lower attributes which are included in TT_ATTRIBUTES_MASK.
The PrevEntryAttribute paramete
From: Michael Kubacki
This series contains two changes:
1. To fix a compiler warning with the current state of code.
2. To update the code to pass the integer width needed for a
comparison to set EFI_MEMORY_XP in the GCD attribute returned
for a given page attribute.
v2 changes:
Squashed
Jin:
This change is good to me. Reviewed-by: Liming Gao
Thanks
Liming
发件人: devel@edk2.groups.io 代表 Zhi Jin
发送时间: 2023年11月27日 14:54
收件人: Ni, Ray ; devel@edk2.groups.io; Gao, Liming
抄送: Wang, Jian J ; Bi, Dandan
主题: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Optimize
CoreInstallMultiplePr
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Ard
> Biesheuvel
> 发送时间: 2023年11月23日 16:36
> 收件人: Nhi Pham
> 抄送: devel@edk2.groups.io; gaolim...@byosoft.com.cn;
> ardb+tianoc...@kernel.org
> 主题: Re: [edk2-devel] [Proposed Fix][PATCH v1 1/1]
> MdeModulePkg/DxeCapsuleLibFm
Hello,
I wrote a patch that make it possible to set Boot at build time using a
pcd.
For example with build option
`--pcd=gEfiMdeModulePkgTokenSpaceGuid.PcdPlatformBootBoot=Lshell.efi`,
I can make sure that efi shell will boot first for a newly build firmware
image.
Thanks,
Hugues
-=-=-
On 11/6/23 17:15, Tom Lendacky wrote:
On 11/6/23 16:45, Lendacky, Thomas via groups.io wrote:
The CPUID_EXTENDED_TOPOLOGY CPUID leaf takes a subleaf as input when
returning CPUID information. However, the AsmCpuid() function does not
zero out ECX before the CPUID instruction, so the input leaf i
Sent an updated patch already.
On Sat, Nov 18, 2023 at 3:27 AM Laszlo Ersek wrote:
> On 11/17/23 18:50, Chiu, Chasel wrote:
> >
> > Hi Dhaval,
> >
> > Just a small feedback,
> > the only difference will be TableToInstall between XDsdt and Dsdt, could
> we optimize the code flow to reduce duplica
On Mon, 27 Nov 2023 at 21:04, Tom Lendacky wrote:
>
> On 3/20/23 05:06, Gerd Hoffmann wrote:
> > On Thu, Mar 02, 2023 at 09:15:30AM +, Dov Murik wrote:
> >> AMD SEV and SEV-ES support measured direct boot with
> >> kernel/initrd/cmdline hashes injected by QEMU and verified by OVMF
> >> during
On Tue, 28 Nov 2023 at 00:58, wrote:
>
> From: Michael Kubacki
>
> mReplaceLiveEntryFunc is a function pointer but assigned as a VOID*
> pointer:
>
> mReplaceLiveEntryFunc = *(VOID **)GET_GUID_HOB_DATA (Hob);
>
> This leads to the Visual Studio warning:
>
> nonstandard extension, function/dat
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Tom Lendacky
> Sent: Tuesday, November 7, 2023 6:46 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Rahul R ; Gerd Hoffmann ;
> Ard Biesheuvel ; Michael Roth
>
> Subject: [PATCH 2/2] UefiCpuPkg/MpInitLib: C
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Tom Lendacky
> Sent: Tuesday, November 7, 2023 6:46 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Rahul R ; Gerd Hoffmann ;
> Ard Biesheuvel ; Michael Roth
>
> Subject: [PATCH 1/2] UefiCpuPkg/MpInitLib: U
Taylor,
Thanks for spending time on removing the duplicated code in DxeCore and SmmCore.
I am ok with your current patch series. But I do have some suggestions that you
or someone else could possibly enhance the lib API in future:
In MdeModulePkg\Core\Dxe\Misc\MemoryAttributesTable.c, InsertImag
On Tue, 28 Nov 2023 at 01:15, wrote:
>
> From: Michael Kubacki
>
> This series contains two changes:
>
> 1. To fix a compiler warning with the current state of code.
> 2. To update the code to pass the integer width needed for a
>comparison to set EFI_MEMORY_XP in the GCD attribute returned
>
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Liu, Zhiguang
> Sent: Thursday, November 23, 2023 11:23 AM
> To: devel@edk2.groups.io
> Cc: Liu, Zhiguang ; Ni, Ray ;
> Kumar, Rahul R ; Gerd Hoffmann
> ; Laszlo Ersek
> Subject: [PATCH v3] UefiCpuPkg/PiSmmCpuDxeSmm: Use NonSm
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Liu, Zhiguang
> Sent: Monday, November 20, 2023 11:10 AM
> To: devel@edk2.groups.io
> Cc: Liu, Zhiguang ; Ni, Ray ;
> Kumar, Rahul R ; Gerd Hoffmann
> ; Laszlo Ersek
> Subject: [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Use NonSmm
On Thu, 23 Nov 2023 at 16:02, Gerd Hoffmann wrote:
>
> This is the edk2 side of the qemu patch series posted last week to
> qemu-devel:
> https://lists.gnu.org/archive/html/qemu-devel/2023-11/msg03714.html
>
> The driver forwards MM calls to the virtualization host instead of the
> MM code runni
37 matches
Mail list logo
