Re: [edk2-devel] [Patch V4] UefiCpuPkg/MpInitLib: Enable execute disable bit.

2023-11-16 Thread Ni, Ray
Laszlo, I agree that the BSP's XD status is saved in both CpuMpData and ExchangeInfo. But, thinking from another perspective, ExchangeInfo is "only" used by the assembly code. That's why the BSP code needs to save the XD status in CpuMpData and ExchangeInfo. If we remove the XD status field in E

Re: [edk2-devel] [PATCH 0/3] Maintainers.txt: add Laszlo Ersek as an ArmVirt, Ovmf, UefiCpu Pkg "M"

2023-11-16 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: Kinney, Michael D > Sent: Friday, November 17, 2023 6:52 AM > To: Laszlo Ersek ; devel@edk2.groups.io > Cc: Andrew Fish ; Ard Biesheuvel > ; Gerd Hoffmann ; Yao, > Jiewen ; Leif Lindholm ; > Kumar, Rahul R ; Ni, Ray ; Sami > Mujawar ;

[edk2-devel] question about PrmPkg

2023-11-16 Thread Yoshinoya
Hi, I find there is a PrmPkg in udk source code. Based on its Readme.md, its goal is to offload smm code to sci os mechanisms. So, is there any actual use case on real platform now? It seems it's just a conceptional prototype. Thanks -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all m

Re: [edk2-devel] question about cxl device enumeration in pci bus driver

2023-11-16 Thread Yoshinoya
Hi, Brian: Thanks. That is helpful. It seems cxl device hot-plug feature depends on pcie bus native hot plug feature. Not need bios asl code or smm handler code attends it. OS kernel will cover all procedure. At 2023-11-08 05:54:01, "Brian J. Johnson" wrote: I see a long discus

回复: [edk2-devel] [PATCH] MdeModulePkg/Variable: Merge variable header + data update into one step

2023-11-16 Thread gaoliming via groups.io
Cheng: I think this change is fine. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Gao > 发送时间: 2023年11月14日 16:24 > 收件人: devel@edk2.groups.io > 抄送: Gao Cheng ; Liming Gao > ; Ray Ni > 主题: [edk2-devel] [PATCH] MdeModulePkg/Variable: Merge variable header >

Re: [edk2-devel] [PATCH 0/3] Maintainers.txt: add Laszlo Ersek as an ArmVirt, Ovmf, UefiCpu Pkg "M"

2023-11-16 Thread Leif Lindholm
For the series: Reviewed-by: Leif Lindholm On Thu, Nov 16, 2023 at 22:50:55 +0100, Laszlo Ersek wrote: > I'm offering to restore a subset of my earlier ArmVirtPkg and OvmfPkg > maintainer responsibilities. > > I'm both offering and requesting an escalation of my earlier UefiCpuPkg > role. > > T

[edk2-devel] [PATCH edk2-platforms 1/1] IpmiFeaturePkg/IpmiRedirFru: Switch to AfterConsole event for callback

2023-11-16 Thread Zhen Gong
Use AfterConsole event instead of ReadyToBoot for callback so the driver can update SMBIOS table before booting to setup menu. Cc: Nate DeSimone Cc: Liming Gao Change-Id: Ife697f4c78449b90f17ffa7b7bc5a6a5f77d9436 Signed-off-by: Zhen Gong --- .../IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.inf |

Re: [edk2-devel] [PATCH 0/3] Maintainers.txt: add Laszlo Ersek as an ArmVirt, Ovmf, UefiCpu Pkg "M"

2023-11-16 Thread Michael D Kinney
Series Reviewed-by: Michael D Kinney > -Original Message- > From: Laszlo Ersek > Sent: Thursday, November 16, 2023 1:51 PM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Ard Biesheuvel > ; Gerd Hoffmann ; Yao, > Jiewen ; Leif Lindholm > ; Kinney, Michael D > ; Kumar, Rahul R > ; Ni, Ray

Re: [edk2-devel] [PATCH 2/3] Maintainers.txt: add Laszlo Ersek as an OvmfPkg maintainer

2023-11-16 Thread Ard Biesheuvel
On Fri, 17 Nov 2023 at 07:51, Laszlo Ersek wrote: > > I intend to assist with the maintenance of the following files and > directories: > > OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c > OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h > OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf > OvmfPkg/AcpiPlatformDx

Re: [edk2-devel] [PATCH 1/3] Maintainers.txt: add Laszlo Ersek as an ArmVirtPkg maintainer

2023-11-16 Thread Ard Biesheuvel
On Fri, 17 Nov 2023 at 07:51, Laszlo Ersek wrote: > > I intend to assist with the maintenance of the following files and > directories: > > ArmVirtPkg/ArmVirt.dsc.inc > ArmVirtPkg/ArmVirtPkg.dec > ArmVirtPkg/ArmVirtQemu.dsc > ArmVirtPkg/ArmVirtQemu.fdf > ArmVirtPkg/ArmVirtQemuFvMain.fdf.

[edk2-devel] [PATCH 3/3] Maintainers.txt: add Laszlo Ersek as a UefiCpuPkg maintainer

2023-11-16 Thread Laszlo Ersek
I intend to assist with the maintenance of the following files and directories: UefiCpuPkg/CpuDxe/ UefiCpuPkg/CpuIo2Dxe/ UefiCpuPkg/CpuIo2Smm/CpuIo2Mm.c UefiCpuPkg/CpuIo2Smm/CpuIo2Mm.h UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.c UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf UefiCpuPkg/CpuMpPei/ UefiCpuP

[edk2-devel] [PATCH 2/3] Maintainers.txt: add Laszlo Ersek as an OvmfPkg maintainer

2023-11-16 Thread Laszlo Ersek
I intend to assist with the maintenance of the following files and directories: OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf OvmfPkg/AcpiPlatformDxe/EntryPoint.c OvmfPkg/CpuHotplugSmm/ OvmfPkg/CpuS3DataDxe/

[edk2-devel] [PATCH 0/3] Maintainers.txt: add Laszlo Ersek as an ArmVirt, Ovmf, UefiCpu Pkg "M"

2023-11-16 Thread Laszlo Ersek
I'm offering to restore a subset of my earlier ArmVirtPkg and OvmfPkg maintainer responsibilities. I'm both offering and requesting an escalation of my earlier UefiCpuPkg role. The commit messages contain lists of files and directories that I intend to assist with. Under ArmVirtPkg, my focus is

[edk2-devel] [PATCH 1/3] Maintainers.txt: add Laszlo Ersek as an ArmVirtPkg maintainer

2023-11-16 Thread Laszlo Ersek
I intend to assist with the maintenance of the following files and directories: ArmVirtPkg/ArmVirt.dsc.inc ArmVirtPkg/ArmVirtPkg.dec ArmVirtPkg/ArmVirtQemu.dsc ArmVirtPkg/ArmVirtQemu.fdf ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc ArmVirtPkg/ArmVirtRules.fdf.inc ArmVirtPkg/Include/Guid/Earl

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

2023-11-16 Thread Michael Kubacki
On 11/16/2023 3:29 AM, Pedro Falcato wrote: On Tue, Nov 14, 2023 at 3:01 PM Laszlo Ersek wrote: On 11/13/23 22:33, Pedro Falcato wrote: On Mon, Nov 13, 2023 at 8:37 PM Rebecca Cran wrote: On 11/13/2023 1:08 PM, Michael Kubacki wrote: Yes. I just did it. It is relatively minor and impacts

Re: [edk2-devel] [edk2-platforms PATCH v2 0/1] Marvell package restructure

2023-11-16 Thread Leif Lindholm
Apologies, I managed to misfile this. Reviewed-by: Leif Lindholm Typo in subject line fixed, pushed as ec5de71d83f3. Thanks! / Leif On Thu, Nov 02, 2023 at 09:15:51 +0530, ndhil...@marvell.com wrote: > From: Narinder Dhillon > > Current Silicon/Marvell package structure does not allow sh

Re: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 installed after RestEx

2023-11-16 Thread Igor Kulchytskyy via groups.io
Hi Liming, I created PR for the final v6 patch: https://github.com/tianocore/edk2/pull/5050 Could you please merge those changes? Thank you, Igor -Original Message- From: Chang, Abner Sent: Thursday, November 16, 2023 8:03 AM To: devel@edk2.groups.io; Igor Kulchytskyy ; Leif Lindholm Su

Re: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 installed after RestEx

2023-11-16 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Great and happy ending! 😊 Hi Igor, could you please inform Liming he can merge this change. Thanks Abner > -Original Message- > From: devel@edk2.groups.io On Behalf Of Igor > Kulchytskyy via groups.io > Sent: Thursday, November 16, 2023 8:31 PM > To: Le

Re: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 installed after RestEx

2023-11-16 Thread Igor Kulchytskyy via groups.io
Thank you all for the reviews! -Original Message- From: Leif Lindholm Sent: Thursday, November 16, 2023 7:29 AM To: devel@edk2.groups.io; Igor Kulchytskyy Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 installed after RestEx **CAUTION: The e-mai

Re: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 installed after RestEx

2023-11-16 Thread Leif Lindholm
On Wed, Nov 15, 2023 at 22:12:34 +, Igor Kulchytskyy via groups.io wrote: > Igor Kulchytskyy (2): > RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after > RestEx > RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow > > .../RedfishDiscoverDxe/RedfishDiscove

Re: [edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

2023-11-16 Thread Leif Lindholm
Ah, I fell off cc. Having a look now. / Leif On 2023-11-16 12:23, Igor Kulchytskyy wrote: Hi Leif, Already sent it yesterday. Thank you, Igor -Original Message- From: Leif Lindholm Sent: Thursday, November 16, 2023 7:15 AM To: devel@edk2.groups.io; mike.maslen...@gmail.com; Igor K

Re: [edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

2023-11-16 Thread Igor Kulchytskyy via groups.io
Hi Leif, Already sent it yesterday. Thank you, Igor -Original Message- From: Leif Lindholm Sent: Thursday, November 16, 2023 7:15 AM To: devel@edk2.groups.io; mike.maslen...@gmail.com; Igor Kulchytskyy Cc: Abner Chang ; Nickle Wang Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v5 2/2] Re

Re: [edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

2023-11-16 Thread Leif Lindholm
On 2023-11-15 18:27, Mike Maslenkin wrote: On Wed, Nov 15, 2023 at 4:52 PM Igor Kulchytskyy wrote: Hello Leif and Mike, Let me try to explain the idea of the filtering IP. That filtering should work only if we know exactly that IP is IPv4 or IPv6 in SMBIOS Type 42. Hm. I've already composed

[edk2-devel] [edk2-platforms][PATCH V1 5/5] Platform/ARM/N1Sdp: Enable FaultTolerantWrite Dxe driver for N1Sdp

2023-11-16 Thread sahil
Signed-off-by: sahil --- Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 5 + Platform/ARM/N1Sdp/N1SdpPlatform.fdf | 1 + 2 files changed, 6 insertions(+) diff --git a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc b/Platform/ARM/N1Sdp/N1SdpPlatform.dsc index 10fe2db9e1b1..703829bbac99 100644 --- a/Platform/A

[edk2-devel] [edk2-platforms][PATCH V1 4/5] Platform/ARM/N1Sdp: Persistent storage for N1Sdp

2023-11-16 Thread sahil
Enable persistent storage on QSPI flash device. Signed-off-by: sahil --- Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 20 ++-- Platform/ARM/N1Sdp/N1SdpPlatform.fdf | 4 +++- 2 files changed, 17 insertions(+), 7 deletions(-) diff --git a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc b/Platfor

[edk2-devel] [edk2-platforms][PATCH V1 3/5] Platform/ARM/N1Sdp: NOR flash Dxe Driver for N1Sdp

2023-11-16 Thread sahil
Add NOR flash DXE driver, this brings up NV storage on QSPI's flash device using FVB protocol. Signed-off-by: sahil --- Platform/ARM/N1Sdp/N1SdpPlatform.dec |5 +- Platform/ARM/N1Sdp/Drivers/CadenceQspiDxe/CadenceQspiDxe.inf | 72 ++ Platform/ARM/N1Sdp/Drivers/Caden

[edk2-devel] [edk2-platforms][PATCH V1 2/5] Silicon/ARM/NeoverseN1Soc: NOR flash library for N1Sdp

2023-11-16 Thread sahil
Add NOR flash library, this library provides APIs for getting the list of NOR flash devices on the platform. Signed-off-by: sahil --- Silicon/ARM/NeoverseN1Soc/Library/NorFlashLib/NorFlashLib.inf | 36 ++ Silicon/ARM/NeoverseN1Soc/Library/NorFlashLib/NorFlashLib.c | 52 ++

[edk2-devel] [edk2-platforms][PATCH V1 0/5] Enable non volatile storage on N1SDP

2023-11-16 Thread sahil
N1SDP uses an emulated variable storage on DDR memory for the variable storage. But this emulated variable storage is a volatile memory and so the values of variable cant persist on next reboot or in power cycle. In N1SDP platform, the SoC is connected to IOFPGA which has a Cadence Quad SPI (QSPI)

[edk2-devel] [edk2-platforms][PATCH V1 1/5] Silicon/ARM/NeoverseN1Soc: Enable SCP QSPI flash region

2023-11-16 Thread sahil
Enable SCP QSPI flash region access by adding it in the PlatformLibMem Signed-off-by: sahil --- Silicon/ARM/NeoverseN1Soc/Include/NeoverseN1Soc.h | 6 +- Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem.c | 10 -- 2 files changed, 13 insertions(+), 3 deletio

Re: [edk2-devel] [PATCH v2 15/30] EmbeddedPkg: Add PcdPrePiCpuIoSize width for LOONGARCH64

2023-11-16 Thread Leif Lindholm
On 2023-11-16 08:15, Pedro Falcato wrote: Leif, Can you clarify the meaning of PcdPrePiCpuIoSize? Not out of memory, so let's go exploring. > I was thinking it's > supposed to be the size of the port-mapped IO for the > architecture/platform (as hinted by in X64 = IA32 = 16, and ARM=0), > but

Re: [edk2-devel] [PATCH v2 15/30] EmbeddedPkg: Add PcdPrePiCpuIoSize width for LOONGARCH64

2023-11-16 Thread Chao Li
Hi Pedro, I think this size is the CPU IO or PCI IO space width, like you saied, LoongArch doesn't mapped the IO ports, but it has IO area. For example, it can map the LPC IO or PCI IO ports onto the physical addres space and register the CPU IO or PCI IO protocols to access them. The *Loon

Re: [edk2-devel] [PATCH v2] OvmfPkg/MemEncryptSevLib: Fix address overflow during PVALIDATE

2023-11-16 Thread Gerd Hoffmann
On Wed, Nov 15, 2023 at 11:51:53AM -0600, Michael Roth wrote: > The struct used for GHCB-based page-state change requests uses a 40-bit > bit-field for the GFN, which is shifted by PAGE_SHIFT to generate a > 64-bit address. However, anything beyond 40-bits simply gets shifted off > when doing this,

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

2023-11-16 Thread Pedro Falcato
On Tue, Nov 14, 2023 at 3:01 PM Laszlo Ersek wrote: > > On 11/13/23 22:33, Pedro Falcato wrote: > > On Mon, Nov 13, 2023 at 8:37 PM Rebecca Cran wrote: > >> > >> On 11/13/2023 1:08 PM, Michael Kubacki wrote: > >>> Yes. I just did it. It is relatively minor and impacts expected code > >>> areas. >

Re: [edk2-devel] [PATCH v2 15/30] EmbeddedPkg: Add PcdPrePiCpuIoSize width for LOONGARCH64

2023-11-16 Thread Pedro Falcato
On Wed, Nov 15, 2023 at 6:55 PM Leif Lindholm wrote: > > On 2023-11-06 03:29, Chao Li wrote: > > Added LoongArch64 architecture CPU IO width. > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=4584 > > > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Cc: Abner Chang > > Cc: Daniel Schaefer