Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members

2023-10-28 Thread Pedro Falcato
On Sat, Oct 28, 2023 at 8:23 PM Michael D Kinney wrote: > > Over the past few months, all the of the Maintainers and > Reviewers listed in Maintainers.txt have been contacted to make > sure Maintainers.txt accurately represents the TianoCore > community members that are actively participating in t

Re: [edk2-devel] [edk2-platforms][PATCH 2/2] OutOfBandManagement/IpmiFeaturePKg: Remove IpmiCommandLib.h from IpmiFeaturePkg

2023-10-28 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Please ignore this, Liming already gave RB. (https://edk2.groups.io/g/devel/message/109510) Thanks > -Original Message- > From: Chang, Abner > Sent: Wednesday, October 18, 2023 12:53 PM > To: devel@edk2.groups.io; Chang, Abner > Cc: Attar, AbdulLateef

Re: [edk2-devel] [PATCH edk2-platforms 0/4] IpmiFeaturePkg: Add server management features

2023-10-28 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Gong, Please note that your code may have conflict as IpmiCommandLib was removed (please check https://edk2.groups.io/g/devel/message/109510), now we are using the one under MdeModulePKg. Second, I had cleaned up those server management feature drivers and m

[edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members

2023-10-28 Thread Michael D Kinney
Over the past few months, all the of the Maintainers and Reviewers listed in Maintainers.txt have been contacted to make sure Maintainers.txt accurately represents the TianoCore community members that are actively participating in their roles. Based on specific feedback, bounced emails, and no res

[edk2-devel] [PATCH v2 0/1] UefiPayloadPkg: Fix Add FV broken on fit format and remove clang dependency for version check

2023-10-28 Thread brucex . wang
From: Gua Guo V2: Fix FIT Add FV failure broken. V1: Remove clang dependency. BruceX Wang (1): UefiPayloadPkg: Fix incorrect code on Fit function. UefiPayloadPkg/Tools/MkFitImage.py | 7 ++- UefiPayloadPkg/UniversalPayloadBuild.py | 10 -- 2 files changed, 6 insertions(+),

[edk2-devel] [PATCH v2 1/1] UefiPayloadPkg: Fix incorrect code on Fit function.

2023-10-28 Thread brucex . wang
From: BruceX Wang 1. Add firmware volume need to check firmware volume exist or not. 2. Remove clang version check dependency. Cc: Guo Dong Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: BruceX Wang --- UefiPayloadPkg/Tools/MkFitImage.py | 7 ++- UefiPayloadPkg/Universa

Re: [edk2-devel] [PATCH] Maintainers.txt: update Gary's email address

2023-10-28 Thread Michael D Kinney
Merged: https://github.com/tianocore/edk2/pull/4973 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110250): https://edk2.groups.io/g/devel/message/110250 Mute This Topic: https://groups.io/mt/93267348/21656 Group Owner: devel+ow...@edk2.g

Re: [edk2-devel] [PATCH v1 0/2] Upgrade edk2-pytools to latest

2023-10-28 Thread Laszlo Ersek
On 10/28/23 16:20, Laszlo Ersek wrote: > On 10/27/23 19:41, Joey Vagedes via groups.io wrote: >> Thank you for the reviews. Pending any reviews other maintainers of these >> packages would like to do, this patch series is ready to merge. I've updated >> the PR with the reviewed-by tags: >> >> htt

Re: [edk2-devel] SSL handshake in HTTPS boot if the certificate was signed with a root certificate

2023-10-28 Thread Laszlo Ersek
On 10/26/23 14:37, jacopo.r0...@gmail.com wrote: > Hi there, > > I was trying to HTTPs boot a virtual machine with the following > scenario: > > 1) I have a self signed root CA /root.crt /and then I use it to sign > another self signed certificate /myip.crt /for the IP address X.X.X.X > 2) I have a

Re: [edk2-devel] [PATCH v1 0/2] Upgrade edk2-pytools to latest

2023-10-28 Thread Laszlo Ersek
On 10/27/23 19:41, Joey Vagedes via groups.io wrote: > Thank you for the reviews. Pending any reviews other maintainers of these > packages would like to do, this patch series is ready to merge. I've updated > the PR with the reviewed-by tags: > > https://github.com/tianocore/edk2/pull/4966 I f

Re: [edk2-devel] [PATCH 0/2] Add Platform Hook Lib into StandaloneMmCore

2023-10-28 Thread Laszlo Ersek
On 10/27/23 18:08, Michael Kubacki wrote: > This allows ambiguous "platform" code in the critical path of the MM > core. Is this necessary? > > Do you need this for one feature that others might too and can be > abstracted? Or, do you plan to perform an unknown and arbitrary number > of changes be

Re: [edk2-devel] [edk2-platforms PATCH] Maintainers.txt: remove Isaac Oram's email address

2023-10-28 Thread Laszlo Ersek
On 10/25/23 10:35, Laszlo Ersek wrote: > Email to Isaac's address bounces ("5.1.0 Address > rejected"); remove that address. > > Cc: Abdul Lateef Attar > Cc: Abner Chang > Cc: Ashraf Ali S > Cc: Chasel Chiu > Cc: Eric Dong > Cc: Liming Gao > Cc: Nate DeSimone > Cc: Nickle Wang > Cc: Pedro

Re: [edk2-devel] [PATCH] Remove checking Smm Rev ID in AMD Save State lib when Reading Save State Register EFI_MM_SAVE_STATE_REGISTER_IO

2023-10-28 Thread Laszlo Ersek
On 10/27/23 07:36, Jacque Lin via groups.io wrote: > --- > UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c | 13 - > 1 file changed, 13 deletions(-) Why? (The commit message is empty.) Laszlo > > diff --git a/UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c > b/UefiCpuPkg/Li

Re: [edk2-devel] CodeQL and Apache Licensed Files

2023-10-28 Thread Laszlo Ersek
On 10/27/23 23:11, Michael Kubacki wrote: > I'd like to bring attention to Apache License 2.0 code in the CodeQL > series I sent to the mailing list for steward review. > > In particular, the files in the BaseTools/Plugin/CodeQL/analyze > directory of this patch: > > https://edk2.groups.io/g/deve

Re: [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev

2023-10-28 Thread Laszlo Ersek
On 10/27/23 23:31, Lendacky, Thomas via groups.io wrote: > On 10/27/23 03:05, Tan, Dun wrote: >> Hi all, >> >> Could you please help to review this patch set? In this patch set, the >> IoLib instance BaseIoLibIntrinsic is modified to support AMD SEV >> feature and the BaseIoLibIntrinsicSev is remov

Re: [edk2-devel] [PATCH v2 0/1] StandaloneMmCore finds drivers in uncompressed inner fv.

2023-10-28 Thread Laszlo Ersek
On 10/27/23 07:49, Ni, Ray wrote: > Wei, > Thanks for fixing the 3 issues. > Can you kindly separate the one patch to at least 2 patches? > One patch is to fix minor issues. > The other is to add support of nested uncompressed FV. Yes please! I'd even prefer a separate patch per individual issue

Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg: Fix the failure to find uncompressed inner FV.

2023-10-28 Thread Laszlo Ersek
On 10/27/23 04:21, Xu, Wei6 wrote: > Hi Laszlo, > > Thanks a lot for the review. > > I send review the patch v2 to fix: > - memory leaks on error paths > - missing object size checks before casting pointers to header types > (https://edk2.groups.io/g/devel/message/110160) Thanks, will check it.

Re: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: Sample python scripts for socket client capabilities on UEFI shell

2023-10-28 Thread Laszlo Ersek
On 10/27/23 18:27, Jayaprakash, N wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4580 > > This BZ has been created to provide the sample python scripts > to demonstrate the socket client capabilities using http library > on UEFI shell with the help of Python UEFI interpreter. > The h

Re: [edk2-devel] [PATCH v2 0/3] Add Variable Policy Audit App and Shell Command

2023-10-28 Thread Ard Biesheuvel
On Sat, 28 Oct 2023 at 03:18, Michael Kubacki wrote: > > From: Michael Kubacki > > Adds a new module (dynamic shell command) to ShellPkg that lists > variable policy information for all UEFI variables on the system. > > Some other UEFI variable related functionality is also included to > give a g