[edk2-devel] [PATCH 1/2] MdeModulePkg: UsbNetwork: fix Ethernet functional descriptor processing

2023-08-25 Thread Mike Maslenkin
This patch fixes wrong condition because of UINT16 value to integer promotion. NumberMcFilters is UINT16 value, so when bitwise shift operator applied to small integer type, the operation is preceded by integral promotion. This is described in MISRA-C:2004 guideline as Rule 10.5: "If the bitwise op

[edk2-devel] [PATCH 2/2] MdeModulePkg: UsbRndis: get rid of magic values

2023-08-25 Thread Mike Maslenkin
Replace magic values used for checking Base Class, SubClass and Protocol fields of USB Interface Descriptor. Add definitions for Base Class EFh (Miscellaneous) and RNDIS subclass. These definitions were taken from https://www.usb.org/defined-class-codes Cc: Richard Ho Cc: Rebecca Cran Signed-off

[edk2-devel] [PATCH 0/2] MdeModulePkg: small improvements to UsbNetwork

2023-08-25 Thread Mike Maslenkin
Please review small improvements to UsbNetwork Here is corresponding PR https://github.com/tianocore/edk2/pull/4762 Cc: Richard Ho Cc: Rebecca Cran Signed-off-by: Mike Maslenkin -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108039)

[edk2-devel] [PATCH v2] UefiPayloadPkg:Enhance the build processing for Universalpayload

2023-08-25 Thread kasimx . liu
From: KasimX Liu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4532 To Copy the PrebuildUplBinary to Build folder then add/replace Fvs. Cc: Guo Dong Cc: Ray Ni Cc: James Lu Cc: Gua Guo Signed-off-by: KasimX Liu --- UefiPayloadPkg/UniversalPayloadBuild.py | 8 +++- 1 file changed

[edk2-devel] [PATCH v2] UefiPayloadPkg:Enhance the build processing for Universalpayload

2023-08-25 Thread kasimx . liu
From: KasimX Liu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4532 To Copy the PrebuildUplBinary to Build folder then add/replace Fvs. Cc: Guo Dong Cc: Ray Ni Cc: James Lu Cc: Gua Guo Signed-off-by: KasimX Liu --- UefiPayloadPkg/UniversalPayloadBuild.py | 11 --- 1 file cha

Re: [edk2-devel] Can RELEASE target disable -Werror CC_FLAG？

2023-08-25 Thread 汪流
Is there an update on the status of the PR? Is there any additional information or feedback needed before it can be merged? This is the PR： https://github.com/tianocore/edk2/pull/4734 -原始郵件- 發件人:"汪流" 發送時間:2023-08-21 15:04:54 (星期一) 收件人: "Andrew (EFI) Fish" 抄送: devel@edk2.groups.io,

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc/StdLib: Fix console jump to 0, 0 issue in lseek()

2023-08-25 Thread Jayaprakash, N
Reviewed the changes and it looks good. Also verified that the fix solves the problem. Reviewed-by : Jayaprakash N -Original Message- From: devel@edk2.groups.io On Behalf Of Jayaprakash, N Sent: Thursday, August 24, 2023 10:04 PM To: devel@edk2.groups.io Cc: Jayaprakash, N ; Rebecca Cra

Re: [edk2-devel] [PATCH v2] UefiPayloadPkg:Enhance the build processing for Universalpayload

2023-08-25 Thread Lu, James
Reviewed-by: James Lu Thanks, James -Original Message- From: Liu, KasimX Sent: Friday, August 25, 2023 5:28 PM To: devel@edk2.groups.io Cc: Liu, KasimX ; Dong, Guo ; Ni, Ray ; Lu, James ; Guo, Gua Subject: [PATCH v2] UefiPayloadPkg:Enhance the build processing for Universalpayload

Re: [edk2-devel] [PATCH v2] UefiPayloadPkg:Enhance the build processing for Universalpayload

2023-08-25 Thread Guo, Gua
Reviewed-by: Gua Guo -Original Message- From: Liu, KasimX Sent: Friday, August 25, 2023 5:28 PM To: devel@edk2.groups.io Cc: Liu, KasimX ; Dong, Guo ; Ni, Ray ; Lu, James ; Guo, Gua Subject: [PATCH v2] UefiPayloadPkg:Enhance the build processing for Universalpayload From: KasimX Liu

Re: [edk2-devel] [PATCH 0/1] UefiPayloadPkg: Match BAR if framebuffer is at an offset

2023-08-25 Thread Sheng Lean Tan
Hi Michael, You will need to CC the maintainers/reviewers for UEFIpayloadpkg. I have added them in ;) Best Regards, *Lean Sheng Tan* 9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany Email: sheng@9elements.com Phone: *+49 234 68 94 188 <+492346894188>* Mobile: *+49 176 76 113842 <+49