[edk2-devel] [PATCH 1/1] ShellPkg/SmbiosView: Update display of PCIe system slot ID

2023-08-17 Thread Nhi Pham via groups.io
This updates the system slot ID up to SlotTypePCIExpressGen6andBeyond (0xC4) to cover modern PCIe Gen. Cc: Zhichao Gao Signed-off-by: Nhi Pham --- ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ShellPkg/Libr

Re: [edk2-devel] [PATCH V2 0/2] Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

2023-08-17 Thread Zeng, Star
I have given review to both patches and Zhichao has given review to ShellPkg patch. Liming, need your help to review and merge the patches. šŸ˜Š Thanks, Star -Original Message- From: devel@edk2.groups.io On Behalf Of Eduardo Cuevas Farfan Sent: Friday, August 11, 2023 12:32 AM To: devel@e

Re: [edk2-devel] About EDK2 supports Self Modifying Code

2023-08-17 Thread Andrew Fish via groups.io
> On Aug 17, 2023, at 12:53 PM, Michael D Kinney > wrote: > > How many different integer values are needed by FW for use of the csrrd > instruction? > MIke, Iā€™m no expert on this and I just tried to site read a specification for the 1st timeā€¦. It looks to me the like the arch spec does n

Re: [edk2-devel] Can RELEASE target disable -Werror CC_FLAGļ¼Ÿ

2023-08-17 Thread Michael D Kinney
Hi Pedro, I agree that compiler and static analysis absolutely do get false positive results. When we see these, we have a choice to make * Document for all consumers that a specific tool has a false positive and we can all safely ignore the report. This is challenging to communicate these to

Re: [edk2-devel] Can RELEASE target disable -Werror CC_FLAGļ¼Ÿ

2023-08-17 Thread Pedro Falcato
On Thu, Aug 17, 2023 at 9:00ā€ÆPM Michael D Kinney wrote: > > I am surprised this same GCC error is not being seen for other CPU archs. > > > > The simple fix is to this specific issue is to initialize CommandLine to NULL > at the beginning of the function. The correct fix here is to -Wno-error=ma

Re: [edk2-devel] Can RELEASE target disable -Werror CC_FLAGļ¼Ÿ

2023-08-17 Thread Michael D Kinney
I am surprised this same GCC error is not being seen for other CPU archs. The simple fix is to this specific issue is to initialize CommandLine to NULL at the beginning of the function. We have observed that compilers continue to add more and more static analysis like features over time. Code

Re: [edk2-devel] About EDK2 supports Self Modifying Code

2023-08-17 Thread Michael D Kinney
How many different integer values are needed by FW for use of the csrrd instruction? There are examples of access functions on x86 for things like mm0, mm1, mm2, ā€¦, mm7 and cs, ds, es, ss, fs, gs. These are implemented as different BaseLib APIs because they would also require SMC to do in a si

Re: 回复: edk2-stable202308 Re: [edk2-devel][PATCH v1 1/1] MdeModulePkg: HeapGuard: Don't Assume Pool Head Allocated In First Page

2023-08-17 Thread Oliver Smith-Denny
On 8/15/2023 6:40 PM, gaoliming wrote: Oliver: This change reverts the changes done in AdjustPoolHeadA(). It matches the allocation logic. I think this change is good. Reviewed-by: Liming Gao I am also OK to merge this change for the stable tag 202308. Besides, AdjustPoolHeadA() implem

[edk2-devel] [PATCH v1 0/1] TCG MemoryOverwriteRequest Tests

2023-08-17 Thread Abhimanyu Singh
These tests support platform firmware that implement MemoryOverwriteRequestControl & MemoryOverwriteRequestControlLock UEFI variables in accordance with TCG PC Platform Reset Attack Mitigation Specification. The first patch contains the Platform Reset Check Test that is defined in the SCT spec.

[edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: TCG MemoryOverwriteRequest

2023-08-17 Thread Abhimanyu Singh
From: "Abhi.Singh" SCT Platform Reset Check Test SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 Test: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement initial test infrastructure for all test cases including updates to: CommonGenFramework.sh, UEFI_SCT.dsc, and Ca

Re: [edk2-devel] Error F001: Module SmmLockBox.inf NOT found

2023-08-17 Thread Andrew Fish via groups.io
I think I may have botched this message in moderationā€¦. Andrew, Did you update the submodule? git submodule update ā€”init See Submodules under this section of the ReadMe.rst: https://github.com/tianocore/edk2 What were you trying to build? Thanks, Andrew Fish > Subject: Error F001: Module SmmL

[edk2-devel] Error F001: Module SmmLockBox.inf NOT found

2023-08-17 Thread kamchatnikov via groups.io
Hi, I have cloned edk from git: I have got an error: Error F001: Module SmmLockBox.inf NOT found in DSC file; Is it really a binary module? I did not make any changes, just trying to build. How can I solve it? Thank you in advance, Andrew -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receiv

Re: [edk2-devel] [PATCH 1/1] OutOfBandManagement/SpcrFeaturePkg: PCD based IRQ/GSI

2023-08-17 Thread Attar, AbdulLateef (Abdul Lateef) via groups.io
[AMD Official Use Only - General] Gentle reminder, review please. -Original Message- From: Chang, Abner Sent: Thursday, August 3, 2023 12:12 PM To: Attar, AbdulLateef (Abdul Lateef) ; devel@edk2.groups.io Cc: Attar, AbdulLateef (Abdul Lateef) ; Sai Chaganty ; Isaac Oram ; Nate DeSimon

[edk2-devel] Error F001: Module SmmLockBox.inf NOT found

2023-08-17 Thread kamchatnikov via groups.io
Hi, I have cloned edk from git: I have got an error: Architecture(s): IA32 X64 Build target = RELEASE Toolchain =GCC5 Error F001: Module SmmLockBox.inf NOT found in DSC file; Is it really a binary module? I did not make any changes, just trying to build. How can I solve it? Thank you in adv

Re: [edk2-devel] Can RELEASE target disable -Werror CC_FLAGļ¼Ÿ

2023-08-17 Thread Andrew Fish via groups.io
Can you add -Wno-maybe-uninitialized to compiler flags to work around the error?On Aug 16, 2023, at 11:31 PM, ę±Ŗ굁 wrote:ļ»æ This is the failed build log:Ā https://build.tarsier-infra.com/package/live_build_log/home:ouuleilei:branches:openEuler:Mainline/edk2/openEuler_Mainline_standard_riscv64_gcc/ris

Re: [edk2-devel] [PATCH edk2-platforms v3 3/3] Platform/SbsaQemu: handle systems without GIC ITS

2023-08-17 Thread Marcin Juszkiewicz
W dniu 19.07.2023 oĀ 14:08, Marcin Juszkiewicz via groups.io pisze: If firmware is used with QEMU 8.0 or older then there will be no GIC ITS support. In such case we would not add information about it into MCFG and there will be no IORT table. Signed-off-by: Marcin Juszkiewicz --- .../Qemu/Sb

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/QemuSbsa: enlarge firmware offsets

2023-08-17 Thread Leif Lindholm
On Wed, Aug 16, 2023 at 18:33:33 +0200, Marcin Juszkiewicz wrote: > GenFv: ERROR 3000: Invalid > the required fv image size 0x216510 exceeds the set fv image size 0x20 > > Signed-off-by: Marcin Juszkiewicz Reviewed-by: Leif Lindholm Presumably caused by the openssl3 shenanigans. But rega

Re: [edk2-devel] [edk2-staging/crypto-new-api][PATCH] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1u

2023-08-17 Thread Heng Luo
Reviewed-by: Heng Luo > -Original Message- > From: Li, Yi1 > Sent: Thursday, August 17, 2023 3:10 PM > To: devel@edk2.groups.io > Cc: Sheng, W ; Gao, Zhichao ; > Luo, Heng ; Li, Yi1 > Subject: [edk2-staging/crypto-new-api][PATCH] CryptoPkg/OpensslLib: > Upgrade OpenSSL to 1.1.1u > > Fr

[edk2-devel] [edk2-staging/crypto-new-api][PATCH] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1u

2023-08-17 Thread Li, Yi
From: Sheng Wei (cherry-pick from: master b2de9ec5a759aa4a7ac029cda9079dce077bf856) Cc: Zhichao Gao Cc: Heng Luo Signed-off-by: Yi Li --- CryptoPkg/Library/OpensslLib/OpensslLib.inf | 1 - CryptoPkg/Library/OpensslLib/OpensslLibFull.inf | 1 - CryptoPkg/Library/OpensslLib/openssl