Hi Isaac,
Seems Uncrustify has not done this for IpmiFeaturePkg. Do I need to provide the
changes for the complete IpmiFeaturePkg or for my changes alone fine?
Sure, I will use the PCD directly instead of macros. the main concern of #if is
to avoid compiler warnings when the library is not mapp
I updated the patch per Zhiguang's comments to remove ALIGN 16 requirement.
Can you please review again?
Only the 2nd patch is updated.
Thanks,
Ray
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ni, Ray
> Sent: Wednesday, June 21, 2023 10:55 AM
> To: devel@edk2.groups.io
From: Abdul Lateef Attar
Current logo INF and IDF files are used for server
platform logo. Additional INF, IDF and logo image
files are required for other platform usages but
leverage logo source files.
Set PcdAmdDisplayLogoEventGuid to change the event
GUID for displaying logo.
Signed-off-by: A
From: Abner Chang
Platform/AMD/AmdPlatformPkg provides the AMD edk2 common
platform drivers and libraries for AMD server, client
and Strategic Silicon Solutions (S3) platforms.
Signed-off-by: Abner Chang
Cc: Abdul Lateef Attar
---
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 18 +++
Reviewed-by: jiewen@intel.com
发件人: Gerd Hoffmann
发送时间: 星期二, 六月 20, 2023 10:41 下午
收件人: devel@edk2.groups.io ; Li, Yi1
抄送: Ard Biesheuvel ; Yao, Jiewen
; Justen, Jordan L
主题: Re: [edk2-devel] [PATCH] OvmfPkg/PlatformCI: Skip
GCC5_OVMF_IA32X64_FULL_NOOPT buil
Hello, I didn’t mean LTO doesn't work.
For the NOOPT build target, we did not enable LTO or any optimization flag:
DEBUG_GCC5_IA32_DLINK_FLAGS= DEF(GCC5_IA32_X64_DLINK_FLAGS) -flto -Os
-Wl,-m,elf_i386,--oformat=elf32-i386
NOOPT_GCC5_IA32_DLINK_FLAGS= DEF(GCC5_IA32_X64_DLINK_FLAGS)
-Wl,-m
Hello, edk2 stewards,
Could you please help this case?
Thanks,
Chasel
From: devel@edk2.groups.io On Behalf Of cbduggap
Sent: Sunday, June 18, 2023 10:28 PM
To: devel@edk2.groups.io
Subject: [edk2-devel] Need help to add me to the edk-ii-maintainers and
edk-ii-reviewers team
HI All
I signed
ResetVector assembly implementation puts "ALIGN 16" in the end
to guarantee the final executable file size is multiple of 16 bytes.
Because the module uses a special GUID which guarantees it's put in
the very end of a FV, which should be also the end of the FD.
All of these (file size is multiple o
Because it's simpler for a platform to include the ResetVector source
and having pre-built binaries add burdens of updating the pre-built
binaries. This patch removes the pre-built binaries and the script
that buids the pre-built binaries.
Signed-off-by: Ray Ni
Cc: Eric Dong
Cc: Rahul Kumar
Ack
Since ResetVector source module shares the same GUID as the binary
module, the binary INF file is just removed from DSC.
Signed-off-by: Ray Ni
Cc: Eric Dong
Cc: Rahul Kumar
Acked-by: Gerd Hoffmann
---
UefiCpuPkg/UefiCpuPkg.dsc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --
Ray Ni (3):
UefiCpuPkg: Include ResetVector in DSC
UefiCpuPkg/ResetVector: Add guidance of FDF ffs rule
UefiCpuPkg/ResetVector: Remove pre-built binaries
.../Vtf0/Bin/IA32/ResetVector.ia32.port80.raw | Bin 532 -> 0 bytes
.../Vtf0/Bin/IA32/ResetVector.ia32.raw| Bin 500 -> 0 bytes
.
From: Abner Chang
Signed-off-by: Abner Chang
Cc: Abdul Lateef Attar
---
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 3 +
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc | 69
.../DxeAcpiSdtParserLib.inf | 33 ++
.../Include/Library/AmdAcpiSdtParserLib.h | 118 +
From: Abner Chang
Platform/AMD/AmdPlatformPkg provides the AMD edk2 common
platform drivers and libraries for AMD server, client
and Strategic Silicon Solutions (S3) platforms.
Signed-off-by: Abner Chang
Cc: Abdul Lateef Attar
---
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 18 +++
From: Abner Chang
AMD simulator port 80 serial port library.
Signed-off-by: Abner Chang
Cc: Abdul Lateef Attar
---
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc | 71 ++
.../SimulatorSerialPortLibPort80.inf | 31 +++
.../SimulatorSerialPortLibPort80.c| 207 +
From: Abner Chang
Platform/AMD/AmdPlatformPkg provides the AMD edk2 common
platform drivers and libraries for AMD server, client
and Strategic Silicon Solutions (S3) platforms.
Signed-off-by: Abner Chang
Cc: Abdul Lateef Attar
---
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 18 +++
Series:
Acked-by: Peter Grehan
later,
Peter.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106228): https://edk2.groups.io/g/devel/message/106228
Mute This Topic: https://groups.io/mt/99643180/21656
Group Owner: devel+ow...@edk2.grou
I believe someone is currently working on it.
—
Rebecca
On Tue, Jun 20, 2023, at 4:56 PM, joe.hasselst...@icloud.com wrote:
> Greetings,
>
> I was wondering if the wiki task "Port C Tools to Python” is still
> relevant for the EDK2 project and if so I’d like to start working on
> it. Any sugge
On Tue, 20 Jun 2023, 12:11 Li, Yi, wrote:
> The effect of LTO is limited with optimization turned off, and blocked
> the upgrade of Openssl3.0. We already skipped this build with VS2019,
> skip the GCC NOOPT build also.
>
Hi,
If LTO is the problem here, have you given ffunction-sections +
fdata-
[AMD Official Use Only - General]
> -Original Message-
> From: Mike Maslenkin
> Sent: Wednesday, June 21, 2023 5:32 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; nick...@nvidia.com;
> ig...@ami.com; Mike Maslenkin
> Subject: [PATCH] [edk2-redfish-client] Remove reference to BaseSort
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Mike Maslenkin
> Sent: Wednesday, June 21, 2023 5:30 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; nick...@nvidia.com;
> ig...@ami.com; Mike Maslenkin
> Subject: [PATCH] RedfishPkg: Fix SortLib
There are two problems with BaseSortLib reference:
1 BaseSortLib is the library instance name not the class name.
2 UefiSortLib instance from MdeModulePkg is also referenced below.
Let's use only one reference to SortLib.
Even though Redfish Client uses only quick sort for char* elements,
UefiSort
BaseSortLib is the library instance name not the class name.
Signed-off-by: Mike Maslenkin
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
---
RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf | 2 +-
RedfishPkg/RedfishLibs.dsc.inc| 2 +-
2 files chang
I don't think a MemoryAttributes2Protocol with a single API would have
avoided the errors.
The programming pattern that triggered this would still need multiple
calls to any API and in the future where all memory is allocated as NX
this possibility would still exist.
A short term effort to m
On Tue, Jun 20, 2023 at 04:16:40PM +0300, Ard Biesheuvel wrote:
> On Tue, Jun 20, 2023, 12:33 Gerd Hoffmann wrote:
>
> > On Mon, Jun 19, 2023 at 10:32:25PM +0200, Oliver Steffen wrote:
> > > Recent versions of shim (15.6 and 15.7) crash when the newly added
> > > EFI_MEMORY_ATTRIBUTE_PROTOCOL is
We recently encountered this issue as well.
For reference, some details are in this issue:
https://github.com/microsoft/mu_silicon_arm_tiano/issues/124
Specifically, this comment:
https://github.com/microsoft/mu_silicon_arm_tiano/issues/124#issuecomment-1593550704
On 6/20/2023 9:16 AM, Ard Bies
On Tue, Jun 20, 2023 at 07:11:39PM +0800, Li, Yi wrote:
> The effect of LTO is limited with optimization turned off, and blocked
> the upgrade of Openssl3.0. We already skipped this build with VS2019,
> skip the GCC NOOPT build also.
>
> Signed-off-by: Yi Li
> Cc: Ard Biesheuvel
> Cc: Jiewen Yao
On Mon, Jun 12, 2023 at 07:27:37PM +, Kallol Biswas [C] wrote:
> Hi,
> We have been observing an issue that IO BARs can't be claimed due to
> resource
> conflict.
>
> [0.457693] pci :00:1d.0: can't claim BAR 4 [io 0x92a0-0x92bf]:
> address conflict with PCI Bus :01 [io 0x90
On Mon, Jun 12, 2023 at 09:37:18PM +0800, Yuanhao Xie wrote:
> Refactor the logic for placing APs in
> Mwait/Runloop into a separate function.
> +// If AP start-up signal is written, AP is waken up
> +// otherwise place AP in loop again
> +//
> +if ((*ApStartupSignalBuffer == WAKEU
Hi,
> +typedef struct {
> + UINT32ApicId;
> + UINT32Health;
> + UINT64StartupSignalAddress;
> + UINT64StartupProcedureAddress;
> +} PROCESSOR_HAND_OFF;
> +
> +typedef struct {
> + //
> + // The ProcessorIndex indicates the range of processors. If it is set to
> 0, it signi
On Tue, Jun 20, 2023, 12:33 Gerd Hoffmann wrote:
> On Mon, Jun 19, 2023 at 10:32:25PM +0200, Oliver Steffen wrote:
> > Recent versions of shim (15.6 and 15.7) crash when the newly added
> > EFI_MEMORY_ATTRIBUTE_PROTOCOL is provided by the firmware. To allow
> > existing installations to boot, pr
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Leif Lindholm
Cc: Peter Grehan
Cc: Rebecca Cran
Cc: Sami Mujawar
---
OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/OvmfPkg/Bhyve/Ac
This makes the InstallQemuFwcfgTables function reusable by bhyve.
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Leif Lindholm
Cc: Peter Grehan
Cc: Rebecca Cran
Cc: Sami Mujawar
---
OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
This is required to move InstallQemuFwCfgTables into AcpiPlatformLib.
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Leif Lindholm
Cc: Peter Grehan
Cc: Rebecca Cran
Cc: Sami Mujawar
---
OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf |
Bhyve supports providing ACPI tables by FwCfg. Therefore,
InstallQemuFwCfgTables should be moved to AcpiPlatformLib to reuse the
code. As first step, move PciEncoding into AcpiPlatformLib.
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Le
The definition and declaration of GetAcpiRsdpFromMemory doesn't match.
We don't get a compile error yet because UINTN is the same as UINT64 on
64bit machines. As the function works on memory addresses, UINTN is the
correct type of the input parameters.
Signed-off-by: Corvin Köhne
Tested-by: Gerd
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Leif Lindholm
Cc: Peter Grehan
Cc: Rebecca Cran
Cc: Sami Mujawar
---
OvmfPkg/Include/Library/AcpiPlatformLib.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/OvmfPkg/Include/Lib
CI: https://github.com/tianocore/edk2/pull/4545
Corvin Köhne (6):
OvmfPkg/Library: fix definition of GetAcpiRsdpFromMemory
OvmfPkg: avoid including AcpiPlatformLib twice
OvmfPkg: move PciEncoding into AcpiPlatformLib
OvmfPkg: move BootScript into AcpiPlatformLib
OvmfPkg: move QemuFwCfgAc
The effect of LTO is limited with optimization turned off, and blocked
the upgrade of Openssl3.0. We already skipped this build with VS2019,
skip the GCC NOOPT build also.
Signed-off-by: Yi Li
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
---
.../PlatformCI/.azurepipe
Add a readme file which provides information regarding how
to build and test EDK2 on RISC-V qemu virt platform.
Signed-off-by: Sunil V L
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Andrei Warkentin
Cc: Heinrich Schuchardt
---
OvmfPkg/RiscVVirt/README.md | 49 +
Currently, RiscVVirtQemu supports unified code and variable store
mainly because only one pflash devices was available in qemu for
EDK2. However, this doesn't allow to map the code part as read-only.
With recent qemu enhancements, it is now possible for EDK2 to make
use of both pflash devices in R
This library is required to support separate code and
variable store images.
Signed-off-by: Sunil V L
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Andrei Warkentin
Cc: Heinrich Schuchardt
---
.../VirtNorFlashDeviceTreeLib.inf | 40 +
.../VirtNo
The size of the FV and the WriteQueueSize is incorrect which causes
the flash to be re-written during boot. Fix them and update the new
checksum value.
Signed-off-by: Sunil V L
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Andrei Warkentin
Cc: Heinrich Schuchardt
Recent updates to RISC-V qemu virt platform merged today (07/14),
have enabled both pflash devices for the S-mode payload like EDK2.
These updates also aligned the design similar to other architectures
where pflash0 is for read-only code and pflash1 for variable store.
Previously only pflash1 was a
Ray:
After ExitBS, you can update CreatePerformanceMeasurement() API directly
returns EFI_UNSUPPORTED. Then, no PERF record will be handled. With this
change, you don't need to update SmmPerformanceLib.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Ni, Ray
> 发送时间: 2023年6月13日 14
On Mon, Jun 19, 2023 at 10:32:25PM +0200, Oliver Steffen wrote:
> Recent versions of shim (15.6 and 15.7) crash when the newly added
> EFI_MEMORY_ATTRIBUTE_PROTOCOL is provided by the firmware. To allow
> existing installations to boot, provide a workaround in form of a Pcd
> that allows tuning it
From: Mark Wilson
This module overrides BlockToConfig and ConfigToBlock
interfaces for the better performance.
Signed-off-by: Abner Chang
Cc: Abdul Lateef Attar
Cc: Mark Wilson
---
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc | 33 +
.../HiiConfigRouting/AmdConfigRouting.inf | 45 +
From: Abner Chang
Platform/AMD/AmdPlatformPkg provides the AMD edk2 common
platform drivers and libraries for AMD server, client
and Strategic Silicon Solutions (S3) platforms.
Signed-off-by: Abner Chang
Cc: Abdul Lateef Attar
---
.../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 18 +++
On Mon, Jun 19, 2023 at 03:12:23PM +0200, Corvin Köhne wrote:
> The definition and declaration of GetAcpiRsdpFromMemory doesn't match.
> We don't get a compile error yet because UINTN is the same as UINT64 on
> 64bit machines. As the function works on memory addresses, UINTN is the
> correct type o
From: LakX Huang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4485
Add Google Mock Library for UefiBootServicesTableLib
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: LakX Huang
---
MdePkg/Test/MdePkgHostTest.dsc| 1 +
.../Library/MockUefiBootS
Add StandaloneMmIplPei IA32/X64 driver at PEI stage.
FSP will use this driver to load Standalone MM code
to dispatch other Standalone MM drivers.
Signed-off-by: Hongbin1 Zhang
Cc: Jiewen Yao
Cc: Ray Ni
Cc: Star Zeng
Cc: Jiaxin Wu
Cc: Sami Mujawar
Cc: Ard Biesheuvel
Cc: Supreeth Venkatesh
-
Add StandaloneMmIplPei IA32/X64 driver at PEI stage.
FSP will use this driver to load Standalone MM code
to dispatch other Standalone MM drivers.
Signed-off-by: Hongbin1 Zhang
Cc: Jiewen Yao
Cc: Ray Ni
Cc: Star Zeng
Cc: Jiaxin Wu
Cc: Sami Mujawar
Cc: Ard Biesheuvel
Cc: Supreeth Venkatesh
-
On 6/16/23 12:16, Sunil V L wrote:
Add a readme file which provides information regarding how
to build and test EDK2 on RISC-V qemu virt platform.
Signed-off-by: Sunil V L
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Andrei Warkentin
Unfortunately you only se
Add StandaloneMmIplPei IA32/X64 driver at PEI stage.
FSP will use this driver to load Standalone MM code
to dispatch other Standalone MM drivers.
Signed-off-by: Hongbin1 Zhang
Cc: Jiewen Yao
Cc: Ray Ni
Cc: Star Zeng
Cc: Jiaxin Wu
Cc: Sami Mujawar
Cc: Ard Biesheuvel
Cc: Supreeth Venkatesh
-
Add StandaloneMmIplPei IA32/X64 driver at PEI stage.
FSP will use this driver to load Standalone MM code
to dispatch other Standalone MM drivers.
Signed-off-by: Hongbin1 Zhang
Cc: Jiewen Yao
Cc: Ray Ni
Cc: Star Zeng
Cc: Jiaxin Wu
Cc: Sami Mujawar
Cc: Ard Biesheuvel
Cc: Supreeth Venkatesh
-
Add StandaloneMmIplPei IA32/X64 driver at PEI stage.
FSP will use this driver to load Standalone MM code
to dispatch other Standalone MM drivers.
And this is the 1st patch to implement the entrypoint
to find the correct SMRAM range and dump it
Signed-off-by: Hongbin1 Zhang
Cc: Jiewen Yao
Cc: Ray
Hi Sunil/Pedro,
1. As you know, ProcessorBind.h file of CPU Architecture file declares sets of
base types for edk2 code compiling.
So data type in edk2 code doesn't rely on specific compiler (msvc, gcc etc.),
which is a good design.
But in practice, for the purpose of reuse, some code can be bu
Different symbol (PROCESSOR_BIND_H__) define in RISCV64 ProcessorBinding.h
from other CPU Arch. An unexception compilation error generated
if include __PROCESSOR_BIND_H__ symbol in header file for
cross-platform compiling.
Cc: Andrei Warkentin
Cc: Sunil V L
Cc: Yimin Wang
Cc: Alan Sheng
Signed
57 matches
Mail list logo
