回复: [edk2-devel] 回复: [PATCH 2/2] ShellPkg/UefiShellDebug1CommandsLib: Replace hardcoded SMBIOS strings.

Giri: I create PR https://github.com/tianocore/edk2/pull/4350 to merge this patch. But, Open CI reports the below issue. Please help fix them. ERROR - ERROR - EFI coding style error ERROR - *Error code: 9004 ERROR - *For comment line with '///< ... text ...' format, if it is used, it should be

回复: [edk2-devel] [Patch 1/1] BaseTools/Conf: Add quotes to ADDDEBUGFLAG in tools_def.txt

Mike: I also see GCC_DLINK2_FLAGS_COMMON option uses / as the file path. Does it bring the same problem in Windows OS? DEFINE GCC_DLINK2_FLAGS_COMMON = -Wl,--script=$(EDK_TOOLS_PATH)/Scripts/GccBase.lds Thanks Liming > -邮件原件- > 发件人: Kinney, Michael D > 发送时间: 2023年5月6日 12:55 > 收件

Re: [edk2-devel] [Patch 1/1] BaseTools/Conf: Add quotes to ADDDEBUGFLAG in tools_def.txt

The issue I saw was a mix of / and \ in the file path. On Windows $(DEBUG_DIR) would Have '\' in path and then a '/' before $(MODULE_NAME). Without the quotes, this would generate an error. With quotes, it would get the full filename correct. On Linux, only '/' are used for the whole path and

[edk2-devel] [PATCH v11 7/8] UefiCpuPkg: Removes SmmCpuFeaturesReadSaveStateRegister

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Removes SmmCpuFeaturesReadSaveStateRegister and SmmCpuFeaturesWirteSaveStateRegister function from SmmCpuFeaturesLib library. MmSaveStateLib library replaces the functionality of the above functions. Platform old/new need to use MmSaveState

[edk2-devel] [PATCH v11 8/8] OvmfPkg: Uses MmSaveStateLib library

From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Uses new MmSaveStateLib library instance. Cc: Paul Grimes Cc: Abner Chang Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Signed-off-by: Abdul

[edk2-devel] [PATCH v11 6/8] UefiCpuPkg: Implements MmSaveStateLib for Intel

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Implements MmSaveStateLib library interfaces to read and write save state registers for Intel processor family. Moves Intel and AMD common functionality to common area. Cc: Paul Grimes Cc: Abner Chang Cc: Eric Dong Cc: Ray Ni Cc: Rahul

[edk2-devel] [PATCH v11 5/8] UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family

From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Implements interfaces to read and write save state registers of AMD's processor family. Initializes processor SMMADDR and MASK depends on PcdSmrrEnable flag. Program or corrects the IP once control returns from SMM.

[edk2-devel] [PATCH v11 3/8] UefiCpuPkg: Implements MmSaveStateLib library instance

From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Implements MmSaveStateLib Library class for AMD cpu family. Cc: Paul Grimes Cc: Abner Chang Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Abdul Lateef Attar Reviewed-by: Abner Ch

[edk2-devel] [PATCH v11 4/8] UefiCpuPkg/SmmCpuFeaturesLib: Restructure arch-dependent code

From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 moves Intel-specific code to the arch-dependent file. Other processor families might have different implementation of these functions. Hence, moving out of the common file. Cc: Abner Chang Cc: Paul Grimes Cc: Eri

[edk2-devel] [PATCH v11 1/8] MdePkg: Adds AMD SMRAM save state map

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Adds an SMM SMRAM save-state map for AMD processors. SMRAM save state maps for the AMD processor family are now supported. Save state map structure is added based on AMD64 Architecture Programmer's Manual, Volume 2, Section 10.2. The AMD le

[edk2-devel] [PATCH v11 2/8] UefiCpuPkg: Adds MmSaveStateLib library class

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Adds MmSaveStateLib Library class in UefiCpuPkg.dec. Adds function declaration header file. Cc: Paul Grimes Cc: Abner Chang Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Abdul Lateef Attar Reviewed-by: Abn

[edk2-devel] [PATCH v11 0/8] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib

PR: https://github.com/tianocore/edk2/pull/4341 V11: Delta changes Drop the OVMF implementation of MmSaveStateLib V10: Delta changes: Addressed review comments from Abner. V9: Delta changes: Addressed review comments. Rename to MmSaveStateLib. Also rename SMM_ defines to MM_. Implemented

回复: [edk2-devel] [Patch 1/1] BaseTools/Conf: Align CLANGDWARF and CLANGPDB warning overrides

Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Michael D > Kinney > 发送时间: 2023年5月6日 10:38 > 收件人: devel@edk2.groups.io > 抄送: Rebecca Cran ; Liming Gao > ; Bob Feng ; Yuwei Chen > > 主题: [edk2-devel] [Patch 1/1] BaseTools/Conf: Align CLANGDWARF and > CLANGPDB warning overr

回复: [edk2-devel] [Patch 1/1] BaseTools/Conf: Add quotes to ADDDEBUGFLAG in tools_def.txt

Mike: Do you mean $(DEBUG_DIR)/$(MODULE_NAME).debug file path may have space on windows OS? Does the workspace directory include the space? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Michael D > Kinney > 发送时间: 2023年5月6日 10:47 > 收件人: devel@edk2.groups.io > 抄送: Rebecca Cran ; L

[edk2-devel] [edk2-platforms:PATCH V1] MinPlatformPkg/SaveMemoryConfig: Support NVS Data compression.

Around 50KB "FspNonVolatileStorageHob" data can be compressed to approximately 3 KB which can save NVRAM space and enhance life of the SPI part by decreasing the number of reclaim cycles needed. This patch added support to compress "FspNonVolatileStorageHob" data before saving to NVRAM. A PcdEnab

[edk2-devel] [Patch 1/1] BaseTools/Conf: Add quotes to ADDDEBUGFLAG in tools_def.txt

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4448 Update tools_def.txt to add quotes around the file target in OBJCOPY_ADDDEBUGFLAGS for compatibility with GCC like tool chains used on Windows. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Signed-off-by: Michael D Kinney

[edk2-devel] [Patch 1/1] BaseTools/Conf: Align CLANGDWARF and CLANGPDB warning overrides

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4447 Fix build error related to use of DEBUG_CODE_BEGIN() and DEBUG_CODE_END(). CLANGPDB requires extra warning disables for use of DebugLib.h macros. This change aligns the warning disables between CLANGDWARF and CLANGPDB. Cc: Rebecca Cran Cc

[edk2-devel] 回复: [PATCH v1 03/11] MdePkg/Acpi64: Add _PSD/_CPC/State Coordination Types macros

Pierre: > -邮件原件- > 发件人: pierre.gond...@arm.com > 发送时间: 2023年5月5日 21:17 > 收件人: devel@edk2.groups.io > 抄送: Ard Biesheuvel ; Leif Lindholm > ; Sami Mujawar ; Michael D > Kinney ; Liming Gao > ; Zhiguang Liu > 主题: [PATCH v1 03/11] MdePkg/Acpi64: Add _PSD/_CPC/State Coordination > Types macro

回复: [edk2-devel] [Patch 1/1] MdeModulePkg/CapsuleApp: Add EFIAPI to CompareFileNameInAlphabet()

Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Michael D > Kinney > 发送时间: 2023年5月6日 1:10 > 收件人: devel@edk2.groups.io > 抄送: Jian J Wang ; Liming Gao > ; Guomin Jiang > 主题: [edk2-devel] [Patch 1/1] MdeModulePkg/CapsuleApp: Add EFIAPI to > CompareFileNameInAlphabet() > >

Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg/NestedInterruptTplLib: replace ASSERT() with a warning logged.

On Sat, 6 May 2023 at 01:27, Michael Brown wrote: > > On 05/05/2023 19:56, Laszlo Ersek wrote: > > I don't like the patch. For two reasons: > > > > (1) It papers over the actual issue. The problem should be fixed where > > it is, if possible. > > Agreed, but (as you have shown in > https://bugzill

Re: [edk2-devel] [PATCH V3 5/5] RedfishPkg: Fix compile issue on Linux

I agree that flexible array members are a good way to define this. The consumer needs to allocate extra space for the flexible array member. If the size of the device path is known, then the allocation can be the exact size needed. sizeof(REST_EX_SERVICE_DEVICE_PATH_DATA) + DevicePathSize(Devic

Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg/NestedInterruptTplLib: replace ASSERT() with a warning logged.

On 05/05/2023 19:56, Laszlo Ersek wrote: I don't like the patch. For two reasons: (1) It papers over the actual issue. The problem should be fixed where it is, if possible. Agreed, but (as you have shown in https://bugzilla.redhat.com/show_bug.cgi?id=2189136) the bug lies in Windows code rat

Re: [edk2-devel] [PATCH V3 5/5] RedfishPkg: Fix compile issue on Linux

On Fri, May 5, 2023 at 6:12 PM Minh Nguyen via groups.io wrote: > > From: Vu Nguyen > > It requires a fixed size array to store the content of device path PCD. > Add the array size to solve this issue. > > Signed-off-by: Minh Nguyen > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez

Re: [edk2-devel] purpose of EFI_LOCK

Random and tl;dr fun friday fact. You can see the efi locks replaced w/ spinlocks in https://github.com/tianocore/edk2-staging/tree/MpNetworkStack to support the use case described in https://uefi.org/sites/default/files/resources/7_Maciej%20Vincent_INTEL_network%20stack%20performance.pdf. These ch

Re: [edk2-devel] purpose of EFI_LOCK

Hi Andrew, thank you! The background / paragraph on the naming helps! Cheers, Laszlo On 5/4/23 20:01, Andrew (EFI) Fish wrote: > Laszlo, > > Hope you are doing well! Sorry to top post but I’m just commenting on > the big picture, not answering your specific questions yet. > > The Wiki definiti

Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg/NestedInterruptTplLib: replace ASSERT() with a warning logged.

On 5/5/23 16:10, Michael Brown wrote: > On 03/05/2023 08:19, Gerd Hoffmann wrote: >> OVMF can't guarantee that the ASSERT() doesn't happen.  Misbehaving >> EFI applications can trigger this.  So log a warning instead and try >> to continue. >> >> Reproducer: Fetch windows 11 22H2 iso image, boot it

[edk2-devel] [Patch 1/1] MdeModulePkg/CapsuleApp: Add EFIAPI to CompareFileNameInAlphabet()

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4446 CompareFileNameInAlphabet() is passed as a function pointer parameter and typecast to type SORT_COMPARE that is declared with EFIAPI. Add EFIAPI to CompareFileNameInAlphabet() to match SORT_COMPARE type. Cc: Jian J Wang Cc: Liming Gao Cc

Re: [edk2-devel] [PATCH V2 3/5] RedfishPkg: Create RestEx child on selected interface

Hi Abner,  I have checked in my system and it works fines when using RedfishConfigHandlerDriver.  I also updated new patches, could you please help me to check it? Thanks, Minh Nguyen On 5/4/2023 3:26 PM, Minh Nguyen wrote: Hi Abner,  Let me check in my system and will give the confirmati

[edk2-devel] [PATCH V3 5/5] RedfishPkg: Fix compile issue on Linux

From: Vu Nguyen It requires a fixed size array to store the content of device path PCD. Add the array size to solve this issue. Signed-off-by: Minh Nguyen Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang --- RedfishPkg/Include/Pcd/RestExServiceDevicePath.h | 5

Re: [edk2-devel] [PATCH V3 0/5] Adding necessary changes for RedfishPkg

Hi Abner,  I've updated. Thanks for your review. Thanks, Minh Nguyen On 5/5/2023 2:38 PM, Chang, Abner wrote: [AMD Official Use Only - General] Hi Minh, Please add my RB for 3/5 in commit message and push to minhnampere:Adding_necessary_changes_for_RedfishPkg again. I will check the PR a

[edk2-devel] [PATCH V3 2/5] RedfishPkg: Fix condition checking of error status

From: Vu Nguyen This change fixes condition checking of error status, the condition should be compared with TRUE status to be identical with an error message. Signed-off-by: Minh Nguyen Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Nickle Wang --- RedfishPkg/RedfishDis

Re: [edk2-devel] [PATCH V3 0/5] Adding necessary changes for RedfishPkg

Hi Abner,  While they're checking this issue, they recommend me to re-send v3 so I just sent it, you can also use the PR to review at the same time. Thanks, Minh Nguyen. On 5/5/2023 1:01 PM, Minh Nguyen wrote: Hi Abner,  Here you are: #4338 T

[edk2-devel] [PATCH V3 4/5] RedfishPkg: Add missing newline character

From: Nhi Pham This adds a missing newline character to make the error log readable in case the module is failed. Signed-off-by: Minh Nguyen Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Nickle Wang --- RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 3 +

[edk2-devel] [PATCH V3 3/5] RedfishPkg: Create RestEx child on selected interface

From: Vu Nguyen When a MAC address matching interface is found, a RestEx child will be created to provide the Redfish communication on that interface. Currently, It will try to locate all RestEx binding services and choose the first satisfied instance without taking care about current selected in

Re: [edk2-devel] [PATCH v10 7/9] UefiCpuPkg: Implements MmSaveStateLib for Ovmf

[AMD Official Use Only - General] Thanks Gerd, for the inputs. I'll drop the patch and submit the new version. -AbduL -Original Message- From: Gerd Hoffmann Sent: 04 May 2023 14:13 To: Attar, AbdulLateef (Abdul Lateef) Cc: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) ; Grim

Re: [edk2-devel] [PATCH V3 0/5] Adding necessary changes for RedfishPkg

Hi Abner,  Here you are: #4338 Thanks, Minh Nguyen On 5/5/2023 12:45 PM, Chang, Abner wrote: [EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please be mindful of safe email handling and proprietary information protection p

[edk2-devel] [PATCH V3 1/5] RedfishPkg: Correct variable type to prevent memory corruption

From: Vu Nguyen Id will be casted by CoreOpenProtocol, declare this variable with a wrong type might result in the corruption of other local variables. Signed-off-by: Minh Nguyen Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Nickle Wang --- RedfishPkg/RedfishRestExDxe/

[edk2-devel] [PATCH V3 0/5] Adding necessary changes for RedfishPkg

This patchset adds necessary changes for RedfishPkg to avoid some unexpected cases and fix compilation. Changes since v3: + Replaced __FUNCTION__ with __func__ to be more C11 compliant. Changes since v2: + Added "Cc:" to maintainers in commit message. + Corrected patch format subject prefix. C

Re: [edk2-devel] [PATCH V3 0/5] Adding necessary changes for RedfishPkg

Hi Abner,  Yes, me too. I have sent the email to miki.deme...@intel.com for checking it. Thanks, Minh Nguyen On 5/5/2023 12:03 PM, Chang, Abner wrote: [AMD Official Use Only - General] Hi Minh, I don't know why however I can't see V3 patch set on group.io. Can you see those patches on gro

[edk2-devel] [PATCH V3 3/5] RedfishPkg: Create RestEx child on selected interface

From: Vu Nguyen When a MAC address matching interface is found, a RestEx child will be created to provide the Redfish communication on that interface. Currently, It will try to locate all RestEx binding services and choose the first satisfied instance without taking care about current selected in

[edk2-devel] [PATCH] UefiPayloadPkg:Add YAML support version configuration

From: KasimX Liu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4445 To record the default value of SpecRevision and Revision. add '-st' command of input YAML setting file Cc: Guo Dong Cc: Ray Ni Cc: James Lu Cc: Gua Guo Signed-off-by: KasimX Liu --- UefiPayloadPkg/Settings/UplSetti

[edk2-devel] [PATCH V3 4/5] RedfishPkg: Add missing newline character

From: Nhi Pham This adds a missing newline character to make the error log readable in case the module is failed. Signed-off-by: Minh Nguyen Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Nickle Wang --- RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 3 +

[edk2-devel] [PATCH V3 1/5] RedfishPkg: Correct variable type to prevent memory corruption

From: Vu Nguyen Id will be casted by CoreOpenProtocol, declare this variable with a wrong type might result in the corruption of other local variables. Signed-off-by: Minh Nguyen Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Nickle Wang --- RedfishPkg/RedfishRestExDxe/

[edk2-devel] [PATCH V3 5/5] RedfishPkg: Fix compile issue on Linux

From: Vu Nguyen It requires a fixed size array to store the content of device path PCD. Add the array size to solve this issue. Signed-off-by: Minh Nguyen Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang --- RedfishPkg/Include/Pcd/RestExServiceDevicePath.h | 5

[edk2-devel] [PATCH V3 2/5] RedfishPkg: Fix condition checking of error status

From: Vu Nguyen This change fixes condition checking of error status, the condition should be compared with TRUE status to be identical with an error message. Signed-off-by: Minh Nguyen Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Nickle Wang --- RedfishPkg/RedfishDis

[edk2-devel] [PATCH V3 0/5] Adding necessary changes for RedfishPkg

This patchset adds necessary changes for RedfishPkg to avoid some unexpected cases and fix compilation. Changes since v3: + Replaced __FUNCTION__ with __func__ to be more C11 compliant. Changes since v2: + Added "Cc:" to maintainers in commit message. + Corrected patch format subject prefix. C

Re: [edk2-devel] [PATCH v3 3/3] OvmfPkg/Bhyve: install ACPI tables from memory

On 5/3/23 01:32, Corvin Köhne wrote: diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc index d0d2712c5662..465b81ffcd51 100644 --- a/OvmfPkg/Bhyve/BhyveX64.dsc +++ b/OvmfPkg/Bhyve/BhyveX64.dsc @@ -341,6 +341,7 @@ [LibraryClasses.common.UEFI_DRIVER] PciLib|OvmfPkg/Library/D

Re: [edk2-devel] [PATCH 1/1] CryptoPkg: Delete CLANG35 and CLANG38 build flags; add CLANGDWARF flags

Acked-by: Jiewen Yao > -Original Message- > From: Rebecca Cran > Sent: Friday, May 5, 2023 9:43 PM > To: devel@edk2.groups.io; Yao, Jiewen ; Wang, > Jian J ; Lu, Xiaoyu1 ; Jiang, > Guomin > Cc: Rebecca Cran > Subject: [PATCH 1/1] CryptoPkg: Delete CLANG35 and CLANG38 build flags; > add

Re: [edk2-devel] [PATCH v5 02/10] MdePkg: don't set visibility to hidden

Gerd, Does this series need rework following this discussion, or is it ready to merge? -- Rebecca Cran On 4/21/23 01:46, Marvin Häuser wrote: On 21. Apr 2023, at 09:21, Ard Biesheuvel wrote: On Fri, 21 Apr 2023 at 08:49, Gerd Hoffmann wrote: On Fri, Apr 21, 2023 at 06:01:11AM +00

Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg/NestedInterruptTplLib: replace ASSERT() with a warning logged.

On 03/05/2023 08:19, Gerd Hoffmann wrote: OVMF can't guarantee that the ASSERT() doesn't happen. Misbehaving EFI applications can trigger this. So log a warning instead and try to continue. Reproducer: Fetch windows 11 22H2 iso image, boot it in qemu with OVMF. Traced to BootServices->Stall()

Re: [edk2-devel] [PATCH v1 1/3] MdeModulePkg/Bus/Usb/UsbNetwork/UsbRndis: Add USB RNDIS devices support

On 4/20/23 21:27, RichardHo [何明忠] via groups.io wrote: This driver provides UEFI driver for USB RNDIS device Signed-off-by: Richard Ho Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc: Michael Kubacki Cc: Zhiguang Liu Cc: Liming Gao Cc: Hao A Wu Cc: Ray Ni R: Rebecca Cran

[edk2-devel] [PATCH 1/1] CryptoPkg: Delete CLANG35 and CLANG38 build flags; add CLANGDWARF flags

Since CLANG35 and CLANG38 toolchains have been deleted from tools_def.template, delete the build flags for them from CryptoPkg. Since CLANGDWARF has replaced CLANG38, add build flags for it to the CryptoPkg .inf files. Signed-off-by: Rebecca Cran --- CryptoPkg/Library/BaseCryptLib/BaseCryptLib.

Re: [edk2-devel] [PATCH v3 0/2] OvmfPkg: move two include files to Include/Fdf

Reviewed-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Friday, May 5, 2023 7:06 PM > To: devel@edk2.groups.io > Cc: Pawel Polawski ; Oliver Steffen > ; Gerd Hoffmann > Subject: [edk2-devel] [PATCH v3 0/2] OvmfPkg: move two include

[edk2-devel] [PATCH v1 3/3] Platform/ARM: Juno: Generate _CPC objects for JunoR2

From: Pierre Gondois The SsdtCpuTopologyGenerator can generate _CPC objects. This is done by querying the SCP for the relevant performance state information through SCMI. CM_ARM_CPC_INFO are then populated and used to generate _CPC objects in the Ssdt Cpu topology. Use the ArmScmiInfoLib and add

[edk2-devel] [PATCH v1 2/3] Platform/ARM: Juno: Generate _PSD objects

From: Pierre Gondois The SsdtCpuTopologyGenerator can generate _PSD objects. Add _PSD information and handling to the Configuration Manager to generate them. Signed-off-by: Pierre Gondois --- .../ConfigurationManager.c| 100 -- .../ConfigurationManager.h

[edk2-devel] [PATCH v1 1/3] Platform/ARM: Juno: Fix typo

From: Pierre Gondois Fix a typo. Signed-off-by: Pierre Gondois --- .../ConfigurationManagerDxe/ConfigurationManager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/P

[edk2-devel] [PATCH v1 0/3] Platform/ARM: Enable _CPC/_PSD generation on Juno-r2

From: Pierre Gondois A recent patchset [1] allows the generation of _PSD/_CPC ACPI objects by querying the relevant information through the SCMI protocol. - The _PSD object describes to which performance domain a CPU belongs. CPUs in the same performance domain have the same frequency. - The _C

[edk2-devel] [PATCH v1 10/11] DynamicTablesPkg: Add ArmScmiInfoLib

From: Pierre Gondois The SCP holds some power information that could be advertised through the _CPC object. The communication with the SCP is done through SCMI protocols (c.f. ArmScmiDxe). Use the SCMI protocols to query information and feed it to the DynamicTablesPkg. Signed-off-by: Pierre Gon

[edk2-devel] [PATCH v1 11/11] DynamicTablesPkg: Remove check for _CPC field

From: Pierre Gondois When generating _CPC objects, some fields are mandatory. Some fields cannot be supported by a the Juno platform, which is used to test the _CPC generation. Therefore, don't prevent from generating _CPC objects if the fields below are missing, and let the OS handle the missing

[edk2-devel] [PATCH v1 09/11] DynamicTablesPkg: Generate _PSD in SsdtCpuTopologyGenerator

From: Pierre Gondois Make use of the newly added AmlCreatePsdNode() to generate _PSD objects. _PSD objects allow to describe 'performance control, P-state or CPPC, logical processor dependency', Cf. ACPI 6.4, s8.4.5.5 _PSD (P-State Dependency). Signed-off-by: Pierre Gondois --- .../SsdtCpuTop

[edk2-devel] [PATCH v1 08/11] DynamicTablesPkg: Add AmlCreatePsdNode() to generate _PSD

From: Pierre Gondois Add AmlCreatePsdNode() to the AmlLib to generate _PSD objects. _PSD objects allow to describe 'performance control, P-state or CPPC, logical processor dependency', Cf. ACPI 6.4, s8.4.5.5 _PSD (P-State Dependency). Signed-off-by: Pierre Gondois --- .../Include/Library/AmlLi

[edk2-devel] [PATCH v1 07/11] DynamicTablesPkg: Add PsdToken field to CM_ARM_GICC_INFO object

From: Pierre Gondois The _PSD object (cf. ACPI 6.4, s8.4.5.5 _PSD (P-State Dependency) allows to describe CPU's power state dependencies. Add a PsdToken field to the CM_ARM_GICC_INFO object so that interdependent CPUs can reference the same CM_ARM_PSD_INFO object. Signed-off-by: Pierre Gondois

[edk2-devel] [PATCH v1 06/11] DynamicTablesPkg: Add CM_ARM_PSD_INFO object

From: Pierre Gondois Add an object describing _PSD information, cf. ACPI 6.4, s8.4.5.5 _PSD (P-State Dependency). Also add the corresponding CmObjParser. Signed-off-by: Pierre Gondois --- DynamicTablesPkg/Include/AcpiObjects.h| 20 +++ .../Include/ArmNameSpaceObjects.h

[edk2-devel] [PATCH v1 05/11] DynamicTablesPkg: Rename AmlCpcInfo.h to AcpiObjects.h

From: Pierre Gondois The DynamicTables framework uses the AmlLib to generate some Aml objects. It is done by using structured known by both frameworks, e.g. the AML_CPC_INFO/CM_ARM_CPC_INFO structures. To prepare adding similar structures (e.g. representing _PSD information), rename AmlCpcInfo.h

[edk2-devel] [PATCH v1 04/11] DynamicTablesPkg: Use new CPC revision macro

From: Pierre Gondois Make use of the newly added CPC revision macro. Signed-off-by: Pierre Gondois --- DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c b/

[edk2-devel] [PATCH v1 03/11] MdePkg/Acpi64: Add _PSD/_CPC/State Coordination Types macros

From: Pierre Gondois Add macros for: - _PSD version - _CPC version - C-state/T-state/P-state Coordination Types These objects were present in previous ACPI specification version, but are only added to the latest availbable version (6.4). Signed-off-by: Pierre Gondois --- MdePkg/Include/Indust

[edk2-devel] [PATCH v1 02/11] ArmPkg/ArmScmiDxe: Add PERFORMANCE_DESCRIBE_FASTCHANNEL support

From: Pierre Gondois The PERFORMANCE_DESCRIBE_FASTCHANNEL Scmi command is available since SCMI v2.0 and allows to query information about the supported fast-channels of the Scmi performance protocol. Add support for this command. Signed-off-by: Pierre Gondois --- .../ArmScmiDxe/ScmiPerformance

[edk2-devel] [PATCH v1 00/11] DynamicTablesPkg: Enable _PSD/_CPC generation using SCMI

From: Pierre Gondois The SCMI performance protocol allows to query the Operating Performance Points (OPPs) available for each performance domain. Each OPP has a specific frequency/power consumption/performance. On Device Tree (DT) based platforms, the SCMI protocol is directly available from the

[edk2-devel] [PATCH v1 01/11] ArmPkg/ArmScmiDxe: Rename PERFORMANCE_PROTOCOL_VERSION

From: Pierre Gondois Rename PERFORMANCE_PROTOCOL_VERSION to reflect the different versions of the protocol. The macro is neither used in edk2 nor in edk2-platforms. Signed-off-by: Pierre Gondois --- .../Include/Protocol/ArmScmiPerformanceProtocol.h | 13 - 1 file changed, 8 inser

[edk2-devel] [PATCH v2] MinPlatformPkg: Update ACPI 6.5 definition

From: Aryeh Chen https://bugzilla.tianocore.org/show_bug.cgi?id=4442 Update ACPI 6.5 definition on MinPlatformPkg Cc: Chasel Chiu Cc: Nate DeSimone Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong Cc: Jiewen Yao Cc: Ankit Sinha Signed-off-by: Aryeh Chen --- Platform/Intel/MinPlatformPkg/Acp

[edk2-devel] [PATCH v3 2/2] OvmfPkg: move OvmfTpmDxe.fdf.inc to Include/Fdf

Signed-off-by: Gerd Hoffmann --- OvmfPkg/AmdSev/AmdSevX64.fdf | 2 +- OvmfPkg/CloudHv/CloudHvX64.fdf | 2 +- OvmfPkg/OvmfPkgIa32.fdf | 2 +- OvmfPkg/OvmfPkgIa32X64.fdf | 2 +- OvmfPkg/OvmfPkgX64.fdf | 2 +-

[edk2-devel] [PATCH v3 0/2] OvmfPkg: move two include files to Include/Fdf

v3: - rebase to latest master v2: - rebase to latest master Gerd Hoffmann (2): OvmfPkg: move OvmfTpmPei.fdf.inc to Include/Fdf OvmfPkg: move OvmfTpmDxe.fdf.inc to Include/Fdf OvmfPkg/AmdSev/AmdSevX64.fdf | 4 ++-- OvmfPkg/CloudHv/CloudHvX64.fdf | 4 ++-- OvmfP

[edk2-devel] [PATCH v3 1/2] OvmfPkg: move OvmfTpmPei.fdf.inc to Include/Fdf

Signed-off-by: Gerd Hoffmann --- OvmfPkg/AmdSev/AmdSevX64.fdf | 2 +- OvmfPkg/CloudHv/CloudHvX64.fdf | 2 +- OvmfPkg/OvmfPkgIa32.fdf | 2 +- OvmfPkg/OvmfPkgIa32X64.fdf | 2 +- OvmfPkg/OvmfPkgX64.fdf | 2 +-

[edk2-devel] Request to open an bugzilla's account

Hi Liming, please help me to open a bugzilla account. Thanks Dongyan -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104110): https://edk2.groups.io/g/devel/message/104110 Mute This Topic: https://groups.io/mt/98702467/21656 Gr

Re: [edk2-devel] [RFC PATCH v1 00/30] Support for Arm CCA guest firmware

On Thu, May 04, 2023 at 05:36:32PM +0200, Ard Biesheuvel wrote: > On Thu, 4 May 2023 at 17:13, Jean-Philippe Brucker > wrote: > > > > Hello, > > > > On Tue, Apr 25, 2023 at 05:03:58PM +0100, Sami Mujawar wrote: > > > We are happy to announce an early RFC version of the Arm Confidential > > > Compu

Re: [edk2-devel] [PATCH v6 08/16] Add GCC and GCCNOLTO toolchains to tools_def.txt and update packages

On Fri, May 5, 2023, at 1:41 AM, gaoliming via groups.io wrote: > Rebecca: > This patch makes the changes cross the different packages. So, it may > bring the confuse to the different package maintainers. Can these > changes be separated for the different packages? > Yes, I can send the change

Re: [edk2-devel] [PATCH] MdePkg/BasePeCoffLib: Deal with broken debug directories

On Fri, 5 May 2023 at 03:56, Michael Kubacki wrote: > > Acked-by: Michael Kubacki > Merged as #4340 Thanks all > On 5/4/2023 10:47 AM, Ard Biesheuvel wrote: > > Older versions of GenFw put the wrong value in the debug directory size > > field in the PE/COFF header: instead of putting the comb

回复: [edk2-devel] [PATCH v6 08/16] Add GCC and GCCNOLTO toolchains to tools_def.txt and update packages

Jiewen: As Rebecca describes, IntelFsp2Pkg/Tools/Tests/QemuFspPkg.dsc GCC49 tool chain adds -flto option to enable link-time optimization. So, new GCCNOLTO also copies this option. QemuFspPkg.dsc is in IntelFsp2Pkg. Fsp2Pkg maintainer may give the answer why adds -flto option for GCC49. Reb

Re: [edk2-devel] [PATCH V3 0/5] Adding necessary changes for RedfishPkg

[AMD Official Use Only - General] Hi Minh, Please add my RB for 3/5 in commit message and push to minhnampere:Adding_necessary_changes_for_RedfishPkg again. I will check the PR and merge it once it passes CI. Thank for your contribution. Abner > -Original Message- > From: minhnampere

Re: [edk2-devel] [PATCH V3 3/5] RedfishPkg: Create RestEx child on selected interface

[AMD Official Use Only - General] Thanks Minh, Reviewed-by: Abner Chang > -Original Message- > From: minhnampere > Sent: Friday, May 5, 2023 2:46 PM > To: devel@edk2.groups.io > Cc: patc...@amperecomputing.com; Chang, Abner > ; nick...@nvidia.com; ig...@ami.com; > n...@os.amperecomputi