[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Nickle
> Wang via groups.io
> Sent: Saturday, April 22, 2023 10:45 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Michael D Kinney
> Subjec
Add required files to initial edk2 redfish client repository.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Michael D Kinney
---
.gitignore | 6 +
CONTRIBUTING.md | 3 +++
LICENSE | 51 ++
Maintainers.txt | 48 ++
Thanks, Mike! I mistook this file as some information related to this
repository, but it is not. I will keep it as what I copied from edk2 repository.
Regards,
Nickle
From: Kinney, Michael D
Sent: Friday, April 21, 2023 11:38 PM
To: Nickle Wang ; devel@edk2.groups.io
Cc: Abner Chang ; Igor Kul
Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Rebecca Cran
> Sent: Friday, April 21, 2023 2:27 PM
> To: devel@edk2.groups.io; Ard Biesheuvel ;
> Demeter, Miki ; Kinney, Michael D
> ; Leif Lindholm
> Cc: Rebecca Cran
> Subject: [edk2-deve
Since gitbook.io is no longer used, update the remaining links to point
to the documents on tianocore-docs.github.io instead.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Rebecca Cran
---
CET-in-SMM.md | 2 +-
EDK-II-Code-Formatting.md | 2 +-
ED
On 4/21/23 04:18, Gerd Hoffmann wrote:
Hmm, good question. Can the guest figure what memory ranges are part
of the launch measurement?
I have a patch here (attached below) which refines flash detection and
can detect whenever varstore flash is writable or not. I suspect that
doesn't help much
I addressed some final few ECC complaints, and it finally went through
- now merged as ed2ff315db7e..2c2cb2352896.
Thanks!
On Fri, Apr 21, 2023 at 17:51:16 +0200, Marcin Juszkiewicz wrote:
> App goes through ID_AA64*_EL1 system registers and decode their values.
>
> Signed-off-by: Marcin Juszkie
The TCG PC Client Platform Reset Attack Mitigation Spec v1.10 is based
on UEFI Variables, and there should be a way to test for the variables
and functionality based on the TCG specification.
REF to Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4419
Proposed SCT spec: https://bugzilla
-implement initial test infrastructure for TCG MOR test cases
including updates to: CommonGenFramework.sh, UEFI_SCT.dsc,
and Category.ini
-add initial TCG MOR Platform Reset Check Test
-Test Assertion that checks if the platform creates the MOR
EFI variable as in the TCG Platform Reset Mitiga
Hi Abner,
I created PR.
https://github.com/tianocore/edk2/pull/4297
Since it is my first PR created, I'm not sure if everything done correctly.
Please double check everything.
Thank you,
Igor
-Original Message-
From: Chang, Abner
Sent: Thursday, April 20, 2023 8:13 PM
To: Igor Kulchytskyy
Thanks, I've fixed the issues you noted and sent out a v5 series.
I kept your Reviewed-by on 01/13 despite making minor changes to fix the
build on Windows: I hope that was okay.
--
Rebecca Cran
On 4/20/23 20:32, gaoliming wrote:
Rebecca:
I add my comments below.
-邮件原件-
发件人: R
Bump VERSION to 3.00 and explain the changes made to the toolchains.
Signed-off-by: Rebecca Cran
Reviewed-by: Liming Gao
---
BaseTools/Conf/tools_def.template | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/BaseTools/Conf/tools_def.template
b/BaseTools/Conf/tools_def.
In order to make it clear for anyone reading tools_def.template, add
a section for deprecated tool chains and move GCC48, GCC49 and GCC5
into it.
Signed-off-by: Rebecca Cran
Reviewed-by: Liming Gao
---
BaseTools/Conf/tools_def.template | 31 +++
1 file changed, 23 in
The GCC48, GCC49 and GCC5 toolchains will be deleted in the coming
months. Inform users that they're deprecated and tell them what replaces
them.
Signed-off-by: Rebecca Cran
Reviewed-by: Liming Gao
---
BaseTools/Source/Python/build/build.py | 14 ++
1 file changed, 14 insertions(+)
Avoid calling LoadConfiguration twice, in both InitPreBuild and
InitBuild. Since InitPreBuild is called first, delete the second call
from InitBuild.
Signed-off-by: Rebecca Cran
Reviewed-by: Liming Gao
---
BaseTools/Source/Python/build/build.py | 4 +---
1 file changed, 1 insertion(+), 3 deleti
Add a 'GCC' toolchain that's a copy of the existing GCC5 definition.
Add a 'GCCNOLTO' toolchain that's a copy of the existing GCC49
toolchain.
Signed-off-by: Rebecca Cran
---
UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc | 4
IntelFsp2Pkg/Tools/Tests/QemuFspPkg.dsc |
Update the Visual Studio toolchain descriptions in
tools_def.txt.template:
- The WinDDK is no longer needed.
- Update 3 is required for VS 2015.
- VS 2005 has been removed.
Signed-off-by: Rebecca Cran
Reviewed-by: Liming Gao
---
BaseTools/Conf/tools_def.template | 7 ++-
1 file changed, 2
The edk2-stable202302 release was the last to support building
EFI Byte Code drivers. Since the Intel EFI Byte Code Compiler is no
longer available, a decision has been made to remove support for EBC
from edk2.
Remove the definitions for Intel's EBC compiler from
Conf/tools_def.template.
Signed-o
Remove the unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS definitions
from Conf/tools_def.template.
Signed-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
Reviewed-by: Liming Gao
---
BaseTools/Conf/tools_def.template | 4
1 file changed, 4 deletions(-)
diff --git a/BaseTools/Conf/too
Since Visual Studio versions older than VS2015 are no longer supported,
remove mention of them from edksetup.bat.
Signed-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
Reviewed-by: Liming Gao
Reviewed-by: Leif Lindholm
---
edksetup.bat | 6 +-
1 file changed, 1 insertion(+), 5 delet
Since Visual Studio versions older than VS2015 are no longer supported,
remove mention of them from MdePkg.
Signed-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
Reviewed-by: Liming Gao
---
MdePkg/Include/Ia32/ProcessorBind.h | 8 ++--
MdePkg/Include/X64/ProcessorBind.h | 8 ++--
Remove remnants of Visual Studio 2008-2013 support from
Conf/tools_def.txt and various batch scripts.
Signed-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
Reviewed-by: Liming Gao
---
BaseTools/Conf/tools_def.template | 12
BaseTools/Scripts/SetVisualStudio.bat | 22 +---
With recent changes, Visual Studio versions older than VS2015 are
unable to build EDK2 code.
To avoid confusion, remove VS2008, 2010, 2012 and 2013 toolchain
definitions from Conf/tools_def.template, leaving only versions that can
be used to successfully build firmware.
Signed-off-by: Rebecca Cra
Update the CLANGDWARF toolchain definition in tools_def.template with the
settings from CLANG38, and delete the CLANG35 and CLANG38 toolchains.
The CLANG35 and CLANG38 toolchains were added for compatibility with
ARM's proprietary clang-based toolchain. Things have since moved on, and
with the lat
Update the toolchain definitions:
- Delete the CLANG35 and CLANG38 toolchains, and replace CLANG38 with
CLANGDWARF, updating it to support ARM and AARCH64 in addition to X64
and IA32.
- Mark GCC48, GCC49 and GCC5 as deprecated.
- Add GCC and GCCNOLTO toolchain definitions.
- Remove VS2008, VS
On Fri, Apr 21, 2023 at 08:37:42 -0600, Rebecca Cran wrote:
> I noticed CI failed for the push PR
> (https://github.com/tianocore/edk2/pull/4292).
>
>
> Ecc is complaining about missing Doxygen info for the functions:
>
> https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=88023&view=
App goes through ID_AA64*_EL1 system registers and decode their values.
Signed-off-by: Marcin Juszkiewicz
---
ArmPkg/ArmPkg.dsc|1 +
ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.inf | 31 +
ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 2427 ++
3 fi
ArmCpuInfo uses those to read system registers and other parts of EDK2
may find them useful.
Signed-off-by: Marcin Juszkiewicz
---
ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h| 50 +++-
.../Library/ArmLib/AArch64/AArch64Support.S | 58 ---
2 files changed, 99 inse
Merged
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang, Abner
> via groups.io
> Sent: Friday, April 21, 2023 1:10 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> Cc: Gao, Liming ; Liu, Zhiguang
> ; Nickle Wang ; Igor
> Kulchytskyy ; Oram, Isaac W ; Attar,
Not required.
Is there any use case of a null instances that would actually be needed (e.g.
EmulatorPkg)?
If there is a real use case, then a null instance in the MdePkg would be useful.
Mike
From: Ni, Ray
Sent: Friday, April 21, 2023 1:10 AM
To: Kinney, Michael D ; devel@edk2.groups.io; Wang,
If no modifications were made, you should leave the copyright statement alone.
Mike
From: Nickle Wang
Sent: Thursday, April 20, 2023 8:32 PM
To: devel@edk2.groups.io; Nickle Wang ; Kinney, Michael D
Cc: Abner Chang ; Igor Kulchytskyy
Subject: RE: [edk2-devel] [edk2-redfish-client][PATCH] Init
Acked-by: Michael D Kinney
> -Original Message-
> From: Chang, Abner
> Sent: Thursday, April 20, 2023 10:38 PM
> To: devel@edk2.groups.io; nick...@nvidia.com; Kinney, Michael D
>
> Cc: Igor Kulchytskyy
> Subject: RE: [edk2-devel] [edk2-redfish-client][PATCH] Initial edk2 redfish
> cl
On 4/21/23 08:59, Marcin Juszkiewicz wrote:
Thanks for links. Interface for EDK2 CI is not easy for beginners.
It really isn't, unfortunately.
Doxygen info is something I probably never wrote so would need to look
at rest of EDK2 code to find out what it is and how to use it.
It's pretty st
W dniu 21.04.2023 o 16:37, Rebecca Cran pisze:
I noticed CI failed for the push PR
(https://github.com/tianocore/edk2/pull/4292).
Ecc is complaining about missing Doxygen info for the functions:
https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=88023&view=logs&j=d36e2059-ab45-57a
On Tue, 7 Feb 2023 at 10:07, wrote:
>
> From: Pierre Gondois
>
> The UEFI Shell is a non-active boot option, at the opposite of UiApp.
> If no valid boot option is found, UiApp is selected. UiApp requires a
> human interaction. When installing a new EDKII image in CIs or when
> scripting is requi
On 4/21/23 09:26, Tom Lendacky wrote:
On 4/21/23 03:36, Dun Tan wrote:
Remove code that apply AddressEncMask to non-leaf entry when split
smm page table by MemEncryptSevLib. In FvbServicesSmm driver, it
calls MemEncryptSevClearMmioPageEncMask to clear AddressEncMask
bit in page table for a speci
I noticed CI failed for the push PR
(https://github.com/tianocore/edk2/pull/4292).
Ecc is complaining about missing Doxygen info for the functions:
https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=88023&view=logs&j=d36e2059-ab45-57a4-e2a1-e73032481054&t=463dc808-035c-5fe4-17fd-50
On 4/21/23 03:36, Dun Tan wrote:
Remove code that apply AddressEncMask to non-leaf entry when split
smm page table by MemEncryptSevLib. In FvbServicesSmm driver, it
calls MemEncryptSevClearMmioPageEncMask to clear AddressEncMask
bit in page table for a specific range. In AMD SEV feature, this
Add
> > Patch #1, adding a linker script assert as suggested by ard, then:
> >
> > * compile + test on my local workstation (fedora 37, gcc 12).
> > * run CI
> > * compile on some older distros:
> > - rhel-8 (gcc 8)
> > - ubuntu-18.04 (gcc 7)
>
> Did you include NOOPT? GCC5 specifies USING_LTO fo
> > Hmm, good question. Can the guest figure what memory ranges are part
> > of the launch measurement?
> >
> > I have a patch here (attached below) which refines flash detection and
> > can detect whenever varstore flash is writable or not. I suspect that
> > doesn't help much though as flash p
Hi Liming,
After I change memset() implementation in RegularExpressionDxe, I only need to
cover memcpy() with MDE_CPU_IA32. This is my change for your reference:
https://github.com/tianocore/edk2/pull/4285/commits/15216e83198d7d422ae767833303d1979c8c0839
Please let me know if this makes sense t
Hi Ard,
Just a ping in case this was forgotten,
Regards,
Pierre
On 4/14/23 14:45, PierreGondois via groups.io wrote:
Hello Ard,
On 2/9/23 17:57, Ard Biesheuvel wrote:
On Tue, 7 Feb 2023 at 10:07, wrote:
From: Pierre Gondois
The UEFI Shell is a non-active boot option, at the opposite of U
This commit is code refinement to current smm pagetable generation
code. Add a new GenSmmPageTable() API to create page table for smm
based on the PageTableMap() API in CpuPageTableLib. Caller only
needs to specify the paging mode and the PhysicalAddressBits to map.
This function can be used to cre
This commit is code refinement to current smm runtime pagetable
update code. In InitPaging() function, sort mProtectionMemRange
or mSmmCpuSmramRanges at first. If PcdCpuSmmProfileEnable is TRUE,
use ConvertMemoryPageAttributes() API to map the range in
mProtectionMemRange to the attrbute recorded i
Remove unnecessary function SetNotPresentPage(). We can directly
use ConvertMemoryPageAttributes to set a range to non-present.
Signed-off-by: Dun Tan
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
---
UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 8 ++--
UefiCpuPkg/P
Clear CR0.WP before modify smm page table. Currently, there is
an assumption that smm pagetable is always RW before ReadyToLock.
However, when AMD SEV is enabled, FvbServicesSmm driver calls
MemEncryptSevClearMmioPageEncMask to clear AddressEncMask bit
in smm page table for this range:
[PcdOvmfFdBa
Add two functions to disable/enable CR0.WP. These two unctions
will also be used in later commits. This commit doesn't change any
functionality.
Signed-off-by: Dun Tan
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
---
UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 24
+++
Extern mSmmShadowStackSize in PiSmmCpuDxeSmm.h and remove
extern for mSmmShadowStackSize in c files to simplify code.
Signed-off-by: Dun Tan
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
---
UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmFuncsArch.c | 3 +--
UefiCpuPkg/PiSmmCpuDxeSmm/MpServi
In PiSmmCpuDxeSmm code, SetMemMapAttributes() marks memory ranges
in SmmMemoryAttributesTable to RO/NX. There may exist non-present
range in these memory ranges. Set other attributes for a non-present
range is not permitted in CpuPageTableMapLib. So add code to handle
this case. Only map the presen
Simplify the ConvertMemoryPageAttributes API to convert paging
attribute by CpuPageTableLib. In the new API, it calls
PageTableMap() to update the page attributes of a memory range.
With the PageTableMap() API in CpuPageTableLib, we can remove
the complicated page table manipulating code.
Signed-o
Remove code that apply AddressEncMask to non-leaf entry when split
smm page table by MemEncryptSevLib. In FvbServicesSmm driver, it
calls MemEncryptSevClearMmioPageEncMask to clear AddressEncMask
bit in page table for a specific range. In AMD SEV feature, this
AddressEncMask bit in page table is us
Add CpuPageTableLib required by PiSmmCpuDxeSmm in
UefiPayloadPkg.dsc.
Signed-off-by: Dun Tan
Cc: Guo Dong
Cc: Ray Ni
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/UefiPayloadPkg/UefiPayloadP
In V3 patch set:
1.Add a new patch 'Remove code that apply AddressEncMask to non-leaf entry'.
This patch is to avoid apply AddressEncMask to non-leaf entry when split smm
page table.
2.Add two new patches to clear CR0.WP before modify smm page table when
ReadyToLock.
This is because FvbServi
Add CpuPageTableLib instance required by PiSmmCpuDxe in
corresponding DSC files of OvmfPkg.
Signed-off-by: Dun Tan
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Ray Ni
---
OvmfPkg/CloudHv/CloudHvX64.dsc | 2 +-
OvmfPkg/OvmfPkgIa32.dsc| 3 ++-
OvmfPkg/Ovmf
Mike, shall MdePkg contain the NULL instance?
From: Kinney, Michael D
Sent: Wednesday, April 19, 2023 11:03 PM
To: Ni, Ray ; devel@edk2.groups.io; Wang, Jian J
; Tan, Dun
Cc: Gao, Liming ; Ard Biesheuvel ;
Kinney, Michael D
Subject: RE: [edk2-devel] [Patch V2 5/8] MdeModulePkg: Add UefiCpuPkg
[AMD Official Use Only - General]
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> D Kinney via groups.io
> Sent: Friday, April 21, 2023 5:09 AM
> To: devel@edk2.groups.io; Chang, Abner
> Cc: Gao, Liming ; Liu, Zhiguang
> ; Nickle Wang ; Igor
> Kulchytskyy ; Ora
> On 21. Apr 2023, at 09:21, Ard Biesheuvel wrote:
>
> On Fri, 21 Apr 2023 at 08:49, Gerd Hoffmann wrote:
>>
>>> On Fri, Apr 21, 2023 at 06:01:11AM +, Marvin Häuser wrote:
>>>
On 21. Apr 2023, at 06:45, Gerd Hoffmann wrote:
Not needed any more on modern toolchains, they
On Fri, 21 Apr 2023 at 08:49, Gerd Hoffmann wrote:
>
> On Fri, Apr 21, 2023 at 06:01:11AM +, Marvin Häuser wrote:
> >
> > > On 21. Apr 2023, at 06:45, Gerd Hoffmann wrote:
> > >
> > > Not needed any more on modern toolchains, they are better
> > > in not creating a GOT without this trick.
>
Reviewed-by: Tinh Nguyen
On 4/21/2023 12:22 PM, Chang, Abner via groups.io wrote:
From: Abner Chang
Update GetTransportCapability to support
Maximum Transfer Unit (MTU) of transport interface.
Signed-off-by: Abner Chang
Cc: Isaac Oram
Cc: Abdul Lateef Attar
Cc: Nickle Wang
Cc: Igor Kulch
[AMD Official Use Only - General]
> -Original Message-
> From: Tinh Nguyen
> Sent: Friday, April 21, 2023 2:59 PM
> To: Chang, Abner ; devel@edk2.groups.io
> Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
> ; Nickle Wang ; Igor
> Kulchytskyy
> Subject: Re: [edk2-devel] [edk2-platfo
60 matches
Mail list logo
