Re: [edk2-devel] [Patch V2 5/8] MdeModulePkg: Add UefiCpuPkg.dec to pass DependencyCheck

2023-04-15 Thread Ni, Ray
Mike, MdeModule belongs to the common-package category. I agree that the common-package should not depend on a specific arch. MdeModule depending on UefiCpu because DxeIpl needs to prepare an arch specific environment for DXE phase. So, I am thinking if the arch-specific-env-preparation can be ab

Re: [edk2-devel] [PATCH 3/5] RedfishPkg: Create RestEx child on selected interface

2023-04-15 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Minh, That is weird I can't find this patch set on group.io, and I can't apply this patch from email neither. Could you please check it? Thanks Abner > -Original Message- > From: Minh Nguyen > Sent: Friday, April 14, 2023 4:19 PM > To: devel@edk2.gr

Re: [edk2-devel] [PATCH 4/5] RedfishPkg: Helper library of EDKII_REDFISH_PLATFORM_CONFIG_PROTOCOL

2023-04-15 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] > -Original Message- > From: Nickle Wang > Sent: Thursday, April 13, 2023 2:21 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [PATCH 4/5] RedfishPkg: Helper library of > EDKII_REDFISH_PLATFORM_CONFIG_PRO

Re: [edk2-devel] [PATCH 5/5] RedfishPkg: Add Redfish Platform Config Protocol to RedfishPkg

2023-04-15 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Thursday, April 13, 2023 2:21 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [PATCH 5/5] RedfishPkg: Add Redfish Platform Config

Re: [edk2-devel] Role of DLINK2_FLAGS and link-time option consistency

2023-04-15 Thread Marvin Häuser
> On 7. Apr 2023, at 14:00, Ard Biesheuvel wrote: > > (cc Ray) > > On Fri, 7 Apr 2023 at 13:05, Marvin Häuser wrote: >> >> >> On 7. Apr 2023, at 13:02, Ard Biesheuvel wrote: >> >> IIRC DLINK2_FLAGS is mainly being used (in the GCC case) for passing >> options that need to come after previo

Re: [edk2-devel] [Patch V2 5/8] MdeModulePkg: Add UefiCpuPkg.dec to pass DependencyCheck

2023-04-15 Thread Michael D Kinney
Back in 2019, I had proposed some more generic rules for package dependencies. https://edk2.groups.io/g/devel/message/52211 https://github.com/mdkinney/edk2/wiki/EDKII-Packages#edk-ii-package-dependency-rules The EDK II DEC files do not have enough meta-data to apply these rules. Would

Re: [edk2-devel] [Patch V2 5/8] MdeModulePkg: Add UefiCpuPkg.dec to pass DependencyCheck

2023-04-15 Thread Michael D Kinney
MdePkg: Include files for industry standard and public specs and lib classes and lib implementations that support those specs If all the IA32/X64 CPU header files to support the CpuPageTableLib class are in the MdePkg, then we could consider moving he class to MdePkg and avoid this patch. The c

Re: [edk2-devel] [PATCH v4 7/9] ManageabilityPkg: Implement Ipmi Protocol/Ppi

2023-04-15 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] > -Original Message- > From: Chang, Abner > Sent: Saturday, April 15, 2023 4:39 PM > To: Tinh Nguyen ; > devel@edk2.groups.io > Cc: Liming Gao ; Isaac Oram > ; Nate DeSimone > ; Attar, AbdulLateef (Abdul Lateef) > ; Nickle Wang ; Igor > Kulchytskyy > Su

[edk2-devel] [edk2-platforms][PATCH 2/3] ManageabilityPkg: Use SMBUS I2C instead of I2C

2023-04-15 Thread Chang, Abner via groups.io
From: Abner Chang Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Tinh Nguyen --- Features/ManageabilityPkg/ManageabilityPkg.dec | 10 +- .../BaseManageabilityTransportHelper.inf | 2 +- .../BaseManageabilityTransportHelper.c

[edk2-devel] [edk2-platforms][PATCH 3/3] ManageabilityPkg: Support AARCH64

2023-04-15 Thread Chang, Abner via groups.io
From: Abner Chang Add AARCH64 support in Manageability.dsc Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Tinh Nguyen --- .../ManageabilityPkg/Include/Dsc/Manageability.dsc| 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --gi

[edk2-devel] [edk2-platforms][PATCH 1/3] ManageabilityPkg/IpmiPpi: Fix duplicate library instance

2023-04-15 Thread Chang, Abner via groups.io
From: Abner Chang Remove duplicate library instance in [LibraryClass] section. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Tinh Nguyen --- .../ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiPei.inf | 1 - 1 file changed, 1 deletion(-) diff --

Re: [edk2-devel] [PATCH v4 7/9] ManageabilityPkg: Implement Ipmi Protocol/Ppi

2023-04-15 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] > -Original Message- > From: Tinh Nguyen > Sent: Friday, March 24, 2023 3:41 AM > To: devel@edk2.groups.io; Chang, Abner > Cc: Liming Gao ; Isaac Oram > ; Nate DeSimone > ; Attar, AbdulLateef (Abdul Lateef) > ; Nickle Wang ; Igor > Kulchytskyy > Subje