Re: [edk2-devel] [PATCH] ShellPkg: Update smbiosview type 0/4/17/41 with SMBIOS 3.5 fields v3

2023-04-09 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Lin, MillerX > Sent: Monday, April 10, 2023 11:41 AM > To: devel@edk2.groups.io > Cc: Lin, MillerX ; Ni, Ray ; Gao, > Zhichao > Subject: [PATCH] ShellPkg: Update smbiosview type 0/4/17/41 with SMBIOS > 3.5 fields v3

Re: [edk2-devel] [PATCH v7 8/8] UefiCpuPkg: Uses SmmSmramSaveStateLib library

2023-04-09 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Abdul, Comments inline. > -Original Message- > From: Abdul Lateef Attar > Sent: Friday, April 7, 2023 2:58 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; > Grimes, Paul ; Kirkendall, Garrett > ; Chang, Abner ; > Eric Dong ; Ra

Re: [edk2-devel] [PATCH v7 7/8] UefiCpuPkg: Implements SmmSmramSaveStateLib for Intel

2023-04-09 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Abdul > Lateef Attar via groups.io > Sent: Friday, April 7, 2023 2:58 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; > Grimes, Paul ; Kirken

[edk2-devel] [PATCH] ShellPkg: Update smbiosview type 0/4/17/41 with SMBIOS 3.5 fields v3

2023-04-09 Thread MillerX Lin
Cc: Signed-off-by: MillerX Lin Cc: Ray Ni Cc: Zhichao Gao --- .../SmbiosView/PrintInfo.c| 152 +- .../SmbiosView/SmbiosViewStrings.uni | 28 ++-- 2 files changed, 89 insertions(+), 91 deletions(-) diff --git a/ShellPkg/Library/UefiShellDebug1Comman

Re: [edk2-devel] [PATCH v7 6/8] UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family

2023-04-09 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Abdul, I see the white space error when apply this patch. Could you please check it again? Thanks Abner > -Original Message- > From: Abdul Lateef Attar > Sent: Friday, April 7, 2023 2:58 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul

Re: [edk2-devel] [PATCH v4 1/3] Platform/AMD: Adds AmdMinBoardPkg to support MinPlatformPkg

2023-04-09 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Abdul Lateef Attar > Sent: Monday, April 3, 2023 7:23 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Ard > Biesheuvel ; Leif Lindholm > ; Chang, Abner ; > Michael D Kinney >

Re: [edk2-devel] [PATCH v4 2/3] Platform/AMD/MinBoardPkg: Adds SetCacheMtrrLib library

2023-04-09 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Abdul Lateef Attar > Sent: Monday, April 3, 2023 7:23 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Ard > Biesheuvel ; Leif Lindholm > ; Chang, Abner ; > Michael D Kinney >

Re: [edk2-devel] [PATCH v4 3/3] Maintainers.txt: Adds AMD/AmdMinBoardPkg maintainers

2023-04-09 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Abdul Lateef Attar > Sent: Monday, April 3, 2023 7:23 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Attar, > AbdulLateef (Abdul Lateef) ; Ard Biesheuvel > ; Leif Lindholm ;

Re: [edk2-devel] [edk2-platforms][PATCH V1] IpmiFeaturePkg:Provided multliple IPMI interface support

2023-04-09 Thread Chang, Abner via groups.io
On Wed, Mar 1, 2023 at 12:37 AM, Arun K wrote: Hi Arun, Could you please consider providing those transport interfaces to ManageabilityPkg here: https://github.com/tianocore/edk2-platforms/tree/master/Features/ManageabilityPkg? ( https://github.com/tianocore/edk2-platforms/tree/master/Features/

回复: [edk2-devel] [Patch v3 11/12] MdeModulePkg: HOST_APPLICATION IA32/X64 only

2023-04-09 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Michael D > Kinney > 发送时间: 2023年4月8日 6:21 > 收件人: devel@edk2.groups.io > 抄送: Jian J Wang ; Liming Gao > ; Oliver Smith-Denny > > 主题: [edk2-devel] [Patch v3 11/12] MdeModulePkg: HOST_APPLICATION > IA32/X64 only > > Update Md

Re: [edk2-devel] [PATCH] ShellPkg: Update smbiosview type 0/4/17/41 with SMBIOS 3.5 fields v2

2023-04-09 Thread Gao, Zhichao
> -Original Message- > From: Lin, MillerX > Sent: Friday, April 7, 2023 6:54 PM > To: devel@edk2.groups.io > Cc: Lin, MillerX ; Ni, Ray ; Gao, > Zhichao > Subject: [PATCH] ShellPkg: Update smbiosview type 0/4/17/41 with SMBIOS > 3.5 fields v2 > > Cc: Signed-off-by: MillerX Lin > Cc:

Re: [edk2-devel] [PATCH 18/18] FmpDevicePkg: Update code to be more C11 compliant by using __func__

2023-04-09 Thread Xu, Wei6
Reviewed-by: Wei6 Xu Thanks, Wei -Original Message- From: Rebecca Cran Sent: Friday, April 7, 2023 6:23 AM To: devel@edk2.groups.io; Gao, Liming ; Kinney, Michael D ; Jiang, Guomin ; Xu, Wei6 ; Dong, Guo ; Ni, Ray ; Rhodes, Sean ; Lu, James ; Guo, Gua ; Andrew Fish ; Wu, Hao A ; M

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, April 10, 2023 #cal-reminder

2023-04-09 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, April 10, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1860810 ) *Description:* TianoC