[edk2-devel] [Patch 1/1] PcAtChipsetPkg: Add PCD for RTC default year

Add PcdRtcDefaultYear to specify the default year to use when the RTC is in an invalid state. Make sure PcdRtcDefaultYear is >= PcdMinimalValidYear and <= PcdMaximalValidYear. Set the default value for this PCD to PcdMinimalValidYear to preserve the existing behavior. A platform DSC file can overr

Re: [edk2-devel] [Patch 07/12] SecurityPkg: Add gmock example

Acked-by: Jiewen Yao > -Original Message- > From: Kinney, Michael D > Sent: Sunday, March 26, 2023 2:46 AM > To: devel@edk2.groups.io > Cc: Johnson, Chris N ; Yao, Jiewen > ; Wang, Jian J > Subject: [Patch 07/12] SecurityPkg: Add gmock example > > From: Chris Johnson > > REF: https://

Re: [edk2-devel] [Patch 09/12] SecurityPkg/Library/SecureBootVariableLib: HOST_APPLICATION IA32/X64 only

Reviewed-by: Jiewen Yao > -Original Message- > From: Kinney, Michael D > Sent: Sunday, March 26, 2023 2:46 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J > > Subject: [Patch 09/12] SecurityPkg/Library/SecureBootVariableLib: > HOST_APPLICATION IA32/X64 only > > Cc: Jiewen

Re: [edk2-devel] [Patch 08/12] SecurityPkg/Library/SecureBootVariableLib: Fix VS20xx 4122 errors

Reviewed-by: Jiewen Yao > -Original Message- > From: Kinney, Michael D > Sent: Sunday, March 26, 2023 2:46 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J > > Subject: [Patch 08/12] SecurityPkg/Library/SecureBootVariableLib: Fix > VS20xx 4122 errors > > The unit test code

Re: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium leftover data structure

Merged: https://github.com/tianocore/edk2/pull/4181 Commit: https://github.com/tianocore/edk2/commit/07fa6d1841abcfc58b226027d711ebb47559f442 Mike From: Kinney, Michael D Sent: Saturday, March 25, 2023 6:05 PM To: Pawel Polawski Cc: devel@edk2.groups.io; Gao, Liming ; Liu, Zhiguang ; Zimmer,

Re: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium leftover data structure

Thanks Pawel, I see there were some minor CI issues related to uncrustify formatting. I am fixing those and will post a new PR with my Rb. I will close 4174. Mike From: Pawel Polawski Sent: Friday, March 24, 2023 7:46 AM To: Kinney, Michael D Cc: devel@edk2.groups.io; Gao, Liming ; Liu, Zhig

[edk2-devel] error C0DE: Unknown fatal error

Hi: Could you please help to take a look at the error? Thanks! p.s. It suggest that send an email to devel@edk2.groups.io Thanks BR, Bill Wen [cid:image001.png@01D7B385.1B404CA0] Best Regards Bill.Wen 温登翔 IVM BU SW/ WNC TEL : 03-6667799 Ext8658 Email : bill@wnc.com.tw

Re: [edk2-devel] reg: MAC address could not change on pre-boot environment and failed to PXE boot.

Hi Sivaraman, We did this recently in project mu, trying to find exactly the changes needed but I recall the following: * Mac Address needs to be programmed before network stack fully loads (pretty sure I only got it working in DXE), possible to add changes from this PR and have an event callb

Re: [edk2-devel] [PATCH v4 9/9] edk2-platforms: Maintainers.txt

[Public] Reviewed-by: Abdul Lateef Attar -Original Message- From: Oram, Isaac W Sent: 23 March 2023 23:07 To: Leif Lindholm ; Chang, Abner Cc: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) ; Kinney, Michael D ; Gao, Liming ; Nickle Wang Subject: RE: [PATCH v4 9/9] edk2-pl

Re: [edk2-devel] [PATCH v4 3/9] ManageabilityPkg: Add ManageabilityTransportLib header file

[AMD Official Use Only - General] Some comments inline. -Original Message- From: Chang, Abner Sent: 22 March 2023 08:19 To: devel@edk2.groups.io Cc: Liming Gao ; Isaac Oram ; Nate DeSimone ; Nickle Wang ; Igor Kulchytskyy ; Attar, AbdulLateef (Abdul Lateef) Subject: [PATCH v4 3/9] Ma

[edk2-devel] [Patch 02/12] .pytool/CISettings.py: Add subhook submodule

From: Chris Johnson REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389 Add submodule for https://github.com/Zeex/subhook This submodule is required to hook internal functions when using gmock. Cc: Sean Brogan Cc: Michael Kubacki Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Chri

[edk2-devel] [Patch 11/12] MdeModulePkg: HOST_APPLICATION IA32/X64 only

Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Michael D Kinney --- .../UnitTest/MockUefiRuntimeServicesTableLib.inf| 2 +- .../RuntimeDxeUnitTest/VariableLockRequestToLockUnitTest.inf| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Library

[edk2-devel] [Patch 09/12] SecurityPkg/Library/SecureBootVariableLib: HOST_APPLICATION IA32/X64 only

Cc: Jiewen Yao Cc: Jian J Wang Signed-off-by: Michael D Kinney --- .../UnitTest/MockPlatformPKProtectionLib.inf| 2 +- .../Library/SecureBootVariableLib/UnitTest/MockUefiLib.inf | 2 +- .../UnitTest/MockUefiRuntimeServicesTableLib.inf| 2 +- 3 files chan

[edk2-devel] [Patch 12/12] PrmPkg/Library: HOST_APPLICATION IA32/X64 only

Cc: Michael Kubacki Cc: Nate DeSimone Signed-off-by: Michael D Kinney --- .../UnitTest/DxePrmContextBufferLibUnitTestHost.inf | 2 +- .../UnitTest/DxePrmModuleDiscoveryLibUnitTestHost.inf | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/PrmPkg/Librar

[edk2-devel] [Patch 05/12] MdePkg: Add gmock examples

From: Chris Johnson REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Chris Johnson --- MdePkg/MdePkg.dec | 1 + MdePkg/Test/MdePkgHostTest.dsc| 2 + .../Include/GoogleTe

[edk2-devel] [Patch 04/12] UnitTestFrameworkPkg/ReadMe.md: Add gmock documentation

From: Chris Johnson REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389 Cc: Sean Brogan Cc: Michael Kubacki Cc: Michael D Kinney Signed-off-by: Chris Johnson --- UnitTestFrameworkPkg/ReadMe.md | 999 +++-- 1 file changed, 958 insertions(+), 41 deletions(-)

[edk2-devel] [Patch 07/12] SecurityPkg: Add gmock example

From: Chris Johnson REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389 Cc: Jiewen Yao Cc: Jian J Wang Signed-off-by: Chris Johnson --- .../SecureBootVariableLibGoogleTest.cpp | 156 ++ .../SecureBootVariableLibGoogleTest.inf | 32 .../UnitTest/MockPlat

[edk2-devel] [Patch 10/12] MdePkg/Library/BaseLib: HOST_APPLICATION IA32/X64 only

Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Michael D Kinney --- MdePkg/Library/BaseLib/UnitTestHostBaseLib.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Library/BaseLib/UnitTestHostBaseLib.inf b/MdePkg/Library/BaseLib/UnitTestHostBaseLib.inf index 12a5cdcc0

[edk2-devel] [Patch 08/12] SecurityPkg/Library/SecureBootVariableLib: Fix VS20xx 4122 errors

The unit test code for the SecureBootVariableLib is initializing local variable structures in their declaration from other local variables that are also initialized in their declaration. ANSI C does not allow this and error 4122 is generated on VS20xx compilers. The test cases are updated to init

[edk2-devel] [Patch 06/12] MdeModulePkg/Library/UefiSortLib: Add GoogleTestLib example

From: Chris Johnson REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389 Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Chris Johnson --- .../MockUefiRuntimeServicesTableLib.inf | 4 +- .../GoogleTest/UefiSortLibGoogleTest.cpp | 57 +++ .../GoogleTest/UefiSortL

[edk2-devel] [Patch 03/12] UnitTestFrameworkPkg: Add gmock support to GoogleTestLib

From: Chris Johnson REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389 * Add gmock support to GoogleTestLib * Add FunctionMockLib library class and library instance * Add GoogleTest extension to GoogleTestLib.h for CHAR16 type * Add GoogleTest extension to GoogleTestLib.h for buffer types

[edk2-devel] [Patch 00/12] Add gmock support for host-based unit testing

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389 PR: https://github.com/tianocore/edk2/pull/4180 Branch: https://github.com/mdkinney/edk2/tree/Bug_4389_UnitTestFrameworkPkg_AddGoogleMockSupport * Add subhook submodule that is required to hook internal functions when using gmock. * Add

[edk2-devel] [Patch 01/12] UnitTestFrameworkPkg: Add subhook submodule required for gmock

From: Chris Johnson REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389 Add subhook submodule that is required to hook internal functions when using gmock. https://github.com/Zeex/subhook Add SubhookLib library class and SubhookLib library instance. Include the SUBHOOK_STATIC define i

Re: [edk2-devel] [PATCH v5] MdePkg/Include: Add IPMI KCS definitions

Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner > via groups.io > Sent: Friday, March 24, 2023 2:14 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang ; > Nickle Wang ; Igor Kulchytskyy ; Oram,

Re: [edk2-devel] [PATCH v4] MdePkg/Include: Add IPMI KCS definitions

Thank you for your hard work Reviewed-by: Tinh Nguyen On 3/25/2023 8:46 PM, Chang, Abner wrote: [EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please be mindful of safe email handling and proprietary information protection practices.] [AMD Official Use Only - Genera

Re: [edk2-devel] [PATCH v4] MdePkg/Include: Add IPMI KCS definitions

[AMD Official Use Only - General] Hi Mike, please note there is V5 of IPMI KCS that fixes a typo found by Tinh. Thanks @Tinh, would you like to provide your R-B or Acked-by tag for V5? Thanks Abner > -Original Message- > From: Kinney, Michael D > Sent: Saturday, March 25, 2023 3:37 AM