On Tue, Feb 28, 2023 at 02:43:13PM +0800, gaoliming via groups.io wrote:
> Sunil:
> Is this a critical issue? Dose this fix need to catch this stable tag? Has
> it been verified and code review?
>
Hi Liming,
Yes, this is a critical issue. So, I request to catch the stable tag.
Andrei who repor
RiscVEdk2SbiLib.h has the same macro defination as BaseRiscVSbiLib.h,
the latter one was merged to MdePkg.
Signed-off-by: Evan Chai
---
.../RISC-V/ProcessorPkg/Include/Library/RiscVEdk2SbiLib.h| 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Silicon/RISC-V/ProcessorPk
Given the following, I'm not sure line endings matter at all to git?
$ file .gitmodules
.gitmodules: ASCII text, with CRLF, LF line terminators
$ file .gitignore
.gitignore: ASCII text, with CRLF line terminators
There's a CRLF in .gitmodules at the end of the brotli section.
We could certain
Sunil:
Is this a critical issue? Dose this fix need to catch this stable tag? Has
it been verified and code review?
Thanks
Liming
> -邮件原件-
> 发件人: Sunil V L
> 发送时间: 2023年2月25日 13:32
> 收件人: devel@edk2.groups.io
> 抄送: Liming Gao ; Andrei Warkentin
> ; Ard Biesheuvel ;
> Jiewen Yao ; Jordan
Hi,
> > (a) the SecureBoot variable is not present (EFI_NOT_FOUND) according to
> > the return value, or
>
> @Maintainers Would there be any objection to drop this and skip the SB checks
> only when explicitly disabled?
> Please explicitly respond even if not, so we don't end up with every
Hi,
From this patch, it looks like the main change is selecting a
different submodule sha.
Do you know why crypto/bn/rsa_sup_mul.c is required with these changes?
What testing of this change has been done?
Thanks,
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of S
Thanks for the patch.
The proposed method is not the intended way for the EDKII_SD_MMC_OVERRIDE
protocol to work.
The content in BayhubHost.c should be placed a platform level driver.
This platform level driver should produce the EDKII_SD_MMC_OVERRIDE protocol.
Then SdMmcPciHcDxe will consume the
Upgrade openssl to 1.1.1t
Pick up bugfixes from the latest openssl release.
Cc: Jian J Wang
Cc: Jiewen Yao
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Sheng Wei
---
CryptoPkg/Library/OpensslLib/OpensslLib.inf | 1 +
CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf | 1 +
Crypt
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
Tuesday, February 28, 2023
6:30pm to 7:30pm
(UTC-08:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344
Hi Gerd,
Yes, just like you said, no code logic modified, just relocation.
And thanks for your suggestion, but since it is a simple code change, but
contains too many patches, if it is ok for you, I don't plan to send the whole
patch series this time.
Thanks
Zhiguang
> -Original Message--
*Tools, CI, Code base construction meeting series*
*When:*
Monday, February 27, 2023
4:30pm to 5:30pm
(UTC-08:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1753760 )
*Description:*
TianoCore com
I have updated the pull based on Sean feedback. I added following fields to
module_report.json:
* LibraryClass
* ModuleEntryPointList
* ConstructorList
* DestructorList
I have also added commit from Ard based on this request to fix build issue:
https://github.com/tianocore/edk2-basetools/pull/88
Use predefined type while accessing IPMI command returned data
instead of raw byte array.
Signed-off-by: Mike Maslenkin
---
.../IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git
a/Features/Intel/OutOfBandManagement/Ip
There is no point to have temporary buffer in BMC instance data
used only for synchronous IPMI command as a transfer buffer.
Using local variables make things much simpler.
Signed-off-by: Mike Maslenkin
---
.../GenericIpmi/Common/IpmiBmc.c | 5 ++-
.../GenericIpmi/Common/IpmiBmcCom
Byte 0 of a response contains completion code for the command.
So, the examined data starts from byte 1. It's easy to make a mistake
here since specification counts response data from 1.
For the "Get Self Test Results" command Intelligent Platform Management
Interface Specification v2.0 rev 1.1 pa
This patchset fixes "Get Self Test Results" IPMI command response processing.
The first patch just makes a fix.
The second patch removes a transfer buffer from IPMI instance data as a
preparation of further improvement. It's not clear why a buffer of
a maximum size used for all commands. For the co
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
Monday, February 27, 2023
4:30pm to 5:30pm
(UTC-08:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1753760 )
*Description:*
Tia
Hi Guillermo,
Can you please look at Ards PR and make sure his fix is included in your PR.
Also, please work with Christine and Bob to see what is going on with the
Code Coverage check. We do want it to be easy for all community members to
submit change requests. We may need support from the ed
On Mon, 27 Feb 2023 at 18:40, Guillermo Antonio Palomino Sosa
wrote:
>
> Hi. I have submitted a pull request to edk2-basetools repository:
> https://github.com/tianocore/edk2-basetools/pull/88
> This is the feature request for it:
> https://github.com/tianocore/edk2-basetools/issues/87
> I'm als
On 2/23/23 09:04, Dov Murik wrote:
On 23/02/2023 16:58, Dov Murik wrote:
On 21/02/2023 11:38, Gerd Hoffmann wrote:
On Mon, Feb 20, 2023 at 08:44:23AM -0600, Tom Lendacky wrote:
On 2/20/23 02:49, Dov Murik wrote:
In order to allow the VMM (such as QEMU) to add a page with hashes of
kernel/
.gitmodules must be lf. Not sure about other git config files.
Mike
> -Original Message-
> From: Ard Biesheuvel
> Sent: Monday, February 27, 2023 10:18 AM
> To: devel@edk2.groups.io; rebe...@bsdio.com
> Cc: Kinney, Michael D ; Andrew Fish
> ; Leif Lindholm
> Subject: Re: [edk2-devel]
.gitmodules also must also use tabs.
> -Original Message-
> From: Kinney, Michael D
> Sent: Monday, February 27, 2023 10:22 AM
> To: Ard Biesheuvel ; devel@edk2.groups.io; rebe...@bsdio.com
> Cc: Andrew Fish ; Leif Lindholm ;
> Kinney, Michael D
> Subject: RE: [edk2-devel] [PATCH 1/1] A
On Mon, 27 Feb 2023 at 17:35, Rebecca Cran wrote:
>
> Is it just .sh files that need lf endings, or are there others?
>
I think this only applies to .sh files.
>
>
> On 2/27/23 9:14 AM, Michael D Kinney wrote:
> > There are a few file types that must be lf instead of crlf. Can those be
> > add
Hi. I have submitted a pull request to edk2-basetools repository:
https://github.com/tianocore/edk2-basetools/pull/88
This is the feature request for it:
https://github.com/tianocore/edk2-basetools/issues/87
I'm also attaching the patch here:
(0001-BaseTools-Generate-compile-information-in-build
Hi. I have submitted a pull request to edk2-basetools repository:
https://github.com/tianocore/edk2-basetools/pull/88
This is the feature request for it:
https://github.com/tianocore/edk2-basetools/issues/87
I'm also attaching the patch here: (
0001-BaseTools-Generate-compile-information-in-buil
Is it just .sh files that need lf endings, or are there others?
--
Rebecca Cran
On 2/27/23 9:14 AM, Michael D Kinney wrote:
There are a few file types that must be lf instead of crlf. Can those be added
as well?
Mike
-Original Message-
From: devel@edk2.groups.io On Behalf Of Reb
There are a few file types that must be lf instead of crlf. Can those be added
as well?
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Rebecca Cran
> Sent: Monday, February 27, 2023 5:03 AM
> To: Ard Biesheuvel ; devel@edk2.groups.io
> Cc: Andrew Fish ; Leif Lindho
*Thanks*, Gerd!
Two comments inline.
> On 27. Feb 2023, at 13:55, Gerd Hoffmann wrote:
>
> Call gRT->GetVariable() directly to read the SecureBoot variable. It is
> one byte in size so we can easily place it on the stack instead of
> having GetEfiGlobalVariable2() allocate it for us, which avo
On 2/27/23 1:04 AM, Ard Biesheuvel wrote:
On Mon, 27 Feb 2023 at 04:47, Rebecca Cran wrote:
Add a .editorconfig file which editors can use for basic formatting
details of files, such as tabs/spaces, line endings etc.
Signed-off-by: Rebecca Cran
Thank you very much for this - this is very us
Call gRT->GetVariable() directly to read the SecureBoot variable. It is
one byte in size so we can easily place it on the stack instead of
having GetEfiGlobalVariable2() allocate it for us, which avoids a few
possible error cases.
Skip secure boot checks if (and only if):
(a) the SecureBoot var
On Mon, Feb 27, 2023 at 03:23:57PM +0800, Zhiguang Liu wrote:
> V4:
> This patch set has already gotten reviewed-by except OvmfPkg. Also V4 has a
> little code change for OvmfPkg.
> So I only sent pathces about OvmfPkg (patch NO.1 and NO.4) to avoid
> disturbing other Package Maintainers.
> Other
On Mon, 27 Feb 2023 at 04:47, Rebecca Cran wrote:
>
> Add a .editorconfig file which editors can use for basic formatting
> details of files, such as tabs/spaces, line endings etc.
>
> Signed-off-by: Rebecca Cran
Thank you very much for this - this is very useful.
Acked-by: Ard Biesheuvel
Cou
32 matches
Mail list logo
