On Fri, Feb 03, 2023 at 03:14:42AM +, Ni, Ray wrote:
> Gerd,
> Can you please explain a bit more on the chunk idea?
> > > to introduce a generic and reusable concept of chunked HOBs, so you can
> > > add helper functions to HobLib for splitting and reassembling, with a
> > > struct along the l
Thanks Liming for reviewing this patch.
Could you help push this change?
Thanks
Zhiguang
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> gaoliming via groups.io
> Sent: Thursday, February 2, 2023 11:10 AM
> To: Liu, Zhiguang ; devel@edk2.groups.io; Wang,
> Jian J
> Cc:
> >
> > It's doable to program the hardware interface using DXE MP service
> protocol in
> > CpuSmm driver's entry point.
> > But, considering the standalone MM environment where the CpuMm
> driver runs
> > in a isolated environment and it cannot invoke any DXE or PEI MP service,
> you could
> > un
Hi,
> > > Ok. So new Intel processors apparently got new MSR(s) to set SMBASE
> > > directly. Any specific reason why you don't add support for that to
> > > PiSmmCpuDxeSmm? That would avoid needing the new HOB (and the related
> > > problems with the 8190 cpu limit) in the first place.
>
>
On Thu, Feb 02, 2023 at 05:03:14PM +0800, Min Xu wrote:
> From: Min M Xu
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=4245
>
> QEMU provides the following three files for guest to install the ACPI
> tables:
> - etc/acpi/rsdp
> - etc/acpi/tables
> - etc/table-loader
>
> "etc/acpi/rsdp"
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表
> tlaro...@polynum.com
> 发送时间: 2023年2月1日 3:14
> 收件人: devel@edk2.groups.io
> 抄送: Gao, Liming ; Bob Feng
> ; Chen, Christine ;
> michael.d.kin...@intel.com
> 主题: Re: [edk2-devel] [PATCH 1/1 v2] BaseTools: remove useless
> depe
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Ard
> Biesheuvel
> 发送时间: 2023年2月2日 19:27
> 收件人: devel@edk2.groups.io
> 抄送: Ard Biesheuvel ; Michael Kinney
> ; Liming Gao ;
> Jiewen Yao ; Michael Kubacki
> ; Sean Brogan
> ; Rebecca Cran ;
> Leif Lindholm ; Sami Mujawar
> ;
> -Original Message-
> From: Laszlo Ersek
> Sent: Thursday, February 2, 2023 7:47 PM
> To: Gerd Hoffmann ; Wu, Jiaxin
> Cc: Ni, Ray ; devel@edk2.groups.io; Dong, Eric
> ; Zeng, Star ; Kumar, Rahul R
>
> Subject: Re: [PATCH v3 5/5] OvmfPkg/SmmCpuFeaturesLib: Skip SMBASE
> configuration
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
This patch enables Tdx measurement in OvmfPkgX64 with below changes:
1) CC_MEASUREMENT_ENABLE is introduced in OvmfPkgX64.dsc. This flag
indicates if Intel TDX measurement is enabled in OvmfPkgX64. Its
default value is
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
TdxHelperBuildGuidHobForTdxMeasurement is called in PlatformPei to build
GuidHob for Tdx measurement.
Cc: Erdem Aktas
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Tom Lendacky
Cc: Michael Roth
Acked-by: Ger
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
TdHob and Configuration FV (Cfv) are external inputs from VMM. From the
security perspective, they should be measured before they're consumed.
This patch measures TdHob and Cfv and stores the measurement values in
WorkArea.
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
TdxHelperLib provides below helper functions for a td-guest.
- TdxHelperProcessTdHob
- TdxHelperMeasureTdHob
- TdxHelperMeasureCfvImage
- TdxHelperBuildGuidHobForTdxMeasurement
PeiTdxHelperLib is the PEI instance of TdxH
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
TdHob and Configuration FV (Cfv) are external inputs from VMM. From the
security perspective, they should be measured before they're consumed.
This patch measures TdHob and Cfv and stores the measurement values in
WorkArea.
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
ProcessHobList once was implemented in PlatformInitLib and it walks thru
TdHob list and accept un-accepted memories.
This patch moves the codes to SecTdxHelperLib and rename ProcessHobList
as TdxHelperProcessTdHob
After Tdx
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
MeasureFvImage once was implemented in PeilessStartupLib and it does
measurement and logging for Configuration FV (Cfv) image in one go,
using TpmMeasureAndLogData(). But it doesn't work in SEC.
This patch splits MeasureFvIm
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
MeasureHobList once was implemented in PeilessStartupLib and it does
measurement and logging for TdHob in one go, using TpmMeasureAndLogData().
But it doesn't work in SEC.
This patch splits MeasureHobList into 2 functions an
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
FV_HANDOFF_TABLE_POINTERS2 once was defined in IntelTdx.c. Its structure
is same as PLATFORM_FIRMWARE_BLOB2_STRUCT which is defined in
Library/TcgEventLogRecordLib.h. So this patch reuse the define of
PLATFORM_FIRMWARE_BLOB2_
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
TdxHelperLib provides below helper functions for a td-guest.
- TdxHelperProcessTdHob
- TdxHelperMeasureTdHob
- TdxHelperMeasureCfvImage
- TdxHelperBuildGuidHobForTdxMeasurement
SecTdxHelperLib is the SEC instance of TdxH
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
TdxHelperLib provides below helper functions for a td-guest.
- TdxHelperProcessTdHob
- TdxHelperMeasureTdHob
- TdxHelperMeasureCfvImage
- TdxHelperBuildGuidHobForTdxMeasurement
TdxHelperLibNull is the NULL instance of Td
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
>From the perspective of security any external input should be measured
and extended to some registers (TPM PCRs or TDX RTMR registers).
There are below 2 external input in a Td guest:
- TdHob
- Configuration FV (CFV)
TdH
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
Tdx measurement (RTMR based measurement) is enabled in OvmfPkg/IntelTdx.
This patch-set enables the feature in OvmfPkgX64 as well.
Patch #1:
Introduce TDX_MEASUREMETNS_DATA in SEC_TDX_WORK_AREA. That is because
the RTMR measurement of Td
*Reminder: TianoCore Community Meeting - APAC/NAMO*
*When:*
Thursday, February 2, 2023
7:30pm to 8:30pm
(UTC-08:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_Y2M1NDE3ODYtN2M3Yy00MDMxLTk3OWYtMTlkNjhlNWFlMjA2%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88
Gerd,
Can you please explain a bit more on the chunk idea?
Brian,
Page allocation is not preferred in this SMM case because the pointer
in HOB entry points to another memory. StandaloneMmIpl has to
migrate the "another memory" manually to SMRAM. I want to avoid
that.
Thanks,
Ray
> -Original
Restatement here: we don't want to hide something, it's not my intention to do
that (apologize if give you such impress). I appeal to everyone in community
can have more *inclusion* to every patch contributor.
Please don't bring any aggressive or suggestive words to comment someone or
patch. N
Hi Laszlo,
See below my feedback.
>
> See this is *exactly* my problem. The *whole work* on this should have
> started like this, with a new Feature Request Bugzilla:
>
> "Intel are introducing a new processor register (MSR or other method)
> with their XY product line where firmware can progra
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Xu, Min M
> Sent: Saturday, January 28, 2023 9:58 PM
> To: devel@edk2.groups.io
> Cc: Xu, Min M ; Aktas, Erdem
> ; James Bottomley ; Yao,
> Jiewen ; Gerd Hoffmann ; Tom
> Lendacky ; Michael Roth
>
> Subject: [PATCH V5 00/13] Enable Td
Hello
Can we assume that the entrypoint of PE/COFF image is always ENDBR64, if the
PE/COFF image is enlightened to support IBT?
I believe the compiler should do that, because the loader need use indirect
call to the PE/COFF entrypoint.
We need more code to detect *all* runtime images. The logic
Acked-by: Michael Kubacki
Might be convenient to have a link in the commit message to the
definition in the 2.10 spec:
https://uefi.org/specs/UEFI/2.10/04_EFI_System_Table.html?highlight=memory_attribute#efi-memory-attributes-table
On 2/2/2023 1:03 PM, Ard Biesheuvel wrote:
UEFI v2.10 intro
Ard, I am still actively tracking this for the PE/COFF spec.
Unfortunately, I don't have more firm info right now but I suggest
holding off on alternatives for the time being and I will reply back as
soon as the next steps are known.
Thanks,
Michael
On 2/2/2023 2:00 PM, Ard Biesheuvel wrote:
Could ArmVirtPkg maintainer(s) review this patch?
> -Original Message-
> From: Jan Bobek
> Sent: Saturday, January 21, 2023 6:59 AM
> To: devel@edk2.groups.io
> Cc: Jan Bobek ; Laszlo Ersek ; Yao,
> Jiewen ; Ard Biesheuvel ;
> Leif Lindholm ; Sami Mujawar
> ; Gerd Hoffmann
> Subject: [PA
Thanks Sean.
Acked-by: Jiewen Yao
> -Original Message-
> From: Sean Brogan
> Sent: Saturday, January 28, 2023 10:37 AM
> To: Jan Bobek
> Cc: devel@edk2.groups.io; Yao, Jiewen ; Sean Brogan
> ; Laszlo Ersek
> Subject: Re: [edk2-devel] [PATCH v1 0/4] Don't require self-signed PK in setu
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Xu, Min M
> Sent: Thursday, February 2, 2023 5:04 PM
> To: devel@edk2.groups.io
> Cc: Xu, Min M ; Yao, Jiewen ;
> Wang, Jian J
> Subject: [PATCH V1 1/1] SecurityPkg/TdTcg2Dxe: td-guest shall halt when
> CcMeasurement install fail
>
>
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Xu, Min M
> Sent: Thursday, February 2, 2023 5:03 PM
> To: devel@edk2.groups.io
> Cc: Xu, Min M ; Aktas, Erdem
> ; James Bottomley ; Yao,
> Jiewen ; Gerd Hoffmann ; Tom
> Lendacky ; Michael Roth
>
> Subject: [PATCH V3 1/1] OvmfPkg/Acp
On February 2, 2023 9:11 PM, Gerd Hoffmann wrote:
> On Sat, Jan 28, 2023 at 09:58:38PM +0800, Min Xu wrote:
> > From: Min M Xu
> >
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
> >
> > After TdHob and Configuration FV (Cfv) are measured in SecMain, the
> > same measurements in Peiles
Hi Ritul Guru.
There is a misprint in path to dsc file.
The path should be "UefiPayloadPkg/UefiPayloadPkg.dsc"
But there is another issue with your command line exists.
The instructions you are referred to [1] contain a sentence:
"NOTE: Pure 32bit UEFI payload support could be added if required
l
On 2/2/23 14:49, Brian J. Johnson wrote:
Hum... There is a very lethal weapon actually in use: the pillow. I
already sent various patches and they are silently ignored...
If my contribution will be ignored as others have been till now, honesty
should be to clearly state: "we don't care and we w
Hi,
I was following below link to build UEfiPayload for coreboot to boot from,
https://github.com/tianocore/edk2/blob/master/UefiPayloadPkg/BuildAndIntegrationInstructions.txt
but getting below error,
would appreciate help, thanks.
~/src/opensource/edk2 [master| ]
03:04 $ build -p UefiPayloadPk
On 2/2/23 06:51, Gerd Hoffmann wrote:
Hi,
- With relatively many elements fitting into a single HOB, on most
platforms, just one HOB is going to be used. While that may be good for
performance, it is not good for code coverage (testing). The quirky
indexing method will not be exercised by mo
> 1) It exports PYTHONHASHSEED=1 (needed?);
Setting PYTHONHASHSEED causes python hashes to be iterated in a
deterministic order. The autogen tools use hashes internally, so
setting PYTHONHASHSEED to a fixed value causes them to produce identical
output each time they are run with identical in
> >
> > This change is made given a request from Ard. The CC capability is not
> > applied to other system memory ranges that probably should also have
> > that capability, given that it's encrypted and accepted. I haven't
> > considered carefully where EFI_MEMORY_CPU_CRYPTO should be added to
> >
On Thu, 2 Feb 2023 at 19:49, Kinney, Michael D
wrote:
>
> Hi Ard,
>
> Since the PE/COFF image does not contain this information, is there an option
> to add the information to an FFS file. Either as a new bit in a standard
> header
> or as a GUIDed section defined by EDK II?
>
> Since an FV may c
Hi Ard,
Since the PE/COFF image does not contain this information, is there an option
to add the information to an FFS file. Either as a new bit in a standard header
or as a GUIDed section defined by EDK II?
Since an FV may contain content build from source and additional content
Integrated as b
Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel
> Sent: Thursday, February 2, 2023 10:04 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Kinney, Michael D
> ; Gao, Liming ; Yao,
> Jiewen ; Kubacki, Michael
> ; Sean Broga
Add a build option RUNTIM_BTI_ENABLE, and wire it up to the newly added
PCD that controls the value of the BTI flag in the memory attributes
table, as well as the command line options passed to the compiler to get
it to emit BTI landing pads in BASE and DXE_RUNTIME_DRIVER modules.
Signed-off-by: A
The memory attributes table has been extended with a flag that indicates
whether or not the OS is permitted to map the EFI runtime code regions
with strict enforcement for IBT/BTI landing pad instructions.
This is generally a property of the firmware build, and so we can permit
a platform to set t
UEFI v2.10 introduces a new flag to the memory attributes table to
inform the OS whether or not runtime services code regions were emitted
by the compiler with guard instructions for forward edge control flow
integrity enforcement.
So update our definition accordingly.
Signed-off-by: Ard Biesheuv
Cc: Michael Kinney
Cc: Liming Gao
Cc: Jiewen Yao
Cc: Michael Kubacki
Cc: Sean Brogan
Cc: Rebecca Cran
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Taylor Beebe
Ard Biesheuvel (3):
MdePkg: Update MemoryAttributesTable to v2.10
MdeModulePkg: Enable forward edge CFI in mem attributes table
A
Le Thu, Feb 02, 2023 at 05:50:32PM +0100, Gerd Hoffmann a écrit :
> On Thu, Feb 02, 2023 at 12:29:32PM +0100, tlaro...@polynum.com wrote:
> > edk2setup.sh has shortcomings. To list some:
> >
> > - The functions return a status but it is not tested; hence the
> > script goes to the end wi
There are some cases (for example the _PSL list in thermal zones) where we need
to have a reference to the node and we have been doing that via an Extern and a
reference to the node path. I am push a patch where the effectively the PCD I
added was fixed true but was unsure if that would have une
Hello Jeff,
I was assuming that no other module would rely on the AML path to access
an AML node and that nodes should be retrieved through their
characteristics instead, i.e. internal properties/Name/Uid.
There are currently no public API allowing to do so, but there are
internal APIs that could
On Thu, Feb 02, 2023 at 12:29:32PM +0100, tlaro...@polynum.com wrote:
> edk2setup.sh has shortcomings. To list some:
>
> - The functions return a status but it is not tested; hence the
> script goes to the end with a final "return $?" that simply
> returns the status of the l
Just to clarify you are suggesting that all CPU nodes generated via this with
have an outer processor container? I am fine with that but was concerned with a
change in behavior to other platforms in case they are expecting the CPUs to
just be under \SB.C00x instead of \SB.C000.C00x
-Jeff
> --
*TianoCore Community Meeting EMEA/NAMO*
*When:*
Thursday, February 2, 2023
8:00am to 9:00am
(UTC-08:00) America/Los Angeles
*Where:*
Microsoft Teams meeting Join on your computer or mobile app Click here to join
the meeting Meeting ID: 226 323 011 029 Passcode: hMRCj6 Download Teams | Join
on t
*Reminder: TianoCore Community Meeting EMEA/NAMO*
*When:*
Thursday, February 2, 2023
8:00am to 9:00am
(UTC-08:00) America/Los Angeles
*Where:*
Microsoft Teams meeting Join on your computer or mobile app Click here to join
the meeting Meeting ID: 226 323 011 029 Passcode: hMRCj6 Download Teams |
As per the SCMI specification, section CLOCK_DESCRIBE_RATES mentions that
the value of num_rates_flags[11:0] in the response must be 3 if the return
format is the triplet. Due to the buggy firmware, this was not noticed for
long time. The firmware is now fixed resulting in ClockDescribeRates() to
f
Hi Mike,
I know you are pretty busy. But I need your help. As we discussed in the
tianocore design meeting last year and as per your recommendation
(https://edk2.groups.io/g/devel/message/85481), these changes in MdePkg
are done. Abner has helped to review from RISC-V perspective. If you
could AC
*TianoCore edk2-test Bug Triage Meeting*
*When:*
Thursday, February 2, 2023
10:00pm to 11:00pm
(UTC+08:00) Asia/Shanghai
*Where:*
https://armltd.zoom.us/j/91247522013?pwd=ei9nUndTbG9oWEROS2M1aVREZkpiQT09&from=addon
*Organizer:* Edhaya Chandran edhaya.chand...@arm.com (
edhaya.chand...@arm.com?s
*Reminder: TianoCore edk2-test Bug Triage Meeting*
*When:*
Thursday, February 2, 2023
10:00pm to 11:00pm
(UTC+08:00) Asia/Shanghai
*Where:*
https://armltd.zoom.us/j/91247522013?pwd=ei9nUndTbG9oWEROS2M1aVREZkpiQT09&from=addon
*Organizer:* Edhaya Chandran edhaya.chand...@arm.com (
edhaya.chand...
On Sat, Jan 28, 2023 at 09:58:42PM +0800, Min Xu wrote:
> From: Min M Xu
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
>
> This patch enables Tdx measurement in OvmfPkgX64 with below changes:
> 1) TDX_MEASUREMENT_ENABLE is introduced in OvmfPkgX64.dsc. This flag
>indicates if I
On Sat, Jan 28, 2023 at 09:58:41PM +0800, Min Xu wrote:
> From: Min M Xu
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
>
> TdxHelperBuildGuidHobForTdxMeasurement is called in PlatformPei to build
> GuidHob for Tdx measurement.
>
> Cc: Erdem Aktas
> Cc: James Bottomley
> Cc: Jiew
On Sat, Jan 28, 2023 at 09:58:40PM +0800, Min Xu wrote:
> From: Min M Xu
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
>
> TdHob and Configuration FV (Cfv) are external inputs from VMM. From the
> security perspective, they should be measured before they're consumed.
> This patch m
On Sat, Jan 28, 2023 at 09:58:38PM +0800, Min Xu wrote:
> From: Min M Xu
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
>
> After TdHob and Configuration FV (Cfv) are measured in SecMain, the
> same measurements in PeilessStartupLib should be deleted.
Should be squashed with patch
On Sat, Jan 28, 2023 at 09:58:36PM +0800, Min Xu wrote:
> From: Min M Xu
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
>
> ProcessHobList once was implemented in PlatformInitLib and it walks thru
> TdHob list and accept un-accepted memories.
>
> This patch moves the codes to SecTd
On Sat, Jan 28, 2023 at 09:58:35PM +0800, Min Xu wrote:
> From: Min M Xu
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
>
> MeasureFvImage once was implemented in PeilessStartupLib and it does
> measurement and logging for Configuration FV (Cfv) image in one go,
> using TpmMeasureAn
On Sat, Jan 28, 2023 at 09:58:34PM +0800, Min Xu wrote:
> From: Min M Xu
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
>
> MeasureHobList once was implemented in PeilessStartupLib and it does
> measurement and logging for TdHob in one go, using TpmMeasureAndLogData().
> But it does
On Sat, Jan 28, 2023 at 09:58:33PM +0800, Min Xu wrote:
> From: Min M Xu
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
>
> FV_HANDOFF_TABLE_POINTERS2 once was defined in IntelTdx.c. Its structure
> is same as PLATFORM_FIRMWARE_BLOB2_STRUCT which is defined in
> Library/TcgEventLogR
On Sat, Jan 28, 2023 at 09:58:32PM +0800, Min Xu wrote:
> From: Min M Xu
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
>
> TdxHelperLib provides below helper functions for a td-guest.
> - TdxHelperProcessTdHob
> - TdxHelperMeasureTdHob
> - TdxHelperMeasureCfvImage
> - TdxHelper
Hi,
> > - With relatively many elements fitting into a single HOB, on most
> > platforms, just one HOB is going to be used. While that may be good for
> > performance, it is not good for code coverage (testing). The quirky
> > indexing method will not be exercised by most platforms.
>
> TRUE so
Hi,
> Hiding information, as a *basic modus operandi*,
> is incompatible with open source development.
On point.
I want that printed on a t-shirt.
> What pains me is the dishonest or at least mixed / sloppy messaging
> about *what edk2 is*. Is it open source, or is it open development?
I have
Hello Jeff,
I think it's ok to make this the generic case and remove the
Pcd to enable it.
Cf ACPI 6.5, 5.2.30.1 Processor hierarchy node structure (Type 0):
"Multiple trees may be described, covering for example multiple packages.
For the root of a tree, the parent pointer should be 0."
and
"Eac
I'm going to comment on this one email up-stream, because it showcases
the community problem, as far as I'm concerned, and because Jiaxin made
a reference to my initial request.
On 2/2/23 10:00, Gerd Hoffmann wrote:
> Hi,
>
>>> But the serialized SMBASE programming still happens, now in the PEI
edk2setup.sh has shortcomings. To list some:
- The functions return a status but it is not tested; hence the
script goes to the end with a final "return $?" that simply
returns the status of the last command that is "unset" which
always successfully unsets, ev
Expose the protocol introduced in v2.10 that permits the caller to
manage mapping permissions in the page tables.
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Drivers/CpuDxe/CpuDxe.c | 2 +
ArmPkg/Drivers/CpuDxe/CpuDxe.h | 3 +
ArmPkg/Drivers/CpuDxe/CpuDxe.inf| 2 +
A
In preparation for introducing an implementation of the EFI memory
attributes protocol that is shared between ARM and AArch64, unify the
existing code that converts a page table descriptor into a
EFI_MEMORY_xxx bitfield, so it can be called from the generic code.
Signed-off-by: Ard Biesheuvel
---
Add the Memory Attribute Protocol definition, which was adopted and
included in version 2.10 of the UEFI specification.
Link: https://bugzilla.tianocore.org/show_bug.cgi?id=3519
Signed-off-by: Ard Biesheuvel
---
MdePkg/Include/Protocol/MemoryAttribute.h | 142
MdePkg/MdePkg.
v2:
- drop patch to bump exposed UEFI revision to v2.10
- add missing permitted return values to protocol definition
Cc: Michael Kinney
Cc: Liming Gao
Cc: Jiewen Yao
Cc: Michael Kubacki
Cc: Sean Brogan
Cc: Rebecca Cran
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Taylor Beebe
Ard Biesheuve
The NOR Flash driver was recently moved from the Tianocore\edk2 repository
to the Tianocore\edk2-platforms repository at the following location:
Platform\ARM\Drivers\NorFlashDxe\NorFlashDxe.inf
As part of this move the FILE_GUID for the NorFlashDxe.inf at the new
location was also updated from: 93
On Wed, Feb 1, 2023 at 2:29 PM Ard Biesheuvel wrote:
> On Wed, 1 Feb 2023 at 13:59, Oliver Steffen wrote:
> >
> > On Wed, Feb 1, 2023 at 12:52 PM Ard Biesheuvel wrote:
> >>
> >> On Wed, 1 Feb 2023 at 10:14, Oliver Steffen
> wrote:
> >> >
>
[...]
> >> > I am sorry, this story does not seem to
Acked-by: Marvin Häuser
> On 2. Feb 2023, at 11:21, Savva Mitrofanov wrote:
>
> We need to validate inode number to prevent reading non-existent and
> incorrect inodes so we checks that inode number valid across opened
> partition before we read it in Ext4ReadInode.
>
> Cc: Marvin Häuser
> C
Reviewed-by: Marvin Häuser
> On 2. Feb 2023, at 11:21, Savva Mitrofanov wrote:
>
> Corrects multiplication overflow check code and adds additional check
> for emptiness of number of blocks and block number
>
> Cc: Marvin Häuser
> Cc: Pedro Falcato
> Cc: Vitaly Cheptsov
> Fixes: d9ceedca6c8
Reviewed-by: Marvin Häuser
> On 2. Feb 2023, at 11:21, Savva Mitrofanov wrote:
>
> The directory entry name conventions forbid having null-terminator
> symbols in its body and can lead to undefined behavior conditions
> and crashes
>
> Cc: Marvin Häuser
> Cc: Pedro Falcato
> Cc: Vitaly Chep
Reviewed-by: Marvin Häuser
> On 2. Feb 2023, at 11:21, Savva Mitrofanov wrote:
>
> We need to free SymlinkTmp before exiting if SymlinkSizeTmp != ReadSize
> condition is true
>
> Reported-by: Marvin Häuser
> Cc: Pedro Falcato
> Cc: Vitaly Cheptsov
> Fixes: e81432fbacb7 ("Ext4Pkg: Add symbo
Missing EFI_OUT_OF_RESOURCES exit status on failed Ext4CreateDentry
leads to NULL-pointer dereference in Ext4GetFileInfo (passing NULL
buffer in Ext4ReadDir)
Cc: Marvin Häuser
Cc: Pedro Falcato
Cc: Vitaly Cheptsov
Fixes: 21b1853880d5 ("Ext4Pkg: Add a directory entry tree.")
Signed-off-by: Savva
The directory entry name conventions forbid having null-terminator
symbols in its body and can lead to undefined behavior conditions
and crashes
Cc: Marvin Häuser
Cc: Pedro Falcato
Cc: Vitaly Cheptsov
Fixes: 89b2bb0db263 ("Ext4Pkg: Fix and clarify handling regarding non-utf8 dir
entries")
Sign
We need to free SymlinkTmp before exiting if SymlinkSizeTmp != ReadSize
condition is true
Reported-by: Marvin Häuser
Cc: Pedro Falcato
Cc: Vitaly Cheptsov
Fixes: e81432fbacb7 ("Ext4Pkg: Add symbolic links support")
Signed-off-by: Savva Mitrofanov
Reviewed-by: Marvin Häuser
---
Features/Ext4P
Accessing array using index of uint64 type makes MSVC compiler to
include `__allmul` function in NOOPT which is not referenced in IA32.
So we null-terminates string using ReadSize, which should be equal to
SymlinkSizeTmp after correct reading. Also adds missing MultU64x32
in Ext4Read.
Cc: Marvin H
Missing check in some cases leads to failed StrCpyS call in
Ext4GetVolumeLabelInfo. Also correct condition that checks Inode pointer
for being NULL in Ext4AllocateInode
Cc: Marvin Häuser
Cc: Pedro Falcato
Cc: Vitaly Cheptsov
Fixes: cfbbae595eec ("Ext4Pkg: Add handling of EFI_FILE_SYSTEM_VOLUME_
This check already present in the while loop below, but absent for cases
when input file is nameless, so to handle assertion in Ext4ReadFile we
need to add it at the top of function
Cc: Marvin Häuser
Cc: Pedro Falcato
Cc: Vitaly Cheptsov
Fixes: d9ceedca6c8f ("Ext4Pkg: Add Ext4Dxe driver.")
Sign
Corrects multiplication overflow check code and adds additional check
for emptiness of number of blocks and block number
Cc: Marvin Häuser
Cc: Pedro Falcato
Cc: Vitaly Cheptsov
Fixes: d9ceedca6c8f ("Ext4Pkg: Add Ext4Dxe driver.")
Signed-off-by: Savva Mitrofanov
---
Features/Ext4Pkg/Ext4Pkg.ds
Missing check for wrong s_log_block_size exponent leads to shift out of
bounds. Limit block size to 2 MiB
Cc: Marvin Häuser
Cc: Pedro Falcato
Cc: Vitaly Cheptsov
Fixes: d9ceedca6c8f ("Ext4Pkg: Add Ext4Dxe driver.")
Signed-off-by: Savva Mitrofanov
Reviewed-by: Pedro Falcato
Reviewed-by: Marvin
Superblock s_inodes_per_group field can't be zero, it leads to division
by zero in BlockGroup routine Ext4ReadInode
Cc: Marvin Häuser
Cc: Pedro Falcato
Cc: Vitaly Cheptsov
Fixes: d9ceedca6c8f ("Ext4Pkg: Add Ext4Dxe driver.")
Signed-off-by: Savva Mitrofanov
Reviewed-by: Pedro Falcato
Reviewed-
We need to validate inode number to prevent reading non-existent and
incorrect inodes so we checks that inode number valid across opened
partition before we read it in Ext4ReadInode.
Cc: Marvin Häuser
Cc: Pedro Falcato
Cc: Vitaly Cheptsov
Fixes: d9ceedca6c8f ("Ext4Pkg: Add Ext4Dxe driver.")
Sig
We need to check EXT4_FEATURE_RO_COMPAT_METADATA_CSUM in the
FeatureRoCompat field instead of FeaturesCompat. The proper way to do
this is to use macro EXT4_HAS_METADATA_CSUM.
Also, replace the EXT4_FEATURE_INCOMPAT_CSUM_SEED check with predefined
macro EXT4_HAS_INCOMPAT
Cc: Marvin Häuser
Cc: Ped
Hi all,
In v4 I rebased patches according upstream. Also in this revision I corrected
all remarks and comments from v3.
This patchset fixes several code problems found by fuzzing Ext4Dxe like
buffer and integer overflows, memory leaks, logic bugs and so on.
REF: https://github.com/savvamitrofano
We need to free buffer on return if BlockRemainder != 0. Also changed
return logic from function to use use common exit to prevent code
duplication.
Cc: Marvin Häuser
Cc: Pedro Falcato
Cc: Vitaly Cheptsov
Fixes: d9ceedca6c8f ("Ext4Pkg: Add Ext4Dxe driver.")
Signed-off-by: Savva Mitrofanov
Revi
Yes, I checked this out. Your UTF8 patches and latest patch
which redirects '..' folder to proper '/' with my directory entry '\0' patch
solves the problem.
However, we need to perform inode number validation at least in Ext4ReadInode.
As we discussed, we can do this in a simplified way. These cha
On Wed, 1 Feb 2023 at 19:41, Taylor Beebe wrote:
>
> Hey Ard,
>
> Have you encountered complications which stem from the lack of
> pre-allocated page table memory on ARM devices utilizing the memory
> protection policy?
>
Interesting. No I haven't, but I agree it is a potential concern.
> My obs
On Thu, 2 Feb 2023 at 04:19, gaoliming via groups.io
wrote:
>
> Ard:
> I check this protocol definition in UEFI2.10 spec. GetMemoryAttributes and
> SetMemoryAttributes API return status include EFI_OUT_OF_RESOURCES and
> EFI_ACCESS_DENIED. But, they are missing in this patch. Can you help
> confi
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4335
CcMeasurement protocol is installed when it is supported in a td-guest. If
the installation of the protocol failed, the guest shall go into
CpuDeadLoop. Because the measurement feature is crucial to a td-guest and
it shall st
From: Min M Xu
https://bugzilla.tianocore.org/show_bug.cgi?id=4245
QEMU provides the following three files for guest to install the ACPI
tables:
- etc/acpi/rsdp
- etc/acpi/tables
- etc/table-loader
"etc/acpi/rsdp" and "etc/acpi/tables" are similar, they are only kept
separate because they ha
1 - 100 of 101 matches
Mail list logo
