On Tue, Jan 17, 2023 at 01:07:53PM +, Xu, Min M wrote:
> On January 17, 2023 6:57 PM, Gerd Hoffmann wrote:
> >
> > > -INF
> > MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDx
> > e.inf
> >
> > If you move the gfx console driver you can move the gfx hardware drivers
> > too:
Hi,
> To Gerd's point, removing "first in edk2, later in linux too" I think
> is backwards. We need all users of the protocol to agree that SEV-SNP
> and TDX strictly imply unaccepted memory support. Only then can we
> remove the protocol from EDK2.
Its not backwards.
edk2 dropping support fir
On Wed, 18 Jan 2023 at 07:37, Oliver Steffen wrote:
>
> On Tue, Jan 17, 2023 at 3:57 PM Ard Biesheuvel wrote:
>>
>> On Tue, 17 Jan 2023 at 13:48, Oliver Steffen wrote:
>> >
>> > Hi Ard, Hi everyone,
>> >
>> > Thanks for the work!
>> >
>> > But somehow this patch (as it was merged into master bra
On Tue, Jan 17, 2023 at 05:43:53PM +0100, Ard Biesheuvel wrote:
> On Tue, 17 Jan 2023 at 13:37, Gerd Hoffmann wrote:
> >
> > Hi,
> >
> > > >> In particular the firmware makes no further decisions based on
> > > >> whether QEMU advertized some of these features.
> > > >
> > > > I was thinking the
On Tue, Jan 17, 2023 at 3:57 PM Ard Biesheuvel wrote:
> On Tue, 17 Jan 2023 at 13:48, Oliver Steffen wrote:
> >
> > Hi Ard, Hi everyone,
> >
> > Thanks for the work!
> >
> > But somehow this patch (as it was merged into master branch) does not
> > work for me on the ThunderX box we have.
> >
> >
Merged https://github.com/tianocore/edk2/pull/3922
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yao,
> Jiewen
> Sent: Wednesday, January 18, 2023 8:16 AM
> To: Xu, Min M ; devel@edk2.groups.io
> Cc: Aktas, Erdem ; James Bottomley
> ; Gerd Hoffmann ; Tom
> Lendacky ; Mich
[AMD Official Use Only - General]
This is the duplicate one, there is another above.
Btw Liming, please let me push these two patch sets after you giving
Reviewed-by to this one. I will have to rebase them before merging the change.
Thanks
Abner
> -Original Message-
> From: gaoliming
>
Abner:
I see IPMI_APP_GET_CHANNEL_INFO definition is remove in this patch. Can
you help explain it in detail?
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Chang, Abner
> via groups.io
> 发送时间: 2023年1月6日 10:58
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zh
Merged https://github.com/tianocore/edk2/pull/3921
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yao,
> Jiewen
> Sent: Wednesday, January 18, 2023 8:16 AM
> To: Xu, Min M ; devel@edk2.groups.io
> Cc: Aktas, Erdem ; James Bottomley
> ; Gerd Hoffmann ; Tom
> Lendacky ; Mich
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Chang, Abner
> via groups.io
> 发送时间: 2023年1月18日 9:43
> 收件人: devel@edk2.groups.io
> 抄送: Jian J Wang ; Liming Gao
> ; Nickle Wang ; Igor
> Kulchytskyy ; Isaac Oram ; Nate
> DeSimone
> 主题: [edk2-devel] [PATCH V3 0/3] Add NULL
Merged https://github.com/tianocore/edk2/pull/3920
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yao,
> Jiewen
> Sent: Wednesday, January 18, 2023 8:15 AM
> To: Xu, Min M ; devel@edk2.groups.io
> Cc: Wang, Jian J
> Subject: Re: [edk2-devel] [PATCH V2 1/1] SecurityPkg/TdT
Hi Roth
I got weird merge conflict when I try to apply the patches from email.
Would you please resubmit the patch based on latest code base?
Once I see the new version, I will try to merge them again.
Thank you
Yao, Jiewen
> -Original Message-
> From: Michael Roth
> Sent: Thursday, De
Reviewed-by: Jiewen Yao
Merged https://github.com/tianocore/edk2/pull/3918
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gerd
> Hoffmann
> Sent: Tuesday, January 17, 2023 7:33 PM
> To: Xu, Min M
> Cc: devel@edk2.groups.io; Aktas, Erdem ; James
> Bottomley ; Yao, Jiewen
[AMD Official Use Only - General]
Forwarding this question to Jiangang and Tim.
Abner
> -Original Message-
> From: gaoliming
> Sent: Wednesday, January 18, 2023 11:20 AM
> To: Chang, Abner ; devel@edk2.groups.io
> Cc: 'Dandan Bi' ; Kirkendall, Garrett
>
> Subject: 回复: [PATCH V2] MdeMod
Abner:
What problem will be caused without those source files?
Thanks
Liming
> -邮件原件-
> 发件人: abner.ch...@amd.com
> 发送时间: 2023年1月12日 13:08
> 收件人: devel@edk2.groups.io
> 抄送: Dandan Bi ; Liming Gao
> ; Garrett Kirkendall
> ; Abner Chang
> 主题: [PATCH V2] MdeModulePkg/Decompress: Add missin
Reviewed-by: Jiewen Yao
Merged https://github.com/tianocore/edk2/pull/3916
> -Original Message-
> From: Gerd Hoffmann
> Sent: Tuesday, January 17, 2023 6:58 PM
> To: Xu, Min M
> Cc: devel@edk2.groups.io; Leif Lindholm ; Ard
> Biesheuvel ; Abner Chang
> ; Daniel Schaefer ; Aktas,
> Erde
From: Abner Chang
Add IpmiCommandLib to MdeModulePkg DEC/DSC
files.
Signed-off-by: Abner Chang
Cc: Jian J Wang
Cc: Liming Gao
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Cc: Isaac Oram
Cc: Nate DeSimone
Reviewed-by: Isaac Oram
Reviewed-by: Igor Kulchytskyy
---
MdeModulePkg/MdeModulePkg.dec |
From: Abner Chang
Add IpmiCommandLib to MdeModulePkg. This header file is
copied from edk2-platforms/Features/Intel/OutOfBandManagement/
IpmiFeaturePkg\Include\Library. Having this header file in
edk2 to avoid the dependence of edk2 module with edk2-platfrom.
The NULL instance of IpmiCommandLib u
From: Abner Chang
The NULL instance of IpmiCommandLib library under
MdeModulePkg as the default IpmiCommandLib instance
used by the modules under edk2.
Signed-off-by: Abner Chang
Cc: Jian J Wang
Cc: Liming Gao
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Cc: Isaac Oram
Cc: Nate DeSimone
Reviewed-
From: Abner Chang
BZ# 4231
In V3: Add Igor Kulchytskyy's Reviewed-by
In V2: Address the typos.
This patch adds a NULL instance of IpmiCommandLib to remove
the dependence between edk2 and edk2-platform packages.
Signed-off-by: Abner Chang
Cc: Jian J Wang
Cc: Liming Gao
Cc: Nickle Wang
Cc: I
Signed-off-by: Christopher Zurcher
Reviewed-by: Liming Gao
---
MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c
b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c
index 6555aeed7d..f424ebd041 100644
--- a
On January 17, 2023 7:26 PM, Gerd Hoffmann wrote:
> On Tue, Jan 17, 2023 at 03:40:10PM +0800, Min Xu wrote:
> > From: Min M Xu
> >
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
> >
> > From the perspective of security any external input should be measured
> > and extended to some reg
Good work Isaac!
For the series...
Reviewed-by: Nate DeSimone
-Original Message-
From: Oram, Isaac W
Sent: Thursday, January 12, 2023 3:57 PM
To: devel@edk2.groups.io
Cc: Oram, Isaac W ; Desimone, Nathaniel L
; Chiu, Chasel
Subject: [edk2-devel][edk2-platforms][PATCH V1 0/2] Update
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4246
In function InitPaging, NumberOfPml5Entries is calculated by below code
NumberOfPml5Entries = (UINTN)LShiftU64 (1, SizeOfMemorySpace - 48);
If the SizeOfMemorySpace is larger than 48, NumberOfPml5Entries will be
larger than 1. However, this
Thanks all for reviewing, and I will send a new version to address the comment.
As for Gerd's question, let me explain.
Let's see one example, that the CPU has SizeOfMemorySpace >48, but the CPU
doesn't enable 5 level paging.
The purpose of the current function InitPaging is to modify existing pa
Pushed as 8e927b0f42..e43a63746f
-Original Message-
From: Desimone, Nathaniel L
Sent: Tuesday, January 17, 2023 4:45 PM
To: Benjamin Doron ; devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Oram, Isaac W
; Chiu, Chasel
Subject: RE: [edk2-devel][edk2-platforms][PATCH v2]
KabylakeOpenBoa
Reviewed-by: Nate DeSimone
-Original Message-
From: Benjamin Doron
Sent: Friday, January 13, 2023 9:56 AM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Oram, Isaac W
; Desimone, Nathaniel L
; Chiu, Chasel
Subject: [edk2-devel][edk2-platforms][PATCH v2]
KabylakeOpenBoardPkg/I2c
Hi Ard and Isaac,
Thanks for review.
I will correct it and submit V2.
BR,
by Tommy
> -Original Message-
> From: Oram, Isaac W
> Sent: Wednesday, January 18, 2023 8:16 AM
> To: Ard Biesheuvel ; devel@edk2.groups.io
> Cc: Tommy Huang ; Desimone, Nathaniel
Thanks Ard.
Tommy, I will wait for Patch V2 with the correct INF_VERSION.
Thanks,
Isaac
-Original Message-
From: Ard Biesheuvel
Sent: Tuesday, January 17, 2023 3:16 PM
To: devel@edk2.groups.io; Oram, Isaac W
Cc: Tommy Huang ; Desimone, Nathaniel L
; quic_llind...@quicinc.com; Kinney,
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Xu, Min M
> Sent: Wednesday, January 18, 2023 7:53 AM
> To: devel@edk2.groups.io
> Cc: Xu, Min M ; Aktas, Erdem
> ; James Bottomley ; Yao,
> Jiewen ; Gerd Hoffmann ;
> Tom Lendacky ; Michael Roth
>
> Subject: [PATCH V2 1/1] OvmfPkg/Ba
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Xu, Min M
> Sent: Wednesday, January 18, 2023 7:53 AM
> To: devel@edk2.groups.io
> Cc: Xu, Min M ; Yao, Jiewen ;
> Wang, Jian J
> Subject: [PATCH V2 1/1] SecurityPkg/TdTcg2Dxe: Extend EFI boot variable to
> PCR[1]
>
> From: Min M Xu
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Xu, Min M
> Sent: Wednesday, January 18, 2023 7:53 AM
> To: devel@edk2.groups.io
> Cc: Xu, Min M ; Aktas, Erdem
> ; James Bottomley ; Yao,
> Jiewen ; Gerd Hoffmann ;
> Tom Lendacky ; Michael Roth
>
> Subject: [PATCH V2 1/1] OvmfPkg/Cc
Thanks for the comments. They're will be sent for review in separate patches.
> -Original Message-
> From: Yao, Jiewen
> Sent: Monday, January 16, 2023 8:45 AM
> To: Xu, Min M ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Aktas, Erdem
> ; James Bottomley ; Gerd
> Hoffmann ; Tom Lendacky
> ;
From: Min M Xu
According to TCG PC Client PFP spec 0021 Section 2.4.4.2 EFI boot variable
should be measured and extended to PCR[1], not PCR[5]. This patch is
proposed to fix this error.
Cc: Jiewen Yao
Cc: Jian J Wang
Reviewed-by: Jiewen Yao
Signed-off-by: Min Xu
---
SecurityPkg/Tcg/TdTcg2D
From: Min M Xu
Status should be initialized otherwise it may return unexpected value.
Cc: Erdem Aktas
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Tom Lendacky
Cc: Michael Roth
Reviewed-by: Jiewen Yao
Signed-off-by: Min Xu
---
OvmfPkg/Library/CcExitLib/CcExitVeHandler.c | 9
From: Min M Xu
The previous implementation of SetOrClearSharedBit doesn't handle the
error correctly. In this patch SetOrClearSharedBit is changed to return
error code so that the caller can handle it.
Cc: Erdem Aktas
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Tom Lendacky
Cc:
Note that the value in the INF_VERSION field cannot be chosen
arbitrarily - it should be the latest version of the INF spec, so 1.29
(you don't need to put a hex value here, just "1.29" is fine)
On Tue, 17 Jan 2023 at 23:40, Isaac Oram wrote:
>
> Reviewed-by: Isaac Oram
>
> Note that you do not
On 1/17/23 10:49, Ard Biesheuvel wrote:
On Mon, 16 Jan 2023 at 21:10, Tom Lendacky wrote:
On 1/16/23 11:09, Ard Biesheuvel wrote:
On Thu, 12 Jan 2023 at 18:09, Tom Lendacky wrote:
On 12/6/22 23:32, Gerd Hoffmann via groups.io wrote:
qemu uses the etc/e820 fw_cfg file not only for memory,
edk2-platforms/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBootOption.c
338: Can you change to mUefiShellFileGuid and initialize it to zero? It
seems misleading to me to have the default value here when it is not used. I
think we should also move the declarations to the beginni
Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c
Line 168: Don't we need to free buffer on this path?
Lines 655, 1083: Please put a newline between while and the block to free
resources.
Regards,
Isaac
-Original Message-
From: devel@edk2.groups.io On Behalf Of A
On Mon, 16 Jan 2023 at 18:41, Oliver Steffen wrote:
>
> Update CI, run all Linux (aka Ubuntu-GCC5) based jobs in custom
> containers. This decouples the CI environment from the virtual machine
> images that Azure DevOps provides. The currently used ubuntu-18.04 image
> has been deprecated for a
On 1/17/23 09:40, Ard Biesheuvel wrote:
On Tue, 17 Jan 2023 at 13:55, Rebecca Cran wrote:
I was under the impression that this is becoming a more standard format?
If this is not defined in an ARM spec somewhere, we shouldn't add it
to ArmPkg at this point.
From what I've found, the ARM spe
*Tools, CI, Code base construction meeting series*
*When:*
Tuesday, January 17, 2023
10:00am to 11:00am
(UTC-08:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1650235 )
*Description:*
TianoCore c
Reviewed-by: Michael Kubacki
On 1/16/2023 12:40 PM, Oliver Steffen wrote:
Run the Linux jobs of the OvmfPkg platform CI inside a container,
in the same way the general CI does now. Make use of the default image
specified in the defaults.yml template.
Do not run apt-get in CI jobs to install qe
Reviewed-by: Michael Kubacki
On 1/16/2023 12:40 PM, Oliver Steffen wrote:
Run the Linux jobs of the EmulatorPkg platform CI inside a container,
in the same way the general CI does now. Make use of the default image
specified in the defaults.yml template.
Do not run apt-get in CI jobs to instal
Reviewed-by: Michael Kubacki
On 1/16/2023 12:40 PM, Oliver Steffen wrote:
Run the Linux jobs of the ArmVirtPkg platform CI inside a container,
in the same way the general CI does now. Make use of the default image
specified in the defaults.yml template.
Do not run apt-get in CI jobs to install
Reviewed-by: Michael Kubacki
On 1/16/2023 12:40 PM, Oliver Steffen wrote:
Run all Linux based jobs in a container, using a custom Fedora 35 image
(gcc 11). The image URL specified in the defaults.yml template, so that
all CI jobs can use it. The image is hosted on ghcr.io and the
Dockerfiles a
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
Tuesday, January 17, 2023
10:00am to 11:00am
(UTC-08:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1650235 )
*Description:*
T
On Mon, 16 Jan 2023 at 21:10, Tom Lendacky wrote:
>
> On 1/16/23 11:09, Ard Biesheuvel wrote:
> > On Thu, 12 Jan 2023 at 18:09, Tom Lendacky wrote:
> >>
> >> On 12/6/22 23:32, Gerd Hoffmann via groups.io wrote:
> >>> qemu uses the etc/e820 fw_cfg file not only for memory, but
> >>> also for reser
Series Reviewed-by: Igor Kulchytskyy
-Original Message-
From: abner.ch...@amd.com
Sent: Friday, January 13, 2023 1:03 AM
To: devel@edk2.groups.io
Cc: Jian J Wang ; Liming Gao ;
Nickle Wang ; Igor Kulchytskyy ; Isaac Oram
; Nate DeSimone
Subject: [EXTERNAL] [PATCH V2 0/3] Add NULL Ipmi
>
> Why do you call boot with a bootloader a legacy feature?
>
Gerd answered this about EBS called from the bootloader.
> > they'll only get a safe view of the memory map. I don't think it's right
> > to choose unsafe behavior for a legacy setup.
>
> Present memory map with unaccepted memory to O
On Tue, 17 Jan 2023 at 13:37, Gerd Hoffmann wrote:
>
> Hi,
>
> > >> In particular the firmware makes no further decisions based on
> > >> whether QEMU advertized some of these features.
> > >
> > > I was thinking the other way around: When cpu hotplug is disabled in
> > > qemu it should be safe
On Tue, 17 Jan 2023 at 13:55, Rebecca Cran wrote:
>
> I was under the impression that this is becoming a more standard format?
>
If this is not defined in an ARM spec somewhere, we shouldn't add it
to ArmPkg at this point.
> For example, the Neoverse N2 has AFF0 always 0 (it's not hyperthreaded)
On Tue, 17 Jan 2023 at 13:16, Gerd Hoffmann wrote:
>
> v4:
> - made mmio window move a bit more robust.
> - dropped patches for moving MMCONFIG, they'll come as separate patch
>series later.
>
> v3:
> - Add / fix comments, add notes to commit messages.
> - Make functions static.
> - Loggi
On Tue, 17 Jan 2023 at 16:03, Laszlo Ersek wrote:
>
> On 1/17/23 13:16, Gerd Hoffmann wrote:
> > + PlatformAddMemoryRangeHob (Base, End);
> > +}
> > + }
> > +
>
> (2) Still not sure if this empty line is intentional (it may be, you
> didn't answer it under the v2 review AFAI
[AMD Official Use Only - General]
Hi Maintainers,
Could you please review and merge the below patch?
Thanks
AbduL
-Original Message-
From: devel@edk2.groups.io On Behalf Of Abdul Lateef
Attar via groups.io
Sent: 15 November 2022 17:34
To: devel@edk2.groups.io
Cc: Eric Dong ; Lim
From: KasimX Liu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4193
In order to remove RTC_INDEX/RTC_TARGET from
the UplBuild macro list,change the RTC_INDEX
/RTC_TARGET type from PcdsFixedAtBuild to PcdsDynamicEx
Cc: Guo Dong
Cc: Ray Ni
Cc: James Lu
Cc: Gua Guo
Signed-off-by: KasimX
On 1/17/23 13:16, Gerd Hoffmann wrote:
> Add PlatformReservationConflictCB() callback function for use with
> PlatformScanE820(). It checks whenever the 64bit PCI MMIO window
> overlaps with a reservation from qemu. If so move down the MMIO window
> to resolve the conflict.
>
> Write any actions
On Tue, 17 Jan 2023 at 16:03, Laszlo Ersek wrote:
>
> On 1/17/23 13:16, Gerd Hoffmann wrote:
> > Add PlatformAddHobCB() callback function for use with
> > PlatformScanE820(). It adds HOBs for high memory and reservations (low
> > memory is handled elsewhere because there are some special cases to
On 1/17/23 13:16, Gerd Hoffmann wrote:
> Add PlatformAddHobCB() callback function for use with
> PlatformScanE820(). It adds HOBs for high memory and reservations (low
> memory is handled elsewhere because there are some special cases to
> consider). This replaces calls to PlatformScanOrAdd64BitE
On Tue, 17 Jan 2023 at 13:48, Oliver Steffen wrote:
>
> Hi Ard, Hi everyone,
>
> Thanks for the work!
>
> But somehow this patch (as it was merged into master branch) does not
> work for me on the ThunderX box we have.
>
> Any idea what could be wrong?
I'm not sure I understand the question. The
On Tue, Jan 17, 2023 at 3:50 PM Yao, Jiewen wrote:
> Cool!
> Then I suggest to drop patch 17.
>
Perfectly fine with me.
>
> > -Original Message-
> > From: devel@edk2.groups.io On Behalf Of Gerd
> > Hoffmann
> > Sent: Tuesday, January 17, 2023 8:39 PM
> > To: Yao, Jiewen
> > Cc: devel
On 1/17/23 13:16, Gerd Hoffmann wrote:
> First handle the cases which do not need know the value of
> PlatformInfoHob->LowMemory (microvm and cloudhv). Then call
> PlatformGetSystemMemorySizeBelow4gb() to get LowMemory. Finally handle
> the cases (q35 and pc) which need to look at LowMemory,
>
>
Cool!
Then I suggest to drop patch 17.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gerd
> Hoffmann
> Sent: Tuesday, January 17, 2023 8:39 PM
> To: Yao, Jiewen
> Cc: devel@edk2.groups.io; ostef...@redhat.com; Andrew Fish
> ; Ard Biesheuvel ; Feng,
> Bob C ; Bi, Dandan ;
On Tue, 17 Jan 2023 at 15:47, Laszlo Ersek wrote:
>
> On 1/17/23 13:16, Gerd Hoffmann wrote:
>
> > +/**
> > + Store first address not used by e820 RAM entries in
> > + PlatformInfoHob->FirstNonAddress
> > +**/
> > +VOID
> > +PlatformGetFirstNonAddressCB (
> > + IN EFI_E820_ENTRY64 *E8
On 1/17/23 13:16, Gerd Hoffmann wrote:
> +/**
> + Store first address not used by e820 RAM entries in
> + PlatformInfoHob->FirstNonAddress
> +**/
> +VOID
> +PlatformGetFirstNonAddressCB (
> + IN EFI_E820_ENTRY64 *E820Entry,
> + IN OUT EFI_HOB_PLATFORM_INFO *PlatformInfoHob
> + )
>
On 1/17/23 13:16, Gerd Hoffmann wrote:
> Add PlatformGetLowMemoryCB() callback function for use with
> PlatformScanE820(). It stores the low memory size in
> PlatformInfoHob->LowMemory. This replaces calls to
> PlatformScanOrAdd64BitE820Ram() with non-NULL LowMemory.
>
> Write any actions done (
On Tue, Jan 17, 2023 at 02:10:08PM +, Boeuf, Sebastien wrote:
> Hi,
>
> Looking at the hardcoded limitation provided by PcdPciMmio64Size
> (32GiB), I was wondering what would be the best approach to make this a
> bit more dynamic?
>
> I know that for QEMU, the fw_cfg mechanism can be used to
Reviewed-by: Guo Dong
-Original Message-
From: Liu, KasimX
Sent: Tuesday, January 17, 2023 3:41 AM
To: devel@edk2.groups.io
Cc: Liu, KasimX ; Dong, Guo ; Ni, Ray
; Lu, James ; Guo, Gua
Subject: [PATCH] UefiPayloadPkg: Set RTC dynamic PCD to PeiPCDdatabase
From: KasimX Liu
REF: ht
On 1/17/23 13:16, Gerd Hoffmann wrote:
> First step replacing the PlatformScanOrAdd64BitE820Ram() function.
>
> Add a PlatformScanE820() function which loops over the e280 entries
> from FwCfg and calls a callback for each of them.
>
> Add a GetFirstNonAddressCB() function which will store the fi
Hi,
Looking at the hardcoded limitation provided by PcdPciMmio64Size
(32GiB), I was wondering what would be the best approach to make this a
bit more dynamic?
I know that for QEMU, the fw_cfg mechanism can be used to override the
value of PcdPciMmio64Size, but this isn't something Cloud Hyperviso
On January 17, 2023 7:22 PM, Gerd Hoffmann wrote:
>
> > Patch #2:
> > Introduce TdxHelperLib which provides helper functions for td-guest.
>
> > Patch #6:
> > ProcessTdxHobList is moved to TdxHelperLib and is renamed as
> > TdxHelperProcessTdHob(). So the duplicated codes are deleted in thi
On January 17, 2023 6:57 PM, Gerd Hoffmann wrote:
>
> > -INF
> MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDx
> e.inf
>
> If you move the gfx console driver you can move the gfx hardware drivers
> too:
>
> OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf
> OvmfPkg/QemuRamfbDxe/Qemu
Create Acpi65.h, which is copied from Acpi64.h, and make the following
changes:
1. Replace all occurences of "6.4/6_4" with "6.5/6_5".
2. Incremented FADT minor revision.
3. Make Acpi65.h the latest ACPI definitions that Acpi.h contains.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4306
Cc
Add CORE_PIC, LIO_PIC, HT_PIC, EIO_PIC, MSI_PIC, BIO_PIC and LPC_PIC
tables for LoongArch64 as defined in ACPI SPEC 6.5.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4306
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Chao Li
---
MdePkg/Include/IndustryStandard/Acp
ACPI specification 6.5 has been released in August 2022, EDK2 needs to
add V6.5 header.
v1:
1. Added ACPI 6.5 header, copied from Acpi64.h.
2. Added CORE_PIC, LIO_PIC ,etc. tables to MADT.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Chao Li (2):
MdePkg: Add ACPI 6.5 header
MdePkg
From: Min M Xu
https://bugzilla.tianocore.org/show_bug.cgi?id=4245
The ACPI tables are downloaded from QEMU. From the security perspective
they should be measured and extended before installation. So that they
can be audited later.
The measurement leverages the TpmMeasurementLib which is availa
Create Acpi65.h, which is copied from Acpi64.h, and make the following
changes:
1. Replace all occurences of "6.4/6_4" with "6.5/6_5".
2. Incremented FADT minor revision.
3. Make Acpi65.h the latest ACPI definitions that Acpi.h contains.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4306
Cc
Add CORE_PIC, LIO_PIC, HT_PIC, EIO_PIC, MSI_PIC, BIO_PIC and LPC_PIC
tables for LoongArch64 as defined in ACPI SPEC 6.5.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4306
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Chao Li
---
MdePkg/Include/IndustryStandard/Acp
I was under the impression that this is becoming a more standard format?
For example, the Neoverse N2 has AFF0 always 0 (it's not hyperthreaded),
it puts the core ID in AFF1, the cluster ID in AFF2, but since it only
has a single socket AFF3 is always 0. This differs from older cores
where the
ACPI specification 6.5 has been released in August 2022, EDK2 needs to
add V6.5 header.
v1:
1. Added ACPI 6.5 header, copied from Acpi64.h.
2. Added CORE_PIC, LIO_PIC ,etc. tables to MADT.
Chao Li (2):
MdePkg: Add ACPI 6.5 header
MdePkg: Added serveral tables to MATD used by LoongArch64
Mde
> > > +ASSERT (SizeOfMemorySpace <= 52);
> > > +
> > > //
> > > -// Calculate the table entries of PML4E and PDPTE.
> > > +// Calculate the table entries of PML5E, PML4E and PDPTE.
> > > //
> > > NumberOfPml5Entries = 1;
> > > -if (SizeOfMemorySpace > 48) {
> > > +
Hi Ard, Hi everyone,
Thanks for the work!
But somehow this patch (as it was merged into master branch) does not
work for me on the ThunderX box we have.
Any idea what could be wrong?
I enabled the erratum during build ;-)
CPU Info:
# lscpu
Architecture: aarch64
CPU op-mode(s):
Hi all,
Just to let you know: I performed a test with this modified version
of EDK2 and 1500 vCPU set in Qemu config. The test ended up with
success. I can confirm that space saved by removing Itanium data
structure allows to allocate more than 1024 vCPU using KVM accelerator.
On thing to not
On Tue, Jan 17, 2023 at 12:20:16PM +, Yao, Jiewen wrote:
> I have seen Gerd sent out V4 patch set for #4251. Is that not enough?
If that is merged first patch 17 should not be needed.
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
Vi
Hi,
> >> In particular the firmware makes no further decisions based on
> >> whether QEMU advertized some of these features.
> >
> > I was thinking the other way around: When cpu hotplug is disabled in
> > qemu it should be safe to skip the whole cpu hotplug checking dance.
> > See test patch b
I have seen Gerd sent out V4 patch set for #4251. Is that not enough?
In general, I prefer no work-around, unless there is strong reason.
I would like to have Gerd and Ard to feedback.
Thank you
Yao, Jiewen
From: devel@edk2.groups.io On Behalf Of Oliver Steffen
Sent: Tuesday, January 17, 2023
Add PlatformReservationConflictCB() callback function for use with
PlatformScanE820(). It checks whenever the 64bit PCI MMIO window
overlaps with a reservation from qemu. If so move down the MMIO window
to resolve the conflict.
Write any actions done (moving mmio window) to the firmware log with
First handle the cases which do not need know the value of
PlatformInfoHob->LowMemory (microvm and cloudhv). Then call
PlatformGetSystemMemorySizeBelow4gb() to get LowMemory. Finally handle
the cases (q35 and pc) which need to look at LowMemory,
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/Library
Add PlatformGetLowMemoryCB() callback function for use with
PlatformScanE820(). It stores the low memory size in
PlatformInfoHob->LowMemory. This replaces calls to
PlatformScanOrAdd64BitE820Ram() with non-NULL LowMemory.
Write any actions done (setting LowMemory) to the firmware log
with INFO lo
First step replacing the PlatformScanOrAdd64BitE820Ram() function.
Add a PlatformScanE820() function which loops over the e280 entries
from FwCfg and calls a callback for each of them.
Add a GetFirstNonAddressCB() function which will store the first free
address (right after the last RAM block) i
v4:
- made mmio window move a bit more robust.
- dropped patches for moving MMCONFIG, they'll come as separate patch
series later.
v3:
- Add / fix comments, add notes to commit messages.
- Make functions static.
- Logging tweaks.
- Fix windows compiler warnings.
- Add patches (5,6,7) mov
Add PlatformAddHobCB() callback function for use with
PlatformScanE820(). It adds HOBs for high memory and reservations (low
memory is handled elsewhere because there are some special cases to
consider). This replaces calls to PlatformScanOrAdd64BitE820Ram() with
AddHighHobs = TRUE.
Write any ac
On Tue, Jan 17, 2023 at 09:02:01AM +, Ni, Ray wrote:
> + Gerd.
>
> > -Original Message-
> > From: Liu, Zhiguang
> > Sent: Wednesday, January 4, 2023 1:41 PM
> > To: devel@edk2.groups.io
> > Cc: Liu, Zhiguang ; Ni, Ray ;
> > Kumar, Rahul R ; Dong,
> > Eric
> > Subject: [PATCH] UefiCp
On Tue, Jan 17, 2023 at 03:43:28PM +0800, Min Xu wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4169
>
> The previous TDX MmioExit doesn't handle the Mmio instructions correctly
> in some scenarios. This patch-set refactors the implementation to fix the
> issues.
>
> Before the refac
On Tue, Jan 17, 2023 at 03:40:14PM +0800, Min Xu wrote:
> From: Min M Xu
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
>
> This patch enables Tdx measurement in OvmfPkgX64 with below changes:
> 1) TDX_ENABLE is introduced in OvmfPkgX64.dsc. This flag indicates
>if Intel TDX is
On Tue, Jan 17, 2023 at 03:40:10PM +0800, Min Xu wrote:
> From: Min M Xu
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
>
> From the perspective of security any external input should be measured
> and extended to some registers (TPM PCRs or TDX RTMR registers).
>
> There are below
Hi,
> Patch #2:
> Introduce TdxHelperLib which provides helper functions for td-guest.
> Patch #6:
> ProcessTdxHobList is moved to TdxHelperLib and is renamed as
> TdxHelperProcessTdHob(). So the duplicated codes are deleted in this
> patch.
This is a unreview-able mess. Please create
On Tue, Jan 17, 2023 at 07:31:54AM +0800, Min Xu wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4152
>
> In current DXE FV there are 100+ drivers. Some of the drivers are not
> used in Td guest. (Such as USB support drivers, network related
> drivers, etc).
>
> From the security pers
Hi,
> -INF MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf
If you move the gfx console driver you can move the gfx hardware drivers
too:
OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf
OvmfPkg/QemuRamfbDxe/QemuRamfbDxe.inf
OvmfPkg/VirtioGpuDxe/VirtioGpu.inf
take care,
1 - 100 of 112 matches
Mail list logo
